Release microsoft.sql 2020-11-01 preview API version #13332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…preview to version 2020-11-01-preview
…on and Databases.json (#12146) * add updated databases.json swagger * update readme with new package * v4 -> v5 * add missing chunk in readme * add correct swaggeR * add examples * add correct examplese * remove unreferenced examples * update swagger and examples. add 2020-11 pure package * Fix reference to 2020-08-01 reference to ElasticPools.json * update Databases.json name * update examples * remove nonexistant swagger * fixed reference capitals in readme * update package composite and fix ref to ManagedInstances.jsON * make backupstorageredundancy settings consistent * add requestedBackupStorageRedundancy to properties object in example * add LTR swagger and examples * add LTR Policies swagger and examples * make v5 match v4 * add updated Databses.json * merge conflicts in LTR Policies swagger' * take out comments in readme * taking ImportExport.json out from 2020-11 package * remove duplicate 2020-11 tag in readme * modify Databases_legacy.json to exclude ImportExport-related APIs * add servers.json for IE APIS and remove unused databases examples * fix model & prettier errors; add missing server example * add missing servers examples * fix example to exclude property from server obj * change RecommendedActions definitoins * change tag to composite v4
…AlertPolicies (#13117) * Add missing properties for api version 2020-02-02-preview * fix checks * fix according to prettier check * Add the change to version 2020-08-01-preview and version 2020-11-01-preview * remove changes in package-lock * Add new line at the end of file * update version 2020-11-01-preview * Update the ref to system data in serverdevopsaudit * add missing point
* fix the validation errors * Delete ServerDevOpsAudit.json * fix the validation errors * re add ServerDevOpsAudit.json
|
Hi, @ericshape Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
Only 10 items are listed, please refer to log for more details.
|
| Rule | Message |
|---|---|
|
Model definition 'ProxyResourceWithWritableName' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. Location: Microsoft.Sql/preview/2020-11-01-preview/FirewallRules.json#L298 |
|
Model definition 'FirewallRule' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. Location: Microsoft.Sql/preview/2020-11-01-preview/FirewallRules.json#L308 |
|
The response of operation:'BackupShortTermRetentionPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Sql/preview/2020-11-01-preview/BackupShortTermRetentionPolicies.json#L20 |
|
The response of operation:'BackupShortTermRetentionPolicies_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Sql/preview/2020-11-01-preview/BackupShortTermRetentionPolicies.json#L74 |
|
The response of operation:'BackupShortTermRetentionPolicies_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Sql/preview/2020-11-01-preview/BackupShortTermRetentionPolicies.json#L141 |
|
The response of operation:'ExtendedDatabaseBlobAuditingPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Sql/preview/2020-11-01-preview/BlobAuditing.json#L20 |
|
The response of operation:'ExtendedDatabaseBlobAuditingPolicies_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Sql/preview/2020-11-01-preview/BlobAuditing.json#L63 |
|
The response of operation:'ExtendedServerBlobAuditingPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Sql/preview/2020-11-01-preview/BlobAuditing.json#L174 |
|
The response of operation:'ExtendedServerBlobAuditingPolicies_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Sql/preview/2020-11-01-preview/BlobAuditing.json#L214 |
|
The response of operation:'ServerBlobAuditingPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Sql/preview/2020-11-01-preview/BlobAuditing.json#L314 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/sql/resource-manager/readme.md tag: specification/sql/resource-manager/readme.md#tag-package-composite-v4 |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️🔄[Staging] Cross Version BreakingChange (Base on preview version) inProgress [Detail]
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌[Staging] SDK Track2 Validation: 2 Errors, 67 Warnings failed [Detail]
Only 10 items are listed, please refer to log for more details.
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
|
"readme":"sql/resource-manager/readme.md", "tag":"package-composite-v4", "details":"Error: Plugin pre-namer reported failure." |
|
"readme":"sql/resource-manager/readme.md", "tag":"package-preview-2020-11", "details":"Error: Plugin pre-namer reported failure." |
| "readme":"sql/resource-manager/readme.md", "tag":"package-composite-v4", "details":"The schema 'RecoverableDatabaseProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"sql/resource-manager/readme.md", "tag":"package-composite-v4", "details":"The schema 'RecoverableDatabase' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"sql/resource-manager/readme.md", "tag":"package-composite-v4", "details":"The schema 'RecoverableDatabaseListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"sql/resource-manager/readme.md", "tag":"package-composite-v4", "details":"The schema 'RestorableDroppedDatabaseProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"sql/resource-manager/readme.md", "tag":"package-composite-v4", "details":"The schema 'RestorableDroppedDatabase' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"sql/resource-manager/readme.md", "tag":"package-composite-v4", "details":"The schema 'RestorableDroppedDatabaseListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"sql/resource-manager/readme.md", "tag":"package-composite-v4", "details":"The schema 'ServerConnectionPolicyProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"sql/resource-manager/readme.md", "tag":"package-composite-v4", "details":"The schema 'ServerConnectionPolicy' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=199539&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
ghost
added
the
|
Hi, @ericshape your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @ |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi @ericshape, Your PR has some issues. Please fix the CI sequentially by following the order of
|
actually, they are carried from old versions. We did not change it in 2020-11-01 as the comment from #12146 (comment) , we can know:
|
This was referenced Mar 9, 2021
akning-ms
approved these changes
Mar 9, 2021
This was referenced Mar 9, 2021
Closed
Closed
[ReleasePR Microsoft.Azure.Management.Sql] add sql tag to readme.go.md
Azure/azure-sdk-for-net#17306
Closed
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* Adds base for updating Microsoft.Sql from version preview/2020-08-01-preview to version 2020-11-01-preview * Updates readme * Updates API version in new specs and examples * Add updated 2020-11-01-preview versions of LongTermRetenionBackups.json and Databases.json (Azure#12146) * add updated databases.json swagger * update readme with new package * v4 -> v5 * add missing chunk in readme * add correct swaggeR * add examples * add correct examplese * remove unreferenced examples * update swagger and examples. add 2020-11 pure package * Fix reference to 2020-08-01 reference to ElasticPools.json * update Databases.json name * update examples * remove nonexistant swagger * fixed reference capitals in readme * update package composite and fix ref to ManagedInstances.jsON * make backupstorageredundancy settings consistent * add requestedBackupStorageRedundancy to properties object in example * add LTR swagger and examples * add LTR Policies swagger and examples * make v5 match v4 * add updated Databses.json * merge conflicts in LTR Policies swagger' * take out comments in readme * taking ImportExport.json out from 2020-11 package * remove duplicate 2020-11 tag in readme * modify Databases_legacy.json to exclude ImportExport-related APIs * add servers.json for IE APIS and remove unused databases examples * fix model & prettier errors; add missing server example * add missing servers examples * fix example to exclude property from server obj * change RecommendedActions definitoins * change tag to composite v4 * Add missing properties for api version 2020-02-02-preview of securityAlertPolicies (Azure#13117) * Add missing properties for api version 2020-02-02-preview * fix checks * fix according to prettier check * Add the change to version 2020-08-01-preview and version 2020-11-01-preview * remove changes in package-lock * Add new line at the end of file * update version 2020-11-01-preview * Update the ref to system data in serverdevopsaudit * add missing point * fix the validation errors (Azure#13325) * fix the validation errors * Delete ServerDevOpsAudit.json * fix the validation errors * re add ServerDevOpsAudit.json Co-authored-by: xaliciayang <59986952+xaliciayang@users.noreply.github.com> Co-authored-by: ayeletshpigelman <ayshpige@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
The goal of 2020-11-01 is to have a Backup Restore feature in .NET SDK and Powershell. cc @xaliciayang
And we will not release any Python / Go SDK. Thus, the known "import-export" namespace issue will not be a problem for .NET SDK and Powershell. We will fix "import/export" issue in the upcoming V5 SDK.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.