Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CosmosDB] Remove ReadOnly tag for PublicNetworkAccess property #13428

Merged
merged 5 commits into from
Mar 17, 2021
Merged

[CosmosDB] Remove ReadOnly tag for PublicNetworkAccess property #13428

merged 5 commits into from
Mar 17, 2021

Conversation

soeom
Copy link
Contributor

@soeom soeom commented Mar 15, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @soeom Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 15, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 6 Errors, 0 Warnings failed [Detail]

    Rule Message
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.DocumentDB/preview/2021-03-01-preview/cosmos-db.json#L6203:9
    Old: Microsoft.DocumentDB/preview/2021-03-01-preview/cosmos-db.json#L6203:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.DocumentDB/preview/2021-03-01-preview/cosmos-db.json#L6497:9
    Old: Microsoft.DocumentDB/preview/2021-03-01-preview/cosmos-db.json#L6497:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.DocumentDB/preview/2021-03-01-preview/cosmos-db.json#L6327:9
    Old: Microsoft.DocumentDB/preview/2021-03-01-preview/cosmos-db.json#L6327:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.DocumentDB/preview/2021-03-01-preview/cosmos-db.json#L6327:9
    Old: Microsoft.DocumentDB/preview/2021-03-01-preview/cosmos-db.json#L6327:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.DocumentDB/preview/2021-03-01-preview/cosmos-db.json#L6327:9
    Old: Microsoft.DocumentDB/preview/2021-03-01-preview/cosmos-db.json#L6327:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.DocumentDB/preview/2021-03-01-preview/cosmos-db.json#L8468:5
    Old: Microsoft.DocumentDB/preview/2021-03-01-preview/cosmos-db.json#L8468:5
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.

    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️⚠️[Staging] SDK Track2 Validation: 78 Warnings warning [Detail] Only 10 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ PreCheck/SchemaMissingType "readme":"cosmos-db/resource-manager/readme.md",
    "tag":"package-2021-03-preview",
    "details":"The schema 'DatabaseAccountsListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"cosmos-db/resource-manager/readme.md",
    "tag":"package-2021-03-preview",
    "details":"The schema 'SqlDatabaseListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"cosmos-db/resource-manager/readme.md",
    "tag":"package-2021-03-preview",
    "details":"The schema 'SqlContainerListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"cosmos-db/resource-manager/readme.md",
    "tag":"package-2021-03-preview",
    "details":"The schema 'SqlStoredProcedureListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"cosmos-db/resource-manager/readme.md",
    "tag":"package-2021-03-preview",
    "details":"The schema 'SqlUserDefinedFunctionListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"cosmos-db/resource-manager/readme.md",
    "tag":"package-2021-03-preview",
    "details":"The schema 'SqlTriggerListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"cosmos-db/resource-manager/readme.md",
    "tag":"package-2021-03-preview",
    "details":"The schema 'MongoDBDatabaseListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"cosmos-db/resource-manager/readme.md",
    "tag":"package-2021-03-preview",
    "details":"The schema 'MongoDBCollectionListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"cosmos-db/resource-manager/readme.md",
    "tag":"package-2021-03-preview",
    "details":"The schema 'TableListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"cosmos-db/resource-manager/readme.md",
    "tag":"package-2021-03-preview",
    "details":"The schema 'CassandraKeyspaceListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 15, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️⚠️ azure-sdk-for-python warning [Detail]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from f6c825a. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️cosmos-db/mgmt/2021-01-15/documentdb [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️cosmos-db/mgmt/2019-08-01/documentdb [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️cosmos-db/mgmt/2015-04-08/documentdb [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/cosmos-db/mgmt/2021-03-01-preview/documentdb [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/cosmos-db/mgmt/2020-09-01-preview/documentdb [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/cosmos-db/mgmt/2020-06-01-preview/documentdb [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 12 items here, please refer to log for details.
      info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `Local`
info	[Changelog] - New const `Geo`
info	[Changelog] - New const `Zone`
info	[Changelog] - New function `PossibleBackupStorageRedundancyValues() []BackupStorageRedundancy`
info	[Changelog] - New struct `CloudError`
info	[Changelog] - New field `BackupStorageRedundancy` in struct `PeriodicModeProperties`
info	[Changelog]
info	[Changelog] Total 7 breaking change(s), 7 additive change(s).
info	[Changelog]
    • ️✔️preview/cosmos-db/mgmt/2020-04-01-preview/documentdb [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/cosmos-db/mgmt/2020-03-01-preview/documentdb [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/cosmos-db/mgmt/2019-12-12-preview/documentdb [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/cosmos-db/mgmt/2019-08-01-preview/documentdb [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from f6c825a. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-03-17 01:16:55 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-cosmos-generated"
cmderr	[generate.py] 2021-03-17 01:16:55 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-03-17 01:16:55 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.20 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/cosmos/azure-resourcemanager-cosmos-generated --java.namespace=com.azure.resourcemanager.cosmos.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/cosmos-db/resource-manager/readme.md
cmderr	[generate.py] 2021-03-17 01:17:59 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-03-17 01:17:59 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-03-17 01:17:59 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-03-17 01:17:59 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-03-17 01:17:59 INFO [POM][Skip] pom already has module sdk/cosmos
cmderr	[generate.py] 2021-03-17 01:17:59 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-cosmos-generated [View full logs]  [Release SDK Changes] 
      cmderr	[Inst] 2021-03-17 01:22:12 DEBUG Got artifact_id: azure-resourcemanager-cosmos-generated
cmderr	[Inst] 2021-03-17 01:22:12 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-03-17 01:22:12 DEBUG Got artifact: azure-resourcemanager-cosmos-generated-1.0.0-beta.1-javadoc.jar
cmderr	[Inst] 2021-03-17 01:22:12 DEBUG Got artifact: azure-resourcemanager-cosmos-generated-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-03-17 01:22:12 DEBUG Got artifact: azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-03-17 01:22:12 DEBUG Match jar package: azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-03-17 01:22:12 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13428/azure-sdk-for-java/azure-resourcemanager-cosmos-generated/azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-cosmos-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from f6c825a. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-cosmosdb [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model CassandraTableGetResults has a new parameter identity
info	[Changelog]   - Model GremlinGraphGetResults has a new parameter identity
info	[Changelog]   - Model SqlDatabaseGetResults has a new parameter identity
info	[Changelog]   - Model GremlinDatabaseGetResults has a new parameter identity
info	[Changelog]   - Model MongoDBCollectionCreateUpdateParameters has a new parameter identity
info	[Changelog]   - Model SqlUserDefinedFunctionCreateUpdateParameters has a new parameter identity
info	[Changelog]   - Model DatabaseAccountGetResults has a new parameter instance_id
info	[Changelog]   - Model DatabaseAccountGetResults has a new parameter create_mode
info	[Changelog]   - Model DatabaseAccountGetResults has a new parameter restore_parameters
info	[Changelog]   - Model DatabaseAccountGetResults has a new parameter system_data
info	[Changelog]   - Model ThroughputSettingsGetResults has a new parameter identity
info	[Changelog]   - Model ARMResourceProperties has a new parameter identity
info	[Changelog]   - Model MongoDBDatabaseCreateUpdateParameters has a new parameter identity
info	[Changelog]   - Model SqlTriggerCreateUpdateParameters has a new parameter identity
info	[Changelog]   - Model GremlinGraphCreateUpdateParameters has a new parameter identity
info	[Changelog]   - Model SqlTriggerGetResults has a new parameter identity
info	[Changelog]   - Model MongoDBDatabaseGetResults has a new parameter identity
info	[Changelog]   - Model CassandraKeyspaceGetResults has a new parameter identity
info	[Changelog]   - Model PeriodicModeProperties has a new parameter backup_storage_redundancy
info	[Changelog]   - Model CassandraTableCreateUpdateParameters has a new parameter identity
info	[Changelog]   - Model SqlUserDefinedFunctionGetResults has a new parameter identity
info	[Changelog]   - Model SqlContainerGetResults has a new parameter identity
info	[Changelog]   - Model TableGetResults has a new parameter identity
info	[Changelog]   - Model SqlStoredProcedureGetResults has a new parameter identity
info	[Changelog]   - Model ThroughputSettingsUpdateParameters has a new parameter identity
info	[Changelog]   - Model CassandraKeyspaceCreateUpdateParameters has a new parameter identity
info	[Changelog]   - Model TableCreateUpdateParameters has a new parameter identity
info	[Changelog]   - Model GremlinDatabaseCreateUpdateParameters has a new parameter identity
info	[Changelog]   - Model SqlContainerCreateUpdateParameters has a new parameter identity
info	[Changelog]   - Model SqlDatabaseCreateUpdateParameters has a new parameter identity
info	[Changelog]   - Model MongoDBCollectionGetResults has a new parameter identity
info	[Changelog]   - Model SqlStoredProcedureCreateUpdateParameters has a new parameter identity
info	[Changelog]   - Added operation SqlResourcesOperations.begin_create_update_sql_role_assignment
info	[Changelog]   - Added operation SqlResourcesOperations.begin_delete_sql_role_definition
info	[Changelog]   - Added operation SqlResourcesOperations.begin_create_update_sql_role_definition
info	[Changelog]   - Added operation SqlResourcesOperations.list_sql_role_assignments
info	[Changelog]   - Added operation SqlResourcesOperations.begin_delete_sql_role_assignment
info	[Changelog]   - Added operation SqlResourcesOperations.list_sql_role_definitions
info	[Changelog]   - Added operation SqlResourcesOperations.get_sql_role_definition
info	[Changelog]   - Added operation SqlResourcesOperations.get_sql_role_assignment
info	[Changelog]   - Added operation group RestorableMongodbCollectionsOperations
info	[Changelog]   - Added operation group RestorableDatabaseAccountsOperations
info	[Changelog]   - Added operation group RestorableMongodbResourcesOperations
info	[Changelog]   - Added operation group RestorableSqlDatabasesOperations
info	[Changelog]   - Added operation group RestorableSqlResourcesOperations
info	[Changelog]   - Added operation group RestorableSqlContainersOperations
info	[Changelog]   - Added operation group CassandraDataCentersOperations
info	[Changelog]   - Added operation group RestorableMongodbDatabasesOperations
info	[Changelog]   - Added operation group CassandraClustersOperations
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model DatabaseAccountCreateUpdateParameters has a new signature
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from f6c825a. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/cosmos-db/resource-manager/readme.md
    • ️✔️@azure/arm-cosmosdb [View full logs]  [Release SDK Changes] 
      cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/cosmosDBManagementClient.js → ./dist/arm-cosmosdb.js...
cmderr	[npmPack] created ./dist/arm-cosmosdb.js in 927ms
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from f6c825a. Schema Automation 14.0.0 
      warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/cosmos-db/resource-manager/readme.md
cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.DocumentDB/databaseAccounts/apis/databases. Skipping definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/apis/mongodb/databases/{databaseName}'.
cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.DocumentDB/databaseAccounts/apis/databases. Skipping definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/apis/gremlin/databases/{databaseName}'.
cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.DocumentDB/databaseAccounts/apis/databases. Using definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/apis/sql/databases/{databaseName}'.
cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.DocumentDB/databaseAccounts/apis/databases. Skipping definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/apis/mongodb/databases/{databaseName}'.
cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.DocumentDB/databaseAccounts/apis/databases. Skipping definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/apis/gremlin/databases/{databaseName}'.
cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.DocumentDB/databaseAccounts/apis/databases. Using definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/apis/sql/databases/{databaseName}'.
cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.DocumentDB/databaseAccounts/apis/databases. Skipping definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/apis/mongodb/databases/{databaseName}'.
cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.DocumentDB/databaseAccounts/apis/databases. Skipping definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/apis/gremlin/databases/{databaseName}'.
cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.DocumentDB/databaseAccounts/apis/databases. Using definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/apis/sql/databases/{databaseName}'.
cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.DocumentDB/databaseAccounts/apis/databases. Skipping definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/apis/mongodb/databases/{databaseName}'.
cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.DocumentDB/databaseAccounts/apis/databases. Skipping definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/apis/gremlin/databases/{databaseName}'.
cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.DocumentDB/databaseAccounts/apis/databases. Using definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/apis/sql/databases/{databaseName}'.
cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.DocumentDB/databaseAccounts/apis/databases. Skipping definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/apis/mongodb/databases/{databaseName}'.
cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.DocumentDB/databaseAccounts/apis/databases. Skipping definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/apis/gremlin/databases/{databaseName}'.
cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.DocumentDB/databaseAccounts/apis/databases. Using definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/apis/sql/databases/{databaseName}'.
    • ️✔️cosmos-db [View full logs]  [Release Schema Changes] 
      cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager]  WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager] WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    Posted by Swagger Pipeline | How to fix these errors?

    This was referenced Mar 15, 2021
    Closed
    Closed
    This was referenced Mar 15, 2021
    Closed
    Closed
    Closed
    @openapi-workflow-bot
    Copy link

    Hi @soeom, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Mar 16, 2021
    @soeom
    Copy link
    Contributor Author

    soeom commented Mar 16, 2021

    @weidongxu-microsoft Please merge.

    @weidongxu-microsoft weidongxu-microsoft merged commit f6c825a into Azure:master Mar 17, 2021
    This was referenced Mar 17, 2021
    Closed
    Closed
    Closed
    Closed
    Closed
    This was referenced Mar 17, 2021
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    MirzaSikander pushed a commit to MirzaSikander/azure-rest-api-specs that referenced this pull request Mar 22, 2021
    @soeom @MirzaSikander
    [CosmosDB] Remove ReadOnly tag for PublicNetworkAccess property (Azur…
    6edca71 
    …e#13428)
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    @soeom @mkarmark
    [CosmosDB] Remove ReadOnly tag for PublicNetworkAccess property (Azur…
    33551e3 
    …e#13428)
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @JeffreyRichter JeffreyRichter JeffreyRichter approved these changes

    @MehaKaushik MehaKaushik MehaKaushik approved these changes

    @shurd shurd Awaiting requested review from shurd

    Assignees

    @weidongxu-microsoft weidongxu-microsoft

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Go
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    4 participants
    @soeom @JeffreyRichter @MehaKaushik @weidongxu-microsoft