[Hub Generated] Review request for Microsoft.Maps to add version preview/2021-07-01-preview #14316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @stack111 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Maps/accounts/{accountName}/privateAtlases/{privateAtlasName}' removed or restructured? Old: Microsoft.Maps/preview/2020-02-01-preview/maps-management.json#L439:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Maps/accounts/{accountName}/privateAtlases' removed or restructured? Old: Microsoft.Maps/preview/2020-02-01-preview/maps-management.json#L637:5 |
|
The new version is missing a definition that was found in the old version. Was 'MapsAccountCreateParameters' removed or renamed? New: Microsoft.Maps/preview/2021-07-01-preview/maps-management.json#L718:3 Old: Microsoft.Maps/preview/2020-02-01-preview/maps-management.json#L954:3 |
|
The new version is missing a definition that was found in the old version. Was 'PrivateAtlasCreateParameters' removed or renamed? New: Microsoft.Maps/preview/2021-07-01-preview/maps-management.json#L718:3 Old: Microsoft.Maps/preview/2020-02-01-preview/maps-management.json#L954:3 |
|
The new version is missing a definition that was found in the old version. Was 'CreatorCreateParameters' removed or renamed? New: Microsoft.Maps/preview/2021-07-01-preview/maps-management.json#L718:3 Old: Microsoft.Maps/preview/2020-02-01-preview/maps-management.json#L954:3 |
|
The new version is missing a definition that was found in the old version. Was 'PrivateAtlasUpdateParameters' removed or renamed? New: Microsoft.Maps/preview/2021-07-01-preview/maps-management.json#L718:3 Old: Microsoft.Maps/preview/2020-02-01-preview/maps-management.json#L954:3 |
|
The required parameter 'MapsAccountCreateParameters' was removed in the new version. Old: Microsoft.Maps/preview/2020-02-01-preview/maps-management.json#L65:11 |
|
The required parameter 'CreatorCreateParameters' was removed in the new version. Old: Microsoft.Maps/preview/2020-02-01-preview/maps-management.json#L757:11 |
|
The required parameter 'MapsAccount' was added in the new version. New: Microsoft.Maps/preview/2021-07-01-preview/maps-management.json#L68:11 |
|
The required parameter 'CreatorResource' was added in the new version. New: Microsoft.Maps/preview/2021-07-01-preview/maps-management.json#L521:11 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"maps/resource-manager/readme.md",
"tag":"package-2021-02",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"maps/resource-manager/readme.md",
"tag":"package-2021-02",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"maps/resource-manager/readme.md",
"tag":"package-preview-2021-07",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"maps/resource-manager/readme.md",
"tag":"package-preview-2021-07",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
The following errors/warnings exist before current PR submission:
|:speech_balloon: AutorestCore/Exception|"readme":"maps/resource-manager/readme.md",
"tag":"package-2021-02",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"maps/resource-manager/readme.md",
"tag":"package-preview-2020-02",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"maps/resource-manager/readme.md",
"tag":"package-preview-2020-02",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"maps/resource-manager/readme.md",
"tag":"package-2017-01",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"maps/resource-manager/readme.md",
"tag":"package-2017-01",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"maps/resource-manager/readme.md",
"tag":"package-2018-05",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"maps/resource-manager/readme.md",
"tag":"package-2018-05",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
Hi @stack111, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced May 7, 2021
openapi-pipeline-app
bot
added
CI-BreakingChange-Go
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
|
See the previous PR review for breaking changes on preview api. We are deprecating preview types in August thus we are not carrying forward the preview types to the new preview version. |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @stack111 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @ |
|
Hi, @stack111 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @leni-msft |
stack111
commented
May 10, 2021
| } | ||
| } | ||
| }, | ||
| "LinkedResources": { |
There was a problem hiding this comment.
I'm happy to discuss LinkedResources. We have operations on dataplane where we will want to levarage different sets resourceId(s) to complete an operation.
Examples:
- Map batch request may output the results to a specified storage account
- we may use another storage account to read data to construct spatial data and output to the same resourceId or a different resourceId.
- We may want to support more than storage account. For example geo spatial data can be stored in SQL or Postgres SQL.
- We may have a scenario where multiple resourceIds are required for input to the operation.
We plan to document all the scenarios and provide error responses and error codes (+preflight).
There was a problem hiding this comment.
as we reviewed today @jorgecotillo, I've updated LinkedResources to be an array of an object. We lose the ability to patch an individual resource. However we gain type safety with a path forward to add additional properties in the future. We will leave out type as this can be resolved by the id in the RP.
Take a look if you have a chance, thanks again!
There was a problem hiding this comment.
Looks good. I think the example files need to be updated to reflect this change too.
There was a problem hiding this comment.
Thanks @filizt, example files are updated. If it looks good, feel free to update the PR tags.
filizt
added
ARMSignedOff
leni-msft
approved these changes
May 21, 2021
This was referenced May 21, 2021
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…iew/2021-07-01-preview (Azure#14316) * Adds base for updating Microsoft.Maps from version stable/2021-02-01 to version 2021-07-01-preview * Updates readme * Updates API version in new specs and examples * managed identities * updates based on design review * fixes for examples * adding description * updated example request responses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
June
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
See the previous PR review for breaking changes on preview api. We are deprecating preview types in August thus we are not carrying forward the preview types to the new preview version.
Please follow the link to find more details on PR review process.