Add schedule api #14360
Merged
Add schedule api #14360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
202 status for start and stop CI
ninghu
reviewed
May 17, 2021
...er/Microsoft.MachineLearningServices/preview/2021-03-01-preview/machineLearningServices.json
Show resolved
Hide resolved
ninghu
requested changes
May 17, 2021
...preview/2021-03-01-preview/examples/Compute/createOrUpdate/ComputeInstanceWithSchedules.json
Show resolved
Hide resolved
...oft.MachineLearningServices/preview/2021-03-01-preview/examples/Compute/updateSchedules.json
Show resolved
Hide resolved
ninghu
approved these changes
May 17, 2021
ninghu
requested changes
May 17, 2021
| "recurrence": { | ||
| "frequency": "Day", | ||
| "interval": 1, | ||
| "startTime": "2021-04-23T1:30:00", |
There was a problem hiding this comment.
I believe 2021-04-23T1:30:00 is not valid, it has to be 2021-04-23T01:30:00
| "triggerType": "Cron", | ||
| "cron": { | ||
| "expression": "0 18 * * *", | ||
| "startTime": "2021-04-23T1:30:00", |
ninghu
approved these changes
May 17, 2021
ArcturusZhang
approved these changes
May 18, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced May 18, 2021
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* Add Identity to createWorkpace example * change for getTransitivePEUsages * update * prettier code * add another new endpoint * address comments * change for getTransitivePEUsages * update * prettier code * add another new endpoint * address comments * revert change on transitivePE and notebookKeys * revert change on transitivePE and notebookKeys * add new stable version 2021-01-01 * add ListNotebookAccessToken * add primaryUserAssignedIdentity * fix missing properties and apis * fix one more missing property * 202 status for start and stop CI * make resync keys long runnin operation in version Jan2021 * resync keys 204 * update resync keys example * Dont throw 204 for resync * update resync keys * Formatting * revert Jan2021changes and add new version * start apr2021 version for azure ml rp * undo remove new line in jan2021 * use systemData definition in common * removed old files * fix small swagger bugs * run prettier * remove reference to sku * update readme * minimum agentCount should be 0 * add createdOn and ModifiedOn to compute properties * add LoadBalancerType to aks compute * add isNotebookInstanceCompute to virtualMachine * add leafDomainLabel to SslConfiguration * add overwriteExistingDomain to SslConfiguration * add synapseSpark as supported compute-type * update patch compute response to 202 * remove location from example responses * Revert "remove location from example responses" This reverts commit 048bf25. * MachineLearningCompute_Update should have a 200 response * sys data to use local def due to naming conflicts. * Fix enum casing * Fix operationId PR comment. * Change opId in apr version * remove 20210401 for easy review * only change api version * merge changes for 20210401 version * Add x-ms-discriminator-value for Synapse spark * camelcase loadbalancer properties * add createdOn and Modified on to examples * address AvoidAnonymousTypes error for SynapseSpark * Minor fixes + new property * Remove subscription state. * add schedules api * Add schedule examples * case formatting * Cron example for ci create * Prettier check and model validation * renaming property * Address comments * Give a stop example * Fix time format. Co-authored-by: zhaomuzhi <zhaoweixiong521@gmail.com> Co-authored-by: Vinay Rajmal Soni <vison@microsoft.com> Co-authored-by: jopet@microsoft.com <jopet@microsoft.com> Co-authored-by: Josh Peterson <15050193+joshanator@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.