Update Azure Monitor readme.{go/python}.md with the latest specs #14542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herreraj-ms
requested review from
00Kai0,
ArcturusZhang,
jsntcy,
msyyc,
RAY-316 and
zhangyan133
as code owners
|
Hi, @herreraj-ms Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.insights/autoscalesettings' Location: Microsoft.Insights/stable/2015-04-01/autoscale_API.json#L39 |
|
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.insights/autoscalesettings/{autoscaleSettingName}' Location: Microsoft.Insights/stable/2015-04-01/autoscale_API.json#L81 |
|
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/providers/microsoft.insights/autoscalesettings' Location: Microsoft.Insights/stable/2015-04-01/autoscale_API.json#L264 |
|
Resource provider naming must follow the pascal case. Path: '/providers/microsoft.insights/operations' Location: Microsoft.Insights/stable/2015-04-01/operations_API.json#L39 |
|
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.insights/alertrules/{ruleName}/incidents/{incidentName}' Location: Microsoft.Insights/stable/2016-03-01/alertRulesIncidents_API.json#L39 |
|
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.insights/alertrules/{ruleName}/incidents' Location: Microsoft.Insights/stable/2016-03-01/alertRulesIncidents_API.json#L88 |
|
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/providers/microsoft.insights/logprofiles/{logProfileName}' Location: Microsoft.Insights/stable/2016-03-01/logProfiles_API.json#L39 |
|
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/providers/microsoft.insights/logprofiles' Location: Microsoft.Insights/stable/2016-03-01/logProfiles_API.json#L189 |
|
Resource provider naming must follow the pascal case. Path: '/{resourceUri}/providers/microsoft.insights/diagnosticSettings/{name}' Location: Microsoft.Insights/preview/2017-05-01-preview/diagnosticsSettings_API.json#L39 |
|
Resource provider naming must follow the pascal case. Path: '/{resourceUri}/providers/microsoft.insights/diagnosticSettings' Location: Microsoft.Insights/preview/2017-05-01-preview/diagnosticsSettings_API.json#L161 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/monitor/resource-manager/readme.md tag: specification/monitor/resource-manager/readme.md#tag-package-2021-04 |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌[Staging] SDK Track2 Validation: 25 Errors, 0 Warnings failed [Detail]
- The following tags are being changed in this PR
- monitor/resource-manager/readme.md#package-2021-05-01-preview-only
- monitor/resource-manager/readme.md#package-2021-04-only
- monitor/resource-manager/readme.md#package-2021-02-preview-only
- monitor/resource-manager/readme.md#package-2020-10-only
- monitor/resource-manager/readme.md#package-2020-05-preview-only
- monitor/resource-manager/readme.md#package-2020-01-01-preview-only
- monitor/resource-manager/readme.md#package-2020-03
- monitor/resource-manager/readme.md#package-2019-11
- monitor/resource-manager/readme.md#package-2019-10-17-preview-only
- monitor/resource-manager/readme.md#package-2019-07-only
- monitor/resource-manager/readme.md#package-2019-06
- monitor/resource-manager/readme.md#package-2019-03
- monitor/resource-manager/readme.md#package-2018-11-preview
- monitor/resource-manager/readme.md#package-2018-09
- monitor/resource-manager/readme.md#package-2018-03
- monitor/resource-manager/readme.md#package-2018-02-preview
- monitor/resource-manager/readme.md#package-2017-12
- monitor/resource-manager/readme.md#package-2017-09
- monitor/resource-manager/readme.md#package-2017-09-preview-only
- monitor/resource-manager/readme.md#package-2017-08
- monitor/resource-manager/readme.md#package-2019-11-01-preview-only
- monitor/resource-manager/readme.md#package-2019-06-01-only
- monitor/resource-manager/readme.md#package-2019-03-01-only
- monitor/resource-manager/readme.md#package-2018-11-27-preview-only
- monitor/resource-manager/readme.md#package-2018-09-01-only
- monitor/resource-manager/readme.md#package-2018-06-01-preview-only
- monitor/resource-manager/readme.md#package-2018-04-16-only
- monitor/resource-manager/readme.md#package-2018-03-01-only
- monitor/resource-manager/readme.md#package-2018-01-01-only
- monitor/resource-manager/readme.md#package-2017-12-01-preview-only
- monitor/resource-manager/readme.md#package-2017-11-01-preview-only
- monitor/resource-manager/readme.md#package-2017-05-01-preview-only
- monitor/resource-manager/readme.md#package-2017-04-01-only
- monitor/resource-manager/readme.md#package-2017-03-01-preview-only
- monitor/resource-manager/readme.md#package-2016-09-01-only
- monitor/resource-manager/readme.md#package-2016-06-only
- monitor/resource-manager/readme.md#package-2016-03-01-only
- monitor/resource-manager/readme.md#package-2015-07-01-only
- monitor/resource-manager/readme.md#package-2015-04-01-only
- monitor/resource-manager/readme.md#profile-hybrid-2019-03-01
- monitor/resource-manager/readme.md#profile-hybrid-2020-09-01
- monitor/resource-manager/readme.md#package-2021-04
Only 10 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2020-05-preview-only", "details":"Error: Invalid reference token: ResourceGroupNameParameter" |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2020-03", "details":"Error: Invalid reference token: ResourceGroupNameParameter" |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2019-11", "details":"Error: Invalid reference token: ResourceGroupNameParameter" |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2019-10-17-preview-only", "details":"Error: Invalid reference token: ResourceGroupNameParameter" |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2019-06", "details":"Error: Invalid reference token: ResourceGroupNameParameter" |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2019-03", "details":"Error: Invalid reference token: ResourceGroupNameParameter" |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2018-11-preview", "details":"Error: Invalid reference token: ResourceGroupNameParameter" |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2018-09", "details":"Error: Invalid reference token: ResourceGroupNameParameter" |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2018-03", "details":"Error: Invalid reference token: ResourceGroupNameParameter" |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2018-02-preview", "details":"Error: Invalid reference token: ResourceGroupNameParameter" |
The following errors/warnings exist before current PR submission:
|:speech_balloon: AutorestCore/Exception|"readme":"monitor/resource-manager/readme.md",
"tag":"package-2021-05-01-preview-only",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"monitor/resource-manager/readme.md",
"tag":"package-2021-04-only",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"monitor/resource-manager/readme.md",
"tag":"package-2021-04-only",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"monitor/resource-manager/readme.md",
"tag":"package-2021-02-preview-only",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"monitor/resource-manager/readme.md",
"tag":"package-2021-02-preview-only",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"monitor/resource-manager/readme.md",
"tag":"package-2020-10-only",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"monitor/resource-manager/readme.md",
"tag":"package-2020-10-only",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"monitor/resource-manager/readme.md",
"tag":"package-2020-05-preview-only",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"monitor/resource-manager/readme.md",
"tag":"package-2020-05-preview-only",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"monitor/resource-manager/readme.md",
"tag":"package-2020-01-01-preview-only",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
This was referenced May 25, 2021
This was referenced May 25, 2021
herreraj-ms
changed the title
weidongxu-microsoft
approved these changes
May 26, 2021
ArcturusZhang
approved these changes
May 26, 2021
|
Hi, if there's something pending for merging this changes, please let me know! |
|
@ArcturusZhang |
This PR is only to make a new package, but the error should be fixed on Autorest command, no? |
11 tasks
ArcturusZhang
requested changes
May 28, 2021
@weidongxu-microsoft Both checks have been fixed! @ArcturusZhang GO build is successful, is there other expected fix to be done? |
|
@ArcturusZhang Is there any change you require? |
herreraj-ms
requested review from
ArcturusZhang
and removed request for
zhangyan133
|
@ArcturusZhang ping |
ArcturusZhang
approved these changes
Jun 17, 2021
|
Hi @herreraj-ms if you could fix the merge conflicts, we are good to merge! thank you |
Done! |
This was referenced Jun 17, 2021
asager
pushed a commit
to asager/azure-rest-api-specs
that referenced
this pull request
Jun 24, 2021
…re#14542) * Update readme.{go/python}.md with the latest specs * add new tag: package-2021-04 * Update list for package-2021-04 * Fix CSharpGen adding directive and fix refs in DCR * Moving directive for all SDKs * prettier changes * directive only for go & .net * fixing go output-folder * directive, remove azure-validator, add typescript * fixing PR's LintDiff findings * fixing breaking changes * fixing go/python directives * fix go build * directive go && package-2021-04 * fix go build prev package-2021-04 * fix java build
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…re#14542) * Update readme.{go/python}.md with the latest specs * add new tag: package-2021-04 * Update list for package-2021-04 * Fix CSharpGen adding directive and fix refs in DCR * Moving directive for all SDKs * prettier changes * directive only for go & .net * fixing go output-folder * directive, remove azure-validator, add typescript * fixing PR's LintDiff findings * fixing breaking changes * fixing go/python directives * fix go build * directive go && package-2021-04 * fix go build prev package-2021-04 * fix java build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.