[Hub Generated] Review request for Microsoft.DocumentDB to add version stable/2021-06-15 #14627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…04-15 to version 2021-06-15
…05-15 to version 2021-06-15
|
Hi, @kavskalyan Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: disableLocalAuth Location: Microsoft.DocumentDB/stable/2021-06-15/cosmos-db.json#L6166 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: disableLocalAuth Location: Microsoft.DocumentDB/stable/2021-06-15/cosmos-db.json#L6292 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: disableLocalAuth Location: Microsoft.DocumentDB/stable/2021-06-15/cosmos-db.json#L6452 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Gets private endpoint connection. Location: Microsoft.DocumentDB/stable/2021-06-15/privateLinkResources.json#L69 |
The following errors/warnings exist before current PR submission:
Only 10 items are listed, please refer to log for more details.
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The JSON file has a circular reference. readme: specification/cosmos-db/resource-manager/readme.md json: Microsoft.DocumentDB/stable/2021-06-15/privateEndpointConnection.json |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross-Version Breaking Changes: 55 Errors, 0 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.8.11)
- current:stable/2021-06-15/cosmos-db.json compared with base:preview/2021-04-01-preview/cosmos-db.json
- current:stable/2021-06-15/notebook.json compared with base:preview/2021-04-01-preview/notebook.json
- current:stable/2021-06-15/privateEndpointConnection.json compared with base:preview/2021-04-01-preview/privateEndpointConnection.json
- current:stable/2021-06-15/privateLinkResources.json compared with base:preview/2021-04-01-preview/privateLinkResources.json
- current:stable/2021-06-15/rbac.json compared with base:preview/2021-04-01-preview/rbac.json
- current:stable/2021-06-15/restorable.json compared with base:preview/2021-04-01-preview/restorable.json
- current:stable/2021-06-15/cosmos-db.json compared with base:stable/2021-05-15/cosmos-db.json
- current:stable/2021-06-15/notebook.json compared with base:stable/2021-05-15/notebook.json
- current:stable/2021-06-15/privateEndpointConnection.json compared with base:stable/2021-05-15/privateEndpointConnection.json
- current:stable/2021-06-15/privateLinkResources.json compared with base:stable/2021-05-15/privateLinkResources.json
- current:stable/2021-06-15/rbac.json compared with base:stable/2021-05-15/rbac.json
Only 10 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.DocumentDB/locations/{location}/restorableDatabaseAccounts' removed or restructured? Old: Microsoft.DocumentDB/preview/2021-04-01-preview/cosmos-db.json#L5040:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.DocumentDB/restorableDatabaseAccounts' removed or restructured? Old: Microsoft.DocumentDB/preview/2021-04-01-preview/cosmos-db.json#L5079:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.DocumentDB/locations' removed or restructured? Old: Microsoft.DocumentDB/preview/2021-04-01-preview/cosmos-db.json#L5115:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.DocumentDB/locations/{location}' removed or restructured? Old: Microsoft.DocumentDB/preview/2021-04-01-preview/cosmos-db.json#L5151:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.DocumentDB/locations/{location}/restorableDatabaseAccounts/{instanceId}' removed or restructured? Old: Microsoft.DocumentDB/preview/2021-04-01-preview/cosmos-db.json#L5187:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/sqlDatabases/{databaseName}/containers/{containerName}/retrieveContinuousBackupInformation' removed or restructured? Old: Microsoft.DocumentDB/preview/2021-04-01-preview/cosmos-db.json#L5226:5 |
|
The new version is missing a definition that was found in the old version. Was 'DefaultRequestDatabaseAccountCreateUpdateProperties' removed or renamed? New: Microsoft.DocumentDB/stable/2021-06-15/cosmos-db.json#L5053:3 Old: Microsoft.DocumentDB/preview/2021-04-01-preview/cosmos-db.json#L5279:3 |
|
The new version is missing a definition that was found in the old version. Was 'RestoreReqeustDatabaseAccountCreateUpdateProperties' removed or renamed? New: Microsoft.DocumentDB/stable/2021-06-15/cosmos-db.json#L5053:3 Old: Microsoft.DocumentDB/preview/2021-04-01-preview/cosmos-db.json#L5279:3 |
|
The new version is missing a definition that was found in the old version. Was 'ContinuousBackupRestoreLocation' removed or renamed? New: Microsoft.DocumentDB/stable/2021-06-15/cosmos-db.json#L5053:3 Old: Microsoft.DocumentDB/preview/2021-04-01-preview/cosmos-db.json#L5279:3 |
|
The new version is missing a client parameter that was found in the old version. Was 'locationParameter' removed or renamed? New: Microsoft.DocumentDB/stable/2021-06-15/cosmos-db.json#L8623:3 Old: Microsoft.DocumentDB/preview/2021-04-01-preview/cosmos-db.json#L9007:3 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"cosmos-db/resource-manager/readme.md",
"tag":"package-2021-06",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"cosmos-db/resource-manager/readme.md",
"tag":"package-2021-06",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"cosmos-db/resource-manager/readme.md",
"tag":"package-2021-06",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=224039&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️❌[Staging] SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-cosmosdb - 6.3.0️✔️azure-sdk-for-go - cosmos-db/mgmt/2021-04-15/documentdb - Approved - v55.2.0️✔️azure-sdk-for-go - cosmos-db/mgmt/2021-03-15/documentdb - Approved - v55.2.0️✔️azure-sdk-for-go - cosmos-db/mgmt/2021-01-15/documentdb - Approved - v55.2.0️✔️azure-sdk-for-go - cosmos-db/mgmt/2019-08-01/documentdb - Approved - v55.2.0️✔️azure-sdk-for-go - cosmos-db/mgmt/2015-04-08/documentdb - Approved - v55.2.0️✔️azure-sdk-for-go - preview/cosmos-db/mgmt/2021-04-01-preview/documentdb - Approved - v55.2.0️✔️azure-sdk-for-go - preview/cosmos-db/mgmt/2021-03-01-preview/documentdb - Approved - v55.2.0️✔️azure-sdk-for-go - preview/cosmos-db/mgmt/2020-09-01-preview/documentdb - Approved - v55.2.0❌azure-sdk-for-go - preview/cosmos-db/mgmt/2020-06-01-preview/documentdb - Approved - v55.2.0+ Field `Identity` of struct `RestorableDatabaseAccountGetResult` has been removed + Field `Identity` of struct `RestorableMongodbCollectionGetResult` has been removed + Field `Identity` of struct `RestorableMongodbDatabaseGetResult` has been removed + Field `Identity` of struct `RestorableSQLContainerGetResult` has been removed + Field `Identity` of struct `RestorableSQLDatabaseGetResult` has been removed + Field `Location` of struct `RestorableMongodbCollectionGetResult` has been removed + Field `Location` of struct `RestorableMongodbDatabaseGetResult` has been removed + Field `Location` of struct `RestorableSQLContainerGetResult` has been removed + Field `Location` of struct `RestorableSQLDatabaseGetResult` has been removed + Field `Tags` of struct `RestorableDatabaseAccountGetResult` has been removed + Field `Tags` of struct `RestorableMongodbCollectionGetResult` has been removed + Field `Tags` of struct `RestorableMongodbDatabaseGetResult` has been removed + Field `Tags` of struct `RestorableSQLContainerGetResult` has been removed + Field `Tags` of struct `RestorableSQLDatabaseGetResult` has been removed + Struct `DefaultErrorResponse` has been removed
️✔️azure-sdk-for-go - preview/cosmos-db/mgmt/2020-04-01-preview/documentdb - Approved - v55.2.0️✔️azure-sdk-for-go - preview/cosmos-db/mgmt/2020-03-01-preview/documentdb - Approved - v55.2.0️✔️azure-sdk-for-go - preview/cosmos-db/mgmt/2019-12-12-preview/documentdb - Approved - v55.2.0️✔️azure-sdk-for-go - preview/cosmos-db/mgmt/2019-08-01-preview/documentdb - Approved - v55.2.0️✔️azure-sdk-for-go - cosmos-db/mgmt/2021-05-15/documentdb - Approved - v55.2.0️⚠️ azure-sdk-for-python-track2 warning [Detail]
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️track2_azure-mgmt-cosmosdb [View full logs] [Release SDK Changes]info [Changelog] **Features** info [Changelog] info [Changelog] - Model PeriodicModeBackupPolicy has a new parameter migration_state info [Changelog] - Model DatabaseAccountUpdateParameters has a new parameter disable_local_auth info [Changelog] - Model DatabaseAccountUpdateParameters has a new parameter analytical_storage_configuration info [Changelog] - Model DatabaseAccountCreateUpdateParameters has a new parameter create_mode info [Changelog] - Model DatabaseAccountCreateUpdateParameters has a new parameter restore_parameters info [Changelog] - Model DatabaseAccountCreateUpdateParameters has a new parameter analytical_storage_configuration info [Changelog] - Model DatabaseAccountCreateUpdateParameters has a new parameter disable_local_auth info [Changelog] - Model ContinuousModeBackupPolicy has a new parameter migration_state info [Changelog] - Model DatabaseAccountGetResults has a new parameter system_data info [Changelog] - Model DatabaseAccountGetResults has a new parameter create_mode info [Changelog] - Model DatabaseAccountGetResults has a new parameter analytical_storage_configuration info [Changelog] - Model DatabaseAccountGetResults has a new parameter disable_local_auth info [Changelog] - Model DatabaseAccountGetResults has a new parameter restore_parameters info [Changelog] - Model DatabaseAccountGetResults has a new parameter instance_id info [Changelog] - Model BackupPolicy has a new parameter migration_state info [Changelog] - Added operation SqlResourcesOperations.begin_retrieve_continuous_backup_information info [Changelog] - Added operation group RestorableMongodbCollectionsOperations info [Changelog] - Added operation group RestorableMongodbResourcesOperations info [Changelog] - Added operation group RestorableMongodbDatabasesOperations info [Changelog] - Added operation group RestorableDatabaseAccountsOperations info [Changelog] - Added operation group RestorableSqlDatabasesOperations info [Changelog] - Added operation group RestorableSqlResourcesOperations info [Changelog] - Added operation group RestorableSqlContainersOperations
️⚠️ azure-sdk-for-java warning [Detail]
command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json cmderr [generate.py] 2021-06-15 05:54:52 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-cosmos-generated" cmderr [generate.py] 2021-06-15 05:54:52 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1" cmderr [generate.py] 2021-06-15 05:54:52 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.30 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/cosmos/azure-resourcemanager-cosmos-generated --java.namespace=com.azure.resourcemanager.cosmos.generated --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/cosmos-db/resource-manager/readme.md cmderr [generate.py] 2021-06-15 05:55:48 INFO [CI][Success] Write to ci.yml cmderr [generate.py] 2021-06-15 05:55:48 INFO [POM][Process] dealing with pom.xml cmderr [generate.py] 2021-06-15 05:55:48 INFO [POM][Success] Write to pom.xml cmderr [generate.py] 2021-06-15 05:55:48 INFO [POM][Process] dealing with root pom cmderr [generate.py] 2021-06-15 05:55:48 INFO [POM][Skip] pom already has module sdk/cosmos cmderr [generate.py] 2021-06-15 05:55:48 INFO [POM][Success] Write to root pom
️✔️azure-resourcemanager-cosmos-generated [View full logs] [Release SDK Changes]- pom.xml
- azure-resourcemanager-cosmos-generated-1.0.0-beta.1-javadoc.jar
- azure-resourcemanager-cosmos-generated-1.0.0-beta.1-sources.jar
- azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar
cmderr [Inst] 2021-06-15 06:00:15 DEBUG Got artifact_id: azure-resourcemanager-cosmos-generated cmderr [Inst] 2021-06-15 06:00:15 DEBUG Got artifact: pom.xml cmderr [Inst] 2021-06-15 06:00:15 DEBUG Got artifact: azure-resourcemanager-cosmos-generated-1.0.0-beta.1-javadoc.jar cmderr [Inst] 2021-06-15 06:00:15 DEBUG Got artifact: azure-resourcemanager-cosmos-generated-1.0.0-beta.1-sources.jar cmderr [Inst] 2021-06-15 06:00:15 DEBUG Got artifact: azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar cmderr [Inst] 2021-06-15 06:00:15 DEBUG Match jar package: azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar cmderr [Inst] 2021-06-15 06:00:15 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14627/azure-sdk-for-java/azure-resourcemanager-cosmos-generated/azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-cosmos-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true ```"}
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
command sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️cosmos-db/mgmt/2021-05-15/documentdb [View full logs] [Release SDK Changes]info [Changelog] No exported changes
️✔️cosmos-db/mgmt/2021-04-15/documentdb [View full logs] [Release SDK Changes]info [Changelog] This is a new package
️✔️cosmos-db/mgmt/2021-03-15/documentdb [View full logs] [Release SDK Changes]info [Changelog] No exported changes
️✔️cosmos-db/mgmt/2021-01-15/documentdb [View full logs] [Release SDK Changes]info [Changelog] No exported changes
️✔️cosmos-db/mgmt/2019-08-01/documentdb [View full logs] [Release SDK Changes]info [Changelog] No exported changes
️✔️cosmos-db/mgmt/2015-04-08/documentdb [View full logs] [Release SDK Changes]info [Changelog] No exported changes
️✔️preview/cosmos-db/mgmt/2021-04-01-preview/documentdb [View full logs] [Release SDK Changes]info [Changelog] No exported changes
- Only show 9 items here, please refer to log for details.
️✔️preview/cosmos-db/mgmt/2021-03-01-preview/documentdb [View full logs] [Release SDK Changes]info [Changelog] - New function `BaseClient.LocationListPreparer(context.Context) (*http.Request, error)` info [Changelog] - New function `LocationListResult.MarshalJSON() ([]byte, error)` info [Changelog] - New function `LocationProperties.MarshalJSON() ([]byte, error)` info [Changelog] - New struct `LocationGetResult` info [Changelog] - New struct `LocationListResult` info [Changelog] - New struct `LocationProperties` info [Changelog] info [Changelog] Total 0 breaking change(s), 17 additive change(s). info [Changelog]
️✔️preview/cosmos-db/mgmt/2020-09-01-preview/documentdb [View full logs] [Release SDK Changes]info [Changelog] No exported changes
- Only show 9 items here, please refer to log for details.
️✔️preview/cosmos-db/mgmt/2020-06-01-preview/documentdb [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] - New const `Zone` info [Changelog] - New const `Geo` info [Changelog] - New const `Local` info [Changelog] - New function `PossibleBackupStorageRedundancyValues() []BackupStorageRedundancy` info [Changelog] - New struct `CloudError` info [Changelog] - New field `BackupStorageRedundancy` in struct `PeriodicModeProperties` info [Changelog] info [Changelog] Total 7 breaking change(s), 7 additive change(s). info [Changelog]
️✔️preview/cosmos-db/mgmt/2020-04-01-preview/documentdb [View full logs] [Release SDK Changes]info [Changelog] No exported changes
️✔️preview/cosmos-db/mgmt/2020-03-01-preview/documentdb [View full logs] [Release SDK Changes]info [Changelog] No exported changes
️✔️preview/cosmos-db/mgmt/2019-12-12-preview/documentdb [View full logs] [Release SDK Changes]info [Changelog] No exported changes
️✔️preview/cosmos-db/mgmt/2019-08-01-preview/documentdb [View full logs] [Release SDK Changes]info [Changelog] No exported changes
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
warn Skip initScript due to not configured command autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/cosmos-db/resource-manager/readme.md
️✔️@azure/arm-cosmosdb [View full logs] [Release SDK Changes]cmderr [npmPack] loaded rollup.config.js with warnings cmderr [npmPack] (!) Unused external imports cmderr [npmPack] default imported from external module 'rollup' but never used cmderr [npmPack] ./esm/cosmosDBManagementClient.js → ./dist/arm-cosmosdb.js... cmderr [npmPack] created ./dist/arm-cosmosdb.js in 940ms
️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️cosmos-db [View full logs] [Release Schema Changes]
|
Hi, @kavskalyan your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @ |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
This was referenced Jun 1, 2021
JeffreyRichter
approved these changes
Jun 14, 2021
JeffreyRichter
added
the
Approved-BreakingChange
kavskalyan
added
DoNotMerge
weidongxu-microsoft
approved these changes
Jun 15, 2021
This was referenced Jun 15, 2021
11 tasks
asager
pushed a commit
to asager/azure-rest-api-specs
that referenced
this pull request
Jun 24, 2021
…n stable/2021-06-15 (Azure#14627) * Adds base for updating Microsoft.DocumentDB from version stable/2021-04-15 to version 2021-06-15 * Updates readme * Updates API version in new specs and examples * PITR apis to stable version * Fixing readme * Adding parameters * Fixing restorable.json * Fixing linter errors * missing ref * Unflattening the DatabaseAccountCreateUpdateProperties * Adds base for updating Microsoft.DocumentDB from version stable/2021-05-15 to version 2021-06-15 * Updates readme * Updates API version in new specs and examples * Adding the restorable json to readme * Added disableLocalAuth flag to DatabaseAccount CRU operations. * Adding Backup policy migration state * Fixing linter errors * Fixing linter warnings * Fixing breaking change Co-authored-by: ayanMSFT <53790657+ayanMSFT@users.noreply.github.com>
ctaggart
reviewed
Jun 25, 2021
| @@ -45,11 +59,25 @@ modelerfour: | |||
| lenient-model-deduplication: true | |||
| ``` | |||
|
|
|||
|
|
|||
| ### Tag: package-2021-06 | |||
|
|
|||
There was a problem hiding this comment.
I created #14995 for this duplicate tag.
| ``` | ||
|
|
||
|
|
||
| ### Tag: package-2021-06 |
There was a problem hiding this comment.
This gets duplicated below.
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…n stable/2021-06-15 (Azure#14627) * Adds base for updating Microsoft.DocumentDB from version stable/2021-04-15 to version 2021-06-15 * Updates readme * Updates API version in new specs and examples * PITR apis to stable version * Fixing readme * Adding parameters * Fixing restorable.json * Fixing linter errors * missing ref * Unflattening the DatabaseAccountCreateUpdateProperties * Adds base for updating Microsoft.DocumentDB from version stable/2021-05-15 to version 2021-06-15 * Updates readme * Updates API version in new specs and examples * Adding the restorable json to readme * Added disableLocalAuth flag to DatabaseAccount CRU operations. * Adding Backup policy migration state * Fixing linter errors * Fixing linter warnings * Fixing breaking change Co-authored-by: ayanMSFT <53790657+ayanMSFT@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.