Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the API version for Servers so that it works with OutboundFirewallRules #14687

Merged
merged 2 commits into from
Jun 7, 2021
Merged

Update the API version for Servers so that it works with OutboundFirewallRules #14687

merged 2 commits into from
Jun 7, 2021

Conversation

VMMicrosoft
Copy link
Contributor

@VMMicrosoft VMMicrosoft commented Jun 4, 2021 •
edited by zhenglaizhang
Loading

…wallRules

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@VMMicrosoft VMMicrosoft requested a review from bcham as a code owner June 4, 2021 21:38
@openapi-workflow-bot
Copy link

Hi, @VMMicrosoft Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @ghost ghost added the SQL label Jun 4, 2021
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 4, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/sql/resource-manager/readme.md
    tag: specification/sql/resource-manager/readme.md#tag-package-composite-v5
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail]
    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"sql/resource-manager/readme.md",
    "tag":"package-composite-v5",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"sql/resource-manager/readme.md",
    "tag":"package-composite-v5",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|


    The following errors/warnings exist before current PR submission:

    Rule Message
    ❌ AutorestCore/Exception "readme":"sql/resource-manager/readme.md",
    "tag":"package-composite-v5",
    "details":"Error: Plugin pre-namer reported failure."
    💬 AutorestCore/Exception "readme":"sql/resource-manager/readme.md",
    "tag":"package-composite-v5",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 4, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-sql - 2.1.0
    ️✔️azure-sdk-for-go - sql/mgmt/2014-04-01/sql - Approved - v55.1.0
    ❌azure-sdk-for-go - preview/sql/mgmt/v4.0/sql - Approved - v55.1.0
    +	Const `All` type has been changed from `DatabaseState1` to `DatabaseState`
+	Const `DatabaseState2All` has been removed
+	Const `DatabaseState2Deleted` has been removed
+	Const `DatabaseState2Live` has been removed
+	Const `DatabaseState3All` has been removed
+	Const `DatabaseState3Deleted` has been removed
+	Const `DatabaseState3Live` has been removed
+	Const `DatabaseState4All` has been removed
+	Const `DatabaseState4Deleted` has been removed
+	Const `DatabaseState4Live` has been removed
+	Const `DatabaseState5All` has been removed
+	Const `DatabaseState5Deleted` has been removed
+	Const `DatabaseState5Live` has been removed
+	Const `DatabaseState6All` has been removed
+	Const `DatabaseState6Deleted` has been removed
+	Const `DatabaseState6Live` has been removed
+	Const `Deleted` type has been changed from `DatabaseState1` to `DatabaseState`
+	Const `Geo` type has been changed from `SecondaryType` to `BackupStorageRedundancy`
+	Const `Live` type has been changed from `DatabaseState1` to `DatabaseState`
+	Const `LongTermRetentionDatabaseStateAll` has been removed
+	Const `LongTermRetentionDatabaseStateDeleted` has been removed
+	Const `LongTermRetentionDatabaseStateLive` has been removed
+	Const `Named` has been removed
+	Field `StorageAccountType` of struct `DatabaseProperties` has been removed
+	Function `*BackupLongTermRetentionPoliciesCreateOrUpdateFuture.UnmarshalJSON` has been removed
+	Function `*BackupLongTermRetentionPolicy.UnmarshalJSON` has been removed
+	Function `BackupLongTermRetentionPoliciesClient.CreateOrUpdatePreparer` has been removed
+	Function `BackupLongTermRetentionPoliciesClient.CreateOrUpdateResponder` has been removed
+	Function `BackupLongTermRetentionPoliciesClient.CreateOrUpdateSender` has been removed
+	Function `BackupLongTermRetentionPoliciesClient.CreateOrUpdate` has been removed
+	Function `BackupLongTermRetentionPoliciesClient.GetPreparer` has been removed
+	Function `BackupLongTermRetentionPoliciesClient.GetResponder` has been removed
+	Function `BackupLongTermRetentionPoliciesClient.GetSender` has been removed
+	Function `BackupLongTermRetentionPoliciesClient.Get` has been removed
+	Function `BackupLongTermRetentionPoliciesClient.ListByDatabasePreparer` has been removed
+	Function `BackupLongTermRetentionPoliciesClient.ListByDatabaseResponder` has been removed
+	Function `BackupLongTermRetentionPoliciesClient.ListByDatabaseSender` has been removed
+	Function `BackupLongTermRetentionPoliciesClient.ListByDatabase` has been removed
+	Function `BackupLongTermRetentionPolicy.MarshalJSON` has been removed
+	Function `LongTermRetentionBackupsClient.ListByDatabaseComplete` parameter(s) have been changed from `(context.Context, string, string, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, string, string, *bool, DatabaseState)`
+	Function `LongTermRetentionBackupsClient.ListByDatabasePreparer` parameter(s) have been changed from `(context.Context, string, string, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, string, string, *bool, DatabaseState)`
+	Function `LongTermRetentionBackupsClient.ListByDatabase` parameter(s) have been changed from `(context.Context, string, string, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, string, string, *bool, DatabaseState)`
+	Function `LongTermRetentionBackupsClient.ListByLocationComplete` parameter(s) have been changed from `(context.Context, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, *bool, DatabaseState)`
+	Function `LongTermRetentionBackupsClient.ListByLocationPreparer` parameter(s) have been changed from `(context.Context, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, *bool, DatabaseState)`
+	Function `LongTermRetentionBackupsClient.ListByLocation` parameter(s) have been changed from `(context.Context, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, *bool, DatabaseState)`
+	Function `LongTermRetentionBackupsClient.ListByResourceGroupDatabaseComplete` parameter(s) have been changed from `(context.Context, string, string, string, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, string, string, string, *bool, DatabaseState)`
+	Function `LongTermRetentionBackupsClient.ListByResourceGroupDatabasePreparer` parameter(s) have been changed from `(context.Context, string, string, string, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, string, string, string, *bool, DatabaseState)`
+	Function `LongTermRetentionBackupsClient.ListByResourceGroupDatabase` parameter(s) have been changed from `(context.Context, string, string, string, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, string, string, string, *bool, DatabaseState)`
+	Function `LongTermRetentionBackupsClient.ListByResourceGroupLocationComplete` parameter(s) have been changed from `(context.Context, string, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, string, *bool, DatabaseState)`
+	Function `LongTermRetentionBackupsClient.ListByResourceGroupLocationPreparer` parameter(s) have been changed from `(context.Context, string, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, string, *bool, DatabaseState)`
+	Function `LongTermRetentionBackupsClient.ListByResourceGroupLocation` parameter(s) have been changed from `(context.Context, string, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, string, *bool, DatabaseState)`
+	Function `LongTermRetentionBackupsClient.ListByResourceGroupServerComplete` parameter(s) have been changed from `(context.Context, string, string, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, string, string, *bool, DatabaseState)`
+	Function `LongTermRetentionBackupsClient.ListByResourceGroupServerPreparer` parameter(s) have been changed from `(context.Context, string, string, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, string, string, *bool, DatabaseState)`
+	Function `LongTermRetentionBackupsClient.ListByResourceGroupServer` parameter(s) have been changed from `(context.Context, string, string, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, string, string, *bool, DatabaseState)`
+	Function `LongTermRetentionBackupsClient.ListByServerComplete` parameter(s) have been changed from `(context.Context, string, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, string, *bool, DatabaseState)`
+	Function `LongTermRetentionBackupsClient.ListByServerPreparer` parameter(s) have been changed from `(context.Context, string, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, string, *bool, DatabaseState)`
+	Function `LongTermRetentionBackupsClient.ListByServer` parameter(s) have been changed from `(context.Context, string, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, string, *bool, DatabaseState)`
+	Function `LongTermRetentionManagedInstanceBackupsClient.ListByDatabaseComplete` parameter(s) have been changed from `(context.Context, string, string, string, *bool, DatabaseState1)` to `(context.Context, string, string, string, *bool, DatabaseState)`
+	Function `LongTermRetentionManagedInstanceBackupsClient.ListByDatabasePreparer` parameter(s) have been changed from `(context.Context, string, string, string, *bool, DatabaseState1)` to `(context.Context, string, string, string, *bool, DatabaseState)`
+	Function `LongTermRetentionManagedInstanceBackupsClient.ListByDatabase` parameter(s) have been changed from `(context.Context, string, string, string, *bool, DatabaseState1)` to `(context.Context, string, string, string, *bool, DatabaseState)`
+	Function `LongTermRetentionManagedInstanceBackupsClient.ListByInstanceComplete` parameter(s) have been changed from `(context.Context, string, string, *bool, DatabaseState2)` to `(context.Context, string, string, *bool, DatabaseState)`
+	Function `LongTermRetentionManagedInstanceBackupsClient.ListByInstancePreparer` parameter(s) have been changed from `(context.Context, string, string, *bool, DatabaseState2)` to `(context.Context, string, string, *bool, DatabaseState)`
+	Function `LongTermRetentionManagedInstanceBackupsClient.ListByInstance` parameter(s) have been changed from `(context.Context, string, string, *bool, DatabaseState2)` to `(context.Context, string, string, *bool, DatabaseState)`
+	Function `LongTermRetentionManagedInstanceBackupsClient.ListByLocationComplete` parameter(s) have been changed from `(context.Context, string, *bool, DatabaseState3)` to `(context.Context, string, *bool, DatabaseState)`
+	Function `LongTermRetentionManagedInstanceBackupsClient.ListByLocationPreparer` parameter(s) have been changed from `(context.Context, string, *bool, DatabaseState3)` to `(context.Context, string, *bool, DatabaseState)`
+	Function `LongTermRetentionManagedInstanceBackupsClient.ListByLocation` parameter(s) have been changed from `(context.Context, string, *bool, DatabaseState3)` to `(context.Context, string, *bool, DatabaseState)`
+	Function `LongTermRetentionManagedInstanceBackupsClient.ListByResourceGroupDatabaseComplete` parameter(s) have been changed from `(context.Context, string, string, string, string, *bool, DatabaseState4)` to `(context.Context, string, string, string, string, *bool, DatabaseState)`
+	Function `LongTermRetentionManagedInstanceBackupsClient.ListByResourceGroupDatabasePreparer` parameter(s) have been changed from `(context.Context, string, string, string, string, *bool, DatabaseState4)` to `(context.Context, string, string, string, string, *bool, DatabaseState)`
+	Function `LongTermRetentionManagedInstanceBackupsClient.ListByResourceGroupDatabase` parameter(s) have been changed from `(context.Context, string, string, string, string, *bool, DatabaseState4)` to `(context.Context, string, string, string, string, *bool, DatabaseState)`
+	Function `LongTermRetentionManagedInstanceBackupsClient.ListByResourceGroupInstanceComplete` parameter(s) have been changed from `(context.Context, string, string, string, *bool, DatabaseState5)` to `(context.Context, string, string, string, *bool, DatabaseState)`
+	Function `LongTermRetentionManagedInstanceBackupsClient.ListByResourceGroupInstancePreparer` parameter(s) have been changed from `(context.Context, string, string, string, *bool, DatabaseState5)` to `(context.Context, string, string, string, *bool, DatabaseState)`
+	Function `LongTermRetentionManagedInstanceBackupsClient.ListByResourceGroupInstance` parameter(s) have been changed from `(context.Context, string, string, string, *bool, DatabaseState5)` to `(context.Context, string, string, string, *bool, DatabaseState)`
+	Function `LongTermRetentionManagedInstanceBackupsClient.ListByResourceGroupLocationComplete` parameter(s) have been changed from `(context.Context, string, string, *bool, DatabaseState6)` to `(context.Context, string, string, *bool, DatabaseState)`
+	Function `LongTermRetentionManagedInstanceBackupsClient.ListByResourceGroupLocationPreparer` parameter(s) have been changed from `(context.Context, string, string, *bool, DatabaseState6)` to `(context.Context, string, string, *bool, DatabaseState)`
+	Function `LongTermRetentionManagedInstanceBackupsClient.ListByResourceGroupLocation` parameter(s) have been changed from `(context.Context, string, string, *bool, DatabaseState6)` to `(context.Context, string, string, *bool, DatabaseState)`
+	Function `NewBackupLongTermRetentionPoliciesClientWithBaseURI` has been removed
+	Function `NewBackupLongTermRetentionPoliciesClient` has been removed
+	Function `PossibleDatabaseState1Values` has been removed
+	Function `PossibleDatabaseState2Values` has been removed
+	Function `PossibleDatabaseState3Values` has been removed
+	Function `PossibleDatabaseState4Values` has been removed
+	Function `PossibleDatabaseState5Values` has been removed
+	Function `PossibleDatabaseState6Values` has been removed
+	Function `PossibleLongTermRetentionDatabaseStateValues` has been removed
+	Function `SystemData.MarshalJSON` has been removed
+	Struct `BackupLongTermRetentionPoliciesClient` has been removed
+	Struct `BackupLongTermRetentionPoliciesCreateOrUpdateFuture` has been removed
+	Struct `BackupLongTermRetentionPolicy` has been removed
+	Struct `LongTermRetentionPolicyProperties` has been removed
    ❌azure-sdk-for-go - preview/sql/mgmt/v3.0/sql - Approved - v55.1.0
    +	Const `Average` has been removed
+	Const `Count` type has been changed from `PrimaryAggregationType` to `QueryMetricUnitType`
+	Const `Maximum` has been removed
+	Const `Minimum` has been removed
+	Const `None` type has been changed from `PrimaryAggregationType` to `IdentityType`
+	Const `Total` has been removed
+	Function `*ManagedDatabaseRestoreDetailsResult.UnmarshalJSON` has been removed
+	Function `ManagedDatabaseRestoreDetailsClient.GetPreparer` has been removed
+	Function `ManagedDatabaseRestoreDetailsClient.GetResponder` has been removed
+	Function `ManagedDatabaseRestoreDetailsClient.GetSender` has been removed
+	Function `ManagedDatabaseRestoreDetailsClient.Get` has been removed
+	Function `ManagedDatabaseRestoreDetailsProperties.MarshalJSON` has been removed
+	Function `ManagedDatabaseRestoreDetailsResult.MarshalJSON` has been removed
+	Function `NewManagedDatabaseRestoreDetailsClientWithBaseURI` has been removed
+	Function `NewManagedDatabaseRestoreDetailsClient` has been removed
+	Struct `ManagedDatabaseRestoreDetailsClient` has been removed
+	Struct `ManagedDatabaseRestoreDetailsProperties` has been removed
+	Struct `ManagedDatabaseRestoreDetailsResult` has been removed
    ❌azure-sdk-for-go - preview/sql/mgmt/2018-06-01-preview/sql - Approved - v55.1.0
    +	Const `Critical` has been removed
+	Const `High` has been removed
+	Const `Low` has been removed
+	Const `Medium` has been removed
+	Const `None` type has been changed from `SensitivityLabelRank` to `IdentityType`
    ️✔️azure-sdk-for-go - preview/sql/mgmt/2017-10-01-preview/sql - Approved - v55.1.0
    ❌azure-sdk-for-go - preview/sql/mgmt/2017-03-01-preview/sql - Approved - v55.1.0
    +	Const `Average` has been removed
+	Const `Count` type has been changed from `PrimaryAggregationType` to `UnitDefinitionType`
+	Const `Maximum` has been removed
+	Const `Minimum` has been removed
+	Const `None` type has been changed from `PrimaryAggregationType` to `IdentityType`
+	Const `Total` has been removed
+	Const `UnitDefinitionTypeBytesPerSecond` has been removed
+	Const `UnitDefinitionTypeBytes` has been removed
+	Const `UnitDefinitionTypeCountPerSecond` has been removed
+	Const `UnitDefinitionTypeCount` has been removed
+	Const `UnitDefinitionTypePercent` has been removed
+	Const `UnitDefinitionTypeSeconds` has been removed
    ❌azure-sdk-for-go - preview/sql/mgmt/2015-05-01-preview/sql - Approved - v55.1.0
    +	Const `Average` has been removed
+	Const `Count` type has been changed from `PrimaryAggregationType` to `UnitDefinitionType`
+	Const `Maximum` has been removed
+	Const `Minimum` has been removed
+	Const `None` type has been changed from `PrimaryAggregationType` to `IdentityType`
+	Const `Total` has been removed
+	Const `UnitDefinitionTypeBytesPerSecond` has been removed
+	Const `UnitDefinitionTypeBytes` has been removed
+	Const `UnitDefinitionTypeCountPerSecond` has been removed
+	Const `UnitDefinitionTypeCount` has been removed
+	Const `UnitDefinitionTypePercent` has been removed
+	Const `UnitDefinitionTypeSeconds` has been removed
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 10c93ad. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/sql/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Sql [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 10c93ad. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-sql [View full logs]  [Release SDK Changes] 
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model ServerUpdate has a new parameter federated_client_id
info	[Changelog]   - Model ServerUpdate has a new parameter restrict_outbound_network_access
info	[Changelog]   - Model Server has a new parameter federated_client_id
info	[Changelog]   - Model Server has a new parameter restrict_outbound_network_access
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 10c93ad. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-sql [View full logs]  [Release SDK Changes] 
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model ServerUpdate has a new parameter restrict_outbound_network_access
info	[Changelog]   - Model ServerUpdate has a new parameter federated_client_id
info	[Changelog]   - Model Server has a new parameter restrict_outbound_network_access
info	[Changelog]   - Model Server has a new parameter federated_client_id
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 10c93ad. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-06-07 08:48:23 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-sql-generated"
cmderr	[generate.py] 2021-06-07 08:48:23 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-06-07 08:48:23 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.29 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/sql/azure-resourcemanager-sql-generated --java.namespace=com.azure.resourcemanager.sql.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/sql/resource-manager/readme.md
cmderr	[generate.py] 2021-06-07 08:52:22 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-06-07 08:52:22 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-06-07 08:52:22 INFO [POM][Skip] pom already has module azure-resourcemanager-sql-generated
cmderr	[generate.py] 2021-06-07 08:52:22 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-06-07 08:52:22 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-06-07 08:52:22 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-sql-generated [View full logs]  [Release SDK Changes] 
      cmderr	[Inst] 2021-06-07 08:57:49 DEBUG Got artifact_id: azure-resourcemanager-sql-generated
cmderr	[Inst] 2021-06-07 08:57:49 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-06-07 08:57:49 DEBUG Got artifact: azure-resourcemanager-sql-generated-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-06-07 08:57:49 DEBUG Got artifact: azure-resourcemanager-sql-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-06-07 08:57:49 DEBUG Match jar package: azure-resourcemanager-sql-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-06-07 08:57:49 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14687/azure-sdk-for-java/azure-resourcemanager-sql-generated/azure-resourcemanager-sql-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-sql-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-sql-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-sql-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 10c93ad. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sql/mgmt/2014-04-01/sql [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/sql/mgmt/v4.0/sql [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 18 items here, please refer to log for details.
      info	[Changelog] - New struct `LongTermRetentionBackupsUpdateByResourceGroupFuture`
info	[Changelog] - New struct `LongTermRetentionBackupsUpdateFuture`
info	[Changelog] - New struct `LongTermRetentionOperationResultProperties`
info	[Changelog] - New struct `LongTermRetentionPoliciesClient`
info	[Changelog] - New struct `LongTermRetentionPoliciesCreateOrUpdateFuture`
info	[Changelog] - New struct `LongTermRetentionPolicy`
info	[Changelog] - New struct `LongTermRetentionPolicyListResult`
info	[Changelog] - New struct `LongTermRetentionPolicyListResultIterator`
info	[Changelog] - New struct `LongTermRetentionPolicyListResultPage`
info	[Changelog] - New struct `UpdateLongTermRetentionBackupParameters`
info	[Changelog] - New struct `UpdateLongTermRetentionBackupParametersProperties`
info	[Changelog] - New field `CurrentBackupStorageRedundancy` in struct `DatabaseProperties`
info	[Changelog] - New field `RequestedBackupStorageRedundancy` in struct `DatabaseProperties`
info	[Changelog] - New field `BackupStorageRedundancy` in struct `LongTermRetentionBackupProperties`
info	[Changelog] - New field `RequestedBackupStorageRedundancy` in struct `LongTermRetentionBackupProperties`
info	[Changelog]
info	[Changelog] Total 93 breaking change(s), 111 additive change(s).
info	[Changelog]
    • ️✔️preview/sql/mgmt/v3.0/sql [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 18 items here, please refer to log for details.
      info	[Changelog] - New function `ManagedInstancesClient.ListByManagedInstanceComplete(context.Context, string, string, *int32, string, string, string, QueryTimeGrainType, AggregationFunctionType, MetricType) (TopQueriesListResultIterator, error)`
info	[Changelog] - New function `QueryMetricProperties.MarshalJSON() ([]byte, error)`
info	[Changelog] - New struct `ManagedInstancePecProperty`
info	[Changelog] - New struct `ManagedInstancePrivateEndpointConnectionProperties`
info	[Changelog] - New struct `ManagedInstancePrivateEndpointProperty`
info	[Changelog] - New struct `QueryMetricInterval`
info	[Changelog] - New struct `QueryMetricProperties`
info	[Changelog] - New struct `QueryStatisticsProperties`
info	[Changelog] - New struct `TopQueries`
info	[Changelog] - New struct `TopQueriesListResult`
info	[Changelog] - New struct `TopQueriesListResultIterator`
info	[Changelog] - New struct `TopQueriesListResultPage`
info	[Changelog] - New field `Identity` in struct `ManagedInstanceUpdate`
info	[Changelog] - New field `PrivateEndpointConnections` in struct `ManagedInstanceProperties`
info	[Changelog] - New field `ZoneRedundant` in struct `ManagedInstanceProperties`
info	[Changelog]
info	[Changelog] Total 21 breaking change(s), 73 additive change(s).
info	[Changelog]
    • ️✔️preview/sql/mgmt/2018-06-01-preview/sql [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 18 items here, please refer to log for details.
      info	[Changelog]
info	[Changelog] - Const `None` type has been changed from `SensitivityLabelRank` to `IdentityType`
info	[Changelog] - Const `Medium` has been removed
info	[Changelog] - Const `Critical` has been removed
info	[Changelog] - Const `High` has been removed
info	[Changelog] - Const `Low` has been removed
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `SensitivityLabelRankMedium`
info	[Changelog] - New const `SensitivityLabelRankLow`
info	[Changelog] - New const `SensitivityLabelRankHigh`
info	[Changelog] - New const `UserAssigned`
info	[Changelog] - New const `SensitivityLabelRankCritical`
info	[Changelog] - New const `SensitivityLabelRankNone`
info	[Changelog]
info	[Changelog] Total 5 breaking change(s), 6 additive change(s).
info	[Changelog]
    • ️✔️preview/sql/mgmt/2017-10-01-preview/sql [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/sql/mgmt/2017-03-01-preview/sql [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 18 items here, please refer to log for details.
      info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `Percent`
info	[Changelog] - New const `Bytes`
info	[Changelog] - New const `PrimaryAggregationTypeNone`
info	[Changelog] - New const `PrimaryAggregationTypeTotal`
info	[Changelog] - New const `PrimaryAggregationTypeCount`
info	[Changelog] - New const `PrimaryAggregationTypeMaximum`
info	[Changelog] - New const `CountPerSecond`
info	[Changelog] - New const `PrimaryAggregationTypeMinimum`
info	[Changelog] - New const `BytesPerSecond`
info	[Changelog] - New const `Seconds`
info	[Changelog] - New const `PrimaryAggregationTypeAverage`
info	[Changelog] - New const `UserAssigned`
info	[Changelog]
info	[Changelog] Total 12 breaking change(s), 12 additive change(s).
info	[Changelog]
    • ️✔️preview/sql/mgmt/2015-05-01-preview/sql [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 18 items here, please refer to log for details.
      info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `Seconds`
info	[Changelog] - New const `BytesPerSecond`
info	[Changelog] - New const `Percent`
info	[Changelog] - New const `PrimaryAggregationTypeNone`
info	[Changelog] - New const `PrimaryAggregationTypeMinimum`
info	[Changelog] - New const `CountPerSecond`
info	[Changelog] - New const `Bytes`
info	[Changelog] - New const `PrimaryAggregationTypeTotal`
info	[Changelog] - New const `PrimaryAggregationTypeAverage`
info	[Changelog] - New const `PrimaryAggregationTypeCount`
info	[Changelog] - New const `UserAssigned`
info	[Changelog] - New const `PrimaryAggregationTypeMaximum`
info	[Changelog]
info	[Changelog] Total 12 breaking change(s), 12 additive change(s).
info	[Changelog]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 10c93ad. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.6.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/sql/resource-manager/readme.md
    • ️✔️@azure/arm-sql [View full logs]  [Release SDK Changes] 
      cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/sqlManagementClient.js → ./dist/arm-sql.js...
cmderr	[npmPack] created ./dist/arm-sql.js in 2.5s
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 10c93ad. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
    Posted by Swagger Pipeline | How to fix these errors?

    This was referenced Jun 4, 2021
    Closed
    Closed
    @openapi-workflow-bot
    Copy link

    Hi, @VMMicrosoft your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @zhenglaizhang

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 4, 2021
    This was referenced Jun 4, 2021
    Closed
    Closed
    Closed
    Closed
    @zhenglaizhang zhenglaizhang removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 7, 2021
    @zhenglaizhang
    Copy link
    Contributor

    just readme update, so no need ARM review.

    @zhenglaizhang zhenglaizhang added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Jun 7, 2021
    @zhenglaizhang
    Copy link
    Contributor

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @zhenglaizhang
    Copy link
    Contributor

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @ArcturusZhang ArcturusZhang added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Jun 7, 2021
    @zhenglaizhang zhenglaizhang merged commit 10c93ad into Azure:master Jun 7, 2021
    This was referenced Jun 7, 2021
    Closed
    Closed
    This was referenced Jun 7, 2021
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Merged
    ghost pushed a commit to Azure/azure-resource-manager-schemas that referenced this pull request Jun 7, 2021
    [ReleasePR sql] Update the API version for Servers so that it works w…
    d5db846 
    …ith OutboundFirewallRules (#1744)

Create to sync Azure/azure-rest-api-specs#14687
[ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/master...AzureSDKAutomation:sdkAuto/sql?expand=1)
    @VMMicrosoft VMMicrosoft mentioned this pull request Jun 7, 2021
    Merged
    11 tasks
    @heaths heaths mentioned this pull request Jun 16, 2021
    Merged
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    @VMMicrosoft @mkarmark
    Update the API version for Servers so that it works with OutboundFire…
    f030419 
    …wallRules (Azure#14687)

* Update the API version for Servers so that it works with OutboundFirewallRules

* Sort APIs
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ericshape ericshape ericshape approved these changes

    @bcham bcham Awaiting requested review from bcham

    Assignees

    @zhenglaizhang zhenglaizhang

    Labels
    Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go CI-BreakingChange-Go SQL
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    4 participants
    @VMMicrosoft @zhenglaizhang @ericshape @ArcturusZhang