Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.HybridCompute to add version preview/2021-06-10-preview #14797

Merged
merged 12 commits into from
Jun 21, 2021
Merged

[Hub Generated] Review request for Microsoft.HybridCompute to add version preview/2021-06-10-preview #14797

merged 12 commits into from
Jun 21, 2021

Conversation

dorothyhu
Copy link
Contributor

@dorothyhu dorothyhu commented Jun 14, 2021 •
edited
Loading

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @dorothyhu Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 14, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️⚠️LintDiff: 4 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.HybridCompute/preview/2021-06-10-preview/privateLinkScopes.json#L918
    ⚠️ R4021 - DescriptionAndTitleMissing 'patchSettings' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.HybridCompute/preview/2021-06-10-preview/HybridCompute.json#L783
    ⚠️ R4021 - DescriptionAndTitleMissing 'patchSettings' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.HybridCompute/preview/2021-06-10-preview/HybridCompute.json#L793
    ⚠️ R4021 - DescriptionAndTitleMissing 'osProfile' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.HybridCompute/preview/2021-06-10-preview/HybridCompute.json#L950


    The following errors/warnings exist before current PR submission:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    ❌ R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.HybridCompute/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.HybridCompute/preview/2021-06-10-preview/HybridCompute.json#L673
    ❌ R4037 - MissingTypeObject The schema 'OperationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridCompute/preview/2021-06-10-preview/HybridCompute.json#L706
    ❌ R4037 - MissingTypeObject The schema 'OperationValue' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridCompute/preview/2021-06-10-preview/HybridCompute.json#L719
    ❌ R4037 - MissingTypeObject The schema 'OperationValueDisplay' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridCompute/preview/2021-06-10-preview/HybridCompute.json#L738
    ❌ R4037 - MissingTypeObject The schema 'OSProfile' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridCompute/preview/2021-06-10-preview/HybridCompute.json#L773
    ❌ R4037 - MissingTypeObject The schema 'MachineProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridCompute/preview/2021-06-10-preview/HybridCompute.json#L811
    ❌ R4037 - MissingTypeObject The schema 'MachineUpdateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridCompute/preview/2021-06-10-preview/HybridCompute.json#L945
    ❌ R4037 - MissingTypeObject The schema 'Machine' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridCompute/preview/2021-06-10-preview/HybridCompute.json#L964
    ❌ R4037 - MissingTypeObject The schema 'MachineUpdate' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridCompute/preview/2021-06-10-preview/HybridCompute.json#L986
    ❌ R4037 - MissingTypeObject The schema 'MachineListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridCompute/preview/2021-06-10-preview/HybridCompute.json#L1003
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️❌Cross-Version Breaking Changes: 4 Errors, 0 Warnings failed [Detail]
    The following breaking changes are detected by comparison with the latest stable version:
    Rule Message
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.HybridCompute/preview/2021-06-10-preview/HybridCompute.json#L816:9
    Old: Microsoft.HybridCompute/stable/2021-05-20/HybridCompute.json#L787:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.HybridCompute/preview/2021-06-10-preview/HybridCompute.json#L773:5
    Old: Microsoft.HybridCompute/stable/2021-05-20/HybridCompute.json#L763:5


    The following breaking changes are detected by comparison with latest preview version:

    Rule Message
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.HybridCompute/preview/2021-06-10-preview/HybridCompute.json#L816:9
    Old: Microsoft.HybridCompute/preview/2021-05-17-preview/HybridCompute.json#L787:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.HybridCompute/preview/2021-06-10-preview/HybridCompute.json#L773:5
    Old: Microsoft.HybridCompute/preview/2021-05-17-preview/HybridCompute.json#L763:5
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"hybridcompute/resource-manager/readme.md",
    "tag":"package-preview-2021-06",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"hybridcompute/resource-manager/readme.md",
    "tag":"package-preview-2021-06",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"hybridcompute/resource-manager/readme.md",
    "tag":"package-preview-2021-06",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 14, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go - hybridcompute/mgmt/2020-08-02/hybridcompute - v55.2.0
    ️✔️azure-sdk-for-go - hybridcompute/mgmt/2019-12-12/hybridcompute - v55.2.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-hybridcompute - 7.0.0
    ️❌ azure-powershell failed [Detail]
    • ❌Failed [Logs]Release - Generate from 2273610. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
Resource not accessible by integration
HttpError: Resource not accessible by integration
    at /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@octokit/request@5.5.0/node_modules/@octokit/request/dist-node/index.js:76:23
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async workflowPkgUpdatePR (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:330:21)
    at async Object.exports.workflowPkgMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:41:5)
    at async workflowHandleReadmeMd (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:172:9)
    at async Object.exports.workflowMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:83:9)
    at async Object.exports.sdkAutoMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:152:13)
    at async /home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18
    • ️✔️Az.HybridCompute [View full logs]  
      error	Fatal error: Resource not accessible by integration
error	The following packages are still pending:
error		Az.HybridCompute
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 2273610. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/hybridcompute/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.HybridCompute [View full logs]  [Release SDK Changes] 
      warn	Skip artifact folder because it doesn't exist: artifacts/packages
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 2273610. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-hybridcompute [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model OSProfile has a new parameter linux_configuration
info	[Changelog]   - Model OSProfile has a new parameter windows_configuration
info	[Changelog]   - Model MachineProperties has a new parameter os_type
info	[Changelog]   - Model MachineProperties has a new parameter mssql_discovered
info	[Changelog]   - Model MachineProperties has a new parameter detected_properties
info	[Changelog]   - Model MachineProperties has a new parameter parent_cluster_resource_id
info	[Changelog]   - Model MachineProperties has a new parameter private_link_scope_resource_id
info	[Changelog]   - Added operation MachinesOperations.delete
info	[Changelog]   - Added operation group PrivateLinkResourcesOperations
info	[Changelog]   - Added operation group PrivateEndpointConnectionsOperations
info	[Changelog]   - Added operation group PrivateLinkScopesOperations
info	[Changelog]   - Added operation group HybridComputeManagementClientOperationsMixin
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Operation MachinesOperations.get has a new signature
info	[Changelog]   - Model MachineExtensionUpdate has a new signature
info	[Changelog]   - Model ErrorDetail has a new signature
info	[Changelog]   - Model MachineUpdateProperties has a new signature
info	[Changelog]   - Model MachineExtensionInstanceViewStatus has a new signature
info	[Changelog]   - Model OperationValue has a new signature
info	[Changelog]   - Model MachineExtension has a new signature
info	[Changelog]   - Model Machine has a new signature
info	[Changelog]   - Model MachineUpdate has a new signature
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 2273610. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-hybridcompute [View full logs]  [Release SDK Changes] 
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model MachineUpdateProperties has a new parameter os_profile
info	[Changelog]   - Model OSProfile has a new parameter windows_configuration
info	[Changelog]   - Model OSProfile has a new parameter linux_configuration
info	[Changelog]   - Model HybridComputePrivateLinkScopeProperties has a new parameter private_endpoint_connections
info	[Changelog]   - Model MachineProperties has a new parameter mssql_discovered
info	[Changelog]   - Model MachineProperties has a new parameter os_type
info	[Changelog]   - Added operation group HybridComputeManagementClientOperationsMixin
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 2273610. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-06-21 02:14:09 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-hybridcompute;1.0.0-beta.1;1.0.0-beta.2"
cmderr	[generate.py] 2021-06-21 02:14:09 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
cmderr	[generate.py] 2021-06-21 02:14:09 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.30 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/hybridcompute/azure-resourcemanager-hybridcompute --java.namespace=com.azure.resourcemanager.hybridcompute   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/hybridcompute/resource-manager/readme.md
cmderr	[generate.py] 2021-06-21 02:14:50 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-hybridcompute
cmderr	[generate.py] 2021-06-21 02:14:50 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-06-21 02:14:50 INFO [POM][Skip] pom already has module azure-resourcemanager-hybridcompute
cmderr	[generate.py] 2021-06-21 02:14:50 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-06-21 02:14:50 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-06-21 02:14:50 INFO [POM][Skip] pom already has module sdk/hybridcompute
cmderr	[generate.py] 2021-06-21 02:14:50 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-hybridcompute [View full logs]  [Release SDK Changes] 
      cmderr	[Inst] 2021-06-21 02:17:38 DEBUG Got artifact_id: azure-resourcemanager-hybridcompute
cmderr	[Inst] 2021-06-21 02:17:38 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-06-21 02:17:38 DEBUG Got artifact: azure-resourcemanager-hybridcompute-1.0.0-beta.2-sources.jar
cmderr	[Inst] 2021-06-21 02:17:38 DEBUG Got artifact: azure-resourcemanager-hybridcompute-1.0.0-beta.2.jar
cmderr	[Inst] 2021-06-21 02:17:38 DEBUG Match jar package: azure-resourcemanager-hybridcompute-1.0.0-beta.2.jar
cmderr	[Inst] 2021-06-21 02:17:38 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14797/azure-sdk-for-java/azure-resourcemanager-hybridcompute/azure-resourcemanager-hybridcompute-1.0.0-beta.2.jar\" -o azure-resourcemanager-hybridcompute-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-hybridcompute -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-hybridcompute-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 2273610. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️hybridcompute/mgmt/2020-08-02/hybridcompute [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️hybridcompute/mgmt/2019-12-12/hybridcompute [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 2273610. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/hybridcompute/resource-manager/readme.md
    • ️✔️@azure/arm-hybridcompute [View full logs]  [Release SDK Changes] 
      cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/hybridComputeManagementClient.js → ./dist/arm-hybridcompute.js...
cmderr	[npmPack] created ./dist/arm-hybridcompute.js in 310ms
    ️️✔️ azure-cli-extensions succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 2273610. Azure CLI Automation 14.0.0 
      warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/hybridcompute/resource-manager/readme.md
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'ProxyResource' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationValue' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationValueDisplay' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'OSProfile' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'MachineProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'MachineUpdateProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Machine' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'MachineUpdate' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'MachineListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceUpdate' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'MachineExtension' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'MachineExtensionUpdate' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'MachineExtensionProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'MachineExtensionUpdateProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'MachineExtensionInstanceView' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'MachineExtensionInstanceView-status' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'MachineExtensionsListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ExtensionTargetProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ExtensionTarget' with an undefined type and additionalProperties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'MachineExtensionUpgrade' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'PrivateLinkScopesResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'PrivateLinkScopesResource-tags' with an undefined type and additionalProperties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'TagsResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'TagsResource-tags' with an undefined type and additionalProperties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'HybridComputePrivateLinkScope' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'PrivateLinkScopeValidationDetails' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ConnectionDetail' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'HybridComputePrivateLinkScopeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'HybridComputePrivateLinkScopeListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
cmderr	[Autorest] --------------------------------------------------------
cmderr	[Autorest]   test-scenario:
cmderr	[Autorest]     - name: /Machines/get/Get Machine
cmderr	[Autorest]     - name: /Machines/get/List Machines by resource group
cmderr	[Autorest]     - name: /Machines/get/List Machines by resource group
cmderr	[Autorest]     - name: /connectedmachine/post/Upgrade Machine Extensions
cmderr	[Autorest]     - name: /MachineExtensions/put/Create or Update a Machine Extension
cmderr	[Autorest]     - name: /MachineExtensions/get/GET all Machine Extensions
cmderr	[Autorest]     - name: /MachineExtensions/get/GET Machine Extension
cmderr	[Autorest]     - name: /MachineExtensions/patch/Create or Update a Machine Extension
cmderr	[Autorest]     - name: /MachineExtensions/delete/Delete a Machine Extension
cmderr	[Autorest]     - name: /Machines/delete/Delete a Machine
cmderr	[Autorest]     - name: /PrivateEndpointConnections/put/Approve or reject a private endpoint connection with a given name.
cmderr	[Autorest]     - name: /PrivateEndpointConnections/get/Gets list of private endpoint connections on a private link scope.
cmderr	[Autorest]     - name: /PrivateEndpointConnections/get/Gets private endpoint connection.
cmderr	[Autorest]     - name: /PrivateEndpointConnections/delete/Deletes a private endpoint connection with a given name.
cmderr	[Autorest]     - name: /PrivateLinkResources/get/Gets private endpoint connection.
cmderr	[Autorest]     - name: /PrivateLinkResources/get/Gets private endpoint connection.
cmderr	[Autorest]     - name: /PrivateLinkScopes/put/PrivateLinkScopeCreate
cmderr	[Autorest]     - name: /PrivateLinkScopes/put/PrivateLinkScopeUpdate
cmderr	[Autorest]     - name: /PrivateLinkScopes/get/PrivateLinkScopeGet
cmderr	[Autorest]     - name: /PrivateLinkScopes/get/PrivateLinkScopeGet
cmderr	[Autorest]     - name: /PrivateLinkScopes/get/PrivateLinkScopeGet
cmderr	[Autorest]     - name: /PrivateLinkScopes/get/PrivateLinkScopeListByResourceGroup
cmderr	[Autorest]     - name: /PrivateLinkScopes/get/PrivateLinkScopesList.json
cmderr	[Autorest]     - name: /PrivateLinkScopes/patch/PrivateLinkScopeUpdateTagsOnly
cmderr	[Autorest]     - name: /PrivateLinkScopes/delete/PrivateLinkScopesDelete
cmderr	[Autorest] --------------------------------------------------------
    • ️✔️connectedmachine [View full logs]  [Release Azure CLI Changes]
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 2273610. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]
cmderr	[initScript.sh]  The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh]  so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh]
cmderr	[initScript.sh]  This is a one-time fix-up, please be patient...
cmderr	[initScript.sh]
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️hybridcompute [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    This was referenced Jun 14, 2021
    Draft
    Closed
    @dorothyhu
    Copy link
    Contributor Author

    /azp run unifiedPipeline

    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    This was referenced Jun 14, 2021
    Closed
    Closed
    Closed
    Closed
    This was referenced Jun 14, 2021
    Closed
    Closed
    Closed
    @dorothyhu dorothyhu marked this pull request as ready for review June 14, 2021 23:59
    @openapi-workflow-bot
    Copy link

    Hi, @dorothyhu your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 15, 2021
    @lirenhe
    Copy link
    Member

    lirenhe commented Jun 15, 2021

    @dorothyhu, it seems this PR contains breaking change compared with Microsoft.HybridCompute/stable/2021-05-20, could you follow the breaking change review process for it?

    @openapi-workflow-bot
    Copy link

    Hi @dorothyhu, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @chiragg4u
    Copy link
    Contributor

    Thank you for copying the existing version into new folder for first commit. It helps in reviewing the change. Changes looks good, please follow the process given @ https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/212/Swagger-PR-Review to continue

    @chiragg4u chiragg4u added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 15, 2021
    @dorothyhu
    Copy link
    Contributor Author

    @lirenhe Hi Liren, I don't understand why this is a breaking change. It doesn't remove or add any properties from the previous APIs.

    @jianyexi
    Copy link
    Contributor

    @lirenhe in this case, it's not breaking change, as it 's remove readonly in a model, it's similar to add a property in the request, it's not breaking change in new version, so I removed the label

    @lirenhe lirenhe merged commit 2273610 into Azure:master Jun 21, 2021
    This was referenced Jun 21, 2021
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    asager pushed a commit to asager/azure-rest-api-specs that referenced this pull request Jun 24, 2021
    @dorothyhu
    [Hub Generated] Review request for Microsoft.HybridCompute to add ver…
    8ee4b1d 
    …sion preview/2021-06-10-preview (Azure#14797)

* Adds base for updating Microsoft.HybridCompute from version preview/2021-05-17-preview to version 2021-06-10-preview

* Updates readme

* Updates API version in new specs and examples

* updated the swagger

* added the missing bracket

* removed type object

* removed PatchSettings ref

* used x-ms-client-flatten

* fixed an issue

* added osProfile to the machineUpdateProperties

* removed the extra space

* fixed by npm run prettier
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    @dorothyhu @mkarmark
    [Hub Generated] Review request for Microsoft.HybridCompute to add ver…
    269e093 
    …sion preview/2021-06-10-preview (Azure#14797)

* Adds base for updating Microsoft.HybridCompute from version preview/2021-05-17-preview to version 2021-06-10-preview

* Updates readme

* Updates API version in new specs and examples

* updated the swagger

* added the missing bracket

* removed type object

* removed PatchSettings ref

* used x-ms-client-flatten

* fixed an issue

* added osProfile to the machineUpdateProperties

* removed the extra space

* fixed by npm run prettier
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @lirenhe lirenhe lirenhe approved these changes

    @raghushantha raghushantha raghushantha approved these changes

    @dkirby017 dkirby017 Awaiting requested review from dkirby017

    Assignees

    @lirenhe lirenhe

    Labels
    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Python
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @dorothyhu @lirenhe @chiragg4u @jianyexi @raghushantha