Web ant93.2 2021 01 15 #14805
Merged
Web ant93.2 2021 01 15 #14805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o version 2021-01-15
#14738) * Add Cert and Domain Registration APIs. Fix publishingcredentialpolicies collection API response. Add networkconfig API verbs for sites and slots * Fix examples * Fix issue R4037 * Fix lintDiff issues * Fix more issues Co-authored-by: Naveed Aziz <naveed.aziz@gmail.com>
|
Hi, @naveedaz Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Per the Noun_Verb convention for Operation Ids, the noun 'DeletedWebApps' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-01-15/DeletedWebApps.json#L106 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'Diagnostics' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-01-15/Diagnostics.json#L281 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'Diagnostics' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-01-15/Diagnostics.json#L334 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'Diagnostics' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-01-15/Diagnostics.json#L954 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'Diagnostics' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-01-15/Diagnostics.json#L1014 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'Recommendations' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-01-15/Recommendations.json#L102 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'Recommendations' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-01-15/Recommendations.json#L405 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'Recommendations' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-01-15/Recommendations.json#L712 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-01-15/StaticSites.json#L118 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-01-15/StaticSites.json#L161 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross-Version Breaking Changes: 403 Errors, 2 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.8.11)
- current:stable/2021-01-15/AppServiceCertificateOrders.json compared with base:stable/2021-01-01/AppServiceCertificateOrders.json
- current:stable/2021-01-15/CertificateOrdersDiagnostics.json compared with base:stable/2021-01-01/CertificateOrdersDiagnostics.json
- current:stable/2021-01-15/CertificateRegistrationProvider.json compared with base:stable/2021-01-01/CertificateRegistrationProvider.json
- current:stable/2021-01-15/DomainRegistrationProvider.json compared with base:stable/2021-01-01/DomainRegistrationProvider.json
- current:stable/2021-01-15/Domains.json compared with base:stable/2021-01-01/Domains.json
- current:stable/2021-01-15/TopLevelDomains.json compared with base:stable/2021-01-01/TopLevelDomains.json
- current:stable/2021-01-15/AppServiceEnvironments.json compared with base:stable/2021-01-01/AppServiceEnvironments.json
- current:stable/2021-01-15/AppServicePlans.json compared with base:stable/2021-01-01/AppServicePlans.json
- current:stable/2021-01-15/Certificates.json compared with base:stable/2021-01-01/Certificates.json
- current:stable/2021-01-15/CommonDefinitions.json compared with base:stable/2021-01-01/CommonDefinitions.json
- current:stable/2021-01-15/DeletedWebApps.json compared with base:stable/2021-01-01/DeletedWebApps.json
- current:stable/2021-01-15/Diagnostics.json compared with base:stable/2021-01-01/Diagnostics.json
- current:stable/2021-01-15/Global.json compared with base:stable/2021-01-01/Global.json
- current:stable/2021-01-15/KubeEnvironments.json compared with base:stable/2021-01-01/KubeEnvironments.json
- current:stable/2021-01-15/Provider.json compared with base:stable/2021-01-01/Provider.json
- current:stable/2021-01-15/Recommendations.json compared with base:stable/2021-01-01/Recommendations.json
- current:stable/2021-01-15/ResourceHealthMetadata.json compared with base:stable/2021-01-01/ResourceHealthMetadata.json
- current:stable/2021-01-15/ResourceProvider.json compared with base:stable/2021-01-01/ResourceProvider.json
- current:stable/2021-01-15/StaticSites.json compared with base:stable/2021-01-01/StaticSites.json
- current:stable/2021-01-15/WebApps.json compared with base:stable/2021-01-01/WebApps.json
Only 10 items are listed, please refer to log for more details.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"web/resource-manager/readme.md",
"tag":"package-2021-01-15",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"web/resource-manager/readme.md",
"tag":"package-2021-01-15",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"web/resource-manager/readme.md",
"tag":"package-2021-01-15",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
This was referenced Jun 15, 2021
Closed
|
@weidongxu-microsoft Please review but not merge yet |
|
@naveedaz |
|
If you have new API, please add ARM for review (commit d1361d0 contains new API) |
naveedaz
added
the
WaitForARMFeedback
The change in the operation ID is fix an existing issue where the collection was incorrect named with prefix Get instead of List |
|
As long as it changes (and there is SDK released on the previous version), it will be a breaking changes, and you will need approval from Jeffrey. |
@JeffreyRichter Can you please review and approve? |
|
Hi @naveedaz, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
Complete list on breaking changes reported by CI https://dev.azure.com/azure-sdk/internal/_build/results?buildId=946994&view=logs&j=8f628bfe-7d8d-5bf3-e141-37106862c4f5&t=e8cd626d-0ee4-5bf1-69f3-fe7732da313d "TypeChanged" can be ignored. |
|
@ArcturusZhang and @msyyc for awareness on "CrossVersionBreakingChange" |
|
Please go through the contribution checklist and ARM API Review Checklist added as part of the review and mark them completed. It will help you fix most of the issues and improve the quality of swagger and help close the PR faster. This is a requirement before review can be continued. |
|
Hi, @naveedaz your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
JeffreyRichter
added
the
Approved-BreakingChange
The response for this API has nextLink defined in it, so I am guessing you have a pagable API. In that case, this definition requires below annotation: Same goes for "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/basicPublishingCredentialsPolicies" API as well. Refers to: specification/web/resource-manager/Microsoft.Web/stable/2021-01-15/WebApps.json:9189 in d1361d0. [](commit_id = d1361d0, deletion_comment = False) |
26 tasks
This was referenced Jun 24, 2021
Closed
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
weidongxu-microsoft
approved these changes
Jun 24, 2021
|
@naveedaz Let me know when you need it merged (after ARM approval). |
filizt
added
ARMSignedOff
This was referenced Jun 24, 2021
weidongxu-microsoft
pushed a commit
that referenced
this pull request
Jul 14, 2021
* Adds base for updating Microsoft.Web from version stable/2021-01-01 to version 2021-01-15 * Updates readme * Updates API version in new specs and examples * Add Cert and Domain Registration APIs. Fix publishingcredentialpolici… (#14738) * Add Cert and Domain Registration APIs. Fix publishingcredentialpolicies collection API response. Add networkconfig API verbs for sites and slots * Fix examples * Fix issue R4037 * Fix lintDiff issues * Fix more issues Co-authored-by: Naveed Aziz <naveed.aziz@gmail.com> * Add x-ms-pageable for ListBasicPublishingCredentialsPolicies APIs (#14960) Co-authored-by: Naveed Aziz <naveed.aziz@gmail.com> (cherry picked from commit d9249ed)
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* Adds base for updating Microsoft.Web from version stable/2021-01-01 to version 2021-01-15 * Updates readme * Updates API version in new specs and examples * Add Cert and Domain Registration APIs. Fix publishingcredentialpolici… (Azure#14738) * Add Cert and Domain Registration APIs. Fix publishingcredentialpolicies collection API response. Add networkconfig API verbs for sites and slots * Fix examples * Fix issue R4037 * Fix lintDiff issues * Fix more issues Co-authored-by: Naveed Aziz <naveed.aziz@gmail.com> * Add x-ms-pageable for ListBasicPublishingCredentialsPolicies APIs (Azure#14960) Co-authored-by: Naveed Aziz <naveed.aziz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.