[Synapse] - Update sql pool v3 specs #14839

idear1203 · 2021-06-16T08:04:31Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-06-16T08:04:34Z

Hi, @idear1203 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-workflow-bot · 2021-06-16T08:04:35Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-06-16T08:04:36Z

Swagger Validation Report

️❌BreakingChange: 7 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.11)
- current:Microsoft.Synapse/preview/2020-04-01-preview compared with base:Microsoft.Synapse/preview/2020-04-01-preview
- current:common/v1/types.json compared with base:common/v1/types.json

Rule	Message
`❌` 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'Sku' removed or renamed? New: Microsoft.Synapse/preview/2020-04-01-preview/operations.json#L172:3 Old: Microsoft.Synapse/preview/2020-04-01-preview/operations.json#L172:3
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'code' renamed or removed? New: common-types/resource-management/v2/types.json#L326:7 Old: common-types/resource-management/v1/types.json#L289:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'message' renamed or removed? New: common-types/resource-management/v2/types.json#L326:7 Old: common-types/resource-management/v1/types.json#L289:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'target' renamed or removed? New: common-types/resource-management/v2/types.json#L326:7 Old: common-types/resource-management/v1/types.json#L289:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'details' renamed or removed? New: common-types/resource-management/v2/types.json#L326:7 Old: common-types/resource-management/v1/types.json#L289:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'additionalInfo' renamed or removed? New: common-types/resource-management/v2/types.json#L326:7 Old: common-types/resource-management/v1/types.json#L289:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'error' in response that was not found in the old version. New: common-types/resource-management/v2/types.json#L326:7 Old: common-types/resource-management/v1/types.json#L289:7

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.10.0 , classic-openapi-validator v1.1.8 )
- synapse/resource-manager/readme.md tag:package-sqlGen3-2020-04-01-preview
Linted configuring files (Based on target branch, openapi-validator v1.10.0 , classic-openapi-validator v1.1.8 )
- synapse/resource-manager/readme.md tag:package-sqlGen3-2020-04-01-preview

The following errors/warnings exist before current PR submission:

Rule	Message
⚠️ R2018 - XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Property name: createdByType Location: synapse/common/v1/types.json#L69
⚠️ R2018 - XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Property name: lastModifiedByType Location: synapse/common/v1/types.json#L91
⚠️ R3017 - GuidUsage	Guid used in model definition 'SqlPoolProperties' for property 'sqlPoolGuid'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json#L395
⚠️ R3017 - GuidUsage	Guid used in model definition 'SqlDatabaseProperties' for property 'databaseGuid'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.Synapse/preview/2020-04-01-preview/sqlDatabase.json#L306
⚠️ R4024 - PreviewVersionOverOneYear	The API version:2020-04-01-preview having been in a preview state over one year , please move it to GA or retire. Location: Microsoft.Synapse/preview/2020-04-01-preview/operations.json#L4
⚠️ R4024 - PreviewVersionOverOneYear	The API version:2020-04-01-preview having been in a preview state over one year , please move it to GA or retire. Location: Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json#L4
⚠️ R4024 - PreviewVersionOverOneYear	The API version:2020-04-01-preview having been in a preview state over one year , please move it to GA or retire. Location: Microsoft.Synapse/preview/2020-04-01-preview/sqlDatabase.json#L4

️❌Avocado: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` MISSING_README	Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: specification/synapse/common/v1

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

synapse/resource-manager/readme.md#package-sqlGen3-2020-04-01-preview

The following errors/warnings are introduced by current PR:

|:speech_balloon: AutorestCore/Exception|"readme":"synapse/resource-manager/readme.md",
"tag":"package-sqlGen3-2020-04-01-preview",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"synapse/resource-manager/readme.md",
"tag":"package-sqlGen3-2020-04-01-preview",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|

The following errors/warnings exist before current PR submission:

|:speech_balloon: AutorestCore/Exception|"readme":"synapse/resource-manager/readme.md",
"tag":"package-sqlGen3-2020-04-01-preview",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-06-16T08:04:36Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌[Staging] SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-synapse - 2.0.0
️✔️azure-sdk-for-go - synapse/mgmt/2021-03-01/synapse - v55.4.0
️✔️azure-sdk-for-go - synapse/mgmt/2020-12-01/synapse - v55.4.0
❌azure-sdk-for-go - preview/synapse/mgmt/2019-06-01-preview/synapse - v55.4.0

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 467afe8. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/synapse/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Synapse [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.Synapse.2.0.0.nupkg
- Microsoft.Azure.Management.Synapse.2.0.0.snupkg

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 467afe8. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/synapse/resource-manager/readme.md

️✔️@azure/arm-synapse [View full logs] [Release SDK Changes]

azure-arm-synapse-5.1.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/synapseManagementClient.js → ./dist/arm-synapse.js...
cmderr	[npmPack] created ./dist/arm-synapse.js in 1.2s

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 467afe8. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-06-29 09:06:54 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-synapse;1.0.0-beta.1;1.0.0-beta.2"
cmderr	[generate.py] 2021-06-29 09:06:54 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
cmderr	[generate.py] 2021-06-29 09:06:54 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.30 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/synapse/azure-resourcemanager-synapse --java.namespace=com.azure.resourcemanager.synapse   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/synapse/resource-manager/readme.md
cmderr	[generate.py] 2021-06-29 09:08:22 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-synapse
cmderr	[generate.py] 2021-06-29 09:08:22 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-06-29 09:08:22 INFO [POM][Skip] pom already has module azure-resourcemanager-synapse
cmderr	[generate.py] 2021-06-29 09:08:22 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-06-29 09:08:22 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-06-29 09:08:22 INFO [POM][Skip] pom already has module sdk/synapse
cmderr	[generate.py] 2021-06-29 09:08:22 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-synapse [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-06-29 09:12:09 DEBUG Got artifact_id: azure-resourcemanager-synapse
cmderr	[Inst] 2021-06-29 09:12:09 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-06-29 09:12:09 DEBUG Got artifact: azure-resourcemanager-synapse-1.0.0-beta.2-sources.jar
cmderr	[Inst] 2021-06-29 09:12:09 DEBUG Got artifact: azure-resourcemanager-synapse-1.0.0-beta.2-javadoc.jar
cmderr	[Inst] 2021-06-29 09:12:09 DEBUG Got artifact: azure-resourcemanager-synapse-1.0.0-beta.2.jar
cmderr	[Inst] 2021-06-29 09:12:09 DEBUG Match jar package: azure-resourcemanager-synapse-1.0.0-beta.2.jar
cmderr	[Inst] 2021-06-29 09:12:09 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14839/azure-sdk-for-java/azure-resourcemanager-synapse/azure-resourcemanager-synapse-1.0.0-beta.2.jar\" -o azure-resourcemanager-synapse-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-synapse -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-synapse-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
```"}

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 467afe8. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-synapse [View full logs] [Release SDK Changes]

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model CustomerManagedKeyDetails has a new parameter kek_identity
info	[Changelog]   - Model Workspace has a new parameter csp_workspace_admin_properties
info	[Changelog]   - Added operation PrivateEndpointConnectionsPrivateLinkHubOperations.get

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 467afe8. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️synapse/mgmt/2021-03-01/synapse [View full logs] [Release SDK Changes]

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `NodeSizeFamilyHardwareAcceleratedFPGA`
info	[Changelog] - New const `NodeSizeFamilyHardwareAcceleratedGPU`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 2 additive change(s).
info	[Changelog]

️✔️synapse/mgmt/2020-12-01/synapse [View full logs]

Only show 40 items here, please refer to log for details.

info	[Changelog]
info	[Changelog] - New const `NodeSizeFamilyHardwareAcceleratedFPGA`
info	[Changelog] - New const `NodeSizeFamilyHardwareAcceleratedGPU`
info	[Changelog] - New function `*LibraryListResponsePage.Next() error`
info	[Changelog] - New function `LibraryResource.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `LibraryListResponsePage.Values() []LibraryResource`
info	[Changelog] - New function `*LibraryResource.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `LibraryClient.GetResponder(*http.Response) (LibraryResource, error)`
info	[Changelog] - New function `NewLibrariesClientWithBaseURI(string, string) LibrariesClient`
info	[Changelog] - New function `LibrariesClient.ListByWorkspace(context.Context, string, string) (LibraryListResponsePage, error)`
info	[Changelog] - New function `LibrariesClient.ListByWorkspaceResponder(*http.Response) (LibraryListResponse, error)`
info	[Changelog] - New function `LibrariesClient.ListByWorkspaceComplete(context.Context, string, string) (LibraryListResponseIterator, error)`
info	[Changelog] - New function `NewLibraryClient(string) LibraryClient`
info	[Changelog] - New function `*LibraryListResponsePage.NextWithContext(context.Context) error`
info	[Changelog] - New function `LibraryListResponse.IsEmpty() bool`
info	[Changelog] - New function `NewLibraryClientWithBaseURI(string, string) LibraryClient`
info	[Changelog] - New function `LibraryListResponseIterator.Value() LibraryResource`
info	[Changelog] - New function `LibraryListResponseIterator.Response() LibraryListResponse`
info	[Changelog] - New function `LibraryListResponseIterator.NotDone() bool`
info	[Changelog] - New function `LibraryListResponsePage.Response() LibraryListResponse`
info	[Changelog] - New function `LibraryClient.Get(context.Context, string, string, string) (LibraryResource, error)`
info	[Changelog] - New function `*LibraryListResponseIterator.Next() error`
info	[Changelog] - New function `NewLibrariesClient(string) LibrariesClient`
info	[Changelog] - New function `*LibraryListResponseIterator.NextWithContext(context.Context) error`
info	[Changelog] - New function `LibraryListResponsePage.NotDone() bool`
info	[Changelog] - New function `LibrariesClient.ListByWorkspaceSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `NewLibraryListResponsePage(LibraryListResponse, func(context.Context, LibraryListResponse) (LibraryListResponse, error)) LibraryListResponsePage`
info	[Changelog] - New function `LibraryClient.GetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `NewLibraryListResponseIterator(LibraryListResponsePage) LibraryListResponseIterator`
info	[Changelog] - New function `LibrariesClient.ListByWorkspacePreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New function `LibraryClient.GetPreparer(context.Context, string, string, string) (*http.Request, error)`
info	[Changelog] - New struct `LibrariesClient`
info	[Changelog] - New struct `LibraryClient`
info	[Changelog] - New struct `LibraryListResponse`
info	[Changelog] - New struct `LibraryListResponseIterator`
info	[Changelog] - New struct `LibraryListResponsePage`
info	[Changelog] - New struct `LibraryResource`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 42 additive change(s).
info	[Changelog]

️✔️preview/synapse/mgmt/2019-06-01-preview/synapse [View full logs] Breaking Change Detected

Only show 40 items here, please refer to log for details.

info	[Changelog] - New function `SQLPoolSensitivityLabelsClient.UpdateSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `SQLPoolMaintenanceWindowsClient.GetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `LibraryInfo.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `SQLPoolMaintenanceWindowsClient.CreateOrUpdateSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `PossibleSensitivityLabelRankValues() []SensitivityLabelRank`
info	[Changelog] - New struct `DynamicExecutorAllocation`
info	[Changelog] - New struct `LibraryInfo`
info	[Changelog] - New struct `MaintenanceWindowOptions`
info	[Changelog] - New struct `MaintenanceWindowOptionsProperties`
info	[Changelog] - New struct `MaintenanceWindowTimeRange`
info	[Changelog] - New struct `MaintenanceWindows`
info	[Changelog] - New struct `MaintenanceWindowsProperties`
info	[Changelog] - New struct `ManagedVirtualNetworkReference`
info	[Changelog] - New struct `PrivateLinkHubPrivateLinkResourcesClient`
info	[Changelog] - New struct `RecommendedSensitivityLabelUpdate`
info	[Changelog] - New struct `RecommendedSensitivityLabelUpdateList`
info	[Changelog] - New struct `RecommendedSensitivityLabelUpdateProperties`
info	[Changelog] - New struct `SQLPoolMaintenanceWindowOptionsClient`
info	[Changelog] - New struct `SQLPoolMaintenanceWindowsClient`
info	[Changelog] - New struct `SQLPoolRecommendedSensitivityLabelsClient`
info	[Changelog] - New struct `SensitivityLabelUpdate`
info	[Changelog] - New struct `SensitivityLabelUpdateList`
info	[Changelog] - New struct `SensitivityLabelUpdateProperties`
info	[Changelog] - New field `ManagedBy` in struct `SensitivityLabel`
info	[Changelog] - New field `AdlaResourceID` in struct `WorkspaceProperties`
info	[Changelog] - New field `CacheSize` in struct `BigDataPoolResourceProperties`
info	[Changelog] - New field `DynamicExecutorAllocation` in struct `BigDataPoolResourceProperties`
info	[Changelog] - New field `CustomLibraries` in struct `BigDataPoolResourceProperties`
info	[Changelog] - New field `LastSucceededTimestamp` in struct `BigDataPoolResourceProperties`
info	[Changelog] - New field `SchemaName` in struct `SensitivityLabelProperties`
info	[Changelog] - New field `ColumnName` in struct `SensitivityLabelProperties`
info	[Changelog] - New field `Rank` in struct `SensitivityLabelProperties`
info	[Changelog] - New field `TableName` in struct `SensitivityLabelProperties`
info	[Changelog] - New field `IsComputed` in struct `SQLPoolColumnProperties`
info	[Changelog] - New field `TenantID` in struct `WorkspaceRepositoryConfiguration`
info	[Changelog] - New field `LastCommitID` in struct `WorkspaceRepositoryConfiguration`
info	[Changelog] - New field `ManagedVirtualNetwork` in struct `ManagedIntegrationRuntime`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 119 additive change(s).
info	[Changelog]

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 467afe8. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]
cmderr	[initScript.sh]  The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh]  so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh]
cmderr	[initScript.sh]  This is a one-time fix-up, please be patient...
cmderr	[initScript.sh]
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️synapse [View full logs] [Release Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-06-16T08:07:30Z

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

openapi-workflow-bot · 2021-06-16T08:07:30Z

Hi @idear1203, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

chzachar · 2021-06-16T14:22:11Z

...ification/synapse/resource-manager/Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json

@@ -436,7 +436,7 @@
      ],
      "properties": {
        "sku": {
-          "$ref": "../../../../common/v1/types.json#/definitions/Sku",


Can we remove the old Synapse-specific definitions/Sku object that is in this file now (appears to not be used anywhere else), to avoid confusion in future? https://github.com/Azure/azure-rest-api-specs/blob/master/specification/synapse/common/v1/types.json

ruowan · 2021-06-29T05:28:44Z

/azp run

azure-pipelines · 2021-06-29T05:28:54Z

Azure Pipelines successfully started running 1 pipeline(s).

Create to sync Azure/azure-rest-api-specs#14839 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/master...AzureSDKAutomation:sdkAuto/synapse?expand=1)

* [Synapse] - Update sql pool v3 specs * Address comments Co-authored-by: Dongwei Wang <dongwwa@microsoft.com>

openapi-assignment-bot bot assigned ruowan Jun 16, 2021

ghost added the Synapses label Jun 16, 2021

openapi-pipeline-app bot added BreakingChangeReviewRequired labels Jun 16, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Go label Jun 16, 2021

chzachar reviewed Jun 16, 2021

View reviewed changes

chzachar approved these changes Jun 16, 2021

View reviewed changes

Dongwei Wang added 2 commits June 27, 2021 22:05

[Synapse] - Update sql pool v3 specs

30c3de7

Address comments

e645d31

idear1203 force-pushed the synapse_update_sqlv3_spec branch from ed6f91c to e645d31 Compare June 28, 2021 05:05

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jun 28, 2021

ruowan added the Approved-Avocado label Jun 29, 2021

ruowan approved these changes Jun 29, 2021

View reviewed changes

ruowan merged commit 467afe8 into Azure:master Jun 29, 2021

openapi-sdkautomation bot mentioned this pull request Jun 29, 2021

[ReleasePR @azure/arm-synapse] Updated the swagger files for fixing the casing issue Azure/azure-sdk-for-js#15864

Closed

idear1203 mentioned this pull request Jun 30, 2021

[Synapse] - Build SDK based on API version 2021-04-01-preview and add SQL DW Gen3 API (2020-04-01-preview) Azure/azure-sdk-for-net#21769

Merged

11 tasks

mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021

[Synapse] - Update sql pool v3 specs (Azure#14839)

35edb70

* [Synapse] - Update sql pool v3 specs * Address comments Co-authored-by: Dongwei Wang <dongwwa@microsoft.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Synapse] - Update sql pool v3 specs #14839

[Synapse] - Update sql pool v3 specs #14839

idear1203 commented Jun 16, 2021

openapi-workflow-bot bot commented Jun 16, 2021

openapi-workflow-bot bot commented Jun 16, 2021

openapi-pipeline-app bot commented Jun 16, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jun 16, 2021 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Jun 16, 2021

openapi-workflow-bot bot commented Jun 16, 2021

chzachar Jun 16, 2021 •

edited

Loading

idear1203 Jun 17, 2021

ruowan commented Jun 29, 2021

azure-pipelines bot commented Jun 29, 2021

[Synapse] - Update sql pool v3 specs #14839

[Synapse] - Update sql pool v3 specs #14839

Conversation

idear1203 commented Jun 16, 2021

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jun 16, 2021

openapi-workflow-bot bot commented Jun 16, 2021

openapi-pipeline-app bot commented Jun 16, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jun 16, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Jun 16, 2021

openapi-workflow-bot bot commented Jun 16, 2021

chzachar Jun 16, 2021 • edited Loading

Choose a reason for hiding this comment

idear1203 Jun 17, 2021

Choose a reason for hiding this comment

ruowan commented Jun 29, 2021

azure-pipelines bot commented Jun 29, 2021

openapi-pipeline-app bot commented Jun 16, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jun 16, 2021 •

edited

Loading

chzachar Jun 16, 2021 •

edited

Loading