Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch Control Plane 2021-06-01.14 update #14862

Merged
merged 2 commits into from
Jul 2, 2021

Conversation

paterasMSFT
Copy link
Contributor

@paterasMSFT paterasMSFT commented Jun 17, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @paterasMSFT Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 17, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:
    Rule Message
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'applications' with immediate parent 'BatchAccount', must have a list by immediate parent operation.
    Location: Microsoft.Batch/stable/2021-06-01/BatchManagement.json#L2985
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'versions' with immediate parent 'Application', must have a list by immediate parent operation.
    Location: Microsoft.Batch/stable/2021-06-01/BatchManagement.json#L3019
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'certificates' with immediate parent 'BatchAccount', must have a list by immediate parent operation.
    Location: Microsoft.Batch/stable/2021-06-01/BatchManagement.json#L3394
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'privateLinkResources' with immediate parent 'BatchAccount', must have a list by immediate parent operation.
    Location: Microsoft.Batch/stable/2021-06-01/BatchManagement.json#L3472
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'privateEndpointConnections' with immediate parent 'BatchAccount', must have a list by immediate parent operation.
    Location: Microsoft.Batch/stable/2021-06-01/BatchManagement.json#L3516
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'pools' with immediate parent 'BatchAccount', must have a list by immediate parent operation.
    Location: Microsoft.Batch/stable/2021-06-01/BatchManagement.json#L3640
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️⚠️Cross-Version Breaking Changes: 261 Warnings warning [Detail]
    The following breaking changes are detected by comparison with the latest stable version:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Batch/stable/2021-06-01/BatchManagement.json#L78:13
    Old: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L81:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Batch/stable/2021-06-01/BatchManagement.json#L2547:9
    Old: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2307:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Batch/stable/2021-06-01/BatchManagement.json#L2472:9
    Old: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2268:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Batch/stable/2021-06-01/BatchManagement.json#L2481:9
    Old: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2277:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Batch/stable/2021-06-01/BatchManagement.json#L2490:9
    Old: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2286:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Batch/stable/2021-06-01/BatchManagement.json#L2903:9
    Old: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2657:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Batch/stable/2021-06-01/BatchManagement.json#L2552:9
    Old: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2312:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Batch/stable/2021-06-01/BatchManagement.json#L93:13
    Old: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L96:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Batch/stable/2021-06-01/BatchManagement.json#L2822:9
    Old: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2579:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Batch/stable/2021-06-01/BatchManagement.json#L2729:9
    Old: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2496:9
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"batch/resource-manager/readme.md",
    "tag":"package-2021-01",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"batch/resource-manager/readme.md",
    "tag":"package-2021-01",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"batch/resource-manager/readme.md",
    "tag":"package-2021-06",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"batch/resource-manager/readme.md",
    "tag":"package-2021-06",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|


    The following errors/warnings exist before current PR submission:

    |:speech_balloon: AutorestCore/Exception|"readme":"batch/resource-manager/readme.md",
    "tag":"package-2021-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"batch/resource-manager/readme.md",
    "tag":"package-2020-09",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"batch/resource-manager/readme.md",
    "tag":"package-2020-09",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"batch/resource-manager/readme.md",
    "tag":"package-2020-05",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"batch/resource-manager/readme.md",
    "tag":"package-2020-05",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"batch/resource-manager/readme.md",
    "tag":"package-2020-03",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"batch/resource-manager/readme.md",
    "tag":"package-2020-03",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"batch/resource-manager/readme.md",
    "tag":"package-2019-08",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"batch/resource-manager/readme.md",
    "tag":"package-2019-08",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"batch/resource-manager/readme.md",
    "tag":"package-2019-04",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 17, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go - batch/mgmt/2021-06-01/batch - v55.4.0
    ️✔️azure-sdk-for-go - batch/mgmt/2021-01-01/batch - v55.4.0
    ️✔️azure-sdk-for-go - batch/mgmt/2020-09-01/batch - v55.4.0
    ️✔️azure-sdk-for-go - batch/mgmt/2020-05-01/batch - v55.4.0
    ️✔️azure-sdk-for-go - batch/mgmt/2020-03-01/batch - v55.4.0
    ️✔️azure-sdk-for-go - batch/mgmt/2019-08-01/batch - v55.4.0
    ️✔️azure-sdk-for-go - batch/mgmt/2019-04-01/batch - v55.4.0
    ️✔️azure-sdk-for-go - batch/mgmt/2018-12-01/batch - v55.4.0
    ️✔️azure-sdk-for-go - batch/mgmt/2017-09-01/batch - v55.4.0
    ️✔️azure-sdk-for-go - batch/mgmt/2017-05-01/batch - v55.4.0
    ️✔️azure-sdk-for-go - batch/mgmt/2017-01-01/batch - v55.4.0
    ️✔️azure-sdk-for-go - batch/mgmt/2015-12-01/batch - v55.4.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-batch - 15.0.0
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b55aeb5. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/batch/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Batch [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from b55aeb5. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-batch [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model BatchAccount has a new parameter allowed_authentication_modes
      info	[Changelog]   - Model ResourceFile has a new parameter identity_reference
      info	[Changelog]   - Model VirtualMachineConfiguration has a new parameter os_disk
      info	[Changelog]   - Model ContainerRegistry has a new parameter identity_reference
      info	[Changelog]   - Model BatchAccountCreateParameters has a new parameter allowed_authentication_modes
      info	[Changelog]   - Model BatchAccountUpdateParameters has a new parameter allowed_authentication_modes
      info	[Changelog]   - Model AzureBlobFileSystemConfiguration has a new parameter identity_reference
      info	[Changelog]   - Model Operation has a new parameter is_data_action
      info	[Changelog]   - Model AutoStorageProperties has a new parameter node_identity_reference
      info	[Changelog]   - Model AutoStorageProperties has a new parameter authentication_mode
      info	[Changelog]   - Model AutoStorageBaseProperties has a new parameter node_identity_reference
      info	[Changelog]   - Model AutoStorageBaseProperties has a new parameter authentication_mode
      info	[Changelog]   - Added operation BatchAccountOperations.list_outbound_network_dependencies_endpoints
      info	[Changelog]   - Added operation LocationOperations.list_supported_virtual_machine_skus
      info	[Changelog]   - Added operation LocationOperations.list_supported_cloud_service_skus
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from b55aeb5. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-07-02 02:13:57 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-batch;1.0.0-beta.1;1.0.0-beta.2"
      cmderr	[generate.py] 2021-07-02 02:13:57 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
      cmderr	[generate.py] 2021-07-02 02:13:57 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.30 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/batch/azure-resourcemanager-batch --java.namespace=com.azure.resourcemanager.batch   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/batch/resource-manager/readme.md
      cmderr	[generate.py] 2021-07-02 02:14:43 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-batch
      cmderr	[generate.py] 2021-07-02 02:14:43 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-07-02 02:14:43 INFO [POM][Skip] pom already has module azure-resourcemanager-batch
      cmderr	[generate.py] 2021-07-02 02:14:43 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-07-02 02:14:43 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-07-02 02:14:43 INFO [POM][Skip] pom already has module sdk/batch
      cmderr	[generate.py] 2021-07-02 02:14:43 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-batch [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-07-02 02:16:25 DEBUG Got artifact_id: azure-resourcemanager-batch
      cmderr	[Inst] 2021-07-02 02:16:25 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-07-02 02:16:25 DEBUG Got artifact: azure-resourcemanager-batch-1.0.0-beta.2-sources.jar
      cmderr	[Inst] 2021-07-02 02:16:25 DEBUG Got artifact: azure-resourcemanager-batch-1.0.0-beta.2-javadoc.jar
      cmderr	[Inst] 2021-07-02 02:16:25 DEBUG Got artifact: azure-resourcemanager-batch-1.0.0-beta.2.jar
      cmderr	[Inst] 2021-07-02 02:16:25 DEBUG Match jar package: azure-resourcemanager-batch-1.0.0-beta.2.jar
      cmderr	[Inst] 2021-07-02 02:16:25 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14862/azure-sdk-for-java/azure-resourcemanager-batch/azure-resourcemanager-batch-1.0.0-beta.2.jar\" -o azure-resourcemanager-batch-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-batch -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-batch-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b55aeb5. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️batch/mgmt/2021-06-01/batch [View full logs]  [Release SDK Changes]
      info	[Changelog] This is a new package
    • ️✔️batch/mgmt/2021-01-01/batch [View full logs
      info	[Changelog] This is a new package
    • ️✔️batch/mgmt/2020-09-01/batch [View full logs
      info	[Changelog] No exported changes
    • ️✔️batch/mgmt/2020-05-01/batch [View full logs
      info	[Changelog] No exported changes
    • ️✔️batch/mgmt/2020-03-01/batch [View full logs
      info	[Changelog] No exported changes
    • ️✔️batch/mgmt/2019-08-01/batch [View full logs
      info	[Changelog] No exported changes
    • ️✔️batch/mgmt/2019-04-01/batch [View full logs
      info	[Changelog] No exported changes
    • ️✔️batch/mgmt/2018-12-01/batch [View full logs
      info	[Changelog] No exported changes
    • ️✔️batch/mgmt/2017-09-01/batch [View full logs
      info	[Changelog] No exported changes
    • ️✔️batch/mgmt/2017-05-01/batch [View full logs
      info	[Changelog] No exported changes
    • ️✔️batch/mgmt/2017-01-01/batch [View full logs
      info	[Changelog] No exported changes
    • ️✔️batch/mgmt/2015-12-01/batch [View full logs
      info	[Changelog] No exported changes
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b55aeb5. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/batch/resource-manager/readme.md
    • ️✔️@azure/arm-batch [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/batchManagement.js → ./dist/arm-batch.js...
      cmderr	[npmPack] created ./dist/arm-batch.js in 458ms
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from b55aeb5. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]
      cmderr	[initScript.sh]  The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh]  so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh]
      cmderr	[initScript.sh]  This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    Posted by Swagger Pipeline | How to fix these errors?

    @paterasMSFT paterasMSFT force-pushed the paterasMSFT/batchcontrolplane20210601 branch 2 times, most recently from 47b5a97 to ab78a32 Compare June 18, 2021 20:38
    @paterasMSFT paterasMSFT changed the title [Draft - Do not review] Azure Batch Control Plane 2021-06-01 Azure Batch Control Plane 2021-06-01 Jun 22, 2021
    @paterasMSFT paterasMSFT force-pushed the paterasMSFT/batchcontrolplane20210601 branch 2 times, most recently from f943568 to 1d5e085 Compare June 23, 2021 14:39
    @paterasMSFT paterasMSFT changed the title Azure Batch Control Plane 2021-06-01 Batch Control Plane 2021-06-01.14 update Jun 23, 2021
    @openapi-workflow-bot
    Copy link

    Hi, @paterasMSFT your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 23, 2021
    @paterasMSFT paterasMSFT marked this pull request as ready for review June 23, 2021 16:51
    @paterasMSFT
    Copy link
    Contributor Author

    The breaking change errors pertain to changing the type from nothing ('') to 'object'. I do not believe this is a breaking change.

    Prettier
    
    Suppressions
    
    Added Managed Identity and Authenticate Mode APIs
    
    Added type
    
    Replace spot.
    
    Added line break
    
    Newline
    
    Revert "Newline"
    
    This reverts commit 735a19497174fcbc1cb2c7d7835205018614eb42.
    
    Revert "Added line break"
    
    This reverts commit bd0ceca43016e7df20bbc1280271af0f4b503b8d.
    
    Reverted markdown change to satisfy Avocado
    
    http://azure.github.io/autorest/user/literate-file-formats/configuration.html#the-file-format
    @paterasMSFT paterasMSFT force-pushed the paterasMSFT/batchcontrolplane20210601 branch from 1d5e085 to 95bc64d Compare June 24, 2021 12:39
    @RamyasreeChakka RamyasreeChakka added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jun 25, 2021
    @RamyasreeChakka RamyasreeChakka added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 29, 2021
    Copy link
    Member

    @RamyasreeChakka RamyasreeChakka left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    :shipit:

    @paterasMSFT
    Copy link
    Contributor Author

    Thank you @RamyasreeChakka. @jianyexi would you mind merging?

    @jianyexi
    Copy link
    Contributor

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @paterasMSFT
    Copy link
    Contributor Author

    @jianyexi it looks like the pipeline has passed. Is there anything left to do before we can merge?

    @jianyexi jianyexi merged commit b55aeb5 into master Jul 2, 2021
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    * Copy commit for code review
    
    * Initial changes
    
    Prettier
    
    Suppressions
    
    Added Managed Identity and Authenticate Mode APIs
    
    Added type
    
    Replace spot.
    
    Added line break
    
    Newline
    
    Revert "Newline"
    
    This reverts commit 735a19497174fcbc1cb2c7d7835205018614eb42.
    
    Revert "Added line break"
    
    This reverts commit bd0ceca43016e7df20bbc1280271af0f4b503b8d.
    
    Reverted markdown change to satisfy Avocado
    
    http://azure.github.io/autorest/user/literate-file-formats/configuration.html#the-file-format
    @paterasMSFT paterasMSFT mentioned this pull request Jul 27, 2021
    26 tasks
    @JackTn JackTn deleted the paterasMSFT/batchcontrolplane20210601 branch June 16, 2022 00:51
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review ReadyForSDKReview
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants