Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataFactory] Add properties pipelineName and pipelineRunId to PipelineRunInvokedBy definition #14914

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

elisauhura
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @elUrso Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 21, 2021

    Swagger Validation Report

    ️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]
    Rule Message
    1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property 'pipelineName' in response that was not found in the old version.
    New: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5752:7
    Old: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5752:7
    1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property 'pipelineRunId' in response that was not found in the old version.
    New: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5752:7
    Old: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5752:7
    ️🔄LintDiff inProgress [Detail]
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail]
    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"datafactory/resource-manager/readme.md",
    "tag":"package-2018-06",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"datafactory/resource-manager/readme.md",
    "tag":"package-2018-06",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|


    The following errors/warnings exist before current PR submission:

    Rule Message
    AutorestCore/Exception "readme":"datafactory/resource-manager/readme.md",
    "tag":"package-2018-06",
    "details":"Error: Semantic validation failed. There was some errors"
    💬 AutorestCore/Exception "readme":"datafactory/resource-manager/readme.md",
    "tag":"package-2018-06",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 21, 2021

    Swagger Generation Artifacts

    ️❌[Staging] ApiDocPreview: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    RestBuild error "logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=228262&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b",
    "detail":"Run.ps1 failed with exit code 1 "
    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-python-track2 - track2_azure-mgmt-datafactory - 1.1.0
    azure-sdk-for-go - datafactory/mgmt/2018-06-01/datafactory - Approved - v55.4.0
    +	Type of `AvroDatasetTypeProperties.AvroCompressionCodec` has been changed from `AvroCompressionCodec` to `interface{}`
    +	Type of `OrcDatasetTypeProperties.OrcCompressionCodec` has been changed from `OrcCompressionCodec` to `interface{}`
    ️✔️azure-sdk-for-go - preview/datafactory/mgmt/2017-09-01-preview/datafactory - Approved - v55.4.0
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 9cc5127. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/datafactory/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.DataFactory [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 9cc5127. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-datafactory [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Model AmazonRedshiftSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model AzureDataLakeStoreSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model SftpReadSettings has a new parameter disable_metrics_collection
      info	[Changelog]   - Model FtpReadSettings has a new parameter disable_metrics_collection
      info	[Changelog]   - Model FileServerReadSettings has a new parameter disable_metrics_collection
      info	[Changelog]   - Model OracleServiceCloudSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model DocumentDbCollectionSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model ParquetSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model PipelineRunInvokedBy has a new parameter pipeline_name
      info	[Changelog]   - Model PipelineRunInvokedBy has a new parameter pipeline_run_id
      info	[Changelog]   - Model QuickBooksSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model InformixSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model SapTableSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model OdbcSink has a new parameter disable_metrics_collection
      info	[Changelog]   - Model AzureBlobFSReadSettings has a new parameter disable_metrics_collection
      info	[Changelog]   - Model SalesforceSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model OracleCloudStorageReadSettings has a new parameter disable_metrics_collection
      info	[Changelog]   - Model NetezzaSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model AzureMySqlSink has a new parameter disable_metrics_collection
      info	[Changelog]   - Model PaypalSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model OdbcSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model CommonDataServiceForAppsSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model SqlServerSink has a new parameter disable_metrics_collection
      info	[Changelog]   - Model ExcelDataset has a new parameter sheet_index
      info	[Changelog]   - Model SybaseSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model InformixSink has a new parameter disable_metrics_collection
      info	[Changelog]   - Model ConcurSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model PrestoSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model EloquaSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model MarketoSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model PhoenixSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model BinarySource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model AzureDatabricksDeltaLakeSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model AvroSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model ResponsysSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model IntegrationRuntimeSsisProperties has a new parameter managed_credential
      info	[Changelog]   - Model DynamicsSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model ImpalaSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model SapCloudForCustomerSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model JsonSink has a new parameter disable_metrics_collection
      info	[Changelog]   - Model MicrosoftAccessSink has a new parameter disable_metrics_collection
      info	[Changelog]   - Model AmazonS3CompatibleReadSettings has a new parameter disable_metrics_collection
      info	[Changelog]   - Model StoreReadSettings has a new parameter disable_metrics_collection
      info	[Changelog]   - Model SapEccSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model SapOpenHubSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model SqlDWSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model MySqlSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model HdfsSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model SnowflakeSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model RestSink has a new parameter disable_metrics_collection
      info	[Changelog]   - Model AzureBlobFSSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model AzureSearchIndexSink has a new parameter disable_metrics_collection
      info	[Changelog]   - Model AzureBlobFSSink has a new parameter metadata
      info	[Changelog]   - Model AzureBlobFSSink has a new parameter disable_metrics_collection
      info	[Changelog]   - Model ServiceNowSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model HubspotSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model CosmosDbMongoDbApiSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model WebSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model AzureTableSink has a new parameter disable_metrics_collection
      info	[Changelog]   - Model AzureBlobFSWriteSettings has a new parameter disable_metrics_collection
      info	[Changelog]   - Model XeroSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model AzureSqlSink has a new parameter disable_metrics_collection
      info	[Changelog]   - Model GoogleCloudStorageReadSettings has a new parameter disable_metrics_collection
      info	[Changelog]   - Model AzureFileStorageReadSettings has a new parameter disable_metrics_collection
      info	[Changelog]   - Model SapHanaSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model FileSystemSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model SqlDWSink has a new parameter disable_metrics_collection
      info	[Changelog]   - Model ParquetSink has a new parameter disable_metrics_collection
      info	[Changelog]   - Model CommonDataServiceForAppsSink has a new parameter disable_metrics_collection
      info	[Changelog]   - Model ShopifySource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model AzureDataExplorerSink has a new parameter disable_metrics_collection
      info	[Changelog]   - Model MicrosoftAccessSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model CopySource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model DynamicsAXSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model SqlSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model SnowflakeSink has a new parameter disable_metrics_collection
      info	[Changelog]   - Model AzureQueueSink has a new parameter disable_metrics_collection
      info	[Changelog]   - Model SapBwSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model AzureFileStorageWriteSettings has a new parameter disable_metrics_collection
      info	[Changelog]   - Model AzureSqlSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model PostgreSqlSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model DelimitedTextSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model DynamicsCrmSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model SqlMISource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model BlobSink has a new parameter metadata
      info	[Changelog]   - Model BlobSink has a new parameter disable_metrics_collection
      info	[Changelog]   - Model MongoDbAtlasSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model JsonSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model AzureTableSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model SqlSink has a new parameter disable_metrics_collection
      info	[Changelog]   - Model JiraSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model TeradataSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model DocumentDbCollectionSink has a new parameter disable_metrics_collection
      info	[Changelog]   - Model AzureDataExplorerSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model AzurePostgreSqlSink has a new parameter disable_metrics_collection
      info	[Changelog]   - Model DelimitedTextSink has a new parameter disable_metrics_collection
      info	[Changelog]   - Model CosmosDbSqlApiSink has a new parameter disable_metrics_collection
      info	[Changelog]   - Model ExcelSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model TabularSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model ZohoSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model OracleSink has a new parameter disable_metrics_collection
      info	[Changelog]   - Model SqlServerSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model AzurePostgreSqlSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model AzureBlobStorageWriteSettings has a new parameter disable_metrics_collection
      info	[Changelog]   - Model BinarySink has a new parameter disable_metrics_collection
      info	[Changelog]   - Model SqlMISink has a new parameter disable_metrics_collection
      info	[Changelog]   - Model HttpReadSettings has a new parameter disable_metrics_collection
      info	[Changelog]   - Model AzureDataLakeStoreWriteSettings has a new parameter disable_metrics_collection
      info	[Changelog]   - Model Office365Source has a new parameter disable_metrics_collection
      info	[Changelog]   - Model HiveSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Model AzureDataLakeStoreSink has a new parameter disable_metrics_collection
      info	[Changelog]   - Model SalesforceMarketingCloudSource has a new parameter disable_metrics_collection
      info	[Changelog]   - Added operation group PrivateEndPointConnectionsOperations
      info	[Changelog]   - Added operation group PrivateLinkResourcesOperations
      info	[Changelog]   - Added operation group PrivateEndpointConnectionOperations
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Parameter type of model MappingDataFlow is now required
      info	[Changelog]   - Parameter type of model DataFlow is now required
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 9cc5127. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-06-29 02:18:46 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-datafactory;1.0.0-beta.2;1.0.0-beta.3"
      cmderr	[generate.py] 2021-06-29 02:18:46 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.3"
      cmderr	[generate.py] 2021-06-29 02:18:46 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.30 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/datafactory/azure-resourcemanager-datafactory --java.namespace=com.azure.resourcemanager.datafactory   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/datafactory/resource-manager/readme.md
      cmderr	[generate.py] 2021-06-29 02:20:28 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-datafactory
      cmderr	[generate.py] 2021-06-29 02:20:28 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-06-29 02:20:28 INFO [POM][Skip] pom already has module azure-resourcemanager-datafactory
      cmderr	[generate.py] 2021-06-29 02:20:28 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-06-29 02:20:28 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-06-29 02:20:28 INFO [POM][Skip] pom already has module sdk/datafactory
      cmderr	[generate.py] 2021-06-29 02:20:28 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-datafactory [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-06-29 02:23:56 DEBUG Got artifact_id: azure-resourcemanager-datafactory
      cmderr	[Inst] 2021-06-29 02:23:56 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-06-29 02:23:56 DEBUG Got artifact: azure-resourcemanager-datafactory-1.0.0-beta.3.jar
      cmderr	[Inst] 2021-06-29 02:23:56 DEBUG Match jar package: azure-resourcemanager-datafactory-1.0.0-beta.3.jar
      cmderr	[Inst] 2021-06-29 02:23:56 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14914/azure-sdk-for-java/azure-resourcemanager-datafactory/azure-resourcemanager-datafactory-1.0.0-beta.3.jar\" -o azure-resourcemanager-datafactory-1.0.0-beta.3.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-datafactory -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-datafactory-1.0.0-beta.3.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 9cc5127. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️datafactory/mgmt/2018-06-01/datafactory [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `AvroDatasetTypeProperties.AvroCompressionCodec` has been changed from `AvroCompressionCodec` to `interface{}`
      info	[Changelog] - Type of `OrcDatasetTypeProperties.OrcCompressionCodec` has been changed from `OrcCompressionCodec` to `interface{}`
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New field `PipelineRunID` in struct `PipelineRunInvokedBy`
      info	[Changelog] - New field `PipelineName` in struct `PipelineRunInvokedBy`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 1 additive change(s).
      info	[Changelog]
    • ️✔️preview/datafactory/mgmt/2017-09-01-preview/datafactory [View full logs
      info	[Changelog] No exported changes
    ️🔄 azure-sdk-for-js inProgress [Detail]
    ️️✔️ azure-cli-extensions succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 9cc5127. Azure CLI Automation 14.0.0
      Only show 120 items here, please refer to log for details.
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ForEachActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AzureMLBatchExecutionActivity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AzureMLBatchExecutionActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AzureMLUpdateResourceActivity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AzureMLUpdateResourceActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AzureMLExecutePipelineActivity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AzureMLExecutePipelineActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'DataLakeAnalyticsUSQLActivity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'DataLakeAnalyticsUSQLActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'WaitActivity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'WaitActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'UntilActivity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'UntilActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ValidationActivity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ValidationActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'FilterActivity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'FilterActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'DatabricksNotebookActivity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'DatabricksNotebookActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'DatabricksSparkJarActivity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'DatabricksSparkJarActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'DatabricksSparkPythonActivity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'DatabricksSparkPythonActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'SetVariableActivity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'SetVariableActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AppendVariableActivity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AppendVariableActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AzureFunctionActivity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AzureFunctionActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'WebHookActivity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'WebHookActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ExecuteDataFlowActivity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ExecuteDataFlowActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'MultiplePipelineTrigger' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ScheduleTrigger-typeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'BlobTrigger-typeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'BlobEventsTrigger-typeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CustomEventsTrigger-typeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'TumblingWindowTrigger-typeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'RetryPolicy' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'RerunTumblingWindowTrigger-typeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ChainingTrigger-typeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
      cmdout	[Autorest] WARNING (PreCheck/DuplicateSchema): Duplicate Schema named BlobEventTypes -- type: undefined => "string",items: {"$ref":"#/components/schemas/BlobEventTypes"} => <none>,enum: undefined => ["Microsoft.Storage.BlobCreated","Microsoft.Storage.BlobDeleted"],x-ms-enum: undefined => {"name":"BlobEventTypes","modelAsString":true}
      cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
      cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
      cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
      cmdout	[Autorest] WARNING:  newAzName:linked-integration-runtime create
      cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
      cmderr	[Autorest] --------------------------------------------------------
      cmderr	[Autorest]   test-scenario:
      cmderr	[Autorest]     - name: /Factories/put/Factories_CreateOrUpdate
      cmderr	[Autorest]     - name: /Factories/get/Factories_Get
      cmderr	[Autorest]     - name: /Factories/get/Factories_List
      cmderr	[Autorest]     - name: /Factories/get/Factories_ListByResourceGroup
      cmderr	[Autorest]     - name: /Factories/patch/Factories_Update
      cmderr	[Autorest]     - name: /Factories/post/Factories_ConfigureFactoryRepo
      cmderr	[Autorest]     - name: /Factories/post/Factories_GetDataPlaneAccess
      cmderr	[Autorest]     - name: /Factories/post/Factories_GetGitHubAccessToken
      cmderr	[Autorest]     - name: /ActivityRuns/post/ActivityRuns_QueryByPipelineRun
      cmderr	[Autorest]     - name: /Datasets/put/Datasets_Create
      cmderr	[Autorest]     - name: /Datasets/put/Datasets_Update
      cmderr	[Autorest]     - name: /Datasets/get/Datasets_Get
      cmderr	[Autorest]     - name: /Datasets/get/Datasets_ListByFactory
      cmderr	[Autorest]     - name: /Datasets/delete/Datasets_Delete
      cmderr	[Autorest]     - name: /IntegrationRuntimes/put/IntegrationRuntimes_Create
      cmderr	[Autorest]     - name: /IntegrationRuntimes/get/IntegrationRuntimes_Get
      cmderr	[Autorest]     - name: /IntegrationRuntimes/get/IntegrationRuntimes_ListByFactory
      cmderr	[Autorest]     - name: /IntegrationRuntimes/patch/IntegrationRuntimes_Update
      cmderr	[Autorest]     - name: /IntegrationRuntimes/post/IntegrationRuntimes_CreateLinkedIntegrationRuntime
      cmderr	[Autorest]     - name: /IntegrationRuntimes/post/IntegrationRuntimes_GetConnectionInfo
      cmderr	[Autorest]     - name: /IntegrationRuntimes/post/IntegrationRuntimes_GetMonitoringData
      cmderr	[Autorest]     - name: /IntegrationRuntimes/post/IntegrationRuntimes_GetStatus
      cmderr	[Autorest]     - name: /IntegrationRuntimes/post/IntegrationRuntimes_ListAuthKeys
      cmderr	[Autorest]     - name: /IntegrationRuntimes/post/IntegrationRuntimes_RegenerateAuthKey
      cmderr	[Autorest]     - name: /IntegrationRuntimes/post/IntegrationRuntimes_Start
      cmderr	[Autorest]     - name: /IntegrationRuntimes/post/IntegrationRuntimes_Stop
      cmderr	[Autorest]     - name: /IntegrationRuntimes/post/IntegrationRuntimes_SyncCredentials
      cmderr	[Autorest]     - name: /IntegrationRuntimes/post/IntegrationRuntimes_Upgrade
      cmderr	[Autorest]     - name: /IntegrationRuntimes/post/IntegrationRuntimes_Upgrade
      cmderr	[Autorest]     - name: /IntegrationRuntimeNodes/get/IntegrationRuntimeNodes_Get
      cmderr	[Autorest]     - name: /IntegrationRuntimeNodes/patch/IntegrationRuntimeNodes_Update
      cmderr	[Autorest]     - name: /IntegrationRuntimeNodes/post/IntegrationRuntimeNodes_GetIpAddress
      cmderr	[Autorest]     - name: /IntegrationRuntimeNodes/delete/IntegrationRuntimesNodes_Delete
      cmderr	[Autorest]     - name: /IntegrationRuntimes/delete/IntegrationRuntimes_Delete
      cmderr	[Autorest]     - name: /LinkedServices/put/LinkedServices_Create
      cmderr	[Autorest]     - name: /LinkedServices/put/LinkedServices_Update
      cmderr	[Autorest]     - name: /LinkedServices/get/LinkedServices_Get
      cmderr	[Autorest]     - name: /LinkedServices/get/LinkedServices_ListByFactory
      cmderr	[Autorest]     - name: /LinkedServices/delete/LinkedServices_Delete
      cmderr	[Autorest]     - name: /PipelineRuns/get/PipelineRuns_Get
      cmderr	[Autorest]     - name: /PipelineRuns/post/PipelineRuns_Cancel
      cmderr	[Autorest]     - name: /PipelineRuns/post/PipelineRuns_QueryByFactory
      cmderr	[Autorest]     - name: /Pipelines/put/Pipelines_Create
      cmderr	[Autorest]     - name: /Pipelines/put/Pipelines_Update
      cmderr	[Autorest]     - name: /Pipelines/get/Pipelines_Get
      cmderr	[Autorest]     - name: /Pipelines/get/Pipelines_ListByFactory
      cmderr	[Autorest]     - name: /Pipelines/post/Pipelines_CreateRun
      cmderr	[Autorest]     - name: /Pipelines/delete/Pipelines_Delete
      cmderr	[Autorest]     - name: /privateEndPointConnections/get/privateEndPointConnections_ListByFactory
      cmderr	[Autorest]     - name: /PrivateEndpointConnection/put/Approves or rejects a private endpoint connection for a factory.
      cmderr	[Autorest]     - name: /PrivateEndpointConnection/get/Get a private endpoint connection for a datafactory.
      cmderr	[Autorest]     - name: /PrivateEndpointConnection/delete/Delete a private endpoint connection for a datafactory.
      cmderr	[Autorest]     - name: /privateLinkResources/get/Get private link resources of a site
      cmderr	[Autorest]     - name: /Triggers/put/Triggers_Create
      cmderr	[Autorest]     - name: /Triggers/put/Triggers_Update
      cmderr	[Autorest]     - name: /Triggers/get/Triggers_Get
      cmderr	[Autorest]     - name: /Triggers/get/Triggers_ListByFactory
      cmderr	[Autorest]     - name: /Triggers/post/Triggers_GetEventSubscriptionStatus
      cmderr	[Autorest]     - name: /Triggers/post/Triggers_QueryByFactory
      cmderr	[Autorest]     - name: /Triggers/post/Triggers_Start
      cmderr	[Autorest]     - name: /Triggers/post/Triggers_Stop
      cmderr	[Autorest]     - name: /Triggers/post/Triggers_SubscribeToEvents
      cmderr	[Autorest]     - name: /Triggers/post/Triggers_UnsubscribeFromEvents
      cmderr	[Autorest]     - name: /TriggerRuns/post/TriggerRuns_QueryByFactory
      cmderr	[Autorest]     - name: /TriggerRuns/post/Triggers_Cancel
      cmderr	[Autorest]     - name: /TriggerRuns/post/Triggers_Rerun
      cmderr	[Autorest]     - name: /Triggers/delete/Triggers_Delete
      cmderr	[Autorest]     - name: /Factories/delete/Factories_Delete
      cmderr	[Autorest] --------------------------------------------------------
    • ️✔️datafactory [View full logs]  [Release Azure CLI Changes]
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 9cc5127. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️datafactory [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    @elisauhura
    Copy link
    Contributor Author

    @zhangyd2015, the ADF team already has exception approved for adding changes and introducing properties without breaking existing models.

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jun 25, 2021
    @leni-msft
    Copy link
    Contributor

    @ArcturusZhang @PhoenixHe-msft Please help check if the go sdk generation failure and SDK breaking change tracking failure are related with the changes.

    @leni-msft
    Copy link
    Contributor

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @ArcturusZhang
    Copy link
    Member

    The breaking change shown here was introduced in this PR: #14770
    It looks like backward-compatible from its new description, but could I get some clarification on this?

    @arsunda
    Copy link
    Contributor

    arsunda commented Jun 28, 2021

    @ArcturusZhang the type has been changed from string/enum to generic object to allow for customers to parameterize the value as expressions (i.e instead of specifying as "avroCompressionCodec":"deflate" they can say "avroCompressionCodec" : "@pipeline().variables.variable1" ). We have made several changes similar to this before and they usually get flagged as breaking changes but we have an exception for it to be approved. The owner of the previous PR can give you more specific examples if needed.

    @ArcturusZhang ArcturusZhang added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Jun 29, 2021
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go CI-BreakingChange-Go
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants