extract AutomationRules to new file #15075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @moranraz Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Guid used in model definition 'ClientInfo' for property 'objectId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.SecurityInsights/preview/2019-01-01-preview/AutomationRules.json#L928 |
|
| Guid used in model definition 'IncidentOwnerInfo' for property 'objectId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.SecurityInsights/preview/2019-01-01-preview/AutomationRules.json#L1051 |
The following errors/warnings exist before current PR submission:
Only 10 items are listed, please refer to log for more details.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail]
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"securityinsights/resource-manager/readme.md",
"tag":"package-2019-01-preview",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"securityinsights/resource-manager/readme.md",
"tag":"package-2019-01-preview",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
|
"readme":"securityinsights/resource-manager/readme.md", "tag":"package-2019-01-preview", "details":"Error: Semantic validation failed. There was some errors" |
| 💬 AutorestCore/Exception | "readme":"securityinsights/resource-manager/readme.md", "tag":"package-2019-01-preview", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @moranraz your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
This was referenced Jul 4, 2021
|
NewApiVersionRequired reason: |
|
Hi @moranraz, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=229975&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory" |
️❌[Staging] SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌azure-sdk-for-go - securityinsight/mgmt/v1.0/securityinsight - v55.5.0+ Package was removed
️✔️azure-sdk-for-go - securityinsight/mgmt/2020-01-01/securityinsight - v55.5.0️✔️azure-sdk-for-go - preview/securityinsight/mgmt/2019-01-01-preview/securityinsight - v55.5.0️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
warn Skip initScript due to not configured command sudo apt-get install -y dotnet-sdk-5.0 command autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied
️✔️Microsoft.Azure.Management.SecurityInsights [View full logs] [Release SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
command sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️securityinsight/mgmt/v1.0/securityinsight [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] This package was removed
️✔️securityinsight/mgmt/2020-01-01/securityinsight [View full logs]info [Changelog] No exported changes
️✔️preview/securityinsight/mgmt/2019-01-01-preview/securityinsight [View full logs]info [Changelog] ### Breaking Changes info [Changelog] info [Changelog] ### New Content info [Changelog] info [Changelog] - New function `IPGeodataClient.Get(context.Context, string, string) (EnrichmentIPGeodata, error)` info [Changelog] - New function `NewDomainWhoisClientWithBaseURI(string, string) DomainWhoisClient` info [Changelog] - New function `IPGeodataClient.GetPreparer(context.Context, string, string) (*http.Request, error)` info [Changelog] - New function `NewIPGeodataClient(string) IPGeodataClient` info [Changelog] - New function `DomainWhoisClient.GetSender(*http.Request) (*http.Response, error)` info [Changelog] - New function `NewDomainWhoisClient(string) DomainWhoisClient` info [Changelog] - New function `DomainWhoisClient.GetResponder(*http.Response) (EnrichmentDomainWhois, error)` info [Changelog] - New function `DomainWhoisClient.Get(context.Context, string, string) (EnrichmentDomainWhois, error)` info [Changelog] - New function `DomainWhoisClient.GetPreparer(context.Context, string, string) (*http.Request, error)` info [Changelog] - New function `NewIPGeodataClientWithBaseURI(string, string) IPGeodataClient` info [Changelog] - New function `IPGeodataClient.GetResponder(*http.Response) (EnrichmentIPGeodata, error)` info [Changelog] - New function `IPGeodataClient.GetSender(*http.Request) (*http.Response, error)` info [Changelog] - New struct `DomainWhoisClient` info [Changelog] - New struct `EnrichmentDomainWhois` info [Changelog] - New struct `EnrichmentDomainWhoisContact` info [Changelog] - New struct `EnrichmentDomainWhoisContacts` info [Changelog] - New struct `EnrichmentDomainWhoisDetails` info [Changelog] - New struct `EnrichmentDomainWhoisRegistrarDetails` info [Changelog] - New struct `EnrichmentIPGeodata` info [Changelog] - New struct `IPGeodataClient` info [Changelog] info [Changelog] Total 0 breaking change(s), 28 additive change(s). info [Changelog]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️track2_azure-mgmt-securityinsight [View full logs] [Release SDK Changes]error breakingChangeTracking is enabled, but version or changelogItem is not found in output.
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
warn Skip initScript due to not configured command autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md
️✔️@azure/arm-securityinsight [View full logs] [Release SDK Changes]cmderr [npmPack] loaded rollup.config.js with warnings cmderr [npmPack] (!) Unused external imports cmderr [npmPack] default imported from external module 'rollup' but never used cmderr [npmPack] ./esm/securityInsights.js → ./dist/arm-securityinsight.js... cmderr [npmPack] created ./dist/arm-securityinsight.js in 369ms
️️✔️ azure-cli-extensions succeeded [Detail] [Expand]
warn Skip initScript due to not configured command npx n 12 command python3 -m venv venv command pip install --upgrade setuptools wheel pip command pip install pathlib jinja2 msrestazure command autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md cmdout [Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'AwsCloudTrailDataConnectorDataTypes-logs' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code. cmdout [Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-exchange' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code. cmdout [Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-sharePoint' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code. cmdout [Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-teams' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code. cmdout [Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'TIDataConnectorDataTypes-indicators' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code. cmdout [Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ActionsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object' cmdout [Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRuleTemplatesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object' cmdout [Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRulesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object' cmdout [Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'BookmarkList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object' cmdout [Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object' cmdout [Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'DataConnectorList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object' cmdout [Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'IncidentCommentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object' cmdout [Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'IncidentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object' cmdout [Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'OfficeConsentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object' cmdout [Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object' cmdout [Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object' cmdout [Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object' cmdout [Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceWithEtag' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object' cmdout [Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail. cmdout [Autorest] WARNING (PreCheck/PropertyRedeclarationWarning): Schema 'MCASDataConnectorDataTypes' has a property 'alerts' that is already declared the parent schema 'AlertsDataTypeOfDataConnector' but isn't significantly different. The property has been removed from MCASDataConnectorDataTypes cmdout [Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner cmderr [Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md cmderr [Autorest] -------------------------------------------------------- cmderr [Autorest] test-scenario: cmderr [Autorest] - name: /Actions/put/Creates or updates an action of alert rule. cmderr [Autorest] - name: /Actions/get/Get all actions of alert rule. cmderr [Autorest] - name: /Actions/get/Get an action of alert rule. cmderr [Autorest] - name: /Actions/delete/Delete an action of alert rule. cmderr [Autorest] - name: /AlertRules/put/Creates or updates a Fusion alert rule. cmderr [Autorest] - name: /AlertRules/put/Creates or updates a MicrosoftSecurityIncidentCreation rule. cmderr [Autorest] - name: /AlertRules/put/Creates or updates a Scheduled alert rule. cmderr [Autorest] - name: /AlertRules/get/Get a Fusion alert rule. cmderr [Autorest] - name: /AlertRules/get/Get a MicrosoftSecurityIncidentCreation rule. cmderr [Autorest] - name: /AlertRules/get/Get a Scheduled alert rule. cmderr [Autorest] - name: /AlertRules/get/Get all alert rules. cmderr [Autorest] - name: /AlertRules/delete/Delete an alert rule. cmderr [Autorest] - name: /AlertRuleTemplates/get/Get alert rule template by Id. cmderr [Autorest] - name: /AlertRuleTemplates/get/Get all alert rule templates. cmderr [Autorest] - name: /Bookmarks/put/Creates or updates a bookmark. cmderr [Autorest] - name: /Bookmarks/get/Get a bookmark. cmderr [Autorest] - name: /Bookmarks/get/Get all bookmarks. cmderr [Autorest] - name: /Bookmarks/delete/Delete a bookmark. cmderr [Autorest] - name: /DataConnectors/put/Creates or updates an Office365 data connector. cmderr [Autorest] - name: /DataConnectors/put/Creates or updates an Threat Intelligence Platform data connector. cmderr [Autorest] - name: /DataConnectors/get/Get a ASC data connector. cmderr [Autorest] - name: /DataConnectors/get/Get a MCAS data connector. cmderr [Autorest] - name: /DataConnectors/get/Get a MDATP data connector cmderr [Autorest] - name: /DataConnectors/get/Get a TI data connector. cmderr [Autorest] - name: /DataConnectors/get/Get all data connectors. cmderr [Autorest] - name: /DataConnectors/get/Get an AAD data connector. cmderr [Autorest] - name: /DataConnectors/get/Get an AATP data connector. cmderr [Autorest] - name: /DataConnectors/get/Get an AwsCloudTrail data connector. cmderr [Autorest] - name: /DataConnectors/get/Get an Office365 data connector. cmderr [Autorest] - name: /DataConnectors/delete/Delete an Office365 data connector. cmderr [Autorest] - name: /IncidentComments/put/Creates an incident comment. cmderr [Autorest] - name: /IncidentComments/get/Get all incident comments. cmderr [Autorest] - name: /IncidentComments/get/Get an incident comment. cmderr [Autorest] - name: /Incidents/put/Creates or updates an incident. cmderr [Autorest] - name: /Incidents/get/Get all incidents. cmderr [Autorest] - name: /Incidents/get/Get an incident. cmderr [Autorest] - name: /Incidents/delete/Delete an incident. cmderr [Autorest] --------------------------------------------------------
️✔️securityinsight [View full logs] [Release Azure CLI Changes]
️⚠️ azure-resource-manager-schemas warning [Detail]
command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️securityinsights [View full logs] [Release Schema Changes]
leni-msft
removed
WaitForARMFeedback
leni-msft
added
the
Approved-BreakingChange
leni-msft
approved these changes
Jul 6, 2021
This was referenced Jul 6, 2021
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* extract AutomationRules to new file * fix errors * change ResourceWithEtag * update readme * change resource and subscriptionId * add bracket * . * . * . * revert common definitons * .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.