Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2021-08-01 #15880

Conversation

ayfathim
Copy link
Contributor

@ayfathim ayfathim commented Sep 1, 2021

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @ayfathim Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 1, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/certificates/{certificateName}'
    Location: Microsoft.RecoveryServices/stable/2021-08-01/registeredidentities.json#L21
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/registeredIdentities/{identityName}'
    Location: Microsoft.RecoveryServices/stable/2021-08-01/registeredidentities.json#L80
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/replicationUsages'
    Location: Microsoft.RecoveryServices/stable/2021-08-01/replicationusages.json#L21
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/usages'
    Location: Microsoft.RecoveryServices/stable/2021-08-01/vaultusages.json#L21
    R4009 - RequiredReadOnlySystemData The response of operation:'VaultExtendedInfo_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.RecoveryServices/stable/2021-08-01/vaults.json#L548
    R4009 - RequiredReadOnlySystemData The response of operation:'VaultCertificates_Create' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.RecoveryServices/stable/2021-08-01/registeredidentities.json#L22
    R4009 - RequiredReadOnlySystemData The response of operation:'VaultExtendedInfo_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.RecoveryServices/stable/2021-08-01/vaults.json#L592
    R4009 - RequiredReadOnlySystemData The response of operation:'VaultExtendedInfo_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.RecoveryServices/stable/2021-08-01/vaults.json#L648
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.RecoveryServices/stable/2021-08-01/registeredidentities.json#L64
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.RecoveryServices/stable/2021-08-01/registeredidentities.json#L108
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.RecoveryServices/stable/2021-08-01/replicationusages.json#L45
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.RecoveryServices/stable/2021-08-01/vaultusages.json#L45
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.RecoveryServices/stable/2021-08-01/registeredidentities.json#L108
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.RecoveryServices/stable/2021-08-01/vaults.json#L456
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.RecoveryServices/stable/2021-08-01/replicationusages.json#L70
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.RecoveryServices/stable/2021-08-01/replicationusages.json#L74
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.RecoveryServices/stable/2021-08-01/replicationusages.json#L78
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.RecoveryServices/stable/2021-08-01/replicationusages.json#L88
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.RecoveryServices/stable/2021-08-01/replicationusages.json#L92
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.RecoveryServices/stable/2021-08-01/replicationusages.json#L96
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.RecoveryServices/stable/2021-08-01/replicationusages.json#L100
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.RecoveryServices/stable/2021-08-01/replicationusages.json#L104
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.RecoveryServices/stable/2021-08-01/replicationusages.json#L108
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.RecoveryServices/stable/2021-08-01/replicationusages.json#L126
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.RecoveryServices/stable/2021-08-01/replicationusages.json#L130
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.RecoveryServices/stable/2021-08-01/replicationusages.json#L134
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.RecoveryServices/stable/2021-08-01/replicationusages.json#L138
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.RecoveryServices/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.RecoveryServices/stable/2021-08-01/vaults.json#L231
    R4036 - ImplementPrivateEndpointAPIs The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateEndpointConnections/{privateEndpointConnectionName} is missing.
    Location: Microsoft.RecoveryServices/stable/2021-08-01/vaultusages.json#L20
    R4036 - ImplementPrivateEndpointAPIs The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateEndpointConnections is missing.
    Location: Microsoft.RecoveryServices/stable/2021-08-01/vaultusages.json#L20
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.

    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"recoveryservices/resource-manager/readme.md",
    "tag":"package-2021-08",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"recoveryservices/resource-manager/readme.md",
    "tag":"package-2021-08",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"recoveryservices/resource-manager/readme.md",
    "tag":"package-2021-08",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 1, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go - recoveryservices/mgmt/2016-06-01/recoveryservices - v57.0.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-recoveryservices - 2.0.0
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from cf17f44. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/recoveryservices/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.RecoveryServices [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from cf17f44. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-recoveryservices [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model PrivateEndpointConnectionVaultProperties has a new parameter location
      info	[Changelog]   - Model PrivateEndpointConnectionVaultProperties has a new parameter name
      info	[Changelog]   - Model PrivateEndpointConnectionVaultProperties has a new parameter type
      info	[Changelog]   - Model VaultProperties has a new parameter move_details
      info	[Changelog]   - Model VaultProperties has a new parameter move_state
      info	[Changelog]   - Model Sku has a new parameter size
      info	[Changelog]   - Model Sku has a new parameter capacity
      info	[Changelog]   - Model Sku has a new parameter family
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from cf17f44. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-09-26 02:28:36 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-recoveryservices;1.0.0-beta.1;1.0.0-beta.2"
      cmderr	[generate.py] 2021-09-26 02:28:36 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
      cmderr	[generate.py] 2021-09-26 02:28:36 INFO autorest --version=3.6.0 --use=@autorest/java@4.0.37 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/recoveryservices/azure-resourcemanager-recoveryservices --java.namespace=com.azure.resourcemanager.recoveryservices   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/recoveryservices/resource-manager/readme.md
      cmderr	[generate.py] 2021-09-26 02:29:12 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-recoveryservices
      cmderr	[generate.py] 2021-09-26 02:29:12 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-09-26 02:29:12 INFO [POM][Skip] pom already has module azure-resourcemanager-recoveryservices
      cmderr	[generate.py] 2021-09-26 02:29:12 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-09-26 02:29:12 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-09-26 02:29:12 INFO [POM][Skip] pom already has module sdk/recoveryservices
      cmderr	[generate.py] 2021-09-26 02:29:12 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-recoveryservices [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-09-26 02:31:28 DEBUG Got artifact_id: azure-resourcemanager-recoveryservices
      cmderr	[Inst] 2021-09-26 02:31:28 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-09-26 02:31:28 DEBUG Got artifact: azure-resourcemanager-recoveryservices-1.0.0-beta.2-javadoc.jar
      cmderr	[Inst] 2021-09-26 02:31:28 DEBUG Got artifact: azure-resourcemanager-recoveryservices-1.0.0-beta.2-sources.jar
      cmderr	[Inst] 2021-09-26 02:31:28 DEBUG Got artifact: azure-resourcemanager-recoveryservices-1.0.0-beta.2.jar
      cmderr	[Inst] 2021-09-26 02:31:28 DEBUG Match jar package: azure-resourcemanager-recoveryservices-1.0.0-beta.2.jar
      cmderr	[Inst] 2021-09-26 02:31:28 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15880/azure-sdk-for-java/azure-resourcemanager-recoveryservices/azure-resourcemanager-recoveryservices-1.0.0-beta.2.jar\" -o azure-resourcemanager-recoveryservices-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-recoveryservices -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-recoveryservices-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from cf17f44. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️recoveryservices/mgmt/2016-06-01/recoveryservices [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from cf17f44. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/recoveryservices/resource-manager/readme.md
    • ️✔️@azure/arm-recoveryservices [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/recoveryServicesClient.js → ./dist/arm-recoveryservices.js...
      cmderr	[npmPack] created ./dist/arm-recoveryservices.js in 389ms
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from cf17f44. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️recoveryservices [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @ayfathim ayfathim marked this pull request as ready for review September 1, 2021 10:32
    @ayfathim ayfathim changed the title [Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2021-08-01 <Do not merge>:[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2021-08-01 Sep 1, 2021
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 1, 2021
    @openapi-workflow-bot
    Copy link

    Hi, @ayfathim your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @ayfathim
    Copy link
    Contributor Author

    ayfathim commented Sep 2, 2021

    @RamyasreeChakka : Please review

    @filizt
    Copy link
    Contributor

    filizt commented Sep 3, 2021

    No API change from the previous version.

    @filizt filizt added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 3, 2021
    @msyyc
    Copy link
    Member

    msyyc commented Sep 17, 2021

    @ayfathim Do we need to hold on for this PR?
    image

    @ayfathim
    Copy link
    Contributor Author

    @ayfathim Do we need to hold on for this PR?
    image

    Yes, the deployment for new version is in progress. Once completed, we can merge this PR. I will update here, once we are ready

    @ayfathim ayfathim changed the title <Do not merge>:[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2021-08-01 [Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2021-08-01 Sep 22, 2021
    @ayfathim
    Copy link
    Contributor Author

    @msyyc : Please merge the PR

    @ayfathim Do we need to hold on for this PR?
    image

    The PR can be merged now. Our service an ARM Manifest deployment completed

    @msyyc
    Copy link
    Member

    msyyc commented Sep 23, 2021

    Hi @ayfathim please get approve from reviewers, otherwise I can't merge it:
    image

    @ayfathim ayfathim requested review from pratimaupadhyay02 and removed request for deymadhumanti September 23, 2021 04:58
    @pratimaupadhyay02
    Copy link
    Contributor

    Changes look fine. ADX team, please go ahead and merge the PR.

    @pratimaupadhyay02 pratimaupadhyay02 added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Sep 24, 2021
    @ayfathim
    Copy link
    Contributor Author

    Hi @ayfathim please get approve from reviewers, otherwise I can't merge it:
    image

    Hi @msyyc : Please merge. All required people have aaproved.

    @msyyc msyyc merged commit cf17f44 into Azure:main Sep 26, 2021
    Hardell pushed a commit to Hardell/azure-rest-api-specs that referenced this pull request Sep 27, 2021
    …version stable/2021-08-01 (Azure#15880)
    
    * Adds base for updating Microsoft.RecoveryServices from version stable/2021-07-01 to version 2021-08-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    …version stable/2021-08-01 (Azure#15880)
    
    * Adds base for updating Microsoft.RecoveryServices from version stable/2021-07-01 to version 2021-08-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants