Service Bus : Adding 2021-11-01 Api Version #16532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uthorization rules.json
|
Hi, @damodaravadhani Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @damodaravadhani your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
Swagger Validation Report
|
Swagger Generation Artifacts
|
|
Hi @damodaravadhani, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Oct 25, 2021
v-Ajnava
added
the
DoNotMerge
JeffreyRichter
added
the
Approved-BreakingChange
v-Ajnava
removed
the
DoNotMerge
|
Hi @damodaravadhani, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
j5lim
added
ARMSignedOff
This was referenced Nov 22, 2021
Closed
|
/azp run |
openapi-pipeline-app
bot
removed
BreakingChangeReviewRequired
CI-FixRequiredOnFailure
labels
LeiWang3
pushed a commit
to LeiWang3/azure-rest-api-specs
that referenced
this pull request
Mar 31, 2022
* Added 2021-11-01 folder for new api version * Changed api version to 2021-11-01 * Changed SBQueue allof to point to ProxyResource * added operation Display to operations and Proxyresource addition to Authorization rules.json * Changed network rule set definition to inherit from ProxyResource * Changed rule definition allOf to ProxyResource * Changed SBSubscription allOf to ProxyResource * Change PrivateEndpointConnection allOf to ProxyResource * Changed SBTopic allOf to ProxyResource * Added alternate Name to SBNamespaceProperties * Added parameters dictionary to Rules.json, Action, SqlFilter * Changes to SBAuth and CheckName * Added description to rules and 204 to delete in disaster config * Added 204 response to DisasterConfigDelete * Prettier check fix * Changed disasterRecoveryConfigs auth rules type, defined new property of namespace update without zoneRedundant * Added type object to SBUpdateNamespaceProperties * Prettier fix * Removed parameters from Rules.json * Added type object to definitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[X] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.