Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.Insights to add version preview/2021-09-01-preview #17599

Merged
merged 25 commits into from
Mar 9, 2022
Merged

[Hub Generated] Review request for Microsoft.Insights to add version preview/2021-09-01-preview #17599

merged 25 commits into from
Mar 9, 2022

Conversation

herreraj-ms
Copy link
Contributor

@herreraj-ms herreraj-ms commented Feb 1, 2022 •
edited by raosuhas
Loading

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
    The new api-version service is already rollout behind a feature flag.
    ETA: March 2022
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
    February 2022
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[x] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @herreraj-ms Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 1, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️❌LintDiff: 1 Errors, 0 Warnings failed [Detail] The following errors/warnings are introduced by current PR:
    Rule Message
    ❌ AutoRest exception "location":"specification/monitor/resource-manager/readme.md",
    "tag":"package-2022-02",
    "details":"Failed validating: 'file:///home/vsts/work/1/azure-rest-api-specs/specification/monitor/resource-manager/Microsoft.Insights/stable/2020-10-01/activityLogAlerts_API.json',
    error encountered: TypeError: Cannot read property 'type' of undefined"


    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ R4006 - DeprecatedXmsCodeGenerationSetting The x-ms-code-generation-setting extension is being deprecated. Please remove it and move settings to readme file for code generation.
    Location: Microsoft.Insights/preview/2021-09-01-preview/dataCollectionEndpoints_API.json#L7
    ⚠️ R4006 - DeprecatedXmsCodeGenerationSetting The x-ms-code-generation-setting extension is being deprecated. Please remove it and move settings to readme file for code generation.
    Location: Microsoft.Insights/preview/2021-09-01-preview/dataCollectionRuleAssociations_API.json#L7
    ⚠️ R4006 - DeprecatedXmsCodeGenerationSetting The x-ms-code-generation-setting extension is being deprecated. Please remove it and move settings to readme file for code generation.
    Location: Microsoft.Insights/preview/2021-09-01-preview/dataCollectionRules_API.json#L7
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/monitor/resource-manager/readme.md
    tag: specification/monitor/resource-manager/readme.md#tag-package-2022-02
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.

    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 1, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️❌SDK Breaking Change Tracking failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-net failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-js warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-resource-manager-schemas warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @herreraj-ms, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    This was referenced Feb 1, 2022
    Closed
    Closed
    Closed
    Draft
    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Feb 2, 2022
    Draft
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 2, 2022
    @openapi-workflow-bot
    Copy link

    Hi, @herreraj-ms your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @ArcturusZhang
    Copy link
    Member

    Hi @dw511214992 could you please take a look the breaking changes in JS SDK?

    @ArcturusZhang ArcturusZhang mentioned this pull request Feb 22, 2022
    Closed
    @herreraj-ms
    Copy link
    Contributor Author

    herreraj-ms commented Mar 7, 2022 •
    edited
    Loading

    Hi @ArcturusZhang , friendly ping for merging this PR

    Regarding this issue Azure/azure-sdk-for-go#16192 I added the package 2021-05-01-preview to readme.go.md which includes the latest specs for diagnosticsSettings_API.json.

    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Mar 7, 2022
    Closed
    @jianyexi
    Copy link
    Contributor

    jianyexi commented Mar 8, 2022

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @ArcturusZhang ArcturusZhang merged commit 3f2e518 into Azure:main Mar 9, 2022
    This was referenced Mar 9, 2022
    Closed
    Merged
    Closed
    Closed
    Closed
    Closed
    Closed
    ghost pushed a commit to Azure/azure-resource-manager-schemas that referenced this pull request Mar 9, 2022
    [ReleasePR monitor] [Hub Generated] Review request for Microsoft.Insi…
    84859fe 
    …ghts to add version preview/2021-09-01-preview (#2243)

Create to sync Azure/azure-rest-api-specs#17599
[ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...AzureSDKAutomation:sdkAuto/monitor?expand=1)
    FredericHeem pushed a commit to grucloud/azure-rest-api-specs that referenced this pull request May 16, 2022
    @herreraj-ms @FredericHeem
    [Hub Generated] Review request for Microsoft.Insights to add version …
    2eb6a91 
    …preview/2021-09-01-preview (Azure#17599)

* Base from stable/2021-04-01

* Adding AMCS api version 2021-09-01-preview

* Fix Example

* Addin ID to Column definiton array

* Remove invisible character

* prettier

* R4041 - XmsIdentifierValidation

* Set Metadata as readonly

* directive for c# SDK gen rem x-ms-identifiers use

* add data collection endpoint

* fix DCE path

* remove directives for x-mx-identifiers

* apply prettier

* fix tag package on GO-track1 directives

* fix tag package on GO-track1 directives p2

* fix tag package on GO-track1 directives p3

* Update RPs api version to latest

* sort specs list

* undo api version updates of other AM RPs

* fix x-ms-identifiers

* Go - change mult-api list

* adding package-2021-05-01-preview-only

* Undo readme.go.md changes
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @raosuhas raosuhas raosuhas left review comments

    @ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

    @BigCat20196 BigCat20196 Awaiting requested review from BigCat20196

    @msyyc msyyc Awaiting requested review from msyyc msyyc is a code owner

    Assignees

    @jianyexi jianyexi

    Labels
    Approved-LintDiff Approved-SdkBreakingChange-Go-V2 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go-V2 CI-BreakingChange-JavaScript CI-FixRequiredOnFailure
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    6 participants
    @herreraj-ms @KomlaA @ArcturusZhang @jianyexi @raosuhas @pilor