Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding force delete flag for Network Manager resources #17692

Merged
merged 11 commits into from
Mar 11, 2022
Merged

Conversation

jago2136
Copy link
Contributor

@jago2136 jago2136 commented Feb 7, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
    February/asap
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
    2/11 or asap
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @jago2136 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 7, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 13 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R1003 - ListInOperationName Since operation 'ListActiveConnectivityConfigurations' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Network/preview/2022-02-01-preview/networkManagerActiveConfiguration.json#L67
    ⚠️ R1003 - ListInOperationName Since operation 'ListActiveSecurityAdminRules' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Network/preview/2022-02-01-preview/networkManagerActiveConfiguration.json#L120
    ⚠️ R1003 - ListInOperationName Since operation 'ListActiveSecurityUserRules' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Network/preview/2022-02-01-preview/networkManagerActiveConfiguration.json#L173
    ⚠️ R1003 - ListInOperationName Since operation 'ListNetworkManagerEffectiveConnectivityConfigurations' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Network/preview/2022-02-01-preview/networkManagerEffectiveConfiguration.json#L67
    ⚠️ R1003 - ListInOperationName Since operation 'ListNetworkManagerEffectiveSecurityAdminRules' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Network/preview/2022-02-01-preview/networkManagerEffectiveConfiguration.json#L120
    ⚠️ R1003 - ListInOperationName Since operation 'ListEffectiveVirtualNetworks_ByNetworkGroup' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Network/preview/2022-02-01-preview/networkManagerGroup.json#L232
    ⚠️ R1007 - PatchInOperationName 'PATCH' operation 'NetworkManagers_Patch' should use method name 'Update'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Network/preview/2022-02-01-preview/networkManager.json#L156
    ⚠️ R2007 - LongRunningOperationsWithLongRunningExtension The operation 'NetworkManagerCommits_Post' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation.
    Location: Microsoft.Network/preview/2022-02-01-preview/networkManager.json#L205
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'NetworkManagerDeploymentStatusModel'. Consider using the plural form of 'NetworkManagerDeploymentStatus' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Network/preview/2022-02-01-preview/networkManager.json#L262
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'commit' in:'NetworkManagerCommits_Post'. Consider updating the operationId
    Location: Microsoft.Network/preview/2022-02-01-preview/networkManager.json#L209
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'listdeploymentstatus' in:'NetworkManagerDeploymentStatus_List'. Consider updating the operationId
    Location: Microsoft.Network/preview/2022-02-01-preview/networkManager.json#L262
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'listeffectivevirtualnetworks' in:'EffectiveVirtualNetworks_ListByNetworkManager'. Consider updating the operationId
    Location: Microsoft.Network/preview/2022-02-01-preview/networkManager.json#L394
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'listeffectivevirtualnetworks' in:'ListEffectiveVirtualNetworks_ByNetworkGroup'. Consider updating the operationId
    Location: Microsoft.Network/preview/2022-02-01-preview/networkManagerGroup.json#L232


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L301
    R4037 - MissingTypeObject The schema 'ErrorDetails' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L38
    R4037 - MissingTypeObject The schema 'Error' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L55
    R4037 - MissingTypeObject The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L83
    R4037 - MissingTypeObject The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L83
    R4037 - MissingTypeObject The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L83
    R4037 - MissingTypeObject The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L83
    R4037 - MissingTypeObject The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L83
    R4037 - MissingTypeObject The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L83
    R4037 - MissingTypeObject The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L83
    R4037 - MissingTypeObject The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L83
    R4037 - MissingTypeObject The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L83
    R4037 - MissingTypeObject The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L83
    R4037 - MissingTypeObject The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L93
    R4037 - MissingTypeObject The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L93
    R4037 - MissingTypeObject The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L93
    R4037 - MissingTypeObject The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L93
    R4037 - MissingTypeObject The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L93
    R4037 - MissingTypeObject The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L93
    R4037 - MissingTypeObject The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L93
    R4037 - MissingTypeObject The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L93
    R4037 - MissingTypeObject The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L93
    R4037 - MissingTypeObject The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L93
    R4037 - MissingTypeObject The schema 'AzureAsyncOperationResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L118
    R4037 - MissingTypeObject The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L140
    R4037 - MissingTypeObject The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L140
    R4037 - MissingTypeObject The schema 'SubResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L198
    R4037 - MissingTypeObject The schema 'TagsObject' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L208
    R4037 - MissingTypeObject The schema 'ManagedServiceIdentity' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L273
    R4037 - MissingTypeObject The schema 'ExtendedLocation' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L395
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️⚠️Cross-Version Breaking Changes: 56 Warnings warning [Detail]
    The following breaking changes are detected by comparison with latest preview version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.Network/managementGroups/{managementGroupId}/networkManagerConnections/{networkManagerConnectionName}' removed or restructured?
    Old: Microsoft.Network/preview/2021-05-01-preview/networkManagerConnection.json#L190:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.Network/managementGroups/{managementGroupId}/networkManagerConnections' removed or restructured?
    Old: Microsoft.Network/preview/2021-05-01-preview/networkManagerConnection.json#L298:5
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'SecurityConfiguration' removed or renamed?
    New: Microsoft.Network/preview/2022-02-01-preview/networkManagerSecurityAdminConfiguration.json#L571:3
    Old: Microsoft.Network/preview/2021-05-01-preview/networkManagerSecurityAdminConfiguration.json#L577:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'SecurityConfigurationPropertiesFormat' removed or renamed?
    New: Microsoft.Network/preview/2022-02-01-preview/networkManagerSecurityAdminConfiguration.json#L571:3
    Old: Microsoft.Network/preview/2021-05-01-preview/networkManagerSecurityAdminConfiguration.json#L577:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'RuleCollection' removed or renamed?
    New: Microsoft.Network/preview/2022-02-01-preview/networkManagerSecurityAdminConfiguration.json#L571:3
    Old: Microsoft.Network/preview/2021-05-01-preview/networkManagerSecurityAdminConfiguration.json#L577:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'RuleCollectionPropertiesFormat' removed or renamed?
    New: Microsoft.Network/preview/2022-02-01-preview/networkManagerSecurityAdminConfiguration.json#L571:3
    Old: Microsoft.Network/preview/2021-05-01-preview/networkManagerSecurityAdminConfiguration.json#L577:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'RuleCollectionPropertiesFormat' removed or renamed?
    New: Microsoft.Network/preview/2022-02-01-preview/networkManagerSecurityUserConfiguration.json#L571:3
    Old: Microsoft.Network/preview/2021-05-01-preview/networkManagerSecurityUserConfiguration.json#L556:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'RuleCollection' removed or renamed?
    New: Microsoft.Network/preview/2022-02-01-preview/networkManagerSecurityUserConfiguration.json#L571:3
    Old: Microsoft.Network/preview/2021-05-01-preview/networkManagerSecurityUserConfiguration.json#L556:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'SecurityConfigurationPropertiesFormat' removed or renamed?
    New: Microsoft.Network/preview/2022-02-01-preview/networkManagerSecurityUserConfiguration.json#L571:3
    Old: Microsoft.Network/preview/2021-05-01-preview/networkManagerSecurityUserConfiguration.json#L556:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'SecurityConfiguration' removed or renamed?
    New: Microsoft.Network/preview/2022-02-01-preview/networkManagerSecurityUserConfiguration.json#L571:3
    Old: Microsoft.Network/preview/2021-05-01-preview/networkManagerSecurityUserConfiguration.json#L556:3
    ⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'RecursiveDeleteParameter' removed or renamed?
    New: Microsoft.Network/preview/2022-02-01-preview/networkManagerSecurityAdminConfiguration.json#L1029:3
    Old: Microsoft.Network/preview/2021-05-01-preview/networkManagerSecurityAdminConfiguration.json#L1076:3
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'displayName' renamed or removed?
    New: Microsoft.Network/preview/2022-02-01-preview/networkManager.json#L493:7
    Old: Microsoft.Network/preview/2021-05-01-preview/networkManager.json#L488:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'displayName' renamed or removed?
    New: Microsoft.Network/preview/2022-02-01-preview/networkManagerConnectivityConfiguration.json#L249:7
    Old: Microsoft.Network/preview/2021-05-01-preview/networkManagerConnectivityConfiguration.json#L249:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'displayName' renamed or removed?
    New: Microsoft.Network/preview/2022-02-01-preview/networkManagerGroup.json#L494:7
    Old: Microsoft.Network/preview/2021-05-01-preview/networkManagerGroup.json#L494:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'configurationDisplayName' renamed or removed?
    New: Microsoft.Network/preview/2022-02-01-preview/networkManagerActiveConfiguration.json#L289:7
    Old: Microsoft.Network/preview/2021-05-01-preview/networkManagerActiveConfiguration.json#L289:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'ruleCollectionDisplayName' renamed or removed?
    New: Microsoft.Network/preview/2022-02-01-preview/networkManagerActiveConfiguration.json#L289:7
    Old: Microsoft.Network/preview/2021-05-01-preview/networkManagerActiveConfiguration.json#L289:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'configurationDisplayName' renamed or removed?
    New: Microsoft.Network/preview/2022-02-01-preview/networkManagerActiveConfiguration.json#L381:7
    Old: Microsoft.Network/preview/2021-05-01-preview/networkManagerActiveConfiguration.json#L389:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'ruleCollectionDisplayName' renamed or removed?
    New: Microsoft.Network/preview/2022-02-01-preview/networkManagerActiveConfiguration.json#L381:7
    Old: Microsoft.Network/preview/2021-05-01-preview/networkManagerActiveConfiguration.json#L389:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'displayName' renamed or removed?
    New: Microsoft.Network/preview/2022-02-01-preview/networkManagerSecurityAdminConfiguration.json#L766:7
    Old: Microsoft.Network/preview/2021-05-01-preview/networkManagerSecurityAdminConfiguration.json#L804:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'configurationDisplayName' renamed or removed?
    New: Microsoft.Network/preview/2022-02-01-preview/networkManagerActiveConfiguration.json#L347:7
    Old: Microsoft.Network/preview/2021-05-01-preview/networkManagerActiveConfiguration.json#L355:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'ruleCollectionDisplayName' renamed or removed?
    New: Microsoft.Network/preview/2022-02-01-preview/networkManagerActiveConfiguration.json#L347:7
    Old: Microsoft.Network/preview/2021-05-01-preview/networkManagerActiveConfiguration.json#L355:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'displayName' renamed or removed?
    New: Microsoft.Network/preview/2022-02-01-preview/networkManagerSecurityAdminConfiguration.json#L860:7
    Old: Microsoft.Network/preview/2021-05-01-preview/networkManagerSecurityAdminConfiguration.json#L902:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'configurationDisplayName' renamed or removed?
    New: Microsoft.Network/preview/2022-02-01-preview/networkManagerActiveConfiguration.json#L364:7
    Old: Microsoft.Network/preview/2021-05-01-preview/networkManagerActiveConfiguration.json#L372:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'ruleCollectionDisplayName' renamed or removed?
    New: Microsoft.Network/preview/2022-02-01-preview/networkManagerActiveConfiguration.json#L364:7
    Old: Microsoft.Network/preview/2021-05-01-preview/networkManagerActiveConfiguration.json#L372:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'displayName' renamed or removed?
    New: Microsoft.Network/preview/2022-02-01-preview/networkManagerSecurityUserConfiguration.json#L771:7
    Old: Microsoft.Network/preview/2021-05-01-preview/networkManagerSecurityUserConfiguration.json#L625:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'configurationDisplayName' renamed or removed?
    New: Microsoft.Network/preview/2022-02-01-preview/networkManagerActiveConfiguration.json#L439:7
    Old: Microsoft.Network/preview/2021-05-01-preview/networkManagerActiveConfiguration.json#L455:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'ruleCollectionDisplayName' renamed or removed?
    New: Microsoft.Network/preview/2022-02-01-preview/networkManagerActiveConfiguration.json#L439:7
    Old: Microsoft.Network/preview/2021-05-01-preview/networkManagerActiveConfiguration.json#L455:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'displayName' renamed or removed?
    New: Microsoft.Network/preview/2022-02-01-preview/networkManagerSecurityUserConfiguration.json#L852:7
    Old: Microsoft.Network/preview/2021-05-01-preview/networkManagerSecurityUserConfiguration.json#L710:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'configurationDisplayName' renamed or removed?
    New: Microsoft.Network/preview/2022-02-01-preview/networkManagerActiveConfiguration.json#L456:7
    Old: Microsoft.Network/preview/2021-05-01-preview/networkManagerActiveConfiguration.json#L472:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'ruleCollectionDisplayName' renamed or removed?
    New: Microsoft.Network/preview/2022-02-01-preview/networkManagerActiveConfiguration.json#L456:7
    Old: Microsoft.Network/preview/2021-05-01-preview/networkManagerActiveConfiguration.json#L472:7
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 7, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go-track2 - armnetwork - 0.4.0
    +	Function `CloudErrorBody.MarshalJSON` has been removed
    +	Function `Error.MarshalJSON` has been removed
    +	Function `VirtualHubEffectiveRoute.MarshalJSON` has been removed
    +	Function `VirtualHubEffectiveRouteList.MarshalJSON` has been removed
    +	Struct `AzureAsyncOperationResult` has been removed
    +	Struct `CloudErrorBody` has been removed
    +	Struct `CloudError` has been removed
    +	Struct `ErrorDetails` has been removed
    +	Struct `ErrorResponse` has been removed
    +	Struct `Error` has been removed
    +	Struct `VPNSiteID` has been removed
    +	Struct `VirtualHubEffectiveRouteList` has been removed
    +	Struct `VirtualHubEffectiveRoute` has been removed
    +	Type of `BastionActiveSession.StartTime` has been changed from `map[string]interface{}` to `interface{}`
    azure-sdk-for-js - track2_@azure/arm-network - 27.0.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-network - 19.3.0
    ️✔️azure-sdk-for-go - network/mgmt/2021-05-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2021-03-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2021-02-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2020-11-01/network - v62.1.0
    azure-sdk-for-go - network/mgmt/2020-08-01/network - v62.1.0
    +	Field `ExtendedLocation` of struct `VirtualNetworkGatewayPropertiesFormat` has been removed
    +	Field `VirtualNetworkExtendedLocationResourceID` of struct `VirtualNetworkGatewayPropertiesFormat` has been removed
    +	Type of `SubnetPropertiesFormat.PrivateEndpointNetworkPolicies` has been changed from `*string` to `VirtualNetworkPrivateEndpointNetworkPolicies`
    +	Type of `SubnetPropertiesFormat.PrivateLinkServiceNetworkPolicies` has been changed from `*string` to `VirtualNetworkPrivateLinkServiceNetworkPolicies`
    azure-sdk-for-go - network/mgmt/2020-07-01/network - v62.1.0
    +	Field `ExtendedLocation` of struct `VirtualNetworkGatewayPropertiesFormat` has been removed
    +	Field `VirtualNetworkExtendedLocationResourceID` of struct `VirtualNetworkGatewayPropertiesFormat` has been removed
    +	Type of `SubnetPropertiesFormat.PrivateEndpointNetworkPolicies` has been changed from `*string` to `VirtualNetworkPrivateEndpointNetworkPolicies`
    +	Type of `SubnetPropertiesFormat.PrivateLinkServiceNetworkPolicies` has been changed from `*string` to `VirtualNetworkPrivateLinkServiceNetworkPolicies`
    ️✔️azure-sdk-for-go - network/mgmt/2020-06-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2020-05-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2020-04-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2020-03-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-12-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-11-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-09-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-08-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-07-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-06-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-04-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-02-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-12-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-11-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-10-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-08-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-07-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-06-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-04-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-02-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-01-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2017-11-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2017-10-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2017-09-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2017-08-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2017-06-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2017-03-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2016-12-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2016-09-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2016-06-01/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2016-03-30/network - v62.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2015-06-15/network - v62.1.0
    ️✔️azure-sdk-for-go - preview/network/mgmt/2021-03-01-preview/network - v62.1.0
    ️✔️azure-sdk-for-go - preview/network/mgmt/2015-05-01-preview/network - v62.1.0
    azure-sdk-for-js - @azure/arm-network - 27.0.0
    +	Removed Enum KnownEnum69
    +	Removed Enum KnownEnum70
    +	Removed Enum KnownEnum71
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 08210cd. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-6.0
      command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Network [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 08210cd. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.3.1 -> 8.5.4
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.4>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.5.4` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-network [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 08210cd. SDK Automation 14.0.0
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️network/mgmt/2021-05-01/network [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2021-03-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2021-02-01/network [View full logs
      Only show 3 items here, please refer to log for details.
      info	[Changelog] - New field `ResourceGUID` in struct `PrivateLinkServiceProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 6 additive change(s).
    • ️✔️network/mgmt/2020-11-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2020-08-01/network [View full logs
      Only show 3 items here, please refer to log for details.
      info	[Changelog] - New field `Type` in struct `VirtualNetworkPeering`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 35 additive change(s).
    • ️✔️network/mgmt/2020-07-01/network [View full logs
      Only show 3 items here, please refer to log for details.
      info	[Changelog] - New field `DisplayName` in struct `AvailablePrivateEndpointType`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 27 additive change(s).
    • ️✔️network/mgmt/2020-06-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2020-05-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2020-04-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2020-03-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-12-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-11-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-09-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-08-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-07-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-06-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-04-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-02-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-12-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-11-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-10-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-08-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-07-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-06-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-04-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-02-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-01-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2017-11-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2017-10-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2017-09-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2017-08-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2017-06-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2017-03-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2016-12-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2016-09-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2016-06-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2016-03-30/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2015-06-15/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/network/mgmt/2021-03-01-preview/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/network/mgmt/2015-05-01-preview/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 08210cd. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armnetwork [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `BastionActiveSession.StartTime` has been changed from `map[string]interface{}` to `interface{}`
      info	[Changelog] - Function `CloudErrorBody.MarshalJSON` has been removed
      info	[Changelog] - Function `Error.MarshalJSON` has been removed
      info	[Changelog] - Function `VirtualHubEffectiveRoute.MarshalJSON` has been removed
      info	[Changelog] - Function `VirtualHubEffectiveRouteList.MarshalJSON` has been removed
      info	[Changelog] - Struct `AzureAsyncOperationResult` has been removed
      info	[Changelog] - Struct `CloudError` has been removed
      info	[Changelog] - Struct `CloudErrorBody` has been removed
      info	[Changelog] - Struct `Error` has been removed
      info	[Changelog] - Struct `ErrorDetails` has been removed
      info	[Changelog] - Struct `ErrorResponse` has been removed
      info	[Changelog] - Struct `VPNSiteID` has been removed
      info	[Changelog] - Struct `VirtualHubEffectiveRoute` has been removed
      info	[Changelog] - Struct `VirtualHubEffectiveRouteList` has been removed
      info	[Changelog]
      info	[Changelog] Total 23 breaking change(s), 0 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 08210cd. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      cmderr	[automation_init.sh] WARN deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
      cmderr	[automation_init.sh] deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
      cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
      cmderr	[automation_init.sh]  created a lockfile as package-lock.json. You should commit this file.
      cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-network [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added Type Alias SingleQueryResultDirection
      info	[Changelog]   - Added Type Alias SingleQueryResultMode
      info	[Changelog]   - Added Type Alias SingleQueryResultSeverity
      info	[Changelog]   - Added Enum KnownSingleQueryResultDirection
      info	[Changelog]   - Added Enum KnownSingleQueryResultMode
      info	[Changelog]   - Added Enum KnownSingleQueryResultSeverity
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Removed Enum KnownEnum69
      info	[Changelog]   - Removed Enum KnownEnum70
      info	[Changelog]   - Removed Enum KnownEnum71
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 08210cd. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
      warn	Skip detect changed packages
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @jago2136, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    @openapi-workflow-bot
    Copy link

    Hi @jago2136, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @lirenhe
    Copy link
    Member

    lirenhe commented Feb 18, 2022

    @jago2136 , could you fix the swagger examples for model validation errors?
    Please also check with @MikhailTryakhov about the branch used. Normally, there are apiversion specific repo for NRP.

    @lirenhe lirenhe added Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 18, 2022
    Copy link
    Contributor

    @j5lim j5lim left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Approved from ARM side.

    @j5lim j5lim added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 2, 2022
    @yanfa317
    Copy link
    Contributor

    yanfa317 commented Mar 7, 2022

    LGTM

    @jago2136
    Copy link
    Contributor Author

    jago2136 commented Mar 7, 2022

    Spoke with Mikhail, and he confirmed this is the correct target branch given we are still in preview. Thanks!

    @lirenhe lirenhe removed the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Mar 8, 2022
    @lirenhe
    Copy link
    Member

    lirenhe commented Mar 8, 2022

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @lirenhe lirenhe merged commit 08210cd into Azure:main Mar 11, 2022
    FredericHeem pushed a commit to grucloud/azure-rest-api-specs that referenced this pull request May 16, 2022
    * base commit for PR reviewer
    
    * add force delete flags and remove recursive delete flags
    
    * security configuration split into admin/user
    
    * split rule collection into admin/user rule collection
    
    * updating examples for security config resources
    
    * update api version
    
    * fix parameter types for security admin conf/rule collection
    
    * removing display name from all definitions and examples
    
    * fix properties of security config examples
    
    * fix network manager connection path
    
    * update readme with complete spec list
    
    Co-authored-by: Jared Gorthy <jaredgorthy@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-LintDiff ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go-V2 CI-BreakingChange-JavaScript CI-FixRequiredOnFailure Network
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants