[Stream Analytics] Add Azure Function and Blob Input MSI #17697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @roslynlu Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
|
Hi @roslynlu, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
NewApiVersionRequired reason: |
This was referenced Feb 8, 2022
This was referenced Feb 8, 2022
|
@weidongxu-microsoft I pushed a small fix (removed an extra property in some example files), but then the swagger validation bot started complaining about discriminator_value_not_found for the serialization property in inputs.json. I'm confused because this wasn't modified/touched in this PR, and it wasn't failing the first few commits either. Do you have insight on what the issue could be? |
JeffreyRichter
added
the
Approved-BreakingChange
|
Your example seems wrong.
|
|
@weidongxu-microsoft yes, serialization and datasource are on the same level. you can see this in the object OutputProperties in outputs.json. and as far as I can tell, all the example files are consistent with this |
|
I see. Yes, your example is correct. I will rerun the CI. If it still fails I will loop-in tooling. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Swagger Generation Artifacts
|
|
ModelValidation seems not correct. |
|
@raych1 Hi Ray, would you double check whether ModelValidation result is correct or not? |
weidongxu-microsoft
approved these changes
Feb 19, 2022
weidongxu-microsoft
added
the
Approved-OkToMerge
@weidongxu-microsoft , they are false alarm and were fixed in latest version of OAV. We will release it to pipeline this week. |
|
@weidongxu-microsoft can this PR be merged now? |
This was referenced Feb 24, 2022
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
Mar 7, 2022
* add azure function * add authenticationMode to blob input, AzFunction and DW ex files * update api version in 2021 preview ex files * fix api version * fix password * try to run model validation again Co-authored-by: Roslyn Lu <roslu@microsoft.com>
This was referenced May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR include:
Both Azure Function and MSI for blob input are available in versions 2017 preview, 2021 preview, and 2020 stable. Updating swagger to reflect that.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.