KubernetesConfiguration 2022-04-02-preview version changes #18138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamyasreeChakka
requested review from
msyyc,
BigCat20196 and
ArcturusZhang
as code owners
|
Hi, @RamyasreeChakka Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.KubernetesConfiguration/preview/2022-04-02-preview/privateLinkScopes.json#L591 |
|
| Based on the response model schema, operation 'PrivateLinkResources_ListByPrivateLinkScope' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.KubernetesConfiguration/preview/2022-04-02-preview/privateLinkScopes.json#L297 |
|
| Based on the response model schema, operation 'PrivateEndpointConnections_ListByPrivateLinkScope' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.KubernetesConfiguration/preview/2022-04-02-preview/privateLinkScopes.json#L532 |
|
| The x-ms-code-generation-setting extension is being deprecated. Please remove it and move settings to readme file for code generation. Location: Microsoft.KubernetesConfiguration/preview/2022-04-02-preview/privateLinkScopes.json#L5 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Gets private endpoint connection. Location: Microsoft.KubernetesConfiguration/preview/2022-04-02-preview/privateLinkScopes.json#L376 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Gets private endpoint connection. Location: Microsoft.KubernetesConfiguration/preview/2022-04-02-preview/privateLinkScopes.json#L421 |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: forceDelete Location: Microsoft.KubernetesConfiguration/preview/2022-04-02-preview/extensions.json#L195 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
- Compared Swaggers (Based on Oad v0.9.3)
- current:preview/2022-04-02-preview/extensions.json compared with base:stable/2022-03-01/extensions.json
- current:preview/2022-04-02-preview/extensions.json compared with base:preview/2022-01-01-preview/extensions.json
️❌CredScan: 0 Errors, 0 Warnings failed [Detail]
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
|
Hi, @RamyasreeChakka your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
Swagger Generation Artifacts
|
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
RamyasreeChakka
requested review from
kulalking,
jonathan-innis and
NarayanThiru
|
Hi @RamyasreeChakka, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Mar 9, 2022
RamyasreeChakka
commented
Mar 9, 2022
| @@ -28,11 +28,24 @@ These are the global settings for the KubernetesConfiguration. | |||
| title: SourceControlConfigurationClient | |||
| description: KubernetesConfiguration Client | |||
| openapi-type: arm | |||
| tag: package-2022-03 | |||
| tag: package-preview-2022-04 | |||
| ``` | |||
There was a problem hiding this comment.
Lets use package-2022-03 as the default api version
RamyasreeChakka
commented
Mar 9, 2022
| @@ -59,19 +72,6 @@ input-file: | |||
| - Microsoft.KubernetesConfiguration/preview/2022-01-01-preview/operations.json | |||
| ``` | |||
|
|
|||
| ### Tag: package-preview-2021-11 | |||
|
|
|||
There was a problem hiding this comment.
Can you please revert this change?
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ruowan
approved these changes
Mar 28, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Apr 1, 2022
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Apr 1, 2022
…2-preview version changes (#2275) Create to sync Azure/azure-rest-api-specs#18138 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...AzureSDKAutomation:sdkAuto/kubernetesconfiguration?expand=1)
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
May 16, 2022
* Add 2022-03-01 version files as base commit * 2022-04-02-preview version changes * Readme changes * Update parameters version * update the example files with 2022-04-02 version * prettier and fixing the tooling issues * Some more object fixes * code review comments got fixed and used common types * Fixing more tooling issues and fixed all the code review comments * Code review comments got fixed. * Removing the paging as we always have 1 entry per resource type. * copied the 2022-01-01-preview files to 2022-04-02-preview to avoid the sdk generation issues. * Fixing the swagger lintdiff * Fixed the Avacado error * Removing the extensiontypes json * update readme.python Co-authored-by: Sathish Kulal <sathish.kulal@gmail.com> Co-authored-by: Jiefeng Chen (WICRESOFT NORTH AMERICA LTD) <v-jiechen@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Add a changelog entry for this PR by answering the following questions:
What's the purpose of the update?
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
We plan to deploy the changes in March 2022.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
We target swagger publish in March 2022.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.