Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev tongwu healthcareapis microsoft.healthcare apis stable 2022 06 01 #19496

Merged
merged 5 commits into from
Jul 20, 2022
Merged

Dev tongwu healthcareapis microsoft.healthcare apis stable 2022 06 01 #19496

merged 5 commits into from
Jul 20, 2022

Conversation

tongwu-sh
Copy link
Contributor

@tongwu-sh tongwu-sh commented Jun 17, 2022 •
edited
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @tongwu-msft Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 17, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️⚠️LintDiff: 6 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: initialImportMode
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L2460
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L2465
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isInternal
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L3057
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableRegionalMdmAccount
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L3069
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: initialImportMode
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L3985
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L3990


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L2363
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L2426
    ❌ R4037 - MissingTypeObject The schema 'ServiceAccessPolicyEntry' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L2346
    ❌ R4037 - MissingTypeObject The schema 'ServicesResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L2546
    ❌ R4039 - ParametersOrder The parameters:resourceGroupName,dicomServiceName,workspaceName should be kept in the same order as they present in the path.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L1075
    ❌ R4039 - ParametersOrder The parameters:resourceGroupName,dicomServiceName,workspaceName should be kept in the same order as they present in the path.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L1134
    ❌ R4039 - ParametersOrder The parameters:resourceGroupName,iotConnectorName,workspaceName should be kept in the same order as they present in the path.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L1336
    ❌ R4039 - ParametersOrder The parameters:resourceGroupName,iotConnectorName,workspaceName should be kept in the same order as they present in the path.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L1395
    ❌ R4039 - ParametersOrder The parameters:resourceGroupName,fhirServiceName,workspaceName should be kept in the same order as they present in the path.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L1811
    ❌ R4039 - ParametersOrder The parameters:resourceGroupName,fhirServiceName,workspaceName should be kept in the same order as they present in the path.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L1870
    ❌ R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L2339
    ❌ R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L2815
    ❌ R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L3826
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L2865
    ⚠️ R2017 - PutRequestResponseScheme A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'PrivateEndpointConnections_CreateOrUpdate' Request Model: 'PrivateEndpointConnection' Response Model: 'PrivateEndpointConnectionDescription'
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L444
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'PrivateLinkResources_ListByService' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L546
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'privateEndpointConnections' with immediate parent 'ServicesDescription', must have a list by immediate parent operation.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L2714
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'privateEndpointConnections' with immediate parent 'Workspace', must have a list by immediate parent operation.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L2714
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'privateLinkResources' with immediate parent 'ServicesDescription', must have a list by immediate parent operation.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L2729
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'privateLinkResources' with immediate parent 'Workspace', must have a list by immediate parent operation.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L2729
    ⚠️ R3017 - GuidUsage Guid used in model definition 'ServiceManagedIdentity' for property 'principalId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L3202
    ⚠️ R3017 - GuidUsage Guid used in model definition 'UserAssignedIdentity' for property 'principalId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L3247
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: smartProxyEnabled
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L2391
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: allowCredentials
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L2433
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: nameAvailable
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L2690
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L2839
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: fillGapWithZero
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L3040
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: toBeExportedForShoebox
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L3091
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: allowCredentials
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L3481
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: smartProxyEnabled
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L3884
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️❌ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ API Readiness check failed. Please make sure your service is deployed. "code: InvalidResourceType,
    message: The resource type 'operations' could not be found in the namespace 'Microsoft.HealthcareApis' for api version '2022-06-01'. The supported api-versions are '2018-08-20-preview,
    2019-09-16,
    2020-03-15,
    2020-03-30,
    2021-01-11,
    2021-06-01-preview,
    2021-11-01,
    2022-01-31-preview,
    2022-05-15'."
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.

    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 17, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go - armhealthcareapis - 1.0.1
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-healthcareapis - 1.1.0
    ️❌ azure-sdk-for-net failed [Detail]
    • ❌Failed [Logs]Release - Generate from 7587673. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/healthcareapis/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] No usable version of the libssl was found
cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 7587673. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] config global `--global`, `--local` are deprecated. Use `--location=global` instead.
    • ️✔️track2_azure-mgmt-healthcareapis [View full logs]  [Release SDK Changes] 
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model DicomService has a new parameter cors_configuration
info	[Changelog]   - Model FhirService has a new parameter import_configuration
info	[Changelog]   - Model MetricSpecification has a new parameter enable_regional_mdm_account
info	[Changelog]   - Model MetricSpecification has a new parameter is_internal
info	[Changelog]   - Model MetricSpecification has a new parameter metric_filter_pattern
info	[Changelog]   - Model MetricSpecification has a new parameter resource_id_dimension_name_override
info	[Changelog]   - Model MetricSpecification has a new parameter source_mdm_account
info	[Changelog]   - Model ServicesProperties has a new parameter import_configuration
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 7587673. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armhealthcareapis [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New struct `CorsConfiguration`
info	[Changelog] - New struct `FhirServiceImportConfiguration`
info	[Changelog] - New struct `ServiceImportConfigurationInfo`
info	[Changelog] - New field `CorsConfiguration` in struct `DicomServiceProperties`
info	[Changelog] - New field `ImportConfiguration` in struct `ServicesProperties`
info	[Changelog] - New field `ImportConfiguration` in struct `FhirServiceProperties`
info	[Changelog] - New field `EnableRegionalMdmAccount` in struct `MetricSpecification`
info	[Changelog] - New field `IsInternal` in struct `MetricSpecification`
info	[Changelog] - New field `MetricFilterPattern` in struct `MetricSpecification`
info	[Changelog] - New field `ResourceIDDimensionNameOverride` in struct `MetricSpecification`
info	[Changelog] - New field `SourceMdmAccount` in struct `MetricSpecification`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 10 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 7587673. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh] npm WARN deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh]  uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh]  @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh]  deprecated @azure/storage-blob@10.5.0: This version has been deprecated, please upgrade to the version tagged as latest
cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-healthcareapis [View full logs]  [Release SDK Changes] 
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface CorsConfiguration
info	[Changelog]   - Added Interface FhirServiceImportConfiguration
info	[Changelog]   - Added Interface ServiceImportConfigurationInfo
info	[Changelog]   - Interface MetricSpecification has a new optional parameter enableRegionalMdmAccount
info	[Changelog]   - Interface MetricSpecification has a new optional parameter isInternal
info	[Changelog]   - Interface MetricSpecification has a new optional parameter metricFilterPattern
info	[Changelog]   - Interface MetricSpecification has a new optional parameter resourceIdDimensionNameOverride
info	[Changelog]   - Interface MetricSpecification has a new optional parameter sourceMdmAccount
info	[Changelog]   - Interface ServicesProperties has a new optional parameter importConfiguration
info	[Changelog]   - Type Alias DicomService has a new parameter corsConfiguration
info	[Changelog]   - Type Alias FhirService has a new parameter importConfiguration
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 7587673. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️healthcareapis [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • ❌Failed [Logs]Release - Generate from 7587673. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ❌Az.healthcareapis [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    This was referenced Jun 17, 2022
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    @openapi-workflow-bot openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 17, 2022
    @openapi-workflow-bot
    Copy link

    Hi, @tongwu-msft your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @zizw123
    Copy link

    zizw123 commented Jun 17, 2022 

        "initialImportMode": {

    For these boolean, have you considered if they can be enum: https://armwiki.azurewebsites.net/rp_onboarding/process/api_review_best_practices.html

    Refers to: specification/healthcareapis/resource-manager/Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json:2460 in 7273b6c. [](commit_id = 7273b6c, deletion_comment = False)

    @zizw123 zizw123 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jun 17, 2022
    @openapi-workflow-bot
    Copy link

    Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 17, 2022
    @tongwu-sh
    Copy link
    Contributor Author 

        "initialImportMode": {

    For these boolean, have you considered if they can be enum: https://armwiki.azurewebsites.net/rp_onboarding/process/api_review_best_practices.html

    Refers to: specification/healthcareapis/resource-manager/Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json:2460 in 7273b6c. [](commit_id = 7273b6c, deletion_comment = False)

    Thanks for the comments. The initialImportMode is a settings for customer to run import in this special mode, it is more like a true/false value instead of a enum.

    @tongwu-sh tongwu-sh removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jun 19, 2022
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 19, 2022
    @rkmanda rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jun 21, 2022
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 21, 2022
    @changlong-liu changlong-liu added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Jun 22, 2022
    @changlong-liu changlong-liu merged commit 7587673 into main Jul 20, 2022
    This was referenced Jul 20, 2022
    Closed
    Merged
    Closed
    Closed
    Closed
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @changlong-liu changlong-liu changlong-liu approved these changes

    Assignees

    @changlong-liu changlong-liu

    Labels
    Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    4 participants
    @tongwu-sh @zizw123 @changlong-liu @rkmanda