Update to Release 3.5 standard (pre GA) #5370

leonardbf · 2019-03-13T09:17:45Z

Still in preview - breaking changes are not considered applicable. 
Changes:

Inclusion of status code (due to sync).
Inclusion of account and volume property (AD and export policy)
Inclusion of missing capacityPool patch properties
ServiceLevel name change
Changed resourceGroup to resourceGroupName (correct naming for CLI features)
(internal ticket NFSAAS-1875)

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

NFSAAS-1505 minor update and validation fixes

Put (and patch) for snapshots. Service level definition changes.

NFSAAS-1505 bring in line with RP

NFSAAS-1505 correct resource reference and limits

Incorrect pool resource reference Name elements of property not required Correction to return status code

NFSAAS-1505 resource and property changes

NFSAAS-1505 status codes

NFSAAS-1505 tidy up examples

NFSAAS-1644 remove mt get and add put status code

NFSAAS-1644 remove mt get add status for put

NFSAAS-1875 update to R3.5 standard

azuresdkci · 2019-03-13T09:17:53Z

Can one of the admins verify this patch?

AutorestCI · 2019-03-13T09:18:23Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-03-13T09:18:38Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4622

AutorestCI · 2019-03-13T09:18:41Z

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#1665

AutorestCI · 2019-03-13T09:18:42Z

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

AutorestCI · 2019-03-13T09:18:51Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2019-03-13T09:20:13Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4339

adxsdknet · 2019-03-13T09:23:59Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5431
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@526dc91
adxsdknet/azure-sdk-for-net@af1c3f0
adxsdknet/azure-sdk-for-net@0bf4c9b

REST Spec PR 'Azure/azure-rest-api-specs#5370' REST Spec PR Author 'leonardbf' REST Spec PR Last commit

* NFSAAS-1875 Update to R3.5 Standard * NFSAAS-1875 update to R3.5 standard

REST Spec PR 'Azure/azure-rest-api-specs#5370' REST Spec PR Author 'leonardbf' REST Spec PR Last commit

veronicagg · 2019-03-13T17:28:01Z

@kpajdzik would you take this one? thanks!

kpajdzik · 2019-03-13T17:28:56Z

@veronicagg I will :)

nschonni · 2019-03-13T20:54:27Z

specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/netapp.json

+      "properties": {
+        "activeDirectoryId": {
+          "type": "string",
+          "description": "Id of the active drectory"


drectory -> directory
Maybe also capitalize too

nschonni · 2019-03-13T20:54:33Z

specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/netapp.json

+        },
+        "status": {
+          "type": "string",
+          "description": "Status of the active drectory"


drectory -> directory
Maybe also capitalize too

nschonni · 2019-03-13T20:54:50Z

specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/netapp.json

+        },
+        "allowedClients": {
+          "type": "string",
+          "description": "Client ingress specification as comma seperated string with IPv4 CIDRs, IPv4 host addresses and host names"


seperated -> separated

nschonni · 2019-03-13T20:55:05Z

specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/netapp.json

@@ -1627,6 +1771,12 @@
          "type": "string",
          "example": "255.255.255.0"
        },
+        "smbServerFqdn": {
+          "title": "smbServerFQDN",
+          "description": "The SMB server's Fully Qualified Doman Name, FQDN",


Doman -> Domain

* NFSAAS-1875 Update to R3.5 Standard * NFSAAS-1875 update to R3.5 standard * NFSAAS-1875 updated from review comments

REST Spec PR 'Azure/azure-rest-api-specs#5370' REST Spec PR Author 'leonardbf' REST Spec PR Last commit

Merging to fork from azure master

kpajdzik · 2019-03-14T16:49:12Z

If you haven't taken a look at our new onboarding experience at OpenAPIHub, it's a convenient way to create your PR when you're copying from an existing API version or when you're editing your existing specs. If you have any feedback or questions, feel free to use the feedback button on top of the site for help. Thanks!

kpajdzik · 2019-03-14T16:50:26Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@anuchandy Could you please take a look?

kpajdzik · 2019-03-14T17:02:51Z

specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/netapp.json

+          "type": "string",
+          "description": "Username of Active Directory domain administrator"
+        },
+        "password": {


Could you elaborate on this parameter? Is this secure?

It's credentials for the AD admin at the lower level. The RP only passes this through to the lower level. It is transmitted via https to the RP. But yes quite correct, the security is in question and there is an internal ticket to address this for the next release (pre-GA). Of course this swagger only reflects this implementation.

kpajdzik · 2019-03-14T17:09:09Z

specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/netapp.json

+          "type": "boolean",
+          "description": "Read only access"
+        },
+        "unixReadWrite": {


Why is it prefixed with "unix"? Should this be included in description as well?

It's a consequence of a lower level API that the RP calls. This value is simply passed through. But it is because it only applies to the NFS permissions. It doesn’t do anything useful for NTFS.

leonardbf · 2019-03-15T14:43:21Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@anuchandy Could you please take a look?

Just a clarification - is Java SDK something that Microsoft will auto generate? Is it one of those handled from within the Devx OpenAPI hub for instance?

kpajdzik · 2019-03-15T15:16:42Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@anuchandy Could you please take a look?

Just a clarification - is Java SDK something that Microsoft will auto generate? Is it one of those handled from within the Devx OpenAPI hub for instance?

Yes, it is the one handled by OpenAPI portal. It included Java, Node.js (soon deprecated so no new SDKs), TypeScript, Ruby and Python.

leonardbf · 2019-03-18T09:57:40Z

I've provided answers for the comments but this PR is still open. Can someone either respond if there are further issues or merge please.
Thanks.

leonardbf · 2019-03-19T23:05:17Z

Since this is approved, is there any chance it could be merged? Thanks.

leonardbf and others added 21 commits November 20, 2018 08:04

NFSAAS-1505 minor update and validation fixes

27c0982

Merge pull request #1 from leonardbf/netapp-api-update-public

4535ffb

NFSAAS-1505 minor update and validation fixes

NFSAAS-1505 bring in line with RP

d23b068

Put (and patch) for snapshots. Service level definition changes.

Merge pull request #2 from leonardbf/netapp-api-update-public

d6ce7d9

NFSAAS-1505 bring in line with RP

NFSAAS-1505 correct resource reference and limits

2e3393a

Merge pull request #3 from leonardbf/netapp-api-update-public

d64fced

NFSAAS-1505 correct resource reference and limits

NFSAAS-1505 resource and property changes

f81874b

Incorrect pool resource reference Name elements of property not required Correction to return status code

Merge pull request #4 from leonardbf/netapp-api-update-public

164da1f

NFSAAS-1505 resource and property changes

NFSAAS-1505 status codes

7ec6b9e

Merge pull request #5 from leonardbf/netapp-api-update-public

5892e13

NFSAAS-1505 status codes

NFSAAS-1505 tidy up examples

79df024

Merge pull request #6 from leonardbf/netapp-api-update-public

d8c27fb

NFSAAS-1505 tidy up examples

NFSAAS-1505 tidy up examples

728ffb4

Merge pull request #7 from leonardbf/netapp-api-update-public

e64f32f

NFSAAS-1505 tidy up examples

NFSAAS-1644 remove mt get and add put status code

b820b48

Merge pull request #8 from leonardbf/netapp-api-update-public

2acb8c0

NFSAAS-1644 remove mt get and add put status code

NFSAAS-1644 remove mt get and add put status code

c005d43

Merge pull request #9 from leonardbf/mt-sc-update

4f47c60

NFSAAS-1644 remove mt get add status for put

NFSAAS-1875 update to R3.5 standard

be1df19

Merge pull request #10 from leonardbf/NFSAAS-1875-swagger-update

8efc20e

NFSAAS-1875 update to R3.5 standard

NFSAAS-1875 Update to R3.5 Standard (#11)

46f3cb6

azuresdkci assigned veronicagg Mar 13, 2019

azuresdkci requested a review from veronicagg March 13, 2019 09:18

AutorestCI mentioned this pull request Mar 13, 2019

[AutoPR netapp/resource-manager] Update to Release 3.5 standard (pre GA) Azure/azure-sdk-for-python#4556

Merged

AutorestCI mentioned this pull request Mar 13, 2019

[AutoPR netapp/resource-manager] Update to Release 3.5 standard (pre GA) Azure/azure-sdk-for-js#1541

Closed

AutorestCI mentioned this pull request Mar 13, 2019

[AutoPR netapp/resource-manager] Update to Release 3.5 standard (pre GA) Azure/azure-sdk-for-go#4269

Merged

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 13, 2019

.NET SDK Resource Provider:'NetApp'

526dc91

REST Spec PR 'Azure/azure-rest-api-specs#5370' REST Spec PR Author 'leonardbf' REST Spec PR Last commit

Nfsaas 1875 swagger update (#12)

0845526

* NFSAAS-1875 Update to R3.5 Standard * NFSAAS-1875 update to R3.5 standard

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 13, 2019

.NET SDK Resource Provider:'NetApp'

af1c3f0

REST Spec PR 'Azure/azure-rest-api-specs#5370' REST Spec PR Author 'leonardbf' REST Spec PR Last commit

veronicagg assigned kpajdzik and unassigned veronicagg Mar 13, 2019

nschonni reviewed Mar 13, 2019

View reviewed changes

Nfsaas 1875 swagger update (#13)

0af27c7

* NFSAAS-1875 Update to R3.5 Standard * NFSAAS-1875 update to R3.5 standard * NFSAAS-1875 updated from review comments

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 13, 2019

.NET SDK Resource Provider:'NetApp'

0bf4c9b

REST Spec PR 'Azure/azure-rest-api-specs#5370' REST Spec PR Author 'leonardbf' REST Spec PR Last commit

Merge pull request #14 from Azure/master

e2fdd6a

Merging to fork from azure master

AutorestCI mentioned this pull request Mar 14, 2019

[AutoPR netapp/resource-manager] Update to Release 3.5 standard (pre GA) Azure/azure-sdk-for-js#1564

Closed

kpajdzik reviewed Mar 14, 2019

View reviewed changes

kpajdzik added the potential-sdk-breaking-change label Mar 14, 2019

kpajdzik approved these changes Mar 18, 2019

View reviewed changes

kpajdzik merged commit 55b0caf into Azure:master Mar 20, 2019

AutorestCI mentioned this pull request Mar 20, 2019

[AutoPR netapp/resource-manager] Update to Release 3.5 standard (pre GA) Azure/azure-sdk-for-js#1664

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to Release 3.5 standard (pre GA) #5370

Update to Release 3.5 standard (pre GA) #5370

leonardbf commented Mar 13, 2019

azuresdkci commented Mar 13, 2019

AutorestCI commented Mar 13, 2019 •

edited

Loading

AutorestCI commented Mar 13, 2019 •

edited

Loading

AutorestCI commented Mar 13, 2019 •

edited

Loading

AutorestCI commented Mar 13, 2019 •

edited

Loading

AutorestCI commented Mar 13, 2019 •

edited

Loading

AutorestCI commented Mar 13, 2019 •

edited

Loading

adxsdknet commented Mar 13, 2019 •

edited

Loading

veronicagg commented Mar 13, 2019

kpajdzik commented Mar 13, 2019

nschonni Mar 13, 2019

leonardbf Mar 13, 2019

nschonni Mar 13, 2019

leonardbf Mar 13, 2019

nschonni Mar 13, 2019

leonardbf Mar 13, 2019

nschonni Mar 13, 2019

leonardbf Mar 13, 2019

kpajdzik commented Mar 14, 2019

kpajdzik commented Mar 14, 2019

Automation for azure-sdk-for-java

kpajdzik Mar 14, 2019

leonardbf Mar 15, 2019

kpajdzik Mar 14, 2019

leonardbf Mar 15, 2019

leonardbf commented Mar 15, 2019

Automation for azure-sdk-for-java

kpajdzik commented Mar 15, 2019

Automation for azure-sdk-for-java

leonardbf commented Mar 18, 2019

leonardbf commented Mar 19, 2019

Update to Release 3.5 standard (pre GA) #5370

Update to Release 3.5 standard (pre GA) #5370

Conversation

leonardbf commented Mar 13, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azuresdkci commented Mar 13, 2019

AutorestCI commented Mar 13, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Mar 13, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Mar 13, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Mar 13, 2019 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Mar 13, 2019 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Mar 13, 2019 • edited Loading

Automation for azure-sdk-for-go

adxsdknet commented Mar 13, 2019 • edited Loading

Automation for azure-sdk-for-net

veronicagg commented Mar 13, 2019

kpajdzik commented Mar 13, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kpajdzik commented Mar 14, 2019

kpajdzik commented Mar 14, 2019

Automation for azure-sdk-for-java

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leonardbf commented Mar 15, 2019

Automation for azure-sdk-for-java

kpajdzik commented Mar 15, 2019

Automation for azure-sdk-for-java

leonardbf commented Mar 18, 2019

leonardbf commented Mar 19, 2019

AutorestCI commented Mar 13, 2019 •

edited

Loading

AutorestCI commented Mar 13, 2019 •

edited

Loading

AutorestCI commented Mar 13, 2019 •

edited

Loading

AutorestCI commented Mar 13, 2019 •

edited

Loading

AutorestCI commented Mar 13, 2019 •

edited

Loading

AutorestCI commented Mar 13, 2019 •

edited

Loading

adxsdknet commented Mar 13, 2019 •

edited

Loading