Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small correction to list handling #5446

Merged
merged 27 commits into from
Mar 22, 2019
Merged

Small correction to list handling #5446

merged 27 commits into from
Mar 22, 2019

Conversation

leonardbf
Copy link
Contributor

Still preview - breaking changes not an issue

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

leonardbf and others added 26 commits November 20, 2018 08:04
NFSAAS-1505 minor update and validation fixes
Put (and patch) for snapshots.
Service level definition changes.
NFSAAS-1505 correct resource reference and limits
Incorrect pool resource reference
Name elements of property not required
Correction to return status code
NFSAAS-1505 resource and property changes
NFSAAS-1644 remove mt get and add put status code
NFSAAS-1644 remove mt get add status for put
* NFSAAS-1875 Update to R3.5 Standard

* NFSAAS-1875 update to R3.5 standard
* NFSAAS-1875 Update to R3.5 Standard

* NFSAAS-1875 update to R3.5 standard

* NFSAAS-1875 updated from review comments
Merging to fork from azure master
@AutorestCI
Copy link

AutorestCI commented Mar 21, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4622

@AutorestCI
Copy link

AutorestCI commented Mar 21, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4364

@AutorestCI
Copy link

AutorestCI commented Mar 21, 2019

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 21, 2019
REST Spec PR 'Azure/azure-rest-api-specs#5446'
REST Spec PR Author 'leonardbf'
REST Spec PR Last commit
@adxsdknet
Copy link

adxsdknet commented Mar 21, 2019

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5536
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@d18bcd7
adxsdknet/azure-sdk-for-net@f4f7e6e

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 21, 2019
REST Spec PR 'Azure/azure-rest-api-specs#5446'
REST Spec PR Author 'leonardbf'
REST Spec PR Last commit
@leonardbf
Copy link
Contributor Author

This is just a small change and a quick turn around would be really appreciated. Many thanks.

@AutorestCI
Copy link

AutorestCI commented Mar 21, 2019

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#1740

@dsgouda
Copy link
Contributor

dsgouda commented Mar 21, 2019

@leonardbf could you clean up the commit history here (git rebase -i)

@AutorestCI
Copy link

AutorestCI commented Mar 21, 2019

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@leonardbf
Copy link
Contributor Author

@leonardbf could you clean up the commit history here (git rebase -i)

Thanks for a quick response. Can you give me the full steps for this? Do you mean simply clone my master branch, perform git rebase -i then push back to master? Note this commit history is from earlier commits that have already been merged. This last change was a single commit - does that make a difference? If not then I could perform this squash on my next commit. I was hoping this one could be merged quickly so the SDKs can be generated as soon as possible.

@dsgouda
Copy link
Contributor

dsgouda commented Mar 21, 2019

@leonardbf pull from latest Azure master to your master, if this doesn't work you can simply clone Azure master and copy over your changes in a new branch (hacky and you can skip if it's too much work)

@leonardbf
Copy link
Contributor Author

leonardbf commented Mar 21, 2019

@leonardbf pull from latest Azure master to your master, if this doesn't work you can simply clone Azure master and copy over your changes in a new branch (hacky and you can skip if it's too much work)

Hmm, this was actually a clean branch that I pushed from a newly cloned repo. I did it that way because there were merge conflicts. I'm not really sure why this commit history is here.

@dsgouda Is this a blocker? While I understand the interest in a clean commit history, it's like you say, trying to sort it can be more effort than it's worth especially when time is short.

@leonardbf
Copy link
Contributor Author

@dsgouda hey, I see you tried to contact me on the devex teams channel. I've noticed previously that this is only accessible to me on my SAW machine which is in the office. Teams on my development laptop does not show this channel even when clicking through from the email to my b- account you triggered in Teams (I'm assuming you are on Pacific Time but I'm on UTC in Iceland and won't be in the office for 8 hours or so).

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants