[Resources] Add Deployment scripts as a new resource type - preview - #7486

filizt · 2019-10-14T20:32:37Z

Here's the link to the approved swagger: Azure/azure-rest-api-specs-pr#924

Closing the PR which was created against DeploymentScripts branch.
#7485

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-10-14T20:32:40Z

In Testing, Please Ignore

[Logs] (Generated from 311c8c8, Iteration 8)

.NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]

No packages generated.

Python: test-repo-billy/azure-sdk-for-python [Logs]

No packages generated.

Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]

features/resource-manager/v2015_12_01 [Logs]
locks/resource-manager/v2016_09_01 [Logs]
policy/resource-manager/v2016_12_01 [Logs]
policy/resource-manager/v2018_03_01 [Logs]
policy/resource-manager/v2018_05_01 [Logs]
policy/resource-manager/v2019_01_01 [Logs]
policy/resource-manager/v2019_06_01 [Logs]
resources/resource-manager/v2016_06_01 [Logs]
resources/resource-manager/v2016_09_01 [Logs]
resources/resource-manager/v2018_02_01 [Logs]
resources/resource-manager/v2018_06_01 [Logs]
resources/resource-manager/v2019_03_01 [Logs]
resources/resource-manager/v2019_05_01 [Logs]
resources/resource-manager/v2019_05_10 [Logs]
resources/resource-manager/v2019_06_01 [Logs]
resources/resource-manager/v2019_07_01 [Logs]
resources/resource-manager/v2019_08_01 [Logs]

Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

preview/resources/mgmt/2015-10-01-preview [Logs] [Instructions] [Generation PR]
- preview.resources.mgmt.2015-10-01-preview.zip
preview/resources/mgmt/2016-09-01-preview [Logs] [Instructions] [Generation PR]
- preview.resources.mgmt.2016-09-01-preview.zip
preview/resources/mgmt/2017-06-01-preview [Logs] [Instructions] [Generation PR]
- preview.resources.mgmt.2017-06-01-preview.zip
resources/mgmt/2015-01-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2015-01-01.zip
resources/mgmt/2015-11-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2015-11-01.zip
resources/mgmt/2015-12-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2015-12-01.zip
resources/mgmt/2016-02-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2016-02-01.zip
resources/mgmt/2016-04-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2016-04-01.zip
resources/mgmt/2016-06-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2016-06-01.zip
resources/mgmt/2016-07-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2016-07-01.zip
resources/mgmt/2016-09-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2016-09-01.zip
resources/mgmt/2016-12-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2016-12-01.zip
resources/mgmt/2017-05-10 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2017-05-10.zip
resources/mgmt/2017-09-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2017-09-01.zip
resources/mgmt/2018-02-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2018-02-01.zip
resources/mgmt/2018-03-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2018-03-01.zip
resources/mgmt/2018-05-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2018-05-01.zip
resources/mgmt/2018-06-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2018-06-01.zip
resources/mgmt/2019-01-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2019-01-01.zip
resources/mgmt/2019-03-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2019-03-01.zip
resources/mgmt/2019-05-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2019-05-01.zip
resources/mgmt/2019-06-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2019-06-01.zip
resources/mgmt/2019-07-01 [Logs] [Instructions]
- resources.mgmt.2019-07-01.zip

JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@azure/arm-managedapplications [Logs] [Instructions]
- azure-arm-managedapplications-1.0.2.tgz
@azure/arm-policy [Logs] [Instructions]
- azure-arm-policy-2.0.0.tgz
@azure/arm-resources [Logs] [Instructions]
- azure-arm-resources-2.1.0.tgz

azuresdkci · 2019-10-14T20:33:26Z

Can one of the admins verify this patch?

AutorestCI · 2019-10-14T20:35:08Z

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

AutorestCI · 2019-10-14T20:37:22Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

nschonni · 2019-10-14T21:35:24Z

...urces/resource-manager/Microsoft.Resources/preview/2019-10-01-preview/deploymentScripts.json

+        },
+        "arguments": {
+          "type": "string",
+          "description": "Command line arguments to pass to the script. Arguments are seperated by spaces. ex: -Name blue* -Location 'West US 2' "


Suggested change

"description": "Command line arguments to pass to the script. Arguments are seperated by spaces. ex: -Name blue* -Location 'West US 2' "

"description": "Command line arguments to pass to the script. Arguments are separated by spaces. ex: -Name blue* -Location 'West US 2' "

Juliehzl · 2019-10-15T01:03:18Z

It is already approved in private repo. LGTM. @filizt can you try to make CI pass?

…pporting user assigned MSI.

filizt · 2019-10-17T02:46:51Z

@Juliehzl the swagger is already approved by ARM. See the private repo PR here: https://github.com/Azure/azure-rest-api-specs-pr/pull/924. Could you merge please?

specification/resources/resource-manager/readme.csharp.md

update package name Co-Authored-By: Yeming Liu <felix_liu@outlook.com>

nschonni · 2019-10-17T12:47:21Z

specification/resources/resource-manager/readme.md

+  - from: deploymentScripts.json
+    suppress: TrackedResourceGetOperation 
+    where: $.definitions.AzureCliScript
+    reason: Tooling issue.


Curious what the actual tool issue is

@nschonni we asked about the linter errors to the swagger team and they directed us to suppress the errors. Below is the copy of the response in the email thread and the errors we saw:

After syncing up with Zhiqing offline. The errors you mentioned are actually false positive. You can add suppression section in readme.md. Such as

directive: - suppress: TrackedResourceGetOperation reason: <reason here> where: - $.definitions.CliScript - suppress: TrackedResourcePatchOperation reason: <reason here> where: - $.definitions.PowerShellScript

After debug it. The reason is complex. The rule “TrackedResourceGetOperation” and “TrackedResourcePatchOperation” not only check whether existing “get” or “patch” operation but also check “response.schema.reference” whether equal with name of definition. In your case, The name of CLIScript and PowerShellScript is different from the “response.schema.reference”. So the lint tool report the errors.

Thanks,
Ruoxuan

Errors

ERROR (TrackedResourceGetOperation/R3025/ARMViolation): Tracked resource 'PowerShellScript' must have a get operation.
- file:///C:/Workspace/Git/azure-rest-api-specs-pr/specification/DeploymentScripts/resource-manager/Microsoft.Blueprint/preview/2019-10-01-preview/deploymentScripts.json:397:4 ($.definitions.PowerShellScript)

ERROR (TrackedResourceGetOperation/R3025/ARMViolation): Tracked resource 'CliScript' must have a get operation.
- file:///C:/Workspace/Git/azure-rest-api-specs-pr/specification/DeploymentScripts/resource-manager/Microsoft.Blueprint/preview/2019-10-01-preview/deploymentScripts.json:438:4 ($.definitions.CliScript)

WARNING (TrackedResourceListByResourceGroup/R3027/ARMViolation): The tracked resource, 'DeploymentScript', must have a list by resource group operation.(This rule does not apply for tenant level resources.)
- file:///C:/Workspace/Git/azure-rest-api-specs-pr/specification/DeploymentScripts/resource-manager/Microsoft.Blueprint/preview/2019-10-01-preview/deploymentScripts.json:312:4 ($.definitions.DeploymentScript)

WARNING (TrackedResourceListByResourceGroup/R3027/ARMViolation): The tracked resource, 'PowerShellScript', must have a list by resource group operation.(This rule does not apply for tenant level resources.)
- file:///C:/Workspace/Git/azure-rest-api-specs-pr/specification/DeploymentScripts/resource-manager/Microsoft.Blueprint/preview/2019-10-01-preview/deploymentScripts.json:397:4 ($.definitions.PowerShellScript)

WARNING (TrackedResourceListByResourceGroup/R3027/ARMViolation): The tracked resource, 'CliScript', must have a list by resource group operation.(This rule does not apply for tenant level resources.)
- file:///C:/Workspace/Git/azure-rest-api-specs-pr/specification/DeploymentScripts/resource-manager/Microsoft.Blueprint/preview/2019-10-01-preview/deploymentScripts.json:438:4 ($.definitions.CliScript)

WARNING (TrackedResourceListBySubscription/R3028/ARMViolation): The tracked resource, 'PowerShellScript', must have a list by subscriptions operation.
- file:///C:/Workspace/Git/azure-rest-api-specs-pr/specification/DeploymentScripts/resource-manager/Microsoft.Blueprint/preview/2019-10-01-preview/deploymentScripts.json:397:4 ($.definitions.PowerShellScript)

WARNING (TrackedResourceListBySubscription/R3028/ARMViolation): The tracked resource, 'CliScript', must have a list by subscriptions operation.
- file:///C:/Workspace/Git/azure-rest-api-specs-pr/specification/DeploymentScripts/resource-manager/Microsoft.Blueprint/preview/2019-10-01-preview/deploymentScripts.json:438:4 ($.definitions.CliScript)

ERROR (TrackedResourcePatchOperation/R3026/ARMViolation): Tracked resource 'PowerShellScript' must have patch operation that at least supports the update of tags. It's strongly recommended that the PATCH operation supports update of all mutable properties as well.
- file:///C:/Workspace/Git/azure-rest-api-specs-pr/specification/DeploymentScripts/resource-manager/Microsoft.Blueprint/preview/2019-10-01-preview/deploymentScripts.json:397:4 ($.definitions.PowerShellScript)

ERROR (TrackedResourcePatchOperation/R3026/ARMViolation): Tracked resource 'CliScript' must have patch operation that at least supports the update of tags. It's strongly recommended that the PATCH operation supports update of all mutable properties as well.
- file:///C:/Workspace/Git/azure-rest-api-specs-pr/specification/DeploymentScripts/resource-manager/Microsoft.Blueprint/preview/2019-10-01-preview/deploymentScripts.json:438:4 ($.definitions.CliScript)
PS C:\Workspace\Git\azure-rest-api-specs-pr\specification\DeploymentScripts\resource-manager>

Thanks! I just like kicking the tires on the tools, and like seeing where the limitations pop up

KrisBash

PR was previously reviewed in private repo

yungezz · 2019-10-21T04:46:53Z

@Juliehzl could you pls merge the PR? thanks.

jiasli · 2020-02-25T08:10:28Z

specification/resources/resource-manager/readme.md

+tag: package-deploymentscripts-2019-10-preview
+```
+
+### Tag: package-resources-2019-10-preview


Shouldn't this be package-deploymentscripts-2019-10-preview?

Tag name change is fine with us. It sounds like it'll be more clear this way.

Approved deployments scripts swagger from private repo

88d3c11

filizt requested a review from Tiano2017 as a code owner October 14, 2019 20:32

azuresdkci assigned Juliehzl Oct 14, 2019

azuresdkci requested a review from Juliehzl October 14, 2019 20:34

nschonni reviewed Oct 14, 2019

View reviewed changes

Filiz Topatan added 2 commits October 15, 2019 10:04

Update readme files and fix typo

85d2ed7

Update property letter casing

73c6297

openapi-sdkautomation bot mentioned this pull request Oct 15, 2019

[AutoPR features/resource-manager/v2015_12_01] [Resources] Add Deployment scripts as a new resource type - preview - test-repo-billy/azure-sdk-for-java#599

Closed

Juliehzl added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 16, 2019

Juliehzl approved these changes Oct 16, 2019

View reviewed changes

Removing the containerSettings property due to network profile not su…

d18ce76

…pporting user assigned MSI.

isra-fel reviewed Oct 17, 2019

View reviewed changes

specification/resources/resource-manager/readme.csharp.md Outdated Show resolved Hide resolved

Update specification/resources/resource-manager/readme.csharp.md

311c8c8

update package name Co-Authored-By: Yeming Liu <felix_liu@outlook.com>

nschonni reviewed Oct 17, 2019

View reviewed changes

KrisBash approved these changes Oct 18, 2019

View reviewed changes

KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 18, 2019

Juliehzl merged commit 08ec526 into Azure:master Oct 22, 2019

filizt mentioned this pull request Nov 6, 2019

[Resources] Add deployment scripts resource type to the Resources SDK Azure/azure-sdk-for-net#8436

Merged

jiasli reviewed Feb 25, 2020

View reviewed changes

jiasli mentioned this pull request Feb 25, 2020

Add package-subscriptions-2019-11 #8503

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Resources] Add Deployment scripts as a new resource type - preview - #7486

[Resources] Add Deployment scripts as a new resource type - preview - #7486

filizt commented Oct 14, 2019 •

edited

Loading

openapi-sdkautomation bot commented Oct 14, 2019 •

edited

Loading

azuresdkci commented Oct 14, 2019

AutorestCI commented Oct 14, 2019 •

edited

Loading

AutorestCI commented Oct 14, 2019 •

edited

Loading

nschonni Oct 14, 2019

Juliehzl commented Oct 15, 2019

filizt commented Oct 17, 2019 •

edited

Loading

nschonni Oct 17, 2019

filizt Oct 17, 2019 •

edited

Loading

nschonni Oct 17, 2019

KrisBash left a comment

yungezz commented Oct 21, 2019

jiasli Feb 25, 2020

filizt Feb 25, 2020

	"description": "Command line arguments to pass to the script. Arguments are seperated by spaces. ex: -Name blue* -Location 'West US 2' "
	"description": "Command line arguments to pass to the script. Arguments are separated by spaces. ex: -Name blue* -Location 'West US 2' "

[Resources] Add Deployment scripts as a new resource type - preview - #7486

[Resources] Add Deployment scripts as a new resource type - preview - #7486

Conversation

filizt commented Oct 14, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Oct 14, 2019 • edited Loading

In Testing, Please Ignore

[Logs] (Generated from 311c8c8, Iteration 8)

azuresdkci commented Oct 14, 2019

AutorestCI commented Oct 14, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Oct 14, 2019 • edited Loading

Automation for azure-sdk-for-go

nschonni Oct 14, 2019

Choose a reason for hiding this comment

Juliehzl commented Oct 15, 2019

filizt commented Oct 17, 2019 • edited Loading

nschonni Oct 17, 2019

Choose a reason for hiding this comment

filizt Oct 17, 2019 • edited Loading

Choose a reason for hiding this comment

Errors

nschonni Oct 17, 2019

Choose a reason for hiding this comment

KrisBash left a comment

Choose a reason for hiding this comment

yungezz commented Oct 21, 2019

jiasli Feb 25, 2020

Choose a reason for hiding this comment

filizt Feb 25, 2020

Choose a reason for hiding this comment

filizt commented Oct 14, 2019 •

edited

Loading

openapi-sdkautomation bot commented Oct 14, 2019 •

edited

Loading

AutorestCI commented Oct 14, 2019 •

edited

Loading

AutorestCI commented Oct 14, 2019 •

edited

Loading

filizt commented Oct 17, 2019 •

edited

Loading

filizt Oct 17, 2019 •

edited

Loading