Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fields to Incident properties #8593

Merged
merged 4 commits into from
Apr 2, 2020
Merged

Add fields to Incident properties #8593

merged 4 commits into from
Apr 2, 2020

Conversation

ityankel
Copy link
Contributor

@ityankel ityankel commented Mar 4, 2020 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 4, 2020 •
edited
Loading

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 5ca3b3a with merge commit 7acdc57. SDK Automation 13.0.17.20200326.3 
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 4, 2020 •
edited
Loading

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 4, 2020 •
edited
Loading

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 5ca3b3a with merge commit 7acdc57. SDK Automation 13.0.17.20200326.3
  • ️✔️Microsoft.Azure.Management.SecurityInsights [Logs]  [Release SDK Changes]
      No Artifact Generated.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Mar 4, 2020 •
    edited
    Loading

    azure-sdk-for-python - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 5ca3b3a with merge commit 7acdc57. SDK Automation 13.0.17.20200326.3 
      Failed to find any changed packages. Please check the changed file list.
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/_configuration.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/_security_insights.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/_models_py3.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/_paged_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/_security_insights_enums.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_actions_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_alert_rules_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_data_connectors_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/version.py

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Mar 4, 2020 •
    edited
    Loading

    azure-sdk-for-go - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 5ca3b3a with merge commit 7acdc57. SDK Automation 13.0.17.20200326.3
    • ⚠️preview/securityinsight/mgmt/2017-08-01-preview [Logs]  
        No file is changed.

      @azuresdkci
      Copy link
      Contributor

      Can one of the admins verify this patch?

      @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Mar 4, 2020
      Closed
      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      1 similar comment
      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @ityankel ityankel marked this pull request as ready for review March 4, 2020 20:31
      @raych1 raych1 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 5, 2020
      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Mar 17, 2020 •
      edited
      Loading

      azure-cli-extensions - Release

      No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

      @anthony-c-martin anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 20, 2020
      @raych1 raych1 added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Mar 20, 2020
      @raych1
      Copy link
      Contributor

      raych1 commented Mar 20, 2020

      @akning-ms , please force merge this since this is preview version.

      @akning-ms
      Copy link
      Contributor

      Hi @ityankel can you help resolve the conflicts before I can merge?

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @ityankel
      Copy link
      Contributor Author

      Hi @ityankel can you help resolve the conflicts before I can merge?

      @akning-ms I resolved the conflicts. Can you please merge the changes?

      @akning-ms akning-ms merged commit 7acdc57 into Azure:master Apr 2, 2020
      00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
      @ityankel @00Kai0
      Add fields to Incident properties (Azure#8593)
      04c869b 
      * Add fields to incident properties

* Fix example
      @ityankel ityankel deleted the incidentProperties branch November 17, 2020 11:14
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Reviewers

      @raych1 raych1 raych1 approved these changes

      Assignees

      @raych1 raych1

      Labels
      Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
      Projects
      None yet
      Milestone
      No milestone
      Development

      Successfully merging this pull request may close these issues.
      5 participants
      @ityankel @azuresdkci @raych1 @akning-ms @anthony-c-martin