[acr] update default package tag and PrivateEndpointConnection resource for containerregistry #8646

adewaleo · 2020-03-09T19:27:52Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azure-pipelines · 2020-03-09T19:28:08Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-03-09T19:29:51Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from a810e7b with merge commit 29759b0. SDK Automation 13.0.17.20200320.2
⚠️containerregistry/mgmt/2017-03-01 [Logs]
```
No file is changed.
```
⚠️containerregistry/mgmt/2017-10-01 [Logs]
```
No file is changed.
```
⚠️containerregistry/mgmt/2018-09-01 [Logs]
```
No file is changed.
```
⚠️containerregistry/mgmt/2019-04-01 [Logs]
```
No file is changed.
```
⚠️containerregistry/mgmt/2019-05-01-preview [Logs]
```
No file is changed.
```
⚠️containerregistry/mgmt/2019-05-01 [Logs]
```
No file is changed.
```
️✔️containerregistry/mgmt/2019-06-01-preview [Logs] [Release SDK Changes]
- containerregistry.mgmt.2019-06-01-preview.zip
⚠️preview/containerregistry/mgmt/2016-06-27-preview [Logs]
```
No file is changed.
```
⚠️preview/containerregistry/mgmt/2017-06-01-preview [Logs]
```
No file is changed.
```
⚠️preview/containerregistry/mgmt/2018-02-01 [Logs]
```
No file is changed.
```
️✔️preview/containerregistry/mgmt/2019-12-01-preview [Logs] [Release SDK Changes]
- preview.containerregistry.mgmt.2019-12-01-preview.zip

openapi-sdkautomation · 2020-03-09T19:29:53Z

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from a810e7b with merge commit 29759b0. SDK Automation 13.0.17.20200320.2

⚠️azure-mgmt-containerregistry [Logs] [Release SDK Changes] Breaking Change Detected

[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2018-02-01-preview'} in label v2018_02_01_preview
[after_scripts|python] WARNING:__main__:Guessing you want 2018-02-01-preview based on label v2018_02_01_preview
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2018-09-01'} in label v2018_09_01
[after_scripts|python] WARNING:__main__:Guessing you want 2018-09-01 based on label v2018_09_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2019-04-01'} in label v2019_04_01
[after_scripts|python] WARNING:__main__:Guessing you want 2019-04-01 based on label v2019_04_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2019-05-01', '2019-04-01'} in label v2019_05_01
[after_scripts|python] WARNING:__main__:Guessing you want 2019-05-01 based on label v2019_05_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2019-05-01-preview'} in label v2019_05_01_preview
[after_scripts|python] WARNING:__main__:Guessing you want 2019-05-01-preview based on label v2019_05_01_preview
[after_scripts|python] WARNING:__main__:Found too much API version: {'2019-06-01-preview', '2019-05-01', '2019-05-01-preview'} in label v2019_06_01_preview
[after_scripts|python] WARNING:__main__:Guessing you want 2019-06-01-preview based on label v2019_06_01_preview
[after_scripts|python] WARNING:__main__:Found too much API version: {'2019-06-01-preview', '2019-12-01-preview', '2019-05-01-preview'} in label v2019_12_01_preview
[after_scripts|python] WARNING:__main__:Guessing you want 2019-12-01-preview based on label v2019_12_01_preview
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
[ChangeLog] Size of delta 0.442% size of original (original: 107656 chars, delta: 476 chars)
[ChangeLog] **Breaking changes**
[ChangeLog] 
[ChangeLog] - Operation PrivateEndpointConnectionsOperations.create_or_update has a new signature
[ChangeLog] - Operation PrivateEndpointConnectionsOperations.create_or_update has a new signature

openapi-sdkautomation · 2020-03-09T19:29:57Z

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from a810e7b with merge commit 29759b0. SDK Automation 13.0.17.20200320.2
️✔️sdk/containerregistry/mgmt-v2016_06_27_preview [Logs] [Release SDK Changes]
️✔️sdk/containerregistry/mgmt-v2017_03_01 [Logs] [Release SDK Changes]
️✔️sdk/containerregistry/mgmt-v2017_06_01_preview [Logs] [Release SDK Changes]
️✔️sdk/containerregistry/mgmt-v2017_10_01 [Logs] [Release SDK Changes]
️✔️sdk/containerregistry/mgmt-v2018_02_01_preview [Logs] [Release SDK Changes]
️✔️sdk/containerregistry/mgmt-v2018_09_01 [Logs] [Release SDK Changes]
️✔️sdk/containerregistry/mgmt-v2019_04_01 [Logs] [Release SDK Changes]
️✔️sdk/containerregistry/mgmt-v2019_06_01_preview [Logs] [Release SDK Changes]
️✔️sdk/containerregistry/mgmt-v2019_12_01_preview [Logs] [Release SDK Changes]

openapi-sdkautomation · 2020-03-09T19:29:57Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from a810e7b with merge commit 29759b0. SDK Automation 13.0.17.20200320.2
️✔️Microsoft.Azure.Management.ContainerRegistry [Logs] [Release SDK Changes]
- Microsoft.Azure.Management.ContainerRegistry.4.0.0.nupkg
- Microsoft.Azure.Management.ContainerRegistry.4.0.0.snupkg

openapi-sdkautomation · 2020-03-09T19:30:07Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from a810e7b with merge commit 29759b0. SDK Automation 13.0.17.20200320.2

️✔️@azure/arm-containerregistry [Logs] [Release SDK Changes]

azure-arm-containerregistry-7.0.0.tgz

[npmPack] npm WARN lifecycle @azure/arm-containerregistry@7.0.0~prepack: cannot run in wd @azure/arm-containerregistry@7.0.0 npm install && npm run build (wd=/z/work/azure-sdk-for-js/sdk/containerregistry/arm-containerregistry)

azuresdkci · 2020-03-09T19:57:43Z

Can one of the admins verify this patch?

northtyphoon

LGTM

azure-pipelines · 2020-03-18T01:20:18Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-03-18T01:25:21Z

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-03-18T07:18:51Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-18T07:29:02Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-18T07:42:15Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-18T22:05:39Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-18T22:07:46Z

Azure Pipelines successfully started running 1 pipeline(s).

adewaleo · 2020-03-19T00:10:46Z

@djyou @northtyphoon @zikalino, does this look good to you?

The removed fields are inherited from the proxyresource definition.

So the only breaking change is that id, name and type are now readonly and that PrivateEndpointConnection inherits from proxyresource for the purpose of typing.

Not sure why the example check is failing, no output. Its just in red...

azure-pipelines · 2020-03-19T21:42:05Z

Azure Pipelines successfully started running 1 pipeline(s).

Update spec

azure-pipelines · 2020-03-19T22:13:34Z

Azure Pipelines successfully started running 1 pipeline(s).

adewaleo · 2020-03-19T22:31:18Z

PR looks good to me, although not sure what is causing this example error.

"Breaking changes" are because PrivateEndpointConnection now inherits from ProxyResource.

cc: @zikalino

ruowan · 2020-04-23T09:47:25Z

/azp run

…ce for containerregistry (Azure#8646) * update default package tag * Update typescript autorest config file. * PrivateEndpointConnection should inherit proxyresource Update spec Co-authored-by: Oluwatosin Adewale <oluwatosin.adewale@microsoft.com>

openapi-assignment-bot bot assigned zikalino Mar 9, 2020

northtyphoon approved these changes Mar 16, 2020

View reviewed changes

update default package tag

7127d2a

adewaleo force-pushed the acr/update-default-package-tag branch from 9b20436 to 7127d2a Compare March 18, 2020 01:20

Update typescript autorest config file.

2a0ec7d

openapi-sdkautomation bot mentioned this pull request Mar 18, 2020

[AutoPR @azure/arm-containerregistry] [acr] update default package tag for containerregistry AzureSDKAutomation/azure-sdk-for-js#838

Closed

adewaleo force-pushed the acr/update-default-package-tag branch from e270ea0 to 6ed9f42 Compare March 18, 2020 22:07

adewaleo force-pushed the acr/update-default-package-tag branch from 6ed9f42 to 5444c1f Compare March 19, 2020 21:41

PrivateEndpointConnection should inherit proxyresource

a810e7b

Update spec

adewaleo force-pushed the acr/update-default-package-tag branch from 5444c1f to a810e7b Compare March 19, 2020 22:13

adewaleo changed the title ~~[acr] update default package tag for containerregistry~~ [acr] update default package tag and PrivateEndpointConnection resource for containerregistry Mar 20, 2020

zikalino approved these changes Mar 23, 2020

View reviewed changes

akning-ms merged commit 29759b0 into master Mar 24, 2020

ramya-rao-a mentioned this pull request May 26, 2020

release-containerregistry-mgmt-fix-issue-7763 Azure/azure-sdk-for-js#9111

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[acr] update default package tag and PrivateEndpointConnection resource for containerregistry #8646

[acr] update default package tag and PrivateEndpointConnection resource for containerregistry #8646

adewaleo commented Mar 9, 2020 •

edited by akning-ms

Loading

azure-pipelines bot commented Mar 9, 2020

openapi-sdkautomation bot commented Mar 9, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 9, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 9, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 9, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 9, 2020 •

edited

Loading

azuresdkci commented Mar 9, 2020

northtyphoon left a comment

azure-pipelines bot commented Mar 18, 2020

openapi-sdkautomation bot commented Mar 18, 2020 •

edited

Loading

azure-pipelines bot commented Mar 18, 2020

azure-pipelines bot commented Mar 18, 2020

azure-pipelines bot commented Mar 18, 2020

azure-pipelines bot commented Mar 18, 2020

azure-pipelines bot commented Mar 18, 2020

adewaleo commented Mar 19, 2020 •

edited

Loading

azure-pipelines bot commented Mar 19, 2020

azure-pipelines bot commented Mar 19, 2020

adewaleo commented Mar 19, 2020 •

edited

Loading

ruowan commented Apr 23, 2020

[acr] update default package tag and PrivateEndpointConnection resource for containerregistry #8646

[acr] update default package tag and PrivateEndpointConnection resource for containerregistry #8646

Conversation

adewaleo commented Mar 9, 2020 • edited by akning-ms Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azure-pipelines bot commented Mar 9, 2020

openapi-sdkautomation bot commented Mar 9, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Mar 9, 2020 • edited Loading

azure-sdk-for-python - Release

- Breaking Change detected in SDK

openapi-sdkautomation bot commented Mar 9, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Mar 9, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Mar 9, 2020 • edited Loading

azure-sdk-for-js - Release

azuresdkci commented Mar 9, 2020

northtyphoon left a comment

Choose a reason for hiding this comment

azure-pipelines bot commented Mar 18, 2020

openapi-sdkautomation bot commented Mar 18, 2020 • edited Loading

azure-cli-extensions - Release

azure-pipelines bot commented Mar 18, 2020

azure-pipelines bot commented Mar 18, 2020

azure-pipelines bot commented Mar 18, 2020

azure-pipelines bot commented Mar 18, 2020

azure-pipelines bot commented Mar 18, 2020

adewaleo commented Mar 19, 2020 • edited Loading

azure-pipelines bot commented Mar 19, 2020

azure-pipelines bot commented Mar 19, 2020

adewaleo commented Mar 19, 2020 • edited Loading

ruowan commented Apr 23, 2020

adewaleo commented Mar 9, 2020 •

edited by akning-ms

Loading

openapi-sdkautomation bot commented Mar 9, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 9, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 9, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 9, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 9, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 18, 2020 •

edited

Loading

adewaleo commented Mar 19, 2020 •

edited

Loading

adewaleo commented Mar 19, 2020 •

edited

Loading