[Hub Generated] Review request for Microsoft.ApiManagement to add version stable/2019-12-01 #8796

solankisamir · 2020-03-22T00:16:51Z

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…019-12-01-preview to version 2019-12-01

azure-pipelines · 2020-03-22T00:17:07Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-03-22T00:18:40Z

azure-sdk-for-net - Release

❌ failed [Logs] [Expand Details]

❌ Generate from 3cdb2fb with merge commit ba03faf. SDK Automation 13.0.17.20200320.2

❌Microsoft.Azure.Management.ApiManagement [Logs] [Release SDK Changes]

Failed to create the package Microsoft.Azure.Management.ApiManagement.
Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=apimanagement /v:n /p:SkipTests=true , {}

openapi-sdkautomation · 2020-03-22T00:18:44Z

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-03-22T00:18:45Z

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 3cdb2fb with merge commit ba03faf. SDK Automation 13.0.17.20200320.2

⚠️azure-mgmt-apimanagement [Logs] [Release SDK Changes] Breaking Change Detected

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
[ChangeLog] Size of delta 12.559% size of original (original: 232886 chars, delta: 29248 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog] - Model ApiManagementServiceUpdateParameters has a new parameter disable_gateway
[ChangeLog] - Model ApiManagementServiceUpdateParameters has a new parameter developer_portal_url
[ChangeLog] - Model ApiManagementServiceUpdateParameters has a new parameter api_version_constraint
[ChangeLog] - Model DiagnosticContract has a new parameter log_client_ip
[ChangeLog] - Model DiagnosticContract has a new parameter http_correlation_protocol
[ChangeLog] - Model DiagnosticContract has a new parameter verbosity
[ChangeLog] - Model IdentityProviderUpdateParameters has a new parameter signin_tenant
[ChangeLog] - Model IdentityProviderBaseParameters has a new parameter signin_tenant
[ChangeLog] - Model ApiManagementServiceBaseProperties has a new parameter disable_gateway
[ChangeLog] - Model ApiManagementServiceBaseProperties has a new parameter developer_portal_url
[ChangeLog] - Model ApiManagementServiceBaseProperties has a new parameter api_version_constraint
[ChangeLog] - Model UserCreateParameters has a new parameter app_type
[ChangeLog] - Model ApiManagementServiceResource has a new parameter disable_gateway
[ChangeLog] - Model ApiManagementServiceResource has a new parameter developer_portal_url
[ChangeLog] - Model ApiManagementServiceResource has a new parameter api_version_constraint
[ChangeLog] - Model ApiManagementServiceIdentity has a new parameter user_assigned_identities
[ChangeLog] - Model TagDescriptionContract has a new parameter tag_id
[ChangeLog] - Model AdditionalLocation has a new parameter disable_gateway
[ChangeLog] - Model IdentityProviderContract has a new parameter signin_tenant
[ChangeLog] - Model SchemaContract has a new parameter value
[ChangeLog] - Model SchemaContract has a new parameter definitions
[ChangeLog] - Added operation AuthorizationServerOperations.list_secrets
[ChangeLog] - Added operation SubscriptionOperations.list_secrets
[ChangeLog] - Added operation OpenIdConnectProviderOperations.list_secrets
[ChangeLog] - Added operation IdentityProviderOperations.list_secrets
[ChangeLog] - Added operation TenantAccessGitOperations.list_secrets
[ChangeLog] - Added operation DelegationSettingsOperations.list_secrets
[ChangeLog] - Added operation TenantAccessOperations.list_secrets
[ChangeLog] - Added operation group GatewayApiOperations
[ChangeLog] - Added operation group GatewayOperations
[ChangeLog] - Added operation group GatewayHostnameConfigurationOperations
[ChangeLog] - Added operation group PolicyDescriptionOperations
[ChangeLog] - Added operation group NamedValueOperations
[ChangeLog] 
[ChangeLog] **Breaking changes**
[ChangeLog] 
[ChangeLog] - Operation ApiTagDescriptionOperations.get has a new signature
[ChangeLog] - Operation ApiTagDescriptionOperations.create_or_update has a new signature
[ChangeLog] - Operation ApiTagDescriptionOperations.delete has a new signature
[ChangeLog] - Operation ApiTagDescriptionOperations.get_entity_tag has a new signature
[ChangeLog] - Operation ApiSchemaOperations.create_or_update has a new signature
[ChangeLog] - Parameter capacity of model ApiManagementServiceSkuProperties is now required
[ChangeLog] - Operation ApiSchemaOperations.create_or_update has a new signature
[ChangeLog] - Model DiagnosticContract no longer has parameter enable_http_correlation_headers
[ChangeLog] - Model AuthorizationServerContractBaseProperties no longer has parameter client_secret
[ChangeLog] - Model AuthenticationSettingsContract no longer has parameter subscription_key_required
[ChangeLog] - Model SchemaContract no longer has parameter document
[ChangeLog] - Removed operation group PropertyOperations
[ChangeLog] - Removed operation group PolicySnippetOperations

openapi-sdkautomation · 2020-03-22T00:18:46Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 3cdb2fb with merge commit ba03faf. SDK Automation 13.0.17.20200320.2
️✔️apimanagement/mgmt/2016-07-07 [Logs] [Release SDK Changes]
- apimanagement.mgmt.2016-07-07.zip
️✔️apimanagement/mgmt/2016-10-10 [Logs] [Release SDK Changes]
- apimanagement.mgmt.2016-10-10.zip
️✔️apimanagement/mgmt/2017-03-01 [Logs] [Release SDK Changes]
- apimanagement.mgmt.2017-03-01.zip
️✔️apimanagement/mgmt/2018-01-01 [Logs] [Release SDK Changes]
- apimanagement.mgmt.2018-01-01.zip
️✔️apimanagement/mgmt/2019-01-01 [Logs] [Release SDK Changes]
- apimanagement.mgmt.2019-01-01.zip
️✔️preview/apimanagement/mgmt/2018-06-01-preview [Logs] [Release SDK Changes]
- preview.apimanagement.mgmt.2018-06-01-preview.zip
️✔️preview/apimanagement/mgmt/2019-12-01-preview [Logs] [Release SDK Changes]
- preview.apimanagement.mgmt.2019-12-01-preview.zip

openapi-sdkautomation · 2020-03-22T00:18:46Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 3cdb2fb with merge commit ba03faf. SDK Automation 13.0.17.20200320.2

️✔️@azure/arm-apimanagement [Logs] [Release SDK Changes]

azure-arm-apimanagement-5.1.1.tgz

[npmPack] npm WARN lifecycle @azure/arm-apimanagement@5.1.1~prepack: cannot run in wd @azure/arm-apimanagement@5.1.1 npm install && npm run build (wd=/z/work/azure-sdk-for-js/sdk/apimanagement/arm-apimanagement)

openapi-sdkautomation · 2020-03-22T00:18:51Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azuresdkci · 2020-03-22T00:43:41Z

Can one of the admins verify this patch?

specification/apimanagement/resource-manager/readme.md

azure-pipelines · 2020-03-23T03:35:27Z

Azure Pipelines successfully started running 1 pipeline(s).

raych1

LGTM.

VeryEarly · 2020-07-03T07:16:42Z

...n/apimanagement/resource-manager/Microsoft.ApiManagement/stable/2019-12-01/apimgateways.json

+      }
+    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ApiManagement/service/{serviceName}/gateways/{gatewayId}/listKeys": {
+      "post": {


why this is a POST not GET?

@VeryEarly , it's an operation to retrieve secrets (keys). Common approach is to use POST operation so RBAC system may allow all GET methods for Readers, when not allowing POST methods.

…sion stable/2019-12-01 (Azure#8796) * Adds base for updating Microsoft.ApiManagement from version preview/2019-12-01-preview to version 2019-12-01 * Updates readme * Updates API version in new specs and examples * update examples and readme.md

solankisamir added 3 commits March 21, 2020 17:10

Adds base for updating Microsoft.ApiManagement from version preview/2…

799d847

…019-12-01-preview to version 2019-12-01

Updates readme

a8c9de4

Updates API version in new specs and examples

e965a47

openapi-assignment-bot bot assigned raych1 Mar 22, 2020

solankisamir requested a review from vfedonkin March 22, 2020 00:18

solankisamir added API Management WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 22, 2020

openapi-sdkautomation bot mentioned this pull request Mar 22, 2020

[AutoPR Microsoft.Azure.Management.ApiManagement] [Hub Generated] Review request for Microsoft.ApiManagement to add version stable/2019-12-01 AzureSDKAutomation/azure-sdk-for-net#731

Closed

raych1 reviewed Mar 23, 2020

View reviewed changes

specification/apimanagement/resource-manager/readme.md Outdated Show resolved Hide resolved

update examples and readme.md

3cdb2fb

raych1 reviewed Mar 23, 2020

View reviewed changes

pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 23, 2020

pilor approved these changes Mar 23, 2020

View reviewed changes

vfedonkin approved these changes Mar 24, 2020

View reviewed changes

raych1 approved these changes Mar 24, 2020

View reviewed changes

raych1 merged commit ba03faf into Azure:master Mar 24, 2020

isra-fel mentioned this pull request Mar 24, 2020

Add api-version 2019-12-01 of apimanagement for go SDK #8817

Merged

5 tasks

VeryEarly reviewed Jul 3, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.ApiManagement to add version stable/2019-12-01 #8796

[Hub Generated] Review request for Microsoft.ApiManagement to add version stable/2019-12-01 #8796

solankisamir commented Mar 22, 2020 •

edited

Loading

azure-pipelines bot commented Mar 22, 2020

openapi-sdkautomation bot commented Mar 22, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 22, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 22, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 22, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 22, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 22, 2020 •

edited

Loading

azuresdkci commented Mar 22, 2020

azure-pipelines bot commented Mar 23, 2020

raych1 left a comment

VeryEarly Jul 3, 2020

vfedonkin Jul 6, 2020

[Hub Generated] Review request for Microsoft.ApiManagement to add version stable/2019-12-01 #8796

[Hub Generated] Review request for Microsoft.ApiManagement to add version stable/2019-12-01 #8796

Conversation

solankisamir commented Mar 22, 2020 • edited Loading

Contribution checklist:

azure-pipelines bot commented Mar 22, 2020

openapi-sdkautomation bot commented Mar 22, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Mar 22, 2020 • edited Loading

azure-cli-extensions - Release

openapi-sdkautomation bot commented Mar 22, 2020 • edited Loading

azure-sdk-for-python - Release

- Breaking Change detected in SDK

openapi-sdkautomation bot commented Mar 22, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Mar 22, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Mar 22, 2020 • edited Loading

azure-sdk-for-java - Release

azuresdkci commented Mar 22, 2020

azure-pipelines bot commented Mar 23, 2020

raych1 left a comment

Choose a reason for hiding this comment

VeryEarly Jul 3, 2020

Choose a reason for hiding this comment

vfedonkin Jul 6, 2020

Choose a reason for hiding this comment

solankisamir commented Mar 22, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 22, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 22, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 22, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 22, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 22, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 22, 2020 •

edited

Loading