Update EventGrid 2020-04-01-preview swagger to fix couple of bug fixes. #8880

ahamad-MS · 2020-03-30T18:51:25Z

Update EventGrid 2020-04-01-preview swagger to fix couple of bug fixes.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azure-pipelines · 2020-03-30T18:51:42Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-03-30T18:53:01Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 97dbb97 with merge commit e072b14. SDK Automation 13.0.17.20200326.3
⚠️eventgrid/mgmt/2018-01-01 [Logs]
```
No file is changed.
```
⚠️eventgrid/mgmt/2019-01-01 [Logs]
```
No file is changed.
```
⚠️eventgrid/mgmt/2019-06-01 [Logs]
```
No file is changed.
```
⚠️preview/eventgrid/mgmt/2017-06-15-preview [Logs]
```
No file is changed.
```
⚠️preview/eventgrid/mgmt/2017-09-15-preview [Logs]
```
No file is changed.
```
⚠️preview/eventgrid/mgmt/2018-05-01-preview [Logs]
```
No file is changed.
```
⚠️preview/eventgrid/mgmt/2018-09-15-preview [Logs]
```
No file is changed.
```
⚠️preview/eventgrid/mgmt/2019-02-01-preview [Logs]
```
No file is changed.
```
⚠️preview/eventgrid/mgmt/2020-01-01-preview [Logs]
```
No file is changed.
```
️✔️preview/eventgrid/mgmt/2020-04-01-preview [Logs] [Release SDK Changes]
- preview.eventgrid.mgmt.2020-04-01-preview.zip

openapi-sdkautomation · 2020-03-30T18:53:03Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 97dbb97 with merge commit e072b14. SDK Automation 13.0.17.20200326.3
️✔️Microsoft.Azure.Management.EventGrid [Logs] [Release SDK Changes]
- Microsoft.Azure.Management.EventGrid.5.3.0-preview.nupkg
- Microsoft.Azure.Management.EventGrid.5.3.0-preview.snupkg

openapi-sdkautomation · 2020-03-30T18:53:03Z

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-03-30T18:53:05Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 97dbb97 with merge commit e072b14. SDK Automation 13.0.17.20200326.3

️✔️@azure/arm-eventgrid [Logs] [Release SDK Changes]

azure-arm-eventgrid-6.0.0.tgz

[npmPack] npm WARN lifecycle @azure/arm-eventgrid@6.0.0~prepack: cannot run in wd @azure/arm-eventgrid@6.0.0 npm install && npm run build (wd=/z/work/azure-sdk-for-js/sdk/eventgrid/arm-eventgrid)

openapi-sdkautomation · 2020-03-30T18:53:06Z

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 97dbb97 with merge commit e072b14. SDK Automation 13.0.17.20200326.3

⚠️azure-mgmt-eventgrid [Logs] [Release SDK Changes] Breaking Change Detected

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
[ChangeLog] Size of delta 2.299% size of original (original: 72603 chars, delta: 1669 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Model PartnerRegistrationUpdateParameters has a new parameter tags
[ChangeLog]   - Model EventChannel has a new parameter filter
[ChangeLog] 
[ChangeLog] **Breaking changes**
[ChangeLog] 
[ChangeLog]   - Operation PrivateEndpointConnectionsOperations.update has a new signature
[ChangeLog]   - Operation SystemTopicEventSubscriptionsOperations.list_by_system_topic has a new signature
[ChangeLog]   - Operation PartnerTopicEventSubscriptionsOperations.list_by_partner_topic has a new signature

openapi-sdkautomation · 2020-03-30T18:53:13Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 97dbb97 with merge commit e072b14. SDK Automation 13.0.17.20200326.3
️✔️sdk/eventgrid/mgmt-v2018_01_01 [Logs] [Release SDK Changes]
️✔️sdk/eventgrid/mgmt-v2018_05_01_preview [Logs] [Release SDK Changes]
️✔️sdk/eventgrid/mgmt-v2018_09_15_preview [Logs] [Release SDK Changes]
️✔️sdk/eventgrid/mgmt-v2019_01_01 [Logs] [Release SDK Changes]
️✔️sdk/eventgrid/mgmt-v2019_02_01_preview [Logs] [Release SDK Changes]
️✔️sdk/eventgrid/mgmt-v2019_06_01 [Logs] [Release SDK Changes]
️✔️sdk/eventgrid/mgmt-v2020_01_01_preview [Logs] [Release SDK Changes]

⚠️sdk/eventgrid/mgmt-v2020_04_01_preview [Logs] [Release SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/eventgrid/mgmt-v2020_04_01_preview/src/main/java/com/microsoft/azure/management/eventgrid/v2020_04_01_preview/implementation/PartnerTopicImpl.java:[65,29] withTags(java.util.Map) in com.microsoft.azure.management.eventgrid.v2020_04_01_preview.implementation.PartnerTopicImpl cannot override withTags(java.util.Map) in com.microsoft.azure.arm.resources.models.implementation.ResourceImpl
[mvn]   overridden method is final
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-eventgrid: Compilation failure
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/eventgrid/mgmt-v2020_04_01_preview/src/main/java/com/microsoft/azure/management/eventgrid/v2020_04_01_preview/implementation/PartnerTopicImpl.java:[65,29] withTags(java.util.Map) in com.microsoft.azure.management.eventgrid.v2020_04_01_preview.implementation.PartnerTopicImpl cannot override withTags(java.util.Map) in com.microsoft.azure.arm.resources.models.implementation.ResourceImpl
[mvn] [ERROR]   overridden method is final
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

azure-pipelines · 2020-03-30T19:05:48Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-30T19:12:57Z

Azure Pipelines successfully started running 1 pipeline(s).

azuresdkci · 2020-03-30T19:15:39Z

Can one of the admins verify this patch?

azure-pipelines · 2020-03-30T19:28:06Z

Azure Pipelines successfully started running 1 pipeline(s).

ahamad-MS · 2020-03-30T19:34:13Z

Hello @leni-msft .. Can you please help approving/merging this change. Please note the breaking change failure is not a real breaking change as this is part of api preview that was published last week. this iteration is to fix couple of bug fixes we discovered after publishing. thanks

azure-pipelines · 2020-03-30T20:36:35Z

Azure Pipelines successfully started running 1 pipeline(s).

leni-msft · 2020-03-31T07:26:03Z

@ahamad-MS LGTM. @akning-ms could you help merge this PR?

ahamad-MS · 2020-03-31T21:18:24Z

@akning-ms Can you please help with the merge here? thanks

…s. (Azure#8880) * Update 2020-04-01-preview public swagger with bug fixes * fix file * Fix example * Fix example * fix example for approved eenum * missing property Co-authored-by: Ashraf Hamad <ahamad@ntdev.microsoft.com>

Ashraf Hamad added 2 commits March 30, 2020 11:42

Update 2020-04-01-preview public swagger with bug fixes

a6154e9

fix file

44318c9

ahamad-MS requested a review from kalyanaj as a code owner March 30, 2020 18:51

openapi-assignment-bot bot assigned leni-msft Mar 30, 2020

Fix example

6d48107

Fix example

a30cd96

fix example for approved eenum

99fc83e

missing property

97dbb97

akning-ms merged commit e072b14 into Azure:master Apr 1, 2020

ahamad-MS mentioned this pull request Apr 2, 2020

Regenerate EventGrid .NET SDK to reflect new swagger bug fixes for 20-04-01-preview Azure/azure-sdk-for-net#10974

Merged

changlong-liu mentioned this pull request Apr 3, 2020

Sdk automation/@azure arm eventgrid Azure/azure-sdk-for-js#8183

Merged

ahamad-MS deleted the master branch May 9, 2020 09:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update EventGrid 2020-04-01-preview swagger to fix couple of bug fixes. #8880

Update EventGrid 2020-04-01-preview swagger to fix couple of bug fixes. #8880

ahamad-MS commented Mar 30, 2020

azure-pipelines bot commented Mar 30, 2020

openapi-sdkautomation bot commented Mar 30, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 30, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 30, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 30, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 30, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 30, 2020 •

edited

Loading

azure-pipelines bot commented Mar 30, 2020

azure-pipelines bot commented Mar 30, 2020

azuresdkci commented Mar 30, 2020

azure-pipelines bot commented Mar 30, 2020

ahamad-MS commented Mar 30, 2020

azure-pipelines bot commented Mar 30, 2020

leni-msft commented Mar 31, 2020

ahamad-MS commented Mar 31, 2020

Update EventGrid 2020-04-01-preview swagger to fix couple of bug fixes. #8880

Update EventGrid 2020-04-01-preview swagger to fix couple of bug fixes. #8880

Conversation

ahamad-MS commented Mar 30, 2020

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azure-pipelines bot commented Mar 30, 2020

openapi-sdkautomation bot commented Mar 30, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Mar 30, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Mar 30, 2020 • edited Loading

azure-cli-extensions - Release

openapi-sdkautomation bot commented Mar 30, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Mar 30, 2020 • edited Loading

azure-sdk-for-python - Release

- Breaking Change detected in SDK

openapi-sdkautomation bot commented Mar 30, 2020 • edited Loading

azure-sdk-for-java - Release

azure-pipelines bot commented Mar 30, 2020

azure-pipelines bot commented Mar 30, 2020

azuresdkci commented Mar 30, 2020

azure-pipelines bot commented Mar 30, 2020

ahamad-MS commented Mar 30, 2020

azure-pipelines bot commented Mar 30, 2020

leni-msft commented Mar 31, 2020

ahamad-MS commented Mar 31, 2020

openapi-sdkautomation bot commented Mar 30, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 30, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 30, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 30, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 30, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 30, 2020 •

edited

Loading