-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CloudShell -- create stable 2018-10-01 and preview 2020-04-01 swagger apis #8895
Conversation
Azure Pipelines successfully started running 1 pipeline(s). |
azure-cli-extensions
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release⌛ Pending...
|
Can one of the admins verify this patch? |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
@robins1212 You may need fix Avocado and LinDiff issue first before we start to review. let me know if you have any question about how to fix it. |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
[Staging] Swagger Validation Report️ ~[Staging] BreakingChange [Detail]Posted by Swagger Pipeline |
Azure Pipelines successfully started running 1 pipeline(s). |
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like my comments have been addressed. Thanks!
Hi @robins1212 can you fix the lint failure refer to below result? |
@akning-ms the remaining Lint errors would require a code change to our RP. Since this is an older existing api version that we're adding because it never got done by the previous team owning the service. We can't fix the error in the spec without being inconsistent with the behavior of the RP or making code changes that would break the stability. Is it possible to get an exception this time? |
Ok, I see, @robins1212 if in this case, I will suppress this lint failure, but you have a plan to fix these Lint issue in new version? |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
@akning-ms Yes we do. We're working on a new version |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
… apis (Azure#8895) * add specification for stable and preview version * readme and remove aci examples * service name * service name * style fixes * change casing on filename * run pretty fix * fix headers * add operation ids * fix lintdiff errors * Delete cloudShell.json * Delete cloudShell.json * add patch examples * add proper responses * fix schema * remove schema level * add missing responses * parameter title fixes * change body title to parameters * more parameters fixes * change body to properties * fix typo * fix enums * remove preview file from readme * add schema to putusersettingsresponse * fix version and removed required property * remove mislabeled file * run prettier * add modelAsString * run prettier * add resource definition with parameter * run prettier * add resource more places * lint fixes Co-authored-by: Robin Sturm <rosturm@microsoft.com>
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.