Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudShell -- create stable 2018-10-01 and preview 2020-04-01 swagger apis #8895

Merged
merged 35 commits into from
Jun 16, 2020

Conversation

robins1212
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 31, 2020

azure-cli-extensions

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 31, 2020

azure-sdk-for-go - Release

failed [Logs] [Expand Details]
  • Generate from 0dcd51b with merge commit 12f42bd. SDK Automation 13.0.17.20200605.3
    [AutoRest] FATAL: The schema's 'CloudShellConsole' ancestors should have at lease one property
    [AutoRest] FATAL: AutoRest.Core.Logging.CodeGenerationException: The schema's 'CloudShellConsole' ancestors should have at lease one property
    [AutoRest]    at AutoRest.Modeler.SwaggerModeler.BuildCompositeTypes() in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SwaggerModeler.cs:line 284
    [AutoRest]    at AutoRest.Modeler.SwaggerModeler.Build(ServiceDefinition serviceDefinition) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SwaggerModeler.cs:line 66
    [AutoRest]    at AutoRest.Modeler.Program.d__2.MoveNext() in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\Program.cs:line 60
    [AutoRest] --- End of stack trace from previous location where exception was thrown ---
    [AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    [AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    [AutoRest]    at NewPlugin.d__15.MoveNext()
    [AutoRest] FATAL: go/imodeler1 - FAILED
    [AutoRest] FATAL: Error: Plugin imodeler1 reported failure.
    [AutoRest]   Error: Plugin imodeler1 reported failure.
    Failed to run autorest.
    Error: /z/node_modules/.bin/autorest --use=@microsoft.azure/autorest.go@~2.1.145 --go --verbose --multiapi --use-onever --preview-chk --version=previous --go-sdk-folder=/z/work/src/github.com/Azure/azure-sdk-for-go /z/work/azure-rest-api-specs/specification/cloudshell/resource-manager/readme.md FATAL: The schema's 'CloudShellConsole' ancestors should have at lease one property
    FATAL: AutoRest.Core.Logging.CodeGenerationException: The schema's 'CloudShellConsole' ancestors should have at lease one property
       at AutoRest.Modeler.SwaggerModeler.BuildCompositeTypes() in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SwaggerModeler.cs:line 284
       at AutoRest.Modeler.SwaggerModeler.Build(ServiceDefinition serviceDefinition) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SwaggerModeler.cs:line 66
       at AutoRest.Modeler.Program.d__2.MoveNext() in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\Program.cs:line 60
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
       at NewPlugin.d__15.MoveNext()
    FATAL: go/imodeler1 - FAILED
    FATAL: Error: Plugin imodeler1 reported failure.
      Error: Plugin imodeler1 reported failure.
    , {} 
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 31, 2020

azure-sdk-for-java - Release

failed [Logs] [Expand Details]
  • Generate from 0dcd51b with merge commit 12f42bd. SDK Automation 13.0.17.20200605.3
    [AutoRest] FATAL: The schema's 'CloudShellConsole' ancestors should have at lease one property
    [AutoRest] FATAL: AutoRest.Core.Logging.CodeGenerationException: The schema's 'CloudShellConsole' ancestors should have at lease one property
    [AutoRest]    at AutoRest.Modeler.SwaggerModeler.BuildCompositeTypes() in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SwaggerModeler.cs:line 284
    [AutoRest]    at AutoRest.Modeler.SwaggerModeler.Build(ServiceDefinition serviceDefinition) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SwaggerModeler.cs:line 66
    [AutoRest]    at AutoRest.Modeler.Program.d__2.MoveNext() in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\Program.cs:line 60
    [AutoRest] --- End of stack trace from previous location where exception was thrown ---
    [AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    [AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    [AutoRest]    at NewPlugin.d__15.MoveNext()
    [AutoRest] FATAL: java/imodeler1 - FAILED
    [AutoRest] FATAL: Error: Plugin imodeler1 reported failure.
    [AutoRest]   Error: Plugin imodeler1 reported failure.
    Failed to run autorest.
    Error: /z/node_modules/.bin/autorest --version=V2 --java --verbose --multiapi --use=@microsoft.azure/autorest.java@preview --azure-libraries-for-java-folder=/z/work/azure-sdk-for-java /z/work/azure-rest-api-specs/specification/cloudshell/resource-manager/readme.md FATAL: The schema's 'CloudShellConsole' ancestors should have at lease one property
    FATAL: AutoRest.Core.Logging.CodeGenerationException: The schema's 'CloudShellConsole' ancestors should have at lease one property
       at AutoRest.Modeler.SwaggerModeler.BuildCompositeTypes() in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SwaggerModeler.cs:line 284
       at AutoRest.Modeler.SwaggerModeler.Build(ServiceDefinition serviceDefinition) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SwaggerModeler.cs:line 66
       at AutoRest.Modeler.Program.d__2.MoveNext() in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\Program.cs:line 60
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
       at NewPlugin.d__15.MoveNext()
    FATAL: java/imodeler1 - FAILED
    FATAL: Error: Plugin imodeler1 reported failure.
      Error: Plugin imodeler1 reported failure.
    , {} 
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 31, 2020

azure-sdk-for-js - Release

failed [Logs] [Expand Details]
  • Generate from 0dcd51b with merge commit 12f42bd. SDK Automation 13.0.17.20200605.3
    [AutoRest] FATAL: The schema's 'CloudShellConsole' ancestors should have at lease one property
    [AutoRest] FATAL: AutoRest.Core.Logging.CodeGenerationException: The schema's 'CloudShellConsole' ancestors should have at lease one property
    [AutoRest]    at AutoRest.Modeler.SwaggerModeler.BuildCompositeTypes() in c:\publish\autorest.modeler\src\SwaggerModeler.cs:line 361
    [AutoRest]    at AutoRest.Modeler.SwaggerModeler.Build(ServiceDefinition serviceDefinition) in c:\publish\autorest.modeler\src\SwaggerModeler.cs:line 66
    [AutoRest]    at AutoRest.Modeler.Program.d__2.MoveNext() in c:\publish\autorest.modeler\src\Program.cs:line 60
    [AutoRest] --- End of stack trace from previous location where exception was thrown ---
    [AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    [AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    [AutoRest]    at NewPlugin.d__15.MoveNext()
    [AutoRest] FATAL: typescript/imodeler1 - FAILED
    [AutoRest] FATAL: Error: Plugin imodeler1 reported failure.
    [AutoRest]   Error: Plugin imodeler1 reported failure.
    Failed to run autorest.
    Error: /z/node_modules/.bin/autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.1 --typescript-sdks-folder=/z/work/azure-sdk-for-js /z/work/azure-rest-api-specs/specification/cloudshell/resource-manager/readme.md FATAL: The schema's 'CloudShellConsole' ancestors should have at lease one property
    FATAL: AutoRest.Core.Logging.CodeGenerationException: The schema's 'CloudShellConsole' ancestors should have at lease one property
       at AutoRest.Modeler.SwaggerModeler.BuildCompositeTypes() in c:\publish\autorest.modeler\src\SwaggerModeler.cs:line 361
       at AutoRest.Modeler.SwaggerModeler.Build(ServiceDefinition serviceDefinition) in c:\publish\autorest.modeler\src\SwaggerModeler.cs:line 66
       at AutoRest.Modeler.Program.d__2.MoveNext() in c:\publish\autorest.modeler\src\Program.cs:line 60
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
       at NewPlugin.d__15.MoveNext()
    FATAL: typescript/imodeler1 - FAILED
    FATAL: Error: Plugin imodeler1 reported failure.
      Error: Plugin imodeler1 reported failure.
    , {} 
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 31, 2020

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 31, 2020

azure-sdk-for-python - Release

Pending...

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@akning-ms akning-ms added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 1, 2020
@akning-ms
Copy link
Contributor

@robins1212 You may need fix Avocado and LinDiff issue first before we start to review. let me know if you have any question about how to fix it.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented May 29, 2020

[Staging] Swagger Validation Report

  • 🔄~[Staging] BreakingChange [Detail]

  • Posted by Swagger Pipeline

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented May 29, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    Copy link
    Contributor

    @KrisBash KrisBash left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    It looks like my comments have been addressed. Thanks!

    @KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 29, 2020
    @akning-ms
    Copy link
    Contributor

    @robins1212
    Copy link
    Contributor Author

    @akning-ms the remaining Lint errors would require a code change to our RP. Since this is an older existing api version that we're adding because it never got done by the previous team owning the service. We can't fix the error in the spec without being inconsistent with the behavior of the RP or making code changes that would break the stability. Is it possible to get an exception this time?

    @akning-ms akning-ms added the SuppressionTrack Track suppression in PR label Jun 3, 2020
    @akning-ms
    Copy link
    Contributor

    Ok, I see, @robins1212 if in this case, I will suppress this lint failure, but you have a plan to fix these Lint issue in new version?

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @robins1212
    Copy link
    Contributor Author

    @akning-ms Yes we do. We're working on a new version

    @akning-ms akning-ms merged commit 12f42bd into Azure:master Jun 16, 2020
    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 16, 2020

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
    … apis (Azure#8895)
    
    * add specification for stable and preview version
    
    * readme and remove aci examples
    
    * service name
    
    * service name
    
    * style fixes
    
    * change casing on filename
    
    * run pretty fix
    
    * fix headers
    
    * add operation ids
    
    * fix lintdiff errors
    
    * Delete cloudShell.json
    
    * Delete cloudShell.json
    
    * add patch examples
    
    * add proper responses
    
    * fix schema
    
    * remove schema level
    
    * add missing responses
    
    * parameter title fixes
    
    * change body title to parameters
    
    * more parameters fixes
    
    * change body to properties
    
    * fix typo
    
    * fix enums
    
    * remove preview file from readme
    
    * add schema to putusersettingsresponse
    
    * fix version and removed required property
    
    * remove mislabeled file
    
    * run prettier
    
    * add modelAsString
    
    * run prettier
    
    * add resource definition with parameter
    
    * run prettier
    
    * add resource more places
    
    * lint fixes
    
    Co-authored-by: Robin Sturm <rosturm@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review SuppressionTrack Track suppression in PR
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants