Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Microsoft.ApiManagement][2019-12-01] Gateway hostname configuration protocol settings #8938

Closed
wants to merge 0 commits into from
Closed

[Microsoft.ApiManagement][2019-12-01] Gateway hostname configuration protocol settings #8938

wants to merge 0 commits into from

Conversation

maksimkim
Copy link
Member

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 3, 2020 •
edited
Loading

azure-sdk-for-go

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 3, 2020 •
edited
Loading

azure-cli-extensions

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 3, 2020 •
edited
Loading

azure-sdk-for-net

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 3, 2020 •
edited
Loading

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 6af3972 with merge commit 740364b9844410152d5401779fa8c8fec7082e2c. SDK Automation 13.0.17.20200326.3
  • ️✔️@azure/arm-apimanagement [Logs]  [Preview SDK Changes] 
    [npmPack] npm WARN lifecycle @azure/arm-apimanagement@6.0.0~prepack: cannot run in wd @azure/arm-apimanagement@6.0.0 npm install && npm run build (wd=/z/work/azure-sdk-for-js/sdk/apimanagement/arm-apimanagement)

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 3, 2020 •
edited
Loading

azure-sdk-for-java

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 3, 2020 •
edited
Loading

azure-sdk-for-python

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 6af3972 with merge commit 740364b9844410152d5401779fa8c8fec7082e2c. SDK Automation 13.0.17.20200326.3
  • ️✔️azure-mgmt-apimanagement [Logs]  [Preview SDK Changes] 
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
[ChangeLog] Size of delta 0.229% size of original (original: 233198 chars, delta: 535 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Model GatewayHostnameConfigurationContract has a new parameter tls11_enabled
[ChangeLog]   - Model GatewayHostnameConfigurationContract has a new parameter tls10_enabled
[ChangeLog]   - Model GatewayHostnameConfigurationContract has a new parameter http2_enabled

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Apr 3, 2020
Open
@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Apr 3, 2020
Open
@solankisamir solankisamir added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required API Management labels Apr 3, 2020
@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Apr 3, 2020
Open
KrisBash
KrisBash suggested changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see one comment

...on/apimanagement/resource-manager/Microsoft.ApiManagement/stable/2019-12-01/definitions.json Outdated
@@ -5525,6 +5525,18 @@
"negotiateClientCertificate": {
"type": "boolean",
"description": "Determines whether gateway requests client certificate"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding these within an API version can cause undesired effects as customers use mixed SDK versions where only latest can deserialize these properties. Additionally, Azure Policy becomes unpredictable if properties customers use in policy evaluations are added within an API version. Can they be added in a new version?

@KrisBash KrisBash added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 7, 2020
@ravbhatnagar
Copy link
Contributor

@solankisamir - please let us know if this PR is still relevant and re-add the ARM review label. removing from now due to no activity for several months.

@ravbhatnagar ravbhatnagar removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 27, 2020
@maksimkim maksimkim closed this Jul 29, 2020
@maksimkim maksimkim force-pushed the apimgatewayhostnameprotocols branch from 6af3972 to aa9c384 Compare July 29, 2020 17:45
@solankisamir
Copy link
Member

@ravbhatnagar we have put the changes into new PR #10292

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrisBash KrisBash KrisBash requested changes

@solankisamir solankisamir solankisamir approved these changes

Assignees

@njuCZ njuCZ

Labels
API Management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@maksimkim @azuresdkci @ravbhatnagar @solankisamir @KrisBash @njuCZ