Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Azure Stack] Updates to Azs.Compute.Admin spec for autorest config #9032

Merged
merged 3 commits into from
Jun 27, 2020
Merged

[Azure Stack] Updates to Azs.Compute.Admin spec for autorest config #9032

merged 3 commits into from
Jun 27, 2020

Conversation

viananth
Copy link
Member

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@viananth
Cumulative commit message:
2fabd58 
commit 4ec980f (azure/stackadmin)
Author: Yuxing Zhou <zyx.pulsars@gmail.com>
Date:   Wed Mar 18 15:14:57 2020 +0800

    [Azure Stack] Add scaleUnit and volumeLabel parameter to Disks_List (Azure#8733)

    * add scaleUnit and volumeLabel to Disks_List

    * fix ref location

    * update parameter description

commit c70efa6
Author: bganapa <bganapa@microsoft.com>
Date:   Tue Feb 25 19:33:53 2020 -0800

    Updating ReadMe to include (this-folder)

commit ac2ee55
Author: Yuxing Zhou <zyx.pulsars@gmail.com>
Date:   Mon Feb 17 08:52:02 2020 +0800

    Add TargetScaleUnitParameter and TargetVolumeLabelParameter (Azure#8409)

commit 79944a3
Author: hannah-murphy-0 <60626670+hannah-murphy-0@users.noreply.github.com>
Date:   Thu Feb 13 17:25:47 2020 -0800

    Adding publisher field to VMExtension model (Azure#8398)
                                                                                                                        commit 8ef2c06                                                                         Merge: 4691c2a b53a498                                                                                              Author: bganapa <bganapa@microsoft.com>                            Date:   Tue Feb 4 22:11:56 2020 -0800                                        git merge upstream/master
    commit 9e551f0
Author: bganapa <bganapa@microsoft.com>
Date:   Tue Nov 12 11:44:22 2019 -0800

    Reset to Stackadmin2 (Azure#7766)
@viananth
Add autorest config to readme.md
9685164
@viananth viananth requested a review from bganapa April 13, 2020 18:13
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 13, 2020 •
edited
Loading

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 13, 2020 •
edited
Loading

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 13, 2020 •
edited
Loading

azure-sdk-for-go - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 13, 2020 •
edited
Loading

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 13, 2020 •
edited
Loading

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 13, 2020 •
edited
Loading

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

bganapa
bganapa reviewed Apr 13, 2020
View reviewed changes
specification/azsadmin/resource-manager/compute/readme.md
@@ -56,32 +56,16 @@ csharp:
clear-output-folder: true
```

## Multi-API/Profile support for AutoRest v3 generators
# AutoRest v3 generators
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we dont need to change this part i think

bganapa
bganapa reviewed Apr 13, 2020
View reviewed changes
...admin/resource-manager/compute/Microsoft.Compute.Admin/preview/2018-07-30-preview/Disks.json
@@ -44,6 +44,12 @@
{
"$ref": "Disks.json#/parameters/SourceSharePathParameter"
},
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zyxyoshine Havent you made this change already to master? you made this only in stackadmin?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bganapa I believe they are in master. PR #8747 has been merged.

@bganapa bganapa requested a review from zyxyoshine April 13, 2020 18:56
@fengzhou-msft fengzhou-msft added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 14, 2020
KrisBash
KrisBash approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 14, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 20, 2020 •
edited
Loading

azure-sdk-for-trenton

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@viananth
Copy link
Member Author

@zyxyoshine could you please approve this PR if it looks good to you? Thanks!

@viananth
Copy link
Member Author

@fengzhou-msft could you pls merge this PR if it looks good to you? Thanks!

@fengzhou-msft
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@viananth
Copy link
Member Author

@KrisBash could you pls merge this PR if it looks good? Thank you! @bganapa FYI

@bganapa
Copy link
Member

bganapa commented May 12, 2020

@KrisBash Do you need anything to be fixed here? Could you pls merge this

@viananth
Copy link
Member Author

@fengzhou-msft is there any changes you are expecting? Could you please merge if it looks good? Kris had already signed off.

@fengzhou-msft fengzhou-msft added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jun 25, 2020
@fengzhou-msft
Copy link
Member

@viananth sorry for the delay, I do not have permission to force merge the PR. @akning-ms can you help merge this PR?

@akning-ms akning-ms merged commit 3030d86 into Azure:master Jun 27, 2020
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 27, 2020 •
edited
Loading

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 27, 2020 •
edited
Loading

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
@viananth @00Kai0
[Azure Stack] Updates to Azs.Compute.Admin spec for autorest config (A…
1bae52e 
…zure#9032)

* Cumulative commit message:
commit 4ec980f (azure/stackadmin)
Author: Yuxing Zhou <zyx.pulsars@gmail.com>
Date:   Wed Mar 18 15:14:57 2020 +0800

    [Azure Stack] Add scaleUnit and volumeLabel parameter to Disks_List (Azure#8733)

    * add scaleUnit and volumeLabel to Disks_List

    * fix ref location

    * update parameter description

commit c70efa6
Author: bganapa <bganapa@microsoft.com>
Date:   Tue Feb 25 19:33:53 2020 -0800

    Updating ReadMe to include (this-folder)

commit ac2ee55
Author: Yuxing Zhou <zyx.pulsars@gmail.com>
Date:   Mon Feb 17 08:52:02 2020 +0800

    Add TargetScaleUnitParameter and TargetVolumeLabelParameter (Azure#8409)

commit 79944a3
Author: hannah-murphy-0 <60626670+hannah-murphy-0@users.noreply.github.com>
Date:   Thu Feb 13 17:25:47 2020 -0800

    Adding publisher field to VMExtension model (Azure#8398)
                                                                                                                        commit 8ef2c06                                                                         Merge: 4691c2a b53a498                                                                                              Author: bganapa <bganapa@microsoft.com>                            Date:   Tue Feb 4 22:11:56 2020 -0800                                        git merge upstream/master
    commit 9e551f0
Author: bganapa <bganapa@microsoft.com>
Date:   Tue Nov 12 11:44:22 2019 -0800

    Reset to Stackadmin2 (Azure#7766)

* Add autorest config to readme.md

* Fix path reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrisBash KrisBash KrisBash approved these changes

@bganapa bganapa bganapa approved these changes

@zyxyoshine zyxyoshine zyxyoshine approved these changes

Assignees

@fengzhou-msft fengzhou-msft

Labels
Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@viananth @azuresdkci @fengzhou-msft @bganapa @KrisBash @zyxyoshine @akning-ms