Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Resource Name added to swagger #9185

Merged
merged 17 commits into from
Jul 11, 2020
Merged

Check Resource Name added to swagger #9185

merged 17 commits into from
Jul 11, 2020

Conversation

shreyanshn
Copy link
Contributor

@shreyanshn shreyanshn commented Apr 22, 2020 •
edited by raych1
Loading

Microsoft.Resources/checkResourceName/action is not defined in swagger #8780

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask tih@microsoft.com (or NullMDR in github) for additional help.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@raych1 raych1 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 25, 2020
@openapi-assignment-bot openapi-assignment-bot bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 1, 2020
@raych1
Copy link
Contributor

raych1 commented May 29, 2020

/azp run automation - sdk

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented May 29, 2020 •
edited
Loading

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented May 29, 2020 •
edited
Loading

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented May 29, 2020 •
edited
Loading

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 4f88bac with merge commit 1b0aea3. SDK Automation 13.0.17.20200619.4 
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-python/pull/1561: HttpError: Reference does not exist, {"name":"HttpError","status":422,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-length":"121","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Sat, 11 Jul 2020 01:34:41 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"422 Unprocessable Entity","strict-transport-security":"max-age=31536000; includeSubdomains; preload","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"040F:7CA5:C2EB9:E82A2:5F091731","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4788","x-ratelimit-reset":"1594434283","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-python/git/refs/heads/sdkAutomation/track2_azure-mgmt-resource@9185","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/12.18.1 (Linux 5.3; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}
Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-python/pull/1309: HttpError: Reference does not exist, {"name":"HttpError","status":422,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-length":"121","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Sat, 11 Jul 2020 01:34:41 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"422 Unprocessable Entity","strict-transport-security":"max-age=31536000; includeSubdomains; preload","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"0411:7CA6:E5EBC:119BFE:5F091731","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4787","x-ratelimit-reset":"1594434283","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-python/git/refs/heads/sdkAutomation/azure-mgmt-resource@9185","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/12.18.1 (Linux 5.3; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}
[azure-mgmt-resource][after_scripts|python] WARNING:__main__:Patching multi-api client basic files
[azure-mgmt-resource][after_scripts|python] WARNING:__main__:Patching multi-api client basic files
[azure-mgmt-resource][after_scripts|python] WARNING:__main__:Found too much API version: {'2017-06-01-preview', '2016-12-01'} in label v2017_06_01_preview
[azure-mgmt-resource][after_scripts|python] WARNING:__main__:Guessing you want 2017-06-01-preview based on label v2017_06_01_preview
[azure-mgmt-resource][after_scripts|python] WARNING:__main__:Patching multi-api client basic files
[azure-mgmt-resource][after_scripts|python] WARNING:__main__:Patching multi-api client basic files
[azure-mgmt-resource][after_scripts|python] WARNING:__main__:Patching multi-api client basic files
[azure-mgmt-resource][after_scripts|python] WARNING:__main__:Patching multi-api client basic files
[azure-mgmt-resource][after_scripts|python] WARNING:__main__:Patching multi-api client basic files
[azure-mgmt-resource][after_scripts|python] WARNING:__main__:Patching multi-api client basic files
  • ️✔️azure-mgmt-resource [View full logs]  [Release SDK Changes] 
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-resource
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-resource
[after_scripts|python] WARNING:__main__:Patching multi-api client basic files
[after_scripts|python] WARNING:__main__:Patching multi-api client basic files
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-06-01-preview', '2016-12-01'} in label v2017_06_01_preview
[after_scripts|python] WARNING:__main__:Guessing you want 2017-06-01-preview based on label v2017_06_01_preview
[after_scripts|python] WARNING:__main__:Patching multi-api client basic files
[after_scripts|python] WARNING:__main__:Patching multi-api client basic files
[after_scripts|python] WARNING:__main__:Patching multi-api client basic files
[after_scripts|python] WARNING:__main__:Patching multi-api client basic files
[after_scripts|python] WARNING:__main__:Patching multi-api client basic files
[after_scripts|python] WARNING:__main__:Patching multi-api client basic files
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[ChangeLog] Size of delta 3.322% size of original (original: 117501 chars, delta: 3903 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Added operation group SubscriptionClientOperationsMixin

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented May 29, 2020 •
edited
Loading

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 25, 2020
@raych1
Copy link
Contributor

raych1 commented Jun 30, 2020

/azp run automation - sdk

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 30, 2020 •
edited
Loading

azure-sdk-for-python-track2 - Release

❌ failed [Logs] [Expand Details]
  • ❌ Generate from 4f88bac with merge commit 1b0aea3. SDK Automation 13.0.17.20200619.4
    Only show 100 items here, please refer to log for details.
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'FeatureProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'FeatureResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'FeatureOperationsListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceLinkFilter' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceLinkResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceLink' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceLinkProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ManagementLockOwner' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ManagementLockProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ManagementLockObject' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ManagementLockListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ManagementLockProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ManagementLockObject' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ManagementLockListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Application' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ApplicationPatchable' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ApplicationDefinition' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ApplicationProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ApplicationPropertiesPatchable' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ApplicationDefinitionProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Plan' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PlanPatchable' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'GenericResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Sku' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Identity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ApplicationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ApplicationDefinitionListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ApplicationArtifact' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ApplicationProviderAuthorization' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyAssignmentProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ParameterValuesValue' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicySku' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyAssignment' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyAssignmentListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Identity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyDefinitionProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ParameterDefinitionsValue' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyDefinition' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyDefinitionListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicySetDefinitionProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyDefinitionReference' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyDefinitionGroup' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicySetDefinition' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicySetDefinitionListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorAdditionalInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyAssignmentProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicySku' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyAssignment' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyAssignmentListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Identity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyDefinitionProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyDefinition' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyDefinitionListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicySetDefinitionProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyDefinitionReference' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicySetDefinition' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicySetDefinitionListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyAssignmentProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicySku' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyAssignment' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyAssignmentListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Identity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyDefinitionProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyDefinition' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyDefinitionListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicySetDefinitionProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyDefinitionReference' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicySetDefinition' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicySetDefinitionListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyAssignmentProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicySku' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyAssignment' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyAssignmentListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Identity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyDefinitionProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyDefinition' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyDefinitionListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicySetDefinitionProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyDefinitionReference' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicySetDefinition' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicySetDefinitionListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyAssignmentProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicySku' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyAssignment' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyAssignmentListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyDefinitionProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyDefinition' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyDefinitionListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicySetDefinitionProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
  • ️✔️azure-mgmt-resource [View full logs]  [Release SDK Changes] 
    [build_conf_init]   Cache entry deserialization failed, entry ignored
[build_conf_init]   Cache entry deserialization failed, entry ignored
[build_conf] INFO:packaging_tools:Building template azure-mgmt-resource
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-resource
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

raych1
raych1 reviewed Jun 30, 2020
View reviewed changes
specification/resources/resource-manager/readme.md
@@ -616,6 +616,12 @@ input-file:
- Microsoft.Authorization/stable/2016-12-01/policyAssignments.json
- Microsoft.Resources/stable/2016-06-01/subscriptions.json
- Microsoft.Resources/stable/2018-05-01/resources.json

override-info:
title: PolicyClient
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should have one value for title. Can you refer to other tag sections?

raych1
raych1 suggested changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@raych1 raych1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The incorrect value in readme.md caused the SDK task failure.

@raych1
Copy link
Contributor

raych1 commented Jul 1, 2020

@jianyexi , can you help with the lintdiff failures?

@jianyexi
Copy link
Contributor

jianyexi commented Jul 1, 2020

@jianyexi , can you help with the lintdiff failures?

1 override the title in readme, since there are multiple input swaggers
2 For the following error message output by the check of commit: single override, the $.definitions.Operation.description has conflict among input swaggers , the value of $.definitions.Operation.description should be the same in every swaggers

$.definitions.Operation.description' has incompatible values (---\n" +
  'Microsoft.Authorization operation\n' +
  ', ---\n' +
  'Microsoft.Resources operation\n' +
  ').\n'

@raych1
Copy link
Contributor

raych1 commented Jul 7, 2020

@shreyanshn , did you figure out how to fix the lint failures?

@shreyanshn
Copy link
Contributor Author

@raych1 I cannot fix the incompatible values for the operation part of the swagger because it is not a part of the API that I changed. Not sure how to fix that.

@jianyexi
Copy link
Contributor

jianyexi commented Jul 9, 2020

@raych1 I have ran lint locally and no new lint error reported , so I think it can be force merged

SDK Errors/Warnings
===================
Errors:    Before:  18  - After:  18
Warnings:  Before:  9  - After:  9
New SDK Errors:  0
New SDK Warnings:  0
Existing SDK Errors:  0
Existing SDK Warnings:  0
ARM Errors/Warnings
===================
Errors:    Before:  144  - After:  144
Warnings:  Before:  18  - After:  18
New ARM Errors:  0
New ARM Warnings:  0
Existing ARM Errors:  0
Existing ARM Warnings:  0
-----------------------------------------

@raych1
Copy link
Contributor

raych1 commented Jul 10, 2020

/azp run automation - sdk

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@raych1
Copy link
Contributor

raych1 commented Jul 10, 2020

@raych1 I have ran lint locally and no new lint error reported , so I think it can be force merged

SDK Errors/Warnings
===================
Errors:    Before:  18  - After:  18
Warnings:  Before:  9  - After:  9
New SDK Errors:  0
New SDK Warnings:  0
Existing SDK Errors:  0
Existing SDK Warnings:  0
ARM Errors/Warnings
===================
Errors:    Before:  144  - After:  144
Warnings:  Before:  18  - After:  18
New ARM Errors:  0
New ARM Warnings:  0
Existing ARM Errors:  0
Existing ARM Warnings:  0
-----------------------------------------

Thanks @jianyexi !

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jul 10, 2020
Closed
@raych1
Copy link
Contributor

raych1 commented Jul 10, 2020

@akning-ms , as synced with you offline, lintDiff fails by autorest error on different description value for same property which is legacy file. Jianye ran the lintDiff offline and the result looks good for the change. Please help force merge this PR.

@akning-ms akning-ms added the SuppressionTrack Track suppression in PR label Jul 11, 2020
@akning-ms
Copy link
Contributor

@nullMDR @changlong-liu for awareness track 2 python sdk generation fail for this PR

@akning-ms akning-ms merged commit 1b0aea3 into Azure:master Jul 11, 2020
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
@shreyanshn @00Kai0
Check Resource Name added to swagger (Azure#9185)
c15f339 
* Check Resource Name added to swagger

* spellcheck and prettier check fixed

* fixes

* prettier check and x-ms fixes

* added schema for resource name

* fixes

* description added to resourcename

* added changes to all api versions

* default response added

* prettier checl

* default response changed

* removed 2016-06-01 api

* override errors

* file moved to examples

* single override

* reverting

* override policyclient

Co-authored-by: Shreyansh Nawlakha <shnawlak@microsoft.com>
@ifeoluwaokunoren ifeoluwaokunoren mentioned this pull request May 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthony-c-martin anthony-c-martin anthony-c-martin left review comments

@KrisBash KrisBash KrisBash requested changes

@raych1 raych1 raych1 approved these changes

@Tiano2017 Tiano2017 Awaiting requested review from Tiano2017

Assignees

@raych1 raych1

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review SuppressionTrack Track suppression in PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@shreyanshn @AutorestCI @azuresdkci @raych1 @jianyexi @akning-ms @KrisBash @anthony-c-martin @ravbhatnagar