-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto patch swagger change #9524
Merged
hyonholee
merged 24 commits into
Azure:compute-2020-06
from
jemex:autoPatchSwaggerChange
May 28, 2020
Merged
Auto patch swagger change #9524
hyonholee
merged 24 commits into
Azure:compute-2020-06
from
jemex:autoPatchSwaggerChange
May 28, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull request contains merge conflicts. |
…re-rest-api-specs into autoPatchSwaggerChange
openapi-assignment-bot
bot
added
the
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
label
May 20, 2020
No commit pushedDate could be found for PR 9524 in repo Azure/azure-rest-api-specs |
Can one of the admins verify this patch? |
Pull request contains merge conflicts. |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go
|
azure-sdk-for-java
|
azure-sdk-for-js
|
azure-sdk-for-net
|
azure-sdk-for-trenton
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
…re-rest-api-specs into autoPatchSwaggerChange
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signing off from ARM side.
ravbhatnagar
added
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
and removed
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
labels
May 23, 2020
ArcturusZhang
approved these changes
May 25, 2020
Hi @qiaozha could you please have a look at the failure on JS SDK? |
/azp run automation |
No pipelines are associated with this pull request. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
hyonholee
force-pushed
the
compute-2020-06
branch
from
May 26, 2020 00:09
60ad3dc
to
18dc89f
Compare
Pull request contains merge conflicts. |
Azure Pipelines successfully started running 1 pipeline(s). |
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
ArcturusZhang
pushed a commit
that referenced
this pull request
Jun 23, 2020
* Preparatory commit for compute 2020-06-01 API version * Auto patch swagger change (#9524) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9065) * Adding in-guest vm patch propertyies to VM model * making the enum model as string * adding the change to end of the file for easy comparison * Fixing the name of the property * Preparatory commit for compute 2020-06-01 API version * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9065) * Adding in-guest vm patch propertyies to VM model * making the enum model as string * adding the change to end of the file for easy comparison * Fixing the name of the property * fixing merge conflict * fixing the checks * adding reference to the example * fixing the checks error * fixing the example validation * running prettier Co-authored-by: Hyonho Lee <Hyonho.Lee@microsoft.com> Co-authored-by: Sirajudeen Sahul Hameed <sirajs@microsoft.com> * Revert the breaking change * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9520) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties Co-authored-by: Hyonho Lee <Hyonho.Lee@microsoft.com> Co-authored-by: Hyonho Lee <hylee@microsoft.com> * Added SecurityProfile to support Host Encryption for VM and Scaleset resources - Changes reviewed in PR: 9366 (#9666) * Preparatory commit for compute 2020-06-01 API version * updated swagger * updated swagger * fixed the prettier issues * updated the documentation' * Preparatory commit for compute 2020-06-01 API version * resolved * updated code * resolved conflicts * udpated comments * updated code * resolved prettier fix Co-authored-by: Hyonho Lee <Hyonho.Lee@microsoft.com> * Adding new RetrieveBootDiagnosticsData.POST API. VM/VMSS managed boot diagnostics changes with examples. (#9460) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9065) * managed boot diagnostics changes. * Add new lines to the EOF. * Adding missing response schema. * Preparatory commit for compute 2020-06-01 API version * Adding default error response. * Review comments. * Remove extra comma Co-authored-by: Hyonho Lee <Hyonho.Lee@microsoft.com> Co-authored-by: Sirajudeen Sahul Hameed <sirajs@microsoft.com> Co-authored-by: Avinash Akka <avakka@microsoft.com> * Addressing minor corrections in examples related PR#9460 (#9685) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9065) * managed boot diagnostics changes. * Add new lines to the EOF. * Adding missing response schema. * Preparatory commit for compute 2020-06-01 API version * Adding default error response. * Review comments. * Remove extra comma * Addressing pending review changes. Co-authored-by: Hyonho Lee <Hyonho.Lee@microsoft.com> Co-authored-by: Sirajudeen Sahul Hameed <sirajs@microsoft.com> Co-authored-by: Avinash Akka <avakka@microsoft.com> * Add AssessPatches API (#9275) * Initial commit with updates to compute.json for assessPatches and softwarePatches * Add VirtualMachinesAssessPatches.json * Fix minor issues with softwarePatches * Updates to correct the example per oav * Remove GET and LIST softwarePatches * Remove unneeded list result * update description strings * Add kbid to spell check list. Include Prettier formating changes. * Update SoftwarePatch.InstallationState to AssessmentState * Remove extra properties from patch object array * Fix name of PublishedDate * Add generic error response * Add readonly, make rebootPending a boolean again * Remove LastModifiedDateTime from result object * Adding ExtensionsTimeBudget to new Api Version (#9319) * fixing encoding (+2 squashed commit) Squashed commit: [e73eef7] Prettier [68d011b] adding 201 response (+1 squashed commits) Squashed commits: [83f71bb48] Adding references (+1 squashed commits) Squashed commits: [d8ed894] updating GET example (+1 squashed commits) Squashed commits: [61920933d] fix (+1 squashed commits) Squashed commits: [f0151eb78] updated with extensionsTimeBudget * fixing file name Co-authored-by: Hyonho Lee <hylee@microsoft.com> * Changes related to dedicated host group automatic placement (#9684) * Made changes for dedicated host group instance view * Added definitions for dedicated host group instance view * Made changes for SupportAutomaticPlacement * Made changes for assigned host * Made changes on properties.hostGroup * Added a missing comma * Addressed comments * Updated * Added assignedHost to VMScaleSetVMInstanceView * Addressed comments * Added minimum API version for assignedHost * Addressed comments * ModelAsString to false * Added exmples for VM * Added examples for VMSS * small fix * Addressed comments * Added missing parameter * Fixed examples * Add example for VMSS RunCommand (#9875) Co-authored-by: Jemal Abdulkadir <jemex2627@gmail.com> Co-authored-by: Sirajudeen Sahul Hameed <sirajs@microsoft.com> Co-authored-by: hari-bodicherla <43284966+hari-bodicherla@users.noreply.github.com> Co-authored-by: Avinash <akka@usc.edu> Co-authored-by: Avinash Akka <avakka@microsoft.com> Co-authored-by: Mike Richmond <mirichmo@microsoft.com> Co-authored-by: kamusta-msft <56413142+kamusta-msft@users.noreply.github.com> Co-authored-by: dochung4 <40577926+dochung4@users.noreply.github.com> Co-authored-by: Atanas Koralski <koralski@gmail.com>
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
* Preparatory commit for compute 2020-06-01 API version * Auto patch swagger change (Azure#9524) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (Azure#9065) * Adding in-guest vm patch propertyies to VM model * making the enum model as string * adding the change to end of the file for easy comparison * Fixing the name of the property * Preparatory commit for compute 2020-06-01 API version * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (Azure#9065) * Adding in-guest vm patch propertyies to VM model * making the enum model as string * adding the change to end of the file for easy comparison * Fixing the name of the property * fixing merge conflict * fixing the checks * adding reference to the example * fixing the checks error * fixing the example validation * running prettier Co-authored-by: Hyonho Lee <Hyonho.Lee@microsoft.com> Co-authored-by: Sirajudeen Sahul Hameed <sirajs@microsoft.com> * Revert the breaking change * Adding DisallowedConfiguration property to VirtualMachineImageProperties (Azure#9520) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties Co-authored-by: Hyonho Lee <Hyonho.Lee@microsoft.com> Co-authored-by: Hyonho Lee <hylee@microsoft.com> * Added SecurityProfile to support Host Encryption for VM and Scaleset resources - Changes reviewed in PR: 9366 (Azure#9666) * Preparatory commit for compute 2020-06-01 API version * updated swagger * updated swagger * fixed the prettier issues * updated the documentation' * Preparatory commit for compute 2020-06-01 API version * resolved * updated code * resolved conflicts * udpated comments * updated code * resolved prettier fix Co-authored-by: Hyonho Lee <Hyonho.Lee@microsoft.com> * Adding new RetrieveBootDiagnosticsData.POST API. VM/VMSS managed boot diagnostics changes with examples. (Azure#9460) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (Azure#9065) * managed boot diagnostics changes. * Add new lines to the EOF. * Adding missing response schema. * Preparatory commit for compute 2020-06-01 API version * Adding default error response. * Review comments. * Remove extra comma Co-authored-by: Hyonho Lee <Hyonho.Lee@microsoft.com> Co-authored-by: Sirajudeen Sahul Hameed <sirajs@microsoft.com> Co-authored-by: Avinash Akka <avakka@microsoft.com> * Addressing minor corrections in examples related PR#9460 (Azure#9685) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (Azure#9065) * managed boot diagnostics changes. * Add new lines to the EOF. * Adding missing response schema. * Preparatory commit for compute 2020-06-01 API version * Adding default error response. * Review comments. * Remove extra comma * Addressing pending review changes. Co-authored-by: Hyonho Lee <Hyonho.Lee@microsoft.com> Co-authored-by: Sirajudeen Sahul Hameed <sirajs@microsoft.com> Co-authored-by: Avinash Akka <avakka@microsoft.com> * Add AssessPatches API (Azure#9275) * Initial commit with updates to compute.json for assessPatches and softwarePatches * Add VirtualMachinesAssessPatches.json * Fix minor issues with softwarePatches * Updates to correct the example per oav * Remove GET and LIST softwarePatches * Remove unneeded list result * update description strings * Add kbid to spell check list. Include Prettier formating changes. * Update SoftwarePatch.InstallationState to AssessmentState * Remove extra properties from patch object array * Fix name of PublishedDate * Add generic error response * Add readonly, make rebootPending a boolean again * Remove LastModifiedDateTime from result object * Adding ExtensionsTimeBudget to new Api Version (Azure#9319) * fixing encoding (+2 squashed commit) Squashed commit: [e73eef7] Prettier [68d011b] adding 201 response (+1 squashed commits) Squashed commits: [83f71bb48] Adding references (+1 squashed commits) Squashed commits: [d8ed894] updating GET example (+1 squashed commits) Squashed commits: [61920933d] fix (+1 squashed commits) Squashed commits: [f0151eb78] updated with extensionsTimeBudget * fixing file name Co-authored-by: Hyonho Lee <hylee@microsoft.com> * Changes related to dedicated host group automatic placement (Azure#9684) * Made changes for dedicated host group instance view * Added definitions for dedicated host group instance view * Made changes for SupportAutomaticPlacement * Made changes for assigned host * Made changes on properties.hostGroup * Added a missing comma * Addressed comments * Updated * Added assignedHost to VMScaleSetVMInstanceView * Addressed comments * Added minimum API version for assignedHost * Addressed comments * ModelAsString to false * Added exmples for VM * Added examples for VMSS * small fix * Addressed comments * Added missing parameter * Fixed examples * Add example for VMSS RunCommand (Azure#9875) Co-authored-by: Jemal Abdulkadir <jemex2627@gmail.com> Co-authored-by: Sirajudeen Sahul Hameed <sirajs@microsoft.com> Co-authored-by: hari-bodicherla <43284966+hari-bodicherla@users.noreply.github.com> Co-authored-by: Avinash <akka@usc.edu> Co-authored-by: Avinash Akka <avakka@microsoft.com> Co-authored-by: Mike Richmond <mirichmo@microsoft.com> Co-authored-by: kamusta-msft <56413142+kamusta-msft@users.noreply.github.com> Co-authored-by: dochung4 <40577926+dochung4@users.noreply.github.com> Co-authored-by: Atanas Koralski <koralski@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.