VirtualWan: Hubvnet Connection related changes #9536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyamshd
requested review from
MikhailTryakhov,
anton-evseev and
v-shhatt
as code owners
|
You don't have permission to trigger SDK Automation. |
|
Can one of the admins verify this patch? |
shyamshd
force-pushed
the
shdharma/deprecate_hubvnet_in_hub
branch
from
76e94e9
to
0ec481c
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-trenton
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go
|
azure-sdk-for-java
|
azure-sdk-for-js
|
azure-sdk-for-python
|
shyamshd
force-pushed
the
shdharma/deprecate_hubvnet_in_hub
branch
from
0ec481c
to
d9dda25
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced May 20, 2020
|
👍 : approved from vWan Team :) |
nagula-ritvika
approved these changes
May 20, 2020
anton-evseev
approved these changes
May 20, 2020
anton-evseev
added
the
WaitForARMFeedback
shyamshd
force-pushed
the
shdharma/deprecate_hubvnet_in_hub
branch
from
d9dda25
to
76b5090
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
Was this just for the allowHubToRemoteVnetTransit and allowRemoteVnetToUseHubVnetGateways flags? I could mark them deprecated and remove them later. That is not urgent, but I was making the change along with the others which are needed to address certain scenarios. Are you ok with the other changes? We were planning to make changes on powershell/azcli/portal etc. to absorb these changes along with the move to the new API version. I don't think we have direct consumers of the sdk. |
KrisBash
added
ARMSignedOff
|
@myronfanqiu @number213 Looks like some sdk generation in the pipeline timed out last time. How do I kick off the failed job again and/or what else is needed to merge this? |
1. Exposed direct PUT/DELETE APIs for hubvnet connections. This is the API expected to be used in the future by all consumers (direct rest api calls, powershell, portal, azure cli). This avoids needing a put on the virtual hub every time a hubvnet connection is to be added/changed. 2. Deprecate specifying hubvnet connection in virtualHub PUT. This is to avoid having multiple APIs to do the same thing. Also having this API introduces other complexities and breaks some scenarios. 3. Deprecate allowHubToRemoteVnetTransit and allowRemoteVnetToUseHubVnetGateways flags in hubvnet connection. These flags are maintained internally in the implementation and shouldn't be exposed to the user. For now, just mark it as such. Will be removed in later release.
shyamshd
force-pushed
the
shdharma/deprecate_hubvnet_in_hub
branch
from
76b5090
to
0ae19b5
Compare
[Staging] Swagger Validation Report️~[Staging] BreakingChange [Detail]Posted by Swagger Pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
It's a good point. For network service, each month would have a new api version. It's not a breaking change from swagger spec view since 2020-05-01 has not been released yet. For down stream SDKs, if the SDK supports multi apis like python, go or ruby. It's not breaking change. But for C#, it's definitely a breaking change. Meanwhile, it will have direct impact on our tooling. I agree with you that we should deprecate it first instead of removing it directly. |
I pushed a change last night to deprecate the flags instead of removing them.. Please let me know if this is ok. For the other changes, they are being absorbed in the tooling before the move to 2020-05-01 API. But they have a dependency on this change being merged and the sdk being available. Also, for some reason, which I can't quite understand the pipeline is still failing. |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 9536 in repo Azure/azure-rest-api-specs |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@allenjzhang @myronfanqiu @shyamshd isn't removing |
@number213 @myronfanqiu It is. But the old API versions should continue to work as before. Only consumers who move to the new 2020-05-01 API version would need to absorb the change. The change is needed sort of urgently to address certain scenarios where doing a PUT on the hub with vnet connections (to change other hub parameters) could cause the PUT on the hub to fail if the vnet connection spans multiple subscriptions and the user doesn't have permissions for the remote subscription. The change was run by the service PM & thought to be acceptable. The change is already being rolled out in NRP 2020-05-01. We'd need swagger and internal tooling changes (like powershell/azcli etc.) to keep the behavior consistent. |
|
@myronfanqiu please let me know if I need to do anything more from my side? |
mmyyrroonn
pushed a commit
to mmyyrroonn/azure-rest-api-specs
that referenced
this pull request
Jun 4, 2020
1. Exposed direct PUT/DELETE APIs for hubvnet connections. This is the API expected to be used in the future by all consumers (direct rest api calls, powershell, portal, azure cli). This avoids needing a put on the virtual hub every time a hubvnet connection is to be added/changed. 2. Deprecate specifying hubvnet connection in virtualHub PUT. This is to avoid having multiple APIs to do the same thing. Also having this API introduces other complexities and breaks some scenarios. 3. Deprecate allowHubToRemoteVnetTransit and allowRemoteVnetToUseHubVnetGateways flags in hubvnet connection. These flags are maintained internally in the implementation and shouldn't be exposed to the user. For now, just mark it as such. Will be removed in later release. Co-authored-by: Shyam Dharmarajan <shdharma@microsoft.com>
mmyyrroonn
pushed a commit
that referenced
this pull request
Jun 9, 2020
* Adds base for updating Microsoft.Network from version stable/2020-04-01 to version 2020-05-01 * Updates readme * Updates API version in new specs and examples * Add VirtualHubBgpConnections, VirtualHubIpConfigurations, NetworkVirtualApplianceSites child resources (#9357) * Adds base for updating Microsoft.Network from version stable/2020-03-01 to version 2020-05-01 * Updates readme * Updates API version in new specs and examples * Final changes * Fix formatting issues * Fix merge and formatting issues * Fix formatiing * Ipconfig properties * Fix build errors * Lint check * Fix semantics errors * Address review comments * Fix prettier and nextLink checks * Fix dots * Address errors * Fix Ipconfig version Co-authored-by: dexiang-ms <64503627+dexiang-ms@users.noreply.github.com> * Change NRP repo for validation scripts (#9394) * Move terminateTLS flag to ApplicationRuleCondition (#9539) * DNS Proxy support for Firewall Policy (#9461) * Adding DnsProxySettings Support in Firewall Policy dnsServers, dnsEnableProxy, dnsRequireProxyForNetworkRules are added as subproperties. * spell check * Removing DNS as prefix on sub properties. * Syntax error. * DnsProxySettings to DNSSettings * Fixing proxy settings name. Co-authored-by: Ishani Gupta <isgu@microsoft.com> * fix network (#9369) (#9547) * fix network * duplicated publicipprefix * fixed example in 2018-01-01 * final updates * missing examples (cherry picked from commit 42d9639) * Added new properties to ConnectivityHop (#9386) * Added new properties to ConnectivityHop * Fixed spelling * added x-ms-client-flatten to HopLink.properties.properties * Rename Firewall Policy child resource RuleGroup to RuleCollectionGroup (#9356) * Rename Firewall Policy child resource RuleGroup to RuleCollectionGroup * rebase with ti whitelist * rebase with ti whitelist * rebase with ti whitelist * prettier run * making nat rule into a collection * prettier run * Multiple Public IPs support for Azure Firewall in Virtual Hub (#9560) * multi pip for firewall in hub swagger change * resolving issues * VirtualWan: Hubvnet Connection related changes (#9536) 1. Exposed direct PUT/DELETE APIs for hubvnet connections. This is the API expected to be used in the future by all consumers (direct rest api calls, powershell, portal, azure cli). This avoids needing a put on the virtual hub every time a hubvnet connection is to be added/changed. 2. Deprecate specifying hubvnet connection in virtualHub PUT. This is to avoid having multiple APIs to do the same thing. Also having this API introduces other complexities and breaks some scenarios. 3. Deprecate allowHubToRemoteVnetTransit and allowRemoteVnetToUseHubVnetGateways flags in hubvnet connection. These flags are maintained internally in the implementation and shouldn't be exposed to the user. For now, just mark it as such. Will be removed in later release. Co-authored-by: Shyam Dharmarajan <shdharma@microsoft.com> * Destination FQDNs in FirewallPolicy for network rules. (#9609) * v1 * making boolean as nullable Co-authored-by: Ishani Gupta <isgu@microsoft.com> * VirtualHub : Add Routing State and expose Effective Routes Api (#9385) * Add Routing State and expose Effective Routes Api * updated opId name and added examples * prettier fix done * rename variable to prevent conflict * Updating VpnGateway examples for bgpSettings (#9656) * Updating VpnGateway examples * prettier Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * Application Gateway Private Link Support (#9490) * Application Gateway Private Link Support * Fix comments * Fix comments for including example * Add nvaSku property for NetworkVirtualAppliance (#9682) * code fixes for hubIPAddresses (#9775) * Fix lint errors (#9787) Co-authored-by: naveenchekuri <nachekur@microsoft.com> Co-authored-by: dexiang-ms <64503627+dexiang-ms@users.noreply.github.com> Co-authored-by: odedlaz <odedlaz@users.noreply.github.com> Co-authored-by: Ishani Gupta <ishani.gupta27.ig@gmail.com> Co-authored-by: Ishani Gupta <isgu@microsoft.com> Co-authored-by: Zim Kalinowski <zikalino@microsoft.com> Co-authored-by: irrogozh <irrogozh@microsoft.com> Co-authored-by: Sai Sujith Reddy Mankala <samankal@microsoft.com> Co-authored-by: Anchal Kapoor <anchalka@usc.edu> Co-authored-by: shyamshd <64368451+shyamshd@users.noreply.github.com> Co-authored-by: Shyam Dharmarajan <shdharma@microsoft.com> Co-authored-by: Ritvika Reddy Nagula <rinagula@microsoft.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> Co-authored-by: jaishals <jaishal.shah@gmail.com>
lirenhe
pushed a commit
that referenced
this pull request
Jul 14, 2020
* Adds base for updating Microsoft.Network from version stable/2020-04-01 to version 2020-05-01 * Updates readme * Updates API version in new specs and examples * Add VirtualHubBgpConnections, VirtualHubIpConfigurations, NetworkVirtualApplianceSites child resources (#9357) * Adds base for updating Microsoft.Network from version stable/2020-03-01 to version 2020-05-01 * Updates readme * Updates API version in new specs and examples * Final changes * Fix formatting issues * Fix merge and formatting issues * Fix formatiing * Ipconfig properties * Fix build errors * Lint check * Fix semantics errors * Address review comments * Fix prettier and nextLink checks * Fix dots * Address errors * Fix Ipconfig version Co-authored-by: dexiang-ms <64503627+dexiang-ms@users.noreply.github.com> * Change NRP repo for validation scripts (#9394) * Move terminateTLS flag to ApplicationRuleCondition (#9539) * DNS Proxy support for Firewall Policy (#9461) * Adding DnsProxySettings Support in Firewall Policy dnsServers, dnsEnableProxy, dnsRequireProxyForNetworkRules are added as subproperties. * spell check * Removing DNS as prefix on sub properties. * Syntax error. * DnsProxySettings to DNSSettings * Fixing proxy settings name. Co-authored-by: Ishani Gupta <isgu@microsoft.com> * fix network (#9369) (#9547) * fix network * duplicated publicipprefix * fixed example in 2018-01-01 * final updates * missing examples (cherry picked from commit 42d9639) * Added new properties to ConnectivityHop (#9386) * Added new properties to ConnectivityHop * Fixed spelling * added x-ms-client-flatten to HopLink.properties.properties * Rename Firewall Policy child resource RuleGroup to RuleCollectionGroup (#9356) * Rename Firewall Policy child resource RuleGroup to RuleCollectionGroup * rebase with ti whitelist * rebase with ti whitelist * rebase with ti whitelist * prettier run * making nat rule into a collection * prettier run * Multiple Public IPs support for Azure Firewall in Virtual Hub (#9560) * multi pip for firewall in hub swagger change * resolving issues * VirtualWan: Hubvnet Connection related changes (#9536) 1. Exposed direct PUT/DELETE APIs for hubvnet connections. This is the API expected to be used in the future by all consumers (direct rest api calls, powershell, portal, azure cli). This avoids needing a put on the virtual hub every time a hubvnet connection is to be added/changed. 2. Deprecate specifying hubvnet connection in virtualHub PUT. This is to avoid having multiple APIs to do the same thing. Also having this API introduces other complexities and breaks some scenarios. 3. Deprecate allowHubToRemoteVnetTransit and allowRemoteVnetToUseHubVnetGateways flags in hubvnet connection. These flags are maintained internally in the implementation and shouldn't be exposed to the user. For now, just mark it as such. Will be removed in later release. Co-authored-by: Shyam Dharmarajan <shdharma@microsoft.com> * Destination FQDNs in FirewallPolicy for network rules. (#9609) * v1 * making boolean as nullable Co-authored-by: Ishani Gupta <isgu@microsoft.com> * VirtualHub : Add Routing State and expose Effective Routes Api (#9385) * Add Routing State and expose Effective Routes Api * updated opId name and added examples * prettier fix done * rename variable to prevent conflict * Updating VpnGateway examples for bgpSettings (#9656) * Updating VpnGateway examples * prettier Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * Application Gateway Private Link Support (#9490) * Application Gateway Private Link Support * Fix comments * Fix comments for including example * add byoip resources and examples * add resources to readme and update version * fix path * fix validation errors and remove roaExpirationDate * remove swagger files to change name * add the changed file names back * remove to change name * re-add changed name * remove to change name * re-add changed name * remove swagger files to change name * re-add changed name * fix merge conflicts * more merge conflicts * move to june 2020 api version * add default response to operations * fix tab/space discrepancy * fix path names and remove the public ip address version property from mastercustomipprefix * fix camelCase in paths * add acronyms to custom words * fix another camelcase offender * validation check fixes * fix some more model validation issues * fix json formatting * remove invalid property * set readonly on etag, fix paths in examples * fix enum error * fix network validation errors * more naming naming convention changes * change mastercustomipprefix reference from string to subresource * fix spelling error * added patch api to tags update * minor fix * prettier check * minor change to force pipeline again * minor description updates * remove geography property in masterCustomIpPrefix * add customIpPrefix property to publicIpPrefix Co-authored-by: Anton Evseev <anton.evseev@protonmail.com> Co-authored-by: naveenchekuri <nachekur@microsoft.com> Co-authored-by: Anton Evseev <v-anevse@microsoft.com> Co-authored-by: odedlaz <odedlaz@users.noreply.github.com> Co-authored-by: Ishani Gupta <ishani.gupta27.ig@gmail.com> Co-authored-by: Ishani Gupta <isgu@microsoft.com> Co-authored-by: Zim Kalinowski <zikalino@microsoft.com> Co-authored-by: irrogozh <irrogozh@microsoft.com> Co-authored-by: Sai Sujith Reddy Mankala <samankal@microsoft.com> Co-authored-by: Anchal Kapoor <anchalka@usc.edu> Co-authored-by: shyamshd <64368451+shyamshd@users.noreply.github.com> Co-authored-by: Shyam Dharmarajan <shdharma@microsoft.com> Co-authored-by: Ritvika Reddy Nagula <rinagula@microsoft.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> Co-authored-by: jaishals <jaishal.shah@gmail.com>
akning-ms
pushed a commit
that referenced
this pull request
Aug 12, 2020
* Adds base for updating Microsoft.Network from version stable/2020-05-01 to version 2020-06-01 * Updates readme * Updates API version in new specs and examples * New vWAN resource properties (#9722) * retarget * fixed duplicate * Added code changes for generating letter of authorization (#9829) Co-authored-by: Umesh Kanodia <umkanodi@microsoft.com> * Async PATCH operations for Virtual WAN VpnGateways and P2SVpnGateways (#9833) * Add remoteBgpCommunities to VirtualNetworkPeering resource (#9814) * Add remoteBgpCommunities to VirtualNetworkPeering resource * Change VirtualNetworkCommunity in example VirtualNetworkCreateWithBgpCommunities.json to a value that is within the allowed range. * Application Gateway Mutual Authentication Support (#9965) * Adding mutual auth api definitions. * Adding examples. * Fixing case. Co-authored-by: Hemant Imudianda <heimudia@microsoft.com> * Added PATCH flowLog API and example (#9960) * Added PATCH flowLog API and example * Fixed example * Added property to TCPConfiguration * Fixed prettier warning * Fixes based on CR * Add new optional param enableInternetSecurity and new Reset API for P2SVpnGateway resource (#9952) * Add new optional param enableInternetSecurity and new Reset API for P2SVpnGateway resource * Fix validation tool fixes * Remove extra spaces * Update Network's owners (#10006) * Add intrusion system configuration (#9912) * Add intrusion system configuration * Add ignored traffic configuration * Fix checkPirvateLinkServiceVisibility in 2020-06-01 (#9821) * fix checkPirvateLinkServiceVisibility in 2020-06-01 * update examples * add VpnGatewaypacketCapture api (#9832) * add VpnGatewaypacketCapture api * add custom words * add vpn connection packet capture * fix naming errors * fix error * fix word * fixing validation * fix model error * finish prettier * fix test * expressRouteProviderPort changes (#9909) * expressRouteProviderPort changes * fix ref error * suppressing name id type error * prettier fix * locationlist -> listbylocation * adding filter on location * ref listbylocation * fixing id and name * adding get and bug fixes * bug fix * bug fix * adding proxy resource ref * fixes for auto checks * adding proxyresource type to network.json * fixing description * fixing description for proxy resource * Adding swagger updates to support the new NRP resource "DSCP Configuration" (#9954) * Adding the swagger for the new resource DSCP Configuration. Also updated the Network Interface to return it with its get function * Updated the definition to the updated version in the source code * Fix some errors being thrown by the validator (regarding int/ushort typing). Updated the readme.md to include the dscpConfiguration file * Fixed the erroneous reference within the dscpConfiguration.json to the NetworkInterface definition * Removed the long running operation flag. Updated the examples to return two markings * Added more objets within the lists. * Removed the duplicated key * The type 'ushort ' is not accepted. Turn it into an integer. Hopefully this fixes the issue regarding the QosPortRange properties * Added the custome words dscp and qos in order to fix the error of the words being unkown. Refactor the allocatedNetworkInterfaces to associatedNetworkInterfaces to match the examples with the specification. Removed the QosTrafficProfiler from the examples as it no longer exists. Made sure the delete is using dscpName rather than nicName. Added the period at the end of the description. * One traffic profiler slipped through the cracks, removed it. Properly formatted the object for the Qos Port/IP ranges. Was placing a string rather than an integer in the get example. * Well, I was being silly here. Had a typo hahahahaha * Added the warning suppression to the readme file. Run the prettier on the specification * Thought I only had to run the prettier on the specification. Did the same for the examples and the NetworkInterfaceGet.json. * Re-run the command with the full command placed in the documentation. Hopefully this fixes the prettier errors * Corrected the typo * Added the proper formatting for the suppression. * Added the integer format * Added the api calls for list and list all. Made sure the name is plural Added the examples for the new api calls In Network Interface, now it is using the ID of the DSCP configuration rather than the full payload * Forgot to switch the operation id from network interface to dscp configuration * Added the missing next link for the list by resource Co-authored-by: David Velasco <davelasc@microsoft.com> Co-authored-by: MyronFanQiu <49134743+MyronFanQiu@users.noreply.github.com> * Dev/dexiang/byoip (#9818) * Adds base for updating Microsoft.Network from version stable/2020-04-01 to version 2020-05-01 * Updates readme * Updates API version in new specs and examples * Add VirtualHubBgpConnections, VirtualHubIpConfigurations, NetworkVirtualApplianceSites child resources (#9357) * Adds base for updating Microsoft.Network from version stable/2020-03-01 to version 2020-05-01 * Updates readme * Updates API version in new specs and examples * Final changes * Fix formatting issues * Fix merge and formatting issues * Fix formatiing * Ipconfig properties * Fix build errors * Lint check * Fix semantics errors * Address review comments * Fix prettier and nextLink checks * Fix dots * Address errors * Fix Ipconfig version Co-authored-by: dexiang-ms <64503627+dexiang-ms@users.noreply.github.com> * Change NRP repo for validation scripts (#9394) * Move terminateTLS flag to ApplicationRuleCondition (#9539) * DNS Proxy support for Firewall Policy (#9461) * Adding DnsProxySettings Support in Firewall Policy dnsServers, dnsEnableProxy, dnsRequireProxyForNetworkRules are added as subproperties. * spell check * Removing DNS as prefix on sub properties. * Syntax error. * DnsProxySettings to DNSSettings * Fixing proxy settings name. Co-authored-by: Ishani Gupta <isgu@microsoft.com> * fix network (#9369) (#9547) * fix network * duplicated publicipprefix * fixed example in 2018-01-01 * final updates * missing examples (cherry picked from commit 42d9639) * Added new properties to ConnectivityHop (#9386) * Added new properties to ConnectivityHop * Fixed spelling * added x-ms-client-flatten to HopLink.properties.properties * Rename Firewall Policy child resource RuleGroup to RuleCollectionGroup (#9356) * Rename Firewall Policy child resource RuleGroup to RuleCollectionGroup * rebase with ti whitelist * rebase with ti whitelist * rebase with ti whitelist * prettier run * making nat rule into a collection * prettier run * Multiple Public IPs support for Azure Firewall in Virtual Hub (#9560) * multi pip for firewall in hub swagger change * resolving issues * VirtualWan: Hubvnet Connection related changes (#9536) 1. Exposed direct PUT/DELETE APIs for hubvnet connections. This is the API expected to be used in the future by all consumers (direct rest api calls, powershell, portal, azure cli). This avoids needing a put on the virtual hub every time a hubvnet connection is to be added/changed. 2. Deprecate specifying hubvnet connection in virtualHub PUT. This is to avoid having multiple APIs to do the same thing. Also having this API introduces other complexities and breaks some scenarios. 3. Deprecate allowHubToRemoteVnetTransit and allowRemoteVnetToUseHubVnetGateways flags in hubvnet connection. These flags are maintained internally in the implementation and shouldn't be exposed to the user. For now, just mark it as such. Will be removed in later release. Co-authored-by: Shyam Dharmarajan <shdharma@microsoft.com> * Destination FQDNs in FirewallPolicy for network rules. (#9609) * v1 * making boolean as nullable Co-authored-by: Ishani Gupta <isgu@microsoft.com> * VirtualHub : Add Routing State and expose Effective Routes Api (#9385) * Add Routing State and expose Effective Routes Api * updated opId name and added examples * prettier fix done * rename variable to prevent conflict * Updating VpnGateway examples for bgpSettings (#9656) * Updating VpnGateway examples * prettier Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * Application Gateway Private Link Support (#9490) * Application Gateway Private Link Support * Fix comments * Fix comments for including example * add byoip resources and examples * add resources to readme and update version * fix path * fix validation errors and remove roaExpirationDate * remove swagger files to change name * add the changed file names back * remove to change name * re-add changed name * remove to change name * re-add changed name * remove swagger files to change name * re-add changed name * fix merge conflicts * more merge conflicts * move to june 2020 api version * add default response to operations * fix tab/space discrepancy * fix path names and remove the public ip address version property from mastercustomipprefix * fix camelCase in paths * add acronyms to custom words * fix another camelcase offender * validation check fixes * fix some more model validation issues * fix json formatting * remove invalid property * set readonly on etag, fix paths in examples * fix enum error * fix network validation errors * more naming naming convention changes * change mastercustomipprefix reference from string to subresource * fix spelling error * added patch api to tags update * minor fix * prettier check * minor change to force pipeline again * minor description updates * remove geography property in masterCustomIpPrefix * add customIpPrefix property to publicIpPrefix Co-authored-by: Anton Evseev <anton.evseev@protonmail.com> Co-authored-by: naveenchekuri <nachekur@microsoft.com> Co-authored-by: Anton Evseev <v-anevse@microsoft.com> Co-authored-by: odedlaz <odedlaz@users.noreply.github.com> Co-authored-by: Ishani Gupta <ishani.gupta27.ig@gmail.com> Co-authored-by: Ishani Gupta <isgu@microsoft.com> Co-authored-by: Zim Kalinowski <zikalino@microsoft.com> Co-authored-by: irrogozh <irrogozh@microsoft.com> Co-authored-by: Sai Sujith Reddy Mankala <samankal@microsoft.com> Co-authored-by: Anchal Kapoor <anchalka@usc.edu> Co-authored-by: shyamshd <64368451+shyamshd@users.noreply.github.com> Co-authored-by: Shyam Dharmarajan <shdharma@microsoft.com> Co-authored-by: Ritvika Reddy Nagula <rinagula@microsoft.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> Co-authored-by: jaishals <jaishal.shah@gmail.com> * fix the description (#10151) * Add support for addressprefix in NVA and enableVirtualRouterRouteProp… (#10153) * Added O365Policy to VpnSite resource. (#10192) Co-authored-by: Neel Bhavsar <nebhavsa@microsoft.com> * Added new properties to connection monitor endpoint (#10197) * Added new properties to connection monitor endpoint * Updated description of endpointScopeItem * MACsec Configuration Edits (#10181) * Add xpn aes cipher values & rm dashes * Add sci mode param to macsec * remove readonly attribute from customIpPrefix commissionedState property (#10246) * fixing ids in examples (#10221) * Merge branch 'network-june-release' of https://github.com/adgrieve/azure-rest-api-specs into network-june-release (#10069) * Network june release revert - reverting changes which are not deployed from NRP side yet. (#10325) * reverting providerport changes * fixing bug * Remove masterCustomIpPrefix resource from Network-June-Release (does not affect current master branch) (#10338) * remove masterCustomIpPrefix resource * delete the MasterCustomIpPrefix swagger examples Co-authored-by: Anton Evseev <anton.evseev@protonmail.com> Co-authored-by: Henry Chen <henche@microsoft.com> Co-authored-by: Umesh Kanodia <61820145+umkanodi@users.noreply.github.com> Co-authored-by: Umesh Kanodia <umkanodi@microsoft.com> Co-authored-by: ritwikbasu <ritwikbasu@users.noreply.github.com> Co-authored-by: Jesus Arango <jesus.arango@gmail.com> Co-authored-by: Hemant Imudianda <hemant.imudianda@apcera.com> Co-authored-by: Hemant Imudianda <heimudia@microsoft.com> Co-authored-by: irrogozh <irrogozh@microsoft.com> Co-authored-by: Nilambari <nilamd@microsoft.com> Co-authored-by: Anton Evseev <v-anevse@microsoft.com> Co-authored-by: adgrieve <62692874+adgrieve@users.noreply.github.com> Co-authored-by: Kaihui (Kerwin) Sun <sunkaihuisos@gmail.com> Co-authored-by: tyrannicrex <jiaczh@microsoft.com> Co-authored-by: dagoutha <64456132+dagoutha@users.noreply.github.com> Co-authored-by: David Velasco <velascos.davida@gmail.com> Co-authored-by: David Velasco <davelasc@microsoft.com> Co-authored-by: MyronFanQiu <49134743+MyronFanQiu@users.noreply.github.com> Co-authored-by: dexiang-ms <64503627+dexiang-ms@users.noreply.github.com> Co-authored-by: naveenchekuri <nachekur@microsoft.com> Co-authored-by: odedlaz <odedlaz@users.noreply.github.com> Co-authored-by: Ishani Gupta <ishani.gupta27.ig@gmail.com> Co-authored-by: Ishani Gupta <isgu@microsoft.com> Co-authored-by: Zim Kalinowski <zikalino@microsoft.com> Co-authored-by: Sai Sujith Reddy Mankala <samankal@microsoft.com> Co-authored-by: Anchal Kapoor <anchalka@usc.edu> Co-authored-by: shyamshd <64368451+shyamshd@users.noreply.github.com> Co-authored-by: Shyam Dharmarajan <shdharma@microsoft.com> Co-authored-by: Ritvika Reddy Nagula <rinagula@microsoft.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> Co-authored-by: jaishals <jaishal.shah@gmail.com> Co-authored-by: Anchal Kapoor <ankapoo@microsoft.com> Co-authored-by: Neel <neel.bhavsar@protonmail.com> Co-authored-by: Neel Bhavsar <nebhavsa@microsoft.com> Co-authored-by: francescanarea <francesca@Narea.com>
innosam
pushed a commit
to innosam/azure-rest-api-specs
that referenced
this pull request
Aug 17, 2020
* Adds base for updating Microsoft.Network from version stable/2020-05-01 to version 2020-06-01 * Updates readme * Updates API version in new specs and examples * New vWAN resource properties (Azure#9722) * retarget * fixed duplicate * Added code changes for generating letter of authorization (Azure#9829) Co-authored-by: Umesh Kanodia <umkanodi@microsoft.com> * Async PATCH operations for Virtual WAN VpnGateways and P2SVpnGateways (Azure#9833) * Add remoteBgpCommunities to VirtualNetworkPeering resource (Azure#9814) * Add remoteBgpCommunities to VirtualNetworkPeering resource * Change VirtualNetworkCommunity in example VirtualNetworkCreateWithBgpCommunities.json to a value that is within the allowed range. * Application Gateway Mutual Authentication Support (Azure#9965) * Adding mutual auth api definitions. * Adding examples. * Fixing case. Co-authored-by: Hemant Imudianda <heimudia@microsoft.com> * Added PATCH flowLog API and example (Azure#9960) * Added PATCH flowLog API and example * Fixed example * Added property to TCPConfiguration * Fixed prettier warning * Fixes based on CR * Add new optional param enableInternetSecurity and new Reset API for P2SVpnGateway resource (Azure#9952) * Add new optional param enableInternetSecurity and new Reset API for P2SVpnGateway resource * Fix validation tool fixes * Remove extra spaces * Update Network's owners (Azure#10006) * Add intrusion system configuration (Azure#9912) * Add intrusion system configuration * Add ignored traffic configuration * Fix checkPirvateLinkServiceVisibility in 2020-06-01 (Azure#9821) * fix checkPirvateLinkServiceVisibility in 2020-06-01 * update examples * add VpnGatewaypacketCapture api (Azure#9832) * add VpnGatewaypacketCapture api * add custom words * add vpn connection packet capture * fix naming errors * fix error * fix word * fixing validation * fix model error * finish prettier * fix test * expressRouteProviderPort changes (Azure#9909) * expressRouteProviderPort changes * fix ref error * suppressing name id type error * prettier fix * locationlist -> listbylocation * adding filter on location * ref listbylocation * fixing id and name * adding get and bug fixes * bug fix * bug fix * adding proxy resource ref * fixes for auto checks * adding proxyresource type to network.json * fixing description * fixing description for proxy resource * Adding swagger updates to support the new NRP resource "DSCP Configuration" (Azure#9954) * Adding the swagger for the new resource DSCP Configuration. Also updated the Network Interface to return it with its get function * Updated the definition to the updated version in the source code * Fix some errors being thrown by the validator (regarding int/ushort typing). Updated the readme.md to include the dscpConfiguration file * Fixed the erroneous reference within the dscpConfiguration.json to the NetworkInterface definition * Removed the long running operation flag. Updated the examples to return two markings * Added more objets within the lists. * Removed the duplicated key * The type 'ushort ' is not accepted. Turn it into an integer. Hopefully this fixes the issue regarding the QosPortRange properties * Added the custome words dscp and qos in order to fix the error of the words being unkown. Refactor the allocatedNetworkInterfaces to associatedNetworkInterfaces to match the examples with the specification. Removed the QosTrafficProfiler from the examples as it no longer exists. Made sure the delete is using dscpName rather than nicName. Added the period at the end of the description. * One traffic profiler slipped through the cracks, removed it. Properly formatted the object for the Qos Port/IP ranges. Was placing a string rather than an integer in the get example. * Well, I was being silly here. Had a typo hahahahaha * Added the warning suppression to the readme file. Run the prettier on the specification * Thought I only had to run the prettier on the specification. Did the same for the examples and the NetworkInterfaceGet.json. * Re-run the command with the full command placed in the documentation. Hopefully this fixes the prettier errors * Corrected the typo * Added the proper formatting for the suppression. * Added the integer format * Added the api calls for list and list all. Made sure the name is plural Added the examples for the new api calls In Network Interface, now it is using the ID of the DSCP configuration rather than the full payload * Forgot to switch the operation id from network interface to dscp configuration * Added the missing next link for the list by resource Co-authored-by: David Velasco <davelasc@microsoft.com> Co-authored-by: MyronFanQiu <49134743+MyronFanQiu@users.noreply.github.com> * Dev/dexiang/byoip (Azure#9818) * Adds base for updating Microsoft.Network from version stable/2020-04-01 to version 2020-05-01 * Updates readme * Updates API version in new specs and examples * Add VirtualHubBgpConnections, VirtualHubIpConfigurations, NetworkVirtualApplianceSites child resources (Azure#9357) * Adds base for updating Microsoft.Network from version stable/2020-03-01 to version 2020-05-01 * Updates readme * Updates API version in new specs and examples * Final changes * Fix formatting issues * Fix merge and formatting issues * Fix formatiing * Ipconfig properties * Fix build errors * Lint check * Fix semantics errors * Address review comments * Fix prettier and nextLink checks * Fix dots * Address errors * Fix Ipconfig version Co-authored-by: dexiang-ms <64503627+dexiang-ms@users.noreply.github.com> * Change NRP repo for validation scripts (Azure#9394) * Move terminateTLS flag to ApplicationRuleCondition (Azure#9539) * DNS Proxy support for Firewall Policy (Azure#9461) * Adding DnsProxySettings Support in Firewall Policy dnsServers, dnsEnableProxy, dnsRequireProxyForNetworkRules are added as subproperties. * spell check * Removing DNS as prefix on sub properties. * Syntax error. * DnsProxySettings to DNSSettings * Fixing proxy settings name. Co-authored-by: Ishani Gupta <isgu@microsoft.com> * fix network (Azure#9369) (Azure#9547) * fix network * duplicated publicipprefix * fixed example in 2018-01-01 * final updates * missing examples (cherry picked from commit 42d9639) * Added new properties to ConnectivityHop (Azure#9386) * Added new properties to ConnectivityHop * Fixed spelling * added x-ms-client-flatten to HopLink.properties.properties * Rename Firewall Policy child resource RuleGroup to RuleCollectionGroup (Azure#9356) * Rename Firewall Policy child resource RuleGroup to RuleCollectionGroup * rebase with ti whitelist * rebase with ti whitelist * rebase with ti whitelist * prettier run * making nat rule into a collection * prettier run * Multiple Public IPs support for Azure Firewall in Virtual Hub (Azure#9560) * multi pip for firewall in hub swagger change * resolving issues * VirtualWan: Hubvnet Connection related changes (Azure#9536) 1. Exposed direct PUT/DELETE APIs for hubvnet connections. This is the API expected to be used in the future by all consumers (direct rest api calls, powershell, portal, azure cli). This avoids needing a put on the virtual hub every time a hubvnet connection is to be added/changed. 2. Deprecate specifying hubvnet connection in virtualHub PUT. This is to avoid having multiple APIs to do the same thing. Also having this API introduces other complexities and breaks some scenarios. 3. Deprecate allowHubToRemoteVnetTransit and allowRemoteVnetToUseHubVnetGateways flags in hubvnet connection. These flags are maintained internally in the implementation and shouldn't be exposed to the user. For now, just mark it as such. Will be removed in later release. Co-authored-by: Shyam Dharmarajan <shdharma@microsoft.com> * Destination FQDNs in FirewallPolicy for network rules. (Azure#9609) * v1 * making boolean as nullable Co-authored-by: Ishani Gupta <isgu@microsoft.com> * VirtualHub : Add Routing State and expose Effective Routes Api (Azure#9385) * Add Routing State and expose Effective Routes Api * updated opId name and added examples * prettier fix done * rename variable to prevent conflict * Updating VpnGateway examples for bgpSettings (Azure#9656) * Updating VpnGateway examples * prettier Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * Application Gateway Private Link Support (Azure#9490) * Application Gateway Private Link Support * Fix comments * Fix comments for including example * add byoip resources and examples * add resources to readme and update version * fix path * fix validation errors and remove roaExpirationDate * remove swagger files to change name * add the changed file names back * remove to change name * re-add changed name * remove to change name * re-add changed name * remove swagger files to change name * re-add changed name * fix merge conflicts * more merge conflicts * move to june 2020 api version * add default response to operations * fix tab/space discrepancy * fix path names and remove the public ip address version property from mastercustomipprefix * fix camelCase in paths * add acronyms to custom words * fix another camelcase offender * validation check fixes * fix some more model validation issues * fix json formatting * remove invalid property * set readonly on etag, fix paths in examples * fix enum error * fix network validation errors * more naming naming convention changes * change mastercustomipprefix reference from string to subresource * fix spelling error * added patch api to tags update * minor fix * prettier check * minor change to force pipeline again * minor description updates * remove geography property in masterCustomIpPrefix * add customIpPrefix property to publicIpPrefix Co-authored-by: Anton Evseev <anton.evseev@protonmail.com> Co-authored-by: naveenchekuri <nachekur@microsoft.com> Co-authored-by: Anton Evseev <v-anevse@microsoft.com> Co-authored-by: odedlaz <odedlaz@users.noreply.github.com> Co-authored-by: Ishani Gupta <ishani.gupta27.ig@gmail.com> Co-authored-by: Ishani Gupta <isgu@microsoft.com> Co-authored-by: Zim Kalinowski <zikalino@microsoft.com> Co-authored-by: irrogozh <irrogozh@microsoft.com> Co-authored-by: Sai Sujith Reddy Mankala <samankal@microsoft.com> Co-authored-by: Anchal Kapoor <anchalka@usc.edu> Co-authored-by: shyamshd <64368451+shyamshd@users.noreply.github.com> Co-authored-by: Shyam Dharmarajan <shdharma@microsoft.com> Co-authored-by: Ritvika Reddy Nagula <rinagula@microsoft.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> Co-authored-by: jaishals <jaishal.shah@gmail.com> * fix the description (Azure#10151) * Add support for addressprefix in NVA and enableVirtualRouterRouteProp… (Azure#10153) * Added O365Policy to VpnSite resource. (Azure#10192) Co-authored-by: Neel Bhavsar <nebhavsa@microsoft.com> * Added new properties to connection monitor endpoint (Azure#10197) * Added new properties to connection monitor endpoint * Updated description of endpointScopeItem * MACsec Configuration Edits (Azure#10181) * Add xpn aes cipher values & rm dashes * Add sci mode param to macsec * remove readonly attribute from customIpPrefix commissionedState property (Azure#10246) * fixing ids in examples (Azure#10221) * Merge branch 'network-june-release' of https://github.com/adgrieve/azure-rest-api-specs into network-june-release (Azure#10069) * Network june release revert - reverting changes which are not deployed from NRP side yet. (Azure#10325) * reverting providerport changes * fixing bug * Remove masterCustomIpPrefix resource from Network-June-Release (does not affect current master branch) (Azure#10338) * remove masterCustomIpPrefix resource * delete the MasterCustomIpPrefix swagger examples Co-authored-by: Anton Evseev <anton.evseev@protonmail.com> Co-authored-by: Henry Chen <henche@microsoft.com> Co-authored-by: Umesh Kanodia <61820145+umkanodi@users.noreply.github.com> Co-authored-by: Umesh Kanodia <umkanodi@microsoft.com> Co-authored-by: ritwikbasu <ritwikbasu@users.noreply.github.com> Co-authored-by: Jesus Arango <jesus.arango@gmail.com> Co-authored-by: Hemant Imudianda <hemant.imudianda@apcera.com> Co-authored-by: Hemant Imudianda <heimudia@microsoft.com> Co-authored-by: irrogozh <irrogozh@microsoft.com> Co-authored-by: Nilambari <nilamd@microsoft.com> Co-authored-by: Anton Evseev <v-anevse@microsoft.com> Co-authored-by: adgrieve <62692874+adgrieve@users.noreply.github.com> Co-authored-by: Kaihui (Kerwin) Sun <sunkaihuisos@gmail.com> Co-authored-by: tyrannicrex <jiaczh@microsoft.com> Co-authored-by: dagoutha <64456132+dagoutha@users.noreply.github.com> Co-authored-by: David Velasco <velascos.davida@gmail.com> Co-authored-by: David Velasco <davelasc@microsoft.com> Co-authored-by: MyronFanQiu <49134743+MyronFanQiu@users.noreply.github.com> Co-authored-by: dexiang-ms <64503627+dexiang-ms@users.noreply.github.com> Co-authored-by: naveenchekuri <nachekur@microsoft.com> Co-authored-by: odedlaz <odedlaz@users.noreply.github.com> Co-authored-by: Ishani Gupta <ishani.gupta27.ig@gmail.com> Co-authored-by: Ishani Gupta <isgu@microsoft.com> Co-authored-by: Zim Kalinowski <zikalino@microsoft.com> Co-authored-by: Sai Sujith Reddy Mankala <samankal@microsoft.com> Co-authored-by: Anchal Kapoor <anchalka@usc.edu> Co-authored-by: shyamshd <64368451+shyamshd@users.noreply.github.com> Co-authored-by: Shyam Dharmarajan <shdharma@microsoft.com> Co-authored-by: Ritvika Reddy Nagula <rinagula@microsoft.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> Co-authored-by: jaishals <jaishal.shah@gmail.com> Co-authored-by: Anchal Kapoor <ankapoo@microsoft.com> Co-authored-by: Neel <neel.bhavsar@protonmail.com> Co-authored-by: Neel Bhavsar <nebhavsa@microsoft.com> Co-authored-by: francescanarea <francesca@Narea.com>
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
* Adds base for updating Microsoft.Network from version stable/2020-04-01 to version 2020-05-01 * Updates readme * Updates API version in new specs and examples * Add VirtualHubBgpConnections, VirtualHubIpConfigurations, NetworkVirtualApplianceSites child resources (Azure#9357) * Adds base for updating Microsoft.Network from version stable/2020-03-01 to version 2020-05-01 * Updates readme * Updates API version in new specs and examples * Final changes * Fix formatting issues * Fix merge and formatting issues * Fix formatiing * Ipconfig properties * Fix build errors * Lint check * Fix semantics errors * Address review comments * Fix prettier and nextLink checks * Fix dots * Address errors * Fix Ipconfig version Co-authored-by: dexiang-ms <64503627+dexiang-ms@users.noreply.github.com> * Change NRP repo for validation scripts (Azure#9394) * Move terminateTLS flag to ApplicationRuleCondition (Azure#9539) * DNS Proxy support for Firewall Policy (Azure#9461) * Adding DnsProxySettings Support in Firewall Policy dnsServers, dnsEnableProxy, dnsRequireProxyForNetworkRules are added as subproperties. * spell check * Removing DNS as prefix on sub properties. * Syntax error. * DnsProxySettings to DNSSettings * Fixing proxy settings name. Co-authored-by: Ishani Gupta <isgu@microsoft.com> * fix network (Azure#9369) (Azure#9547) * fix network * duplicated publicipprefix * fixed example in 2018-01-01 * final updates * missing examples (cherry picked from commit 42d9639) * Added new properties to ConnectivityHop (Azure#9386) * Added new properties to ConnectivityHop * Fixed spelling * added x-ms-client-flatten to HopLink.properties.properties * Rename Firewall Policy child resource RuleGroup to RuleCollectionGroup (Azure#9356) * Rename Firewall Policy child resource RuleGroup to RuleCollectionGroup * rebase with ti whitelist * rebase with ti whitelist * rebase with ti whitelist * prettier run * making nat rule into a collection * prettier run * Multiple Public IPs support for Azure Firewall in Virtual Hub (Azure#9560) * multi pip for firewall in hub swagger change * resolving issues * VirtualWan: Hubvnet Connection related changes (Azure#9536) 1. Exposed direct PUT/DELETE APIs for hubvnet connections. This is the API expected to be used in the future by all consumers (direct rest api calls, powershell, portal, azure cli). This avoids needing a put on the virtual hub every time a hubvnet connection is to be added/changed. 2. Deprecate specifying hubvnet connection in virtualHub PUT. This is to avoid having multiple APIs to do the same thing. Also having this API introduces other complexities and breaks some scenarios. 3. Deprecate allowHubToRemoteVnetTransit and allowRemoteVnetToUseHubVnetGateways flags in hubvnet connection. These flags are maintained internally in the implementation and shouldn't be exposed to the user. For now, just mark it as such. Will be removed in later release. Co-authored-by: Shyam Dharmarajan <shdharma@microsoft.com> * Destination FQDNs in FirewallPolicy for network rules. (Azure#9609) * v1 * making boolean as nullable Co-authored-by: Ishani Gupta <isgu@microsoft.com> * VirtualHub : Add Routing State and expose Effective Routes Api (Azure#9385) * Add Routing State and expose Effective Routes Api * updated opId name and added examples * prettier fix done * rename variable to prevent conflict * Updating VpnGateway examples for bgpSettings (Azure#9656) * Updating VpnGateway examples * prettier Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * Application Gateway Private Link Support (Azure#9490) * Application Gateway Private Link Support * Fix comments * Fix comments for including example * Add nvaSku property for NetworkVirtualAppliance (Azure#9682) * code fixes for hubIPAddresses (Azure#9775) * Fix lint errors (Azure#9787) Co-authored-by: naveenchekuri <nachekur@microsoft.com> Co-authored-by: dexiang-ms <64503627+dexiang-ms@users.noreply.github.com> Co-authored-by: odedlaz <odedlaz@users.noreply.github.com> Co-authored-by: Ishani Gupta <ishani.gupta27.ig@gmail.com> Co-authored-by: Ishani Gupta <isgu@microsoft.com> Co-authored-by: Zim Kalinowski <zikalino@microsoft.com> Co-authored-by: irrogozh <irrogozh@microsoft.com> Co-authored-by: Sai Sujith Reddy Mankala <samankal@microsoft.com> Co-authored-by: Anchal Kapoor <anchalka@usc.edu> Co-authored-by: shyamshd <64368451+shyamshd@users.noreply.github.com> Co-authored-by: Shyam Dharmarajan <shdharma@microsoft.com> Co-authored-by: Ritvika Reddy Nagula <rinagula@microsoft.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> Co-authored-by: jaishals <jaishal.shah@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.