Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add swagger definition for user assigned identity #9737

Merged
merged 3 commits into from
Jun 16, 2020
Merged

Add swagger definition for user assigned identity #9737

merged 3 commits into from
Jun 16, 2020

Conversation

norshtein
Copy link
Member

@norshtein norshtein commented Jun 5, 2020 •
edited
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
    • adding/removing APIs.
    • adding/removing properties.
    • adding/removing API-version.
    • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 5, 2020 •
edited
Loading

[Staging] Swagger Validation Report

  • ️️✔️~[Staging] BreakingChange [Detail]

    • Posted by Swagger Pipeline

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 5, 2020 •
    edited
    Loading

    Azure CLI Extension Generation

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 5, 2020 •
    edited
    Loading

    azure-sdk-for-go

    ️✔️ succeeded [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 5, 2020 •
    edited
    Loading

    azure-sdk-for-python

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from d07e56b with merge commit b66ad78dfd284b18af09cf3c4776d8f967448be7. SDK Automation 13.0.17.20200526.1
    • ⚠️azure-mgmt-containerservice [View full logs]  
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-containerservice
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-containerservice
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-07-01', '2019-04-01'} in label v2017_07_01
[after_scripts|python] WARNING:__main__:Guessing you want 2017-07-01 based on label v2017_07_01
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
No file is changed.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 5, 2020 •
    edited
    Loading

    azure-sdk-for-js

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from d07e56b with merge commit b66ad78dfd284b18af09cf3c4776d8f967448be7. SDK Automation 13.0.17.20200526.1
    • ️✔️@azure/arm-containerservice [View full logs]  [Preview SDK Changes] 
      No run LangAfterScript
[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
[npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
[npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/containerServiceClient.js → ./dist/arm-containerservice.js...
[npmPack] created ./dist/arm-containerservice.js in 384ms
[npmPack] npm notice 
[npmPack] npm notice package: @azure/arm-containerservice@11.0.0
[npmPack] npm notice === Tarball Contents === 
[npmPack] npm notice 10.9kB  esm/operations/agentPools.js              
[npmPack] npm notice 1.5kB   esm/models/agentPoolsMappers.js           
[npmPack] npm notice 120.2kB dist/arm-containerservice.js              
[npmPack] npm notice 43.2kB  dist/arm-containerservice.min.js          
[npmPack] npm notice 1.8kB   esm/containerServiceClient.js             
[npmPack] npm notice 2.7kB   esm/containerServiceClientContext.js      
[npmPack] npm notice 345B    esm/models/index.js                       
[npmPack] npm notice 446B    esm/operations/index.js                   
[npmPack] npm notice 24.5kB  esm/operations/managedClusters.js         
[npmPack] npm notice 1.5kB   esm/models/managedClustersMappers.js      
[npmPack] npm notice 54.8kB  esm/models/mappers.js                     
[npmPack] npm notice 1.6kB   esm/operations/operations.js              
[npmPack] npm notice 442B    esm/models/operationsMappers.js           
[npmPack] npm notice 2.2kB   esm/models/parameters.js                  
[npmPack] npm notice 1.0kB   rollup.config.js                          
[npmPack] npm notice 1.7kB   package.json                              
[npmPack] npm notice 457B    tsconfig.json                             
[npmPack] npm notice 3.4kB   esm/operations/agentPools.d.ts.map        
[npmPack] npm notice 5.4kB   esm/operations/agentPools.js.map          
[npmPack] npm notice 619B    esm/models/agentPoolsMappers.d.ts.map     
[npmPack] npm notice 632B    esm/models/agentPoolsMappers.js.map       
[npmPack] npm notice 243.6kB dist/arm-containerservice.js.map          
[npmPack] npm notice 34.3kB  dist/arm-containerservice.min.js.map      
[npmPack] npm notice 691B    esm/containerServiceClient.d.ts.map       
[npmPack] npm notice 815B    esm/containerServiceClient.js.map         
[npmPack] npm notice 511B    esm/containerServiceClientContext.d.ts.map
[npmPack] npm notice 1.4kB   esm/containerServiceClientContext.js.map  
[npmPack] npm notice 18.2kB  esm/models/index.d.ts.map                 
[npmPack] npm notice 181B    esm/operations/index.d.ts.map             
[npmPack] npm notice 126B    esm/models/index.js.map                   
[npmPack] npm notice 196B    esm/operations/index.js.map               
[npmPack] npm notice 6.6kB   esm/operations/managedClusters.d.ts.map   
[npmPack] npm notice 11.6kB  esm/operations/managedClusters.js.map     
[npmPack] npm notice 652B    esm/models/managedClustersMappers.d.ts.map
[npmPack] npm notice 665B    esm/models/managedClustersMappers.js.map  
[npmPack] npm notice 2.5kB   esm/models/mappers.d.ts.map               
[npmPack] npm notice 29.0kB  esm/models/mappers.js.map                 
[npmPack] npm notice 663B    esm/operations/operations.d.ts.map        
[npmPack] npm notice 908B    esm/operations/operations.js.map          
[npmPack] npm notice 202B    esm/models/operationsMappers.d.ts.map     
[npmPack] npm notice 215B    esm/models/operationsMappers.js.map       
[npmPack] npm notice 539B    esm/models/parameters.d.ts.map            
[npmPack] npm notice 1.6kB   esm/models/parameters.js.map              
[npmPack] npm notice 3.2kB   README.md                                 
[npmPack] npm notice 9.9kB   esm/operations/agentPools.d.ts            
[npmPack] npm notice 18.0kB  src/operations/agentPools.ts              
[npmPack] npm notice 1.2kB   esm/models/agentPoolsMappers.d.ts         
[npmPack] npm notice 1.5kB   src/models/agentPoolsMappers.ts           
[npmPack] npm notice 1.2kB   esm/containerServiceClient.d.ts           
[npmPack] npm notice 1.7kB   src/containerServiceClient.ts             
[npmPack] npm notice 923B    esm/containerServiceClientContext.d.ts    
[npmPack] npm notice 2.4kB   src/containerServiceClientContext.ts      
[npmPack] npm notice 64.9kB  esm/models/index.d.ts                     
[npmPack] npm notice 130B    esm/operations/index.d.ts                 
[npmPack] npm notice 62.5kB  src/models/index.ts                       
[npmPack] npm notice 414B    src/operations/index.ts                   
[npmPack] npm notice 21.4kB  esm/operations/managedClusters.d.ts       
[npmPack] npm notice 38.6kB  src/operations/managedClusters.ts         
[npmPack] npm notice 1.2kB   esm/models/managedClustersMappers.d.ts    
[npmPack] npm notice 1.5kB   src/models/managedClustersMappers.ts      
[npmPack] npm notice 3.7kB   esm/models/mappers.d.ts                   
[npmPack] npm notice 43.7kB  src/models/mappers.ts                     
[npmPack] npm notice 1.1kB   esm/operations/operations.d.ts            
[npmPack] npm notice 2.3kB   src/operations/operations.ts              
[npmPack] npm notice 132B    esm/models/operationsMappers.d.ts         
[npmPack] npm notice 404B    src/models/operationsMappers.ts           
[npmPack] npm notice 608B    esm/models/parameters.d.ts                
[npmPack] npm notice 2.2kB   src/models/parameters.ts                  
[npmPack] npm notice 1.1kB   LICENSE.txt                               
[npmPack] npm notice === Tarball Details === 
[npmPack] npm notice name:          @azure/arm-containerservice             
[npmPack] npm notice version:       11.0.0                                  
[npmPack] npm notice filename:      azure-arm-containerservice-11.0.0.tgz   
[npmPack] npm notice package size:  102.5 kB                                
[npmPack] npm notice unpacked size: 920.5 kB                                
[npmPack] npm notice shasum:        e811e455ca2656f6d36d3f2446ab5303060da5f2
[npmPack] npm notice integrity:     sha512-Bee0eRq6STUtd[...]uyDBT/7mYE9ag==
[npmPack] npm notice total files:   69                                      
[npmPack] npm notice

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 5, 2020 •
    edited
    Loading

    azure-sdk-for-net

    ❌ failed [Logs] [Expand Details]
    • ❌ Generate from d07e56b with merge commit b66ad78dfd284b18af09cf3c4776d8f967448be7. SDK Automation 13.0.17.20200526.1 
      [AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
    • ❌Microsoft.Azure.Management.ContainerService [View full logs]  [Preview SDK Changes] 
        No run LangAfterScript
Failed to create the package Microsoft.Azure.Management.ContainerService.
Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=containerservice /v:n /p:SkipTests=true , {}

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Jun 5, 2020 •
      edited
      Loading

      azure-sdk-for-java

      ⚠️ warning [Logs] [Expand Details]

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Jun 5, 2020 •
      edited
      Loading

      Trenton Generation

      No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

      This was referenced Jun 5, 2020
      Open
      Open
      @azuresdkci
      Copy link
      Contributor

      Can one of the admins verify this patch?

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 5, 2020
      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @xizha162
      Copy link
      Contributor

      xizha162 commented Jun 9, 2020

      /LGTM

      @majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 11, 2020
      majastrz
      majastrz approved these changes Jun 11, 2020
      View reviewed changes
      Copy link
      Member

      @majastrz majastrz left a comment

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      Signed off from ARM side.

      @yungezz yungezz merged commit 85bfc31 into Azure:dev-containerservice-Microsoft.ContainerService-2020-06-01 Jun 16, 2020
      @tilnl tilnl mentioned this pull request Jun 22, 2020
      Merged
      4 tasks
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Reviewers

      @majastrz majastrz majastrz approved these changes

      Assignees

      @fengzhou-msft fengzhou-msft

      Labels
      ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
      Projects
      None yet
      Milestone
      No milestone
      Development

      Successfully merging this pull request may close these issues.
      6 participants
      @norshtein @azuresdkci @xizha162 @majastrz @yungezz @fengzhou-msft