Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SRP]Adding allowBlobPublicAccess and minimumTlsVersion property for June19 and April19 #9831

Merged
merged 8 commits into from
Jun 22, 2020
Merged

[SRP]Adding allowBlobPublicAccess and minimumTlsVersion property for June19 and April19 #9831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e5d6c0e
Add allowBlobPublicAccess and minimumTlsVersion properties
HimanshuChhabra Jun 11, 2020
6f1ef14
Adding allowBlobPublicAccess and minimumTlsVersion properties to apri…
HimanshuChhabra Jun 12, 2020
49ffaa0
validation fix, added example
HimanshuChhabra Jun 12, 2020
18280f1
filename correction
HimanshuChhabra Jun 12, 2020
f11af0a
Ran prettier check, Moved the example to StorageAccountCreate
HimanshuChhabra Jun 12, 2020
d375c95
Updating comments
HimanshuChhabra Jun 15, 2020
6d6ccff
Updating description
HimanshuChhabra Jun 15, 2020
52aba44
Added update account example
HimanshuChhabra Jun 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...e/resource-manager/Microsoft.Storage/stable/2019-04-01/examples/StorageAccountCreate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@
"kind": "Storage",
"location": "eastus2euap",
"properties": {
"isHnsEnabled": true
"isHnsEnabled": true,
"allowBlobPublicAccess": false,
"minimumTlsVersion": "TLS1_2"
},
"tags": {
"key1": "value1",
Expand All @@ -28,6 +30,8 @@
"name": "sto4445",
"properties": {
"isHnsEnabled": true,
"allowBlobPublicAccess": false,
"minimumTlsVersion": "TLS1_2",
"creationTime": "2017-05-24T13:25:33.4863236Z",
"primaryEndpoints": {
"web": "https://sto4445.web.core.windows.net/",
Expand Down
4 changes: 4 additions & 0 deletions ...e/resource-manager/Microsoft.Storage/stable/2019-04-01/examples/StorageAccountUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
"monitor": "true",
"parameters": {
"properties": {
"allowBlobPublicAccess": false,
"minimumTlsVersion": "TLS1_2",
"networkAcls": {
"defaultAction": "Allow"
},
Expand All @@ -33,6 +35,8 @@
"name": "sto8596",
"properties": {
"isHnsEnabled": true,
"allowBlobPublicAccess": false,
"minimumTlsVersion": "TLS1_2",
"creationTime": "2017-06-01T02:42:41.7633306Z",
"networkAcls": {
"bypass": "AzureServices",
Expand Down
54 changes: 54 additions & 0 deletions specification/storage/resource-manager/Microsoft.Storage/stable/2019-04-01/storage.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1451,6 +1451,24 @@
"modelAsString": true
},
"description": "Allow large file shares if sets to Enabled. It cannot be disabled once it is enabled."
},
"allowBlobPublicAccess": {
"type": "boolean",
"x-ms-client-name": "AllowBlobPublicAccess",
"description": "Allow or disallow public access to all blobs or containers in the storage account. The default interpretation is true for this property."
},
"minimumTlsVersion": {
"type": "string",
"enum": [
"TLS1_0",
"TLS1_1",
"TLS1_2"
],
"x-ms-enum": {
"name": "MinimumTlsVersion",
"modelAsString": true
},
"description": "Set the minimum TLS version to be permitted on requests to storage. The default interpretation is TLS 1.0 for this property."
}
},
"description": "The parameters used to create the storage account."
Expand Down Expand Up @@ -1738,6 +1756,24 @@
"modelAsString": true
},
"description": "Allow large file shares if sets to Enabled. It cannot be disabled once it is enabled."
},
"allowBlobPublicAccess": {
"type": "boolean",
"x-ms-client-name": "AllowBlobPublicAccess",
"description": "Allow or disallow public access to all blobs or containers in the storage account. The default interpretation is true for this property."
},
"minimumTlsVersion": {
"type": "string",
"enum": [
"TLS1_0",
"TLS1_1",
"TLS1_2"
],
"x-ms-enum": {
"name": "MinimumTlsVersion",
"modelAsString": true
},
"description": "Set the minimum TLS version to be permitted on requests to storage. The default interpretation is TLS 1.0 for this property."
}
},
"description": "Properties of the storage account."
Expand Down Expand Up @@ -1900,6 +1936,24 @@
"modelAsString": true
},
"description": "Allow large file shares if sets to Enabled. It cannot be disabled once it is enabled."
},
"allowBlobPublicAccess": {
"type": "boolean",
"x-ms-client-name": "AllowBlobPublicAccess",
"description": "Allow or disallow public access to all blobs or containers in the storage account. The default interpretation is true for this property."
},
"minimumTlsVersion": {
"type": "string",
"enum": [
"TLS1_0",
"TLS1_1",
"TLS1_2"
],
"x-ms-enum": {
"name": "MinimumTlsVersion",
"modelAsString": true
},
"description": "Set the minimum TLS version to be permitted on requests to storage. The default interpretation is TLS 1.0 for this property."
}
},
"description": "The parameters used when updating a storage account."
Expand Down
4 changes: 4 additions & 0 deletions ...e/resource-manager/Microsoft.Storage/stable/2019-06-01/examples/StorageAccountCreate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
"location": "eastus",
"properties": {
"isHnsEnabled": true,
"allowBlobPublicAccess": false,
HimanshuChhabra marked this conversation as resolved.
Show resolved Hide resolved
"minimumTlsVersion": "TLS1_2",
"routingPreference": {
"routingChoice": "MicrosoftRouting",
"publishMicrosoftEndpoints": true,
Expand Down Expand Up @@ -47,6 +49,8 @@
"name": "sto4445",
"properties": {
"isHnsEnabled": true,
"allowBlobPublicAccess": false,
"minimumTlsVersion": "TLS1_2",
"creationTime": "2017-05-24T13:25:33.4863236Z",
"primaryEndpoints": {
"web": "https://sto4445.web.core.windows.net/",
Expand Down
4 changes: 4 additions & 0 deletions ...e/resource-manager/Microsoft.Storage/stable/2019-06-01/examples/StorageAccountUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
"monitor": "true",
"parameters": {
"properties": {
"allowBlobPublicAccess": false,
"minimumTlsVersion": "TLS1_2",
"networkAcls": {
"defaultAction": "Allow"
},
Expand Down Expand Up @@ -40,6 +42,8 @@
"name": "sto8596",
"properties": {
"isHnsEnabled": true,
"allowBlobPublicAccess": false,
"minimumTlsVersion": "TLS1_2",
"creationTime": "2017-06-01T02:42:41.7633306Z",
"networkAcls": {
"bypass": "AzureServices",
Expand Down
54 changes: 54 additions & 0 deletions specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/storage.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2131,6 +2131,24 @@
"$ref": "#/definitions/RoutingPreference",
"x-ms-client-name": "RoutingPreference",
"description": "Maintains information about the network routing choice opted by the user for data transfer"
},
"allowBlobPublicAccess": {
"type": "boolean",
"x-ms-client-name": "AllowBlobPublicAccess",
"description": "Allow or disallow public access to all blobs or containers in the storage account. The default interpretation is true for this property."
},
"minimumTlsVersion": {
"type": "string",
"enum": [
"TLS1_0",
"TLS1_1",
"TLS1_2"
],
"x-ms-enum": {
"name": "MinimumTlsVersion",
"modelAsString": true
},
"description": "Set the minimum TLS version to be permitted on requests to storage. The default interpretation is TLS 1.0 for this property."
}
},
"description": "The parameters used to create the storage account."
Expand Down Expand Up @@ -2566,6 +2584,24 @@
"x-ms-client-name": "BlobRestoreStatus",
"description": "Blob restore status",
"readOnly": true
},
"allowBlobPublicAccess": {
"type": "boolean",
"x-ms-client-name": "AllowBlobPublicAccess",
"description": "Allow or disallow public access to all blobs or containers in the storage account. The default interpretation is true for this property."
},
"minimumTlsVersion": {
"type": "string",
"enum": [
"TLS1_0",
"TLS1_1",
"TLS1_2"
],
"x-ms-enum": {
"name": "MinimumTlsVersion",
"modelAsString": true
},
"description": "Set the minimum TLS version to be permitted on requests to storage. The default interpretation is TLS 1.0 for this property."
}
},
"description": "Properties of the storage account."
Expand Down Expand Up @@ -2733,6 +2769,24 @@
"$ref": "#/definitions/RoutingPreference",
"x-ms-client-name": "RoutingPreference",
"description": "Maintains information about the network routing choice opted by the user for data transfer"
},
"allowBlobPublicAccess": {
"type": "boolean",
"x-ms-client-name": "AllowBlobPublicAccess",
"description": "Allow or disallow public access to all blobs or containers in the storage account. The default interpretation is true for this property."
},
"minimumTlsVersion": {
"type": "string",
"enum": [
"TLS1_0",
"TLS1_1",
"TLS1_2"
],
"x-ms-enum": {
"name": "MinimumTlsVersion",
"modelAsString": true
},
"description": "Set the minimum TLS version to be permitted on requests to storage. The default interpretation is TLS 1.0 for this property."
}
},
"description": "The parameters used when updating a storage account."
Expand Down