Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code tweaks: #15

Merged
merged 1 commit into from
Jan 28, 2015
Merged

Code tweaks: #15

merged 1 commit into from
Jan 28, 2015

Conversation

jf
Copy link
Contributor

@jf jf commented Jan 27, 2015

  • reorder BlobListResponse to be after ContainerListResponse
  • standardize on "name string" parameter for the "Container" methods

Somewhat OCD, but I thought these would be good merged. Let me know what you think.

@ahmetb
Copy link
Contributor

ahmetb commented Jan 27, 2015

@jf your commit message is Code tweaks: , that does not look good.

can you please:

  1. git commit --amend --edit
  2. write a better message for the first like e.g. refactor several methods and parameter names on blob client
  3. git push -f your_remote codetweaks
  4. this PR will be automatically updated with new commit.

otherwise lgtm.

@jf
Copy link
Contributor Author

jf commented Jan 27, 2015

Thanks, @ahmetalpbalkan . This is a multi-line commit message, actually (and the process of submitting the PR only takes the first line). You can see the complete commit message at jf@b545204

@jf
Copy link
Contributor Author

jf commented Jan 27, 2015

ok, I see.

@jf
Copy link
Contributor Author

jf commented Jan 28, 2015

ok I've tried to make the commit message as succinct, and yet as usefully descriptive as possible. Will this new one do? It's still not perfect (it seems that Github forcibly inserts a break at 72 chars?).... but I hope that this will work for you.

@ahmetb
Copy link
Contributor

ahmetb commented Jan 28, 2015

sounds great, though, now you need to rebase because there are merge conflicts due to latest changes :)

  1. git fetch origin (i.e. origin = this msopentech remote)
  2. git rebase origin/master
  3. git push -f your_remote codetweaks

…tring" parameter

for the "Container" methods, plus fix some typos
@jf
Copy link
Contributor Author

jf commented Jan 28, 2015

Got it. The new code is in and rebased.

ahmetb added a commit that referenced this pull request Jan 28, 2015
@ahmetb ahmetb merged commit 005406e into Azure:master Jan 28, 2015
@ahmetb
Copy link
Contributor

ahmetb commented Jan 28, 2015

Thanks @jf. Feel free to "watch" the repo to get notified about other changes.

@jf jf deleted the codetweaks branch January 28, 2015 05:34
marstr added a commit to marstr/azure-sdk-for-go that referenced this pull request Apr 27, 2017
* Updating User Agent

* Updating terminology in user agent.

Now that storage is in its own repository, we don't need to continue
tagging the data-plane that is being used. However, we still would like
to bundle the targeted API Version into the User Agent field. This
update would make that more clear.
marstr added a commit that referenced this pull request Apr 28, 2017
* Updating User Agent

* Updating terminology in user agent.

Now that storage is in its own repository, we don't need to continue
tagging the data-plane that is being used. However, we still would like
to bundle the targeted API Version into the User Agent field. This
update would make that more clear.
mcardosos pushed a commit that referenced this pull request May 4, 2017
* Updating User Agent

* Updating terminology in user agent.

Now that storage is in its own repository, we don't need to continue
tagging the data-plane that is being used. However, we still would like
to bundle the targeted API Version into the User Agent field. This
update would make that more clear.
AutorestCI added a commit that referenced this pull request Jul 4, 2019
Merge pull request #15 from moreOver0/yongw/fix

fix cp field
richardpark-msft pushed a commit to richardpark-msft/azure-sdk-for-go that referenced this pull request Aug 5, 2021
start spans on entity new methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants