Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azidentity: environmnet credential add supports for the cert password #17099

Merged

Conversation

magodo
Copy link
Contributor

@magodo magodo commented Feb 18, 2022

The PR adds a new env var AZURE_CLIENT_CERTIFICATE_PASSWORD to allow users to set the certificate password for the EnvironmentCredential.

@chlowell chlowell added Azure.Identity Client This issue points to a problem in the data-plane of the library. labels Feb 28, 2022
@chlowell
Copy link
Member

chlowell commented Mar 1, 2022

Thanks for doing this! I think we can add this but probably not in the next version. I need to discuss it with the rest of the team (we would add it to the other Azure SDKs as well) and our architecture review board first. In the meantime, could you add a test?

@chlowell chlowell self-assigned this Mar 1, 2022
@magodo
Copy link
Contributor Author

magodo commented Mar 2, 2022

@chlowell Seems only the integration test need to be added, while it needs to change the CI setup(i.e. a new env var something like the PFX_CONTENTS_ENCRYPT), which I don't have access to.

@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label May 6, 2022
@ghost
Copy link

ghost commented May 6, 2022

Hi @magodo. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@ghost ghost removed the no-recent-activity There has been no recent activity on this issue. label May 6, 2022
@chlowell
Copy link
Member

chlowell commented May 6, 2022

To update on the timeline, I'm aiming for this in the next beta release, which will go out in early June.

Copy link
Member

@chlowell chlowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the next beta, thanks again for doing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants