Sync eng/common directory with azure-sdk-tools for PR 870 #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
force-pushed
the
sync-eng-common-pr_temp_link-870
branch
2 times, most recently
from
52357f0
to
c75cfbd
Compare
sima-zhu
approved these changes
Aug 20, 2020
weshaggard
reviewed
Aug 20, 2020
eng/common/README.md
Outdated
| @@ -10,14 +10,3 @@ Any updates to files in the `eng/common` directory should be made in the [azure- | |||
| All changes made will cause a PR to created in all subscribed azure-sdk language repos which will blindly replace all contents of | |||
| the `eng/common` directory in that repo. For that reason do **NOT** make changes to files in this directory in the individual azure-sdk | |||
| languages repos as they will be overwritten the next time an update is taken from the common azure-sdk-tools repo. | |||
There was a problem hiding this comment.
@chidozieononiwu this doesn't look correct. Can you try to understand why it looks like it is removing these things you recently added?
There was a problem hiding this comment.
I suspect it might have to do with the fact that @sima-zhu hasn't merged with your latest tools changes. We need to figure out a good way to make sure we don't accidently undo changes in this way.
There was a problem hiding this comment.
I have merged the conflicts. It disappeared now.
@chidozieononiwu Could you check the diff? I will merge the change once you approved.
azure-sdk
force-pushed
the
sync-eng-common-pr_temp_link-870
branch
from
acfe4e6
to
6ace655
Compare
azure-sdk
force-pushed
the
sync-eng-common-pr_temp_link-870
branch
from
6ace655
to
846858b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR 870