[Tables] Fix tables livetest #14797
Merged
[Tables] Fix tables livetest #14797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsiegel
added
Client
bsiegel
force-pushed
the
tables-livetest
branch
from
128243f
to
ae88645
Compare
bsiegel
requested review from
anuchandy,
conniey,
hemanttanwar,
jianghaolu,
JonathanGiles,
joshfree and
srnagar
as code owners
conniey
reviewed
Sep 4, 2020
bsiegel
force-pushed
the
tables-livetest
branch
from
f618bc9
to
7a9c189
Compare
bsiegel
requested review from
conniey
and removed request for
joshfree,
JonathanGiles,
anuchandy,
danieljurek,
jianghaolu,
hemanttanwar and
srnagar
bsiegel
force-pushed
the
tables-livetest
branch
from
ac250bc
to
19acd89
Compare
conniey
reviewed
Sep 8, 2020
sdk/tables/azure-data-tables/src/test/java/com/azure/data/tables/CosmosThrottled.java
Outdated
Show resolved
Hide resolved
bsiegel
force-pushed
the
tables-livetest
branch
from
718971b
to
d64917d
Compare
conniey
approved these changes
Sep 9, 2020
| // Act & Assert | ||
| if (mode == UpdateMode.MERGE && tableClient.getTableUrl().contains("cosmos.azure.com")) { | ||
| // This scenario is currently broken when using the CosmosDB Table API | ||
| StepVerifier.create(tableClient.updateEntityWithResponse(createdEntity, true, mode)) |
There was a problem hiding this comment.
Can we split this into another test case and disable it? I feel it'll get lost as a comment since there is no issue or TODO tracking this.
There was a problem hiding this comment.
Yes, once support is merged for multiple tests with the same name (#14801) I will separate these into two test classes, one for Cosmos and one for Storage, each with their own recordings.
There was a problem hiding this comment.
Tracking this work in #14930
| serviceClient.createTable(tableName3) | ||
| ).block(TIMEOUT); | ||
|
|
||
| serviceClient.createTable(tableName).block(TIMEOUT); |
There was a problem hiding this comment.
Is there a reason for splitting this into three sequential blocks rather than running them concurrently?
There was a problem hiding this comment.
I was having intermittent 429 issues with failures when using Mono.when with multiple streams against the CosmosDB API.
added 2 commits
September 8, 2020 17:39
added 10 commits
September 8, 2020 17:39
bsiegel
force-pushed
the
tables-livetest
branch
from
d64917d
to
582c6db
Compare
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
/azp run java - tables - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-java
that referenced
this pull request
Jun 21, 2021
[Hub Generated] Review request for Microsoft.HybridCompute to add version preview/2021-06-10-preview (Azure#14797) * Adds base for updating Microsoft.HybridCompute from version preview/2021-05-17-preview to version 2021-06-10-preview * Updates readme * Updates API version in new specs and examples * updated the swagger * added the missing bracket * removed type object * removed PatchSettings ref * used x-ms-client-flatten * fixed an issue * added osProfile to the machineUpdateProperties * removed the extra space * fixed by npm run prettier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #14798