Close client and check for link id when link is stolen #16977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
YijunXieMS
reviewed
Oct 30, 2020
...ubs/src/main/java/com/azure/messaging/eventhubs/implementation/AmqpReceiveLinkProcessor.java
Show resolved
Hide resolved
conniey
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes the
EventHubAsyncClientafter fetching the list of partitions successfully as the client would have opened the connection and wouldn't need to use it after the first call to get the partitions. So, this PR will eagerly close the connection instead of the service closing the connection after idle timeout.Also, the
AmqpReceiveLinkProcessorchecks the link name to pass on the error when a link is stolen. If the current link is different from the link that was stolen, then downstream doesn't need to be informed of this error.Fixes #14976