Reducing surface area and addressing Static analysis problems #19011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabianMeiswinkel
requested review from
kirankumarkolli,
kushagraThapar,
mbhaskar,
milismsft,
moderakh,
simplynaveen20 and
xinlian12
as code owners
ghost
added
the
moderakh
approved these changes
Feb 5, 2021
|
|
||
| override def write(internalRow: InternalRow): Unit = { | ||
| val objectNode = CosmosRowConverter.fromInternalRowToObjectNode(internalRow, inputSchema) | ||
|
|
||
| // TODO modreakh investigate if we should also support point write in non-blocking way | ||
| // TODO moderakh investigate if we should also support point write in non-blocking way |
There was a problem hiding this comment.
haha this one was interesting :-)
There was a problem hiding this comment.
Intelli-J dictionary found it :-) The right one I had added to the dictionary :-)
ealsur
approved these changes
Feb 5, 2021
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Jun 23, 2022
Mitryakh/network 2022 01 01 (Azure#19412) * Adds base for updating Microsoft.Network from version stable/2021-08-01 to version 2022-01-01 * Updates readme * Updates API version in new specs and examples * Updated Explicit proxy settings by adding one boolean field to it (Azure#19011) * API for provider port (Azure#19041) * Update readme.md * Create expressRouteProviderPort.json * Create expressRouteProviderPortList.json * Create expressRouteProviderPort.json * Update custom-words.txt * Update expressRouteProviderPort.json * Update expressRouteProviderPortList.json * Update expressRouteProviderPort.json * Add WAF match variable operators (Azure#18925) ### webapplicationfirewall.json * Add GreaterThanOrEquals operator and Any operator to custom rule match conditions in WAF policy spec * Add VirtualHub Router autoscale configuration (Azure#19131) Co-authored-by: Andrii Kalinichenko <ankalini@microsoft.com> * Adding rule priority to Tls Proxy routing rule object model (Azure#19135) Co-authored-by: Vinay Mundada <vimundad@microsoft.com> * swagger changes for new ssl policies (Azure#19183) * Update Swagger Spec for VMSS Packet Capture (Azure#19202) * Update Swagger Spec for VMSS Packet Capture * Remove extra line * Update Swagger spec for Connection Monitor VMSS (Azure#19203) * Adding new endpoint in ConnectionMonitor * Changing ConnectionMonitor endpoints order * Add flushConnection to NSG (Azure#19085) * Merge NetworkManger into 2022-01-01 (Azure#19169) * Merge NetworkManger into 2022-01-01 * Remove EffectiveVnet APIs * Remove SecurityUser Resource * update readme * Fix as comments * fix as comments * remove network group type * Add new parameter noInternetAdvertise to CustomIPPrefix (Azure#19340) * fix * fix Co-authored-by: Weiheng Li <weihl@microsoft.com> * Route Server Integration feature swagger changes (Azure#19215) * Route Server Integration feature swagger changes * prettier run changes * updating api version in examples file * fixing test errors * fixing test errors * fixing modelvalidation errors * fixing test errors * fixing modelvalidation errors * changes based on review comments * fixing lintdiff failure * updating examples * update wrong enum value for customipprefix (Azure#19382) * fix * fix * fix Co-authored-by: Weiheng Li <weihl@microsoft.com> * Updated ExplicitProxySettings to ExplicitProxy on Firewall Policy ver2022-01-01 (Azure#19299) Co-authored-by: Gizachew Eshetie <v-geshetie@microsoft.com> * Add resource type (Azure#19434) Co-authored-by: Andrii Kalinichenko <ankalini@microsoft.com> * Fix prettier errors (Azure#19462) Co-authored-by: Andrii Kalinichenko <ankalini@microsoft.com> Co-authored-by: uditmisra52 <103006702+uditmisra52@users.noreply.github.com> Co-authored-by: jashsing-mic <79445297+jashsing-mic@users.noreply.github.com> Co-authored-by: Anurag Kishore <kishore.1337.anurag@gmail.com> Co-authored-by: AndriiKalinichenko <kalinichenkoandrew@gmail.com> Co-authored-by: Andrii Kalinichenko <ankalini@microsoft.com> Co-authored-by: Vinay Jayant Mundada <vinaymundada27@gmail.com> Co-authored-by: Vinay Mundada <vimundad@microsoft.com> Co-authored-by: kaushik-ms <103559254+kaushik-ms@users.noreply.github.com> Co-authored-by: snagpal99 <95475229+snagpal99@users.noreply.github.com> Co-authored-by: kumaam <102141910+kumaam@users.noreply.github.com> Co-authored-by: Satya-anshu <70507845+Satya-anshu@users.noreply.github.com> Co-authored-by: yanfa317 <53584318+yanfa317@users.noreply.github.com> Co-authored-by: Weiheng Li <weihengli.tj@gmail.com> Co-authored-by: Weiheng Li <weihl@microsoft.com> Co-authored-by: Anchal Kapoor <ankapoo@microsoft.com> Co-authored-by: Gizachew-Eshetie <gizchanie@gmail.com> Co-authored-by: Gizachew Eshetie <v-geshetie@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.