Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refreshing the MA module to use latest swagger #21790

Merged
merged 3 commits into from
May 25, 2021
Merged

Refreshing the MA module to use latest swagger #21790

merged 3 commits into from
May 25, 2021

Conversation

anuchandy
Copy link
Member

No description provided.

@anuchandy anuchandy requested a review from samvaity May 24, 2021 22:27
@anuchandy
Copy link
Member Author

anuchandy commented May 24, 2021 •
edited
Loading

@samvaity, I tried to keep the convenience layer changes minimum, i.e. changes to get it compiled with breaking changes that swagger introduced. Once the protocol layer updates are in, new features need to be added, which includes the following:

  • Add LogAnalytics, AzureEventHubs data feed source API.
  • Add splitAlertByDimensions (string[]) to AnomalyAlertConfiguration.
  • Expose type in BoundaryCondition model types.
  • Finalize the shape of the new credential API and its implementation.

This pr includes the following feature changes: (which was needed to get code compilable and testable).

  • Expose Alert and detection config listing as pageable APIs.
  • Remove Elasticsearch and HttpRequest data sources APIs.
  • Adapt new models SuppressConditionPatch, SmartDetectionConditionPatch, HardThreasholdConditionPatch, ChangeThreasholdConditionPatch, WholeMetricConfigurationPatch in the SDK implementation.

Update (adding following features):

  • Expose DataFeedId in DataPointAnomaly and AnomalyIncident models.
  • Add value and expected value to Anomaly and incident Result.

@anuchandy anuchandy self-assigned this May 24, 2021
samvaity
samvaity approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@samvaity samvaity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm :)

...java/com/azure/ai/metricsadvisor/administration/MetricsAdvisorAdministrationAsyncClient.java
*
* @param detectionConfigurationId The id of the detection configuration.
* @param options th e additional configurable options to specify when querying the result.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:space between th e

...zure-ai-metricsadvisor/src/main/java/com/azure/ai/metricsadvisor/models/AnomalyIncident.java
*
* @return The value.
*/
public Double getValue() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should dthis be primitive or can be nullable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be primitive (let me confirm), let's address that in a follow-up pr just to unblock us from adding the rest of the features.

@samvaity samvaity mentioned this pull request May 25, 2021
Closed
@anuchandy anuchandy merged commit ed84a89 into Azure:master May 25, 2021
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Feb 22, 2023
@MikhailTryakhov @krishmi
@krmishr-msft @Khushboo-Baheti @utbarn-ms @tejasshah7 @prateek2211
CodeGen from PR 22639 in Azure/azure-rest-api-specs
7072a15 
Networking 2022-09-01 release (Azure#22639)

* Adds base for updating Microsoft.Network from version stable/2022-07-01 to version 2022-09-01

* Updates readme

* Updates API version in new specs and examples

* Added flowlog property in virtual network (Azure#21790)

Co-authored-by: Krishna Mishra <krmishr@microsoft.com>

* commit1 (Azure#22111)

Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>

* adding auth status property to circuit (Azure#22024)

* Make auth status readonly (Azure#22365)

* make auth status read only

* fixing model validation

* prettier fix

* Add support for State flag in Custom Rule (Azure#22457)

* Fix LRO header model validation (Azure#22506)

* Add new status code for application gateway custom error page (Azure#22151)

* Add new status code for application gateway custom error page

* Fix prettier

* Adding words to Custom-Words list

* Fix missing resource id in application gateway list example (Azure#22509)

* Resolving merge conflicts with main branch

---------

Co-authored-by: Mikhail <mitryakh@microsoft.com>
Co-authored-by: KRISHNA MISHRA <krishmi139@gmail.com>
Co-authored-by: Krishna Mishra <krmishr@microsoft.com>
Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com>
Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>
Co-authored-by: utbarn-ms <66377251+utbarn-ms@users.noreply.github.com>
Co-authored-by: tejasshah7 <49326906+tejasshah7@users.noreply.github.com>
Co-authored-by: Prateek Sachan <42961174+prateek2211@users.noreply.github.com>
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Feb 22, 2023
@MikhailTryakhov @krishmi
@krmishr-msft @Khushboo-Baheti @utbarn-ms @tejasshah7 @prateek2211
CodeGen from PR 22639 in Azure/azure-rest-api-specs
fc47d3f 
Networking 2022-09-01 release (Azure#22639)

* Adds base for updating Microsoft.Network from version stable/2022-07-01 to version 2022-09-01

* Updates readme

* Updates API version in new specs and examples

* Added flowlog property in virtual network (Azure#21790)

Co-authored-by: Krishna Mishra <krmishr@microsoft.com>

* commit1 (Azure#22111)

Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>

* adding auth status property to circuit (Azure#22024)

* Make auth status readonly (Azure#22365)

* make auth status read only

* fixing model validation

* prettier fix

* Add support for State flag in Custom Rule (Azure#22457)

* Fix LRO header model validation (Azure#22506)

* Add new status code for application gateway custom error page (Azure#22151)

* Add new status code for application gateway custom error page

* Fix prettier

* Adding words to Custom-Words list

* Fix missing resource id in application gateway list example (Azure#22509)

* Resolving merge conflicts with main branch

---------

Co-authored-by: Mikhail <mitryakh@microsoft.com>
Co-authored-by: KRISHNA MISHRA <krishmi139@gmail.com>
Co-authored-by: Krishna Mishra <krmishr@microsoft.com>
Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com>
Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>
Co-authored-by: utbarn-ms <66377251+utbarn-ms@users.noreply.github.com>
Co-authored-by: tejasshah7 <49326906+tejasshah7@users.noreply.github.com>
Co-authored-by: Prateek Sachan <42961174+prateek2211@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samvaity samvaity samvaity approved these changes

Assignees

@anuchandy anuchandy

Labels
Cognitive - Metrics Advisor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anuchandy @samvaity