Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to monitor query based on API review feedback #22114

Merged
merged 4 commits into from
Jun 8, 2021
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions sdk/monitor/azure-monitor-query/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ This client library provides access to query metrics and logs collected by Azure

<!-- embedme ./src/samples/java/com/azure/monitor/query/ReadmeSamples.java#L41-L43 -->
```java
LogsClient logsClient = new LogsClientBuilder()
LogsQueryClient logsQueryClient = new LogsQueryClientBuilder()
.credential(tokenCredential)
.buildClient();
```
Expand All @@ -49,7 +49,7 @@ LogsClient logsClient = new LogsClientBuilder()

<!-- embedme ./src/samples/java/com/azure/monitor/query/ReadmeSamples.java#L45-L47 -->
```java
LogsAsyncClient logsAsyncClient = new LogsClientBuilder()
LogsQueryAsyncClient logsQueryAsyncClient = new LogsQueryClientBuilder()
.credential(tokenCredential)
.buildAsyncClient();
```
Expand All @@ -58,7 +58,7 @@ LogsAsyncClient logsAsyncClient = new LogsClientBuilder()

<!-- embedme ./src/samples/java/com/azure/monitor/query/ReadmeSamples.java#L201-L233 -->
```java
LogsQueryResult queryResults = logsClient.queryLogs("{workspace-id}", "{kusto-query}",
LogsQueryResult queryResults = logsQueryClient.queryLogs("{workspace-id}", "{kusto-query}",
new QueryTimeSpan(Duration.ofDays(2)));
System.out.println("Number of tables = " + queryResults.getLogsTables().size());

Expand Down Expand Up @@ -90,13 +90,13 @@ LogsAsyncClient logsAsyncClient = new LogsClientBuilder()
+ "; value = " + logsTableCell.getValueAsString()));
}
}

}
```
### Get logs for a query and read the response as a model type

```java

LogsQueryResult queryResults = logsClient
LogsQueryResult queryResults = logsQueryClient
.queryLogs("d2d0e126-fa1e-4b0a-b647-250cdd471e68", "AppRequests", null);

// Sample to use a model type to read the results
Expand Down Expand Up @@ -217,16 +217,16 @@ LogsAsyncClient logsAsyncClient = new LogsClientBuilder()

<!-- embedme ./src/samples/java/com/azure/monitor/query/ReadmeSamples.java#L97-L117 -->
```java
LogsQueryBatch logsQueryBatch = new LogsQueryBatch()
LogsBatchQuery logsBatchQuery = new LogsBatchQuery()
.addQuery("{workspace-id}", "{query-1}", new QueryTimeSpan(Duration.ofDays(2)))
.addQuery("{workspace-id}", "{query-2}", new QueryTimeSpan(Duration.ofDays(30)));

LogsQueryBatchResultCollection batchResultCollection = logsClient
.queryLogsBatchWithResponse(logsQueryBatch, Context.NONE).getValue();
LogsBatchQueryResultCollection batchResultCollection = logsQueryClient
.queryLogsBatchWithResponse(logsBatchQuery, Context.NONE).getValue();

List<LogsQueryBatchResult> responses = batchResultCollection.getBatchResults();
List<LogsBatchQueryResult> responses = batchResultCollection.getBatchResults();

for (LogsQueryBatchResult response : responses) {
for (LogsBatchQueryResult response : responses) {
LogsQueryResult queryResult = response.getQueryResult();

// Sample to iterate by row
Expand All @@ -250,7 +250,7 @@ LogsQueryOptions options = new LogsQueryOptions("{workspace-id}",
.setServerTimeout(Duration.ofMinutes(10));

// make service call with these request options set as filter header
Response<LogsQueryResult> response = logsClient.queryLogsWithResponse(options, Context.NONE);
Response<LogsQueryResult> response = logsQueryClient.queryLogsWithResponse(options, Context.NONE);
LogsQueryResult logsQueryResult = response.getValue();

// Sample to iterate by row
Expand All @@ -267,7 +267,7 @@ for (LogsTable table : logsQueryResult.getLogsTables()) {

<!-- embedme ./src/samples/java/com/azure/monitor/query/ReadmeSamples.java#L56-L58 -->
```java
MetricsClient metricsClient = new MetricsClientBuilder()
MetricsQueryClient metricsQueryClient = new MetricsQueryClientBuilder()
.credential(tokenCredential)
.buildClient();
```
Expand All @@ -276,7 +276,7 @@ MetricsClient metricsClient = new MetricsClientBuilder()

<!-- embedme ./src/samples/java/com/azure/monitor/query/ReadmeSamples.java#L60-L62 -->
```java
MetricsAsyncClient metricsAsyncClient = new MetricsClientBuilder()
MetricsQueryAsyncClient metricsQueryAsyncClient = new MetricsQueryClientBuilder()
.credential(tokenCredential)
.buildAsyncClient();
```
Expand All @@ -285,20 +285,20 @@ MetricsAsyncClient metricsAsyncClient = new MetricsClientBuilder()

<!-- embedme ./src/samples/java/com/azure/monitor/query/ReadmeSamples.java#L161-L188 -->
```java
Response<MetricsQueryResult> metricsResponse = metricsClient
Response<MetricsQueryResult> metricsResponse = metricsQueryClient
.queryMetricsWithResponse(
"{resource-id}",
Arrays.asList("SuccessfulCalls"),
new MetricsQueryOptions()
.setMetricsNamespace("Microsoft.CognitiveServices/accounts")
.setTimespan(Duration.ofDays(30).toString())
.setTimeSpan(new QueryTimeSpan(Duration.ofDays(30)))
.setInterval(Duration.ofHours(1))
.setTop(100)
.setAggregation(Arrays.asList(AggregationType.AVERAGE, AggregationType.COUNT)),
Context.NONE);

MetricsQueryResult metricsQueryResult = metricsResponse.getValue();
List<Metrics> metrics = metricsQueryResult.getMetrics();
List<Metric> metrics = metricsQueryResult.getMetrics();
metrics.stream()
.forEach(metric -> {
System.out.println(metric.getMetricsName());
Expand Down
Loading