-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increment version for cosmos releases #23890
Increment version for cosmos releases #23890
Conversation
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alzimmermsft - we cannot update our changelog formatting, since the same changelog is embedded into our microsoft official release docs. https://docs.microsoft.com/en-us/azure/cosmos-db/sql/sql-api-sdk-java-v4
@weshaggard, @chidozieononiwu, have there been any recent changes to how the CHANGELOG is automatically updated after release? |
sdk/cosmos/azure-cosmos/CHANGELOG.md
Outdated
@@ -1,10 +1,20 @@ | |||
## Release History | |||
# Release History |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe these header changes will break some of the cosmos docs which directly import this file so we will likely need to undo that.
FYI @kushagraThapar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOL nevermind it looks like @kushagraThapar already caught this in the review. I think we will have to manually undo those changes as the changelog automation does not currently support this scenario.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weshaggard - will we need to do this every single time going forward ?
Can we skip azure-cosmos and azure-spring-data-cosmos changelog formatting in some way ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chidozieononiwu can you please file a tracking issue to try and see what we can do to handle this custom formatting problem.
@kushagraThapar we should follow back up with the docs folks to see if we can get them to fix this as I still do not like the way they are directly consuming this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, we can follow up on that!
ccing - @SnehaGunda
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed #23908 to track the changelog automation issue.
Increment package version after release of com.azure azure-cosmos