Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync eng/common directory with azure-sdk-tools for PR 1983 #24000

Merged
merged 3 commits into from
Sep 13, 2021
Merged

Sync eng/common directory with azure-sdk-tools for PR 1983 #24000

merged 3 commits into from
Sep 13, 2021

Commits on Sep 10, 2021

  1. Doc Updates and Revisions for External Use 

    The focus of these changes is to revise the script to better support use
by external contributors and others outside of the Azure SDK ecosystem and
without access to the Microsoft AAD Tenant.

Changes include:

- Creation of a new Test Application service principal is now possible
  from a non-Microsoft AAD tenant.

- When a new Test Application principal is created, the principle of least
  privilege is now applied; the new Test Application is granted ownership
  of the resource group associated with the test resources and no longer
  has access to any other resources in the subscription.

- If an existing Test Application principal is specified, it will be
  assigned ownership of the resource group created.  This supports using
  a Test Application principal without privileges at the subscription-level.

- When no provisioner is specified, the script is now executed in the
  context of the caller rather than the Test Application principal.
  This supports using a Test Application principal that has restricted
  privileges and better aligns to the purpose of the Test Application
  principal.

- The `$TestApplicationOid` is now explicitly bound at the time a new Test
  Application principal is created rather than having to query for it later.

- Common error scenarios resulting from lack of permissions now provide
  messaging with more context of why the failure occurred and suggest
  remediation.

- Added new examples to illustrate the common call patterns needed by
  external contributors running the script, outside of the Microsoft tenant
  and Azure SDK ecosystem.

- Documentation has been enhanced with additional context to detail the
  permissions and roles assigned by the script.

- Added documentation details for Bicep template use.
    @jsquire @azure-sdk
    jsquire authored and azure-sdk committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    64ae119 View commit details
    Browse the repository at this point in the history

  2. Add the provisioner OID to the deployment params 

    Key Vault needs this to deploy Managed HSMs. There's a corresponding change necessary in test-resources.json I'll roll out across languages.
    @heaths @azure-sdk
    heaths authored and azure-sdk committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    1e45e94 View commit details
    Browse the repository at this point in the history

  3. Fixing typos and spelling mistakes

    @jsquire @azure-sdk
    jsquire authored and azure-sdk committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    736f4a1 View commit details
    Browse the repository at this point in the history