Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource manager packages compatible with the 2020-09-01-hybrid profile API versions #25103

Merged
merged 13 commits into from
Nov 24, 2021

Conversation

bbridges
Copy link
Member

@bbridges bbridges commented Oct 29, 2021

This PR adds new Track 2 resource manager packages which were copied and regenerated in order to be compatible with API versions in the 2020-09-01-hybrid profile. Minimal changes were made against the packages to get this to work against these API versions, and resource types which are found in the resource manager packages but not in the hybrid profile were kept to reduce the amount of required changes. These new modules were placed in a new /sdk/resourcemanagerhybrid/ folder.

The group ID / artifact ID of these modules are the same as the existing Track 2 packages, and to reduce conflicts, they are not included in the root POM file. Instead, the versions are suffixed with -hybrid to tell them apart.

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@bganapa
Copy link
Member

bganapa commented Oct 29, 2021

Thanks @bbridges for the extra effort on making cleaner commits here!

@weidongxu-microsoft could you please review the commits and help with build changes? We really appreciate your help and support here

@weidongxu-microsoft
Copy link
Member

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weidongxu-microsoft
Copy link
Member

weidongxu-microsoft commented Nov 1, 2021

I've build it locally, code seems good.

Engineering part, one thing that need to be solved is the versioning integration at https://github.com/Azure/azure-sdk-for-java/blob/main/eng/versioning/version_client.txt#L198
We probably need help from engineering as we got same artifactId but different version.

Please locally run "mvn checkstyle:check" and "mvn spotbugs:check" to solve the error if possible. You seems not using Java11+ for code generation, hence the auto-formatter does not take effect. You might had to re-generate these RPs.
(CI will run these for you, but it worthwhile first run locally to avoid repeatedly commit and check CI)

@weidongxu-microsoft
Copy link
Member

/azp run java - resourcemanagerhybrid - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weidongxu-microsoft
Copy link
Member

version check script is .\eng\versioning\pom_file_version_scanner.ps1, and you can run it locally.

still checking on how this works.

@weidongxu-microsoft weidongxu-microsoft added Mgmt This issue is related to a management-plane library. Mgmt - Track 2 labels Nov 5, 2021
@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure:azure-core-amqp. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure:azure-core-management. You can review API changes here

API changes

-             public String identifier() 
-             @Override public String toString() 
+             public String identifier() 
+             @Override public String toString() 

@weidongxu-microsoft
Copy link
Member

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weidongxu-microsoft
Copy link
Member

/azp run java - resourcemanagerhybrid - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weidongxu-microsoft
Copy link
Member

weidongxu-microsoft commented Nov 24, 2021

Wes OKed with the changes on the CI (add a PreBuildSteps, and exclude sdk/resourcemanagerhybrid in some scripts). We will follow-up if anything unexpected happens.

@weidongxu-microsoft weidongxu-microsoft merged commit 841b878 into Azure:main Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt - Track 2 Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants