Making databaseAccount read dynamic after V4 master merge #8466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simplynaveen20
requested review from
David-Noble-at-work,
kirankumarkolli,
kushagraThapar and
moderakh
as code owners
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
moderakh
suggested changes
Feb 25, 2020
...cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/GlobalEndpointManager.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxDocumentClientImpl.java
Show resolved
Hide resolved
...cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/GlobalEndpointManager.java
Show resolved
Hide resolved
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
moderakh
suggested changes
Feb 26, 2020
...cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/GlobalEndpointManager.java
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxDocumentClientImpl.java
Show resolved
Hide resolved
...va/com/azure/cosmos/implementation/directconnectivity/GatewayServiceConfigurationReader.java
Show resolved
Hide resolved
...cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/GlobalEndpointManager.java
Outdated
Show resolved
Hide resolved
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
moderakh
approved these changes
Feb 26, 2020
simplynaveen20
deleted the
users/nakumar/databaseAccountDynamicUpdate
branch
openapi-sdkautomation-test bot
pushed a commit
to openapi-env-test/azure-sdk-for-java
that referenced
this pull request
Mar 24, 2020
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs into keyvault_multiapi_readme * 'master' of https://github.com/Azure/azure-rest-api-specs: (101 commits) add cli.md for automation (Azure#8411) adjust assignment (Azure#8782) Remove Microsoft.Backup.Admin 2016-05-01 API version (Azure#8588) Updating global setting in PostgreSQL/MySQL readme file (Azure#8777) update package name and output folder in readme.typescript.md (Azure#8764) add package-2019-12 python define (Azure#8769) Fix Parameter Description for validate resource move (Azure#8524) Edit pass for GA swagger (Azure#8759) Update proxy.json (Azure#8596) Model enums that may change in the future as strings (Azure#8760) Add api-version 2019-11-01 for resources/subscriptions (Azure#8728) regenerated all-api-versions PrivateLinkResources for Microsoft.Automation (Azure#8369) add cli.md for serialconsole (Azure#8401) add cli.md for mariadb (Azure#8466) [Computer Vision] Create CV API v3.0-preview (Azure#7402) Publish Microsoft.ContainerService api-version 2020-03-01 (Azure#8756) Update swagger based on auto-gen process change. (Azure#8766) add assignment-bot config (Azure#8716) add tag package-2019-12 to batch (Azure#8751) ...
openapi-sdkautomation-test bot
pushed a commit
to openapi-env-test/azure-sdk-for-java
that referenced
this pull request
Mar 24, 2020
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs into keyvault_multiapi_readme * 'master' of https://github.com/Azure/azure-rest-api-specs: (101 commits) add cli.md for automation (Azure#8411) adjust assignment (Azure#8782) Remove Microsoft.Backup.Admin 2016-05-01 API version (Azure#8588) Updating global setting in PostgreSQL/MySQL readme file (Azure#8777) update package name and output folder in readme.typescript.md (Azure#8764) add package-2019-12 python define (Azure#8769) Fix Parameter Description for validate resource move (Azure#8524) Edit pass for GA swagger (Azure#8759) Update proxy.json (Azure#8596) Model enums that may change in the future as strings (Azure#8760) Add api-version 2019-11-01 for resources/subscriptions (Azure#8728) regenerated all-api-versions PrivateLinkResources for Microsoft.Automation (Azure#8369) add cli.md for serialconsole (Azure#8401) add cli.md for mariadb (Azure#8466) [Computer Vision] Create CV API v3.0-preview (Azure#7402) Publish Microsoft.ContainerService api-version 2020-03-01 (Azure#8756) Update swagger based on auto-gen process change. (Azure#8766) add assignment-bot config (Azure#8716) add tag package-2019-12 to batch (Azure#8751) ...
openapi-sdkautomation-test bot
pushed a commit
to openapi-env-test/azure-sdk-for-java
that referenced
this pull request
Mar 24, 2020
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs into keyvault_multiapi_readme * 'master' of https://github.com/Azure/azure-rest-api-specs: (101 commits) add cli.md for automation (Azure#8411) adjust assignment (Azure#8782) Remove Microsoft.Backup.Admin 2016-05-01 API version (Azure#8588) Updating global setting in PostgreSQL/MySQL readme file (Azure#8777) update package name and output folder in readme.typescript.md (Azure#8764) add package-2019-12 python define (Azure#8769) Fix Parameter Description for validate resource move (Azure#8524) Edit pass for GA swagger (Azure#8759) Update proxy.json (Azure#8596) Model enums that may change in the future as strings (Azure#8760) Add api-version 2019-11-01 for resources/subscriptions (Azure#8728) regenerated all-api-versions PrivateLinkResources for Microsoft.Automation (Azure#8369) add cli.md for serialconsole (Azure#8401) add cli.md for mariadb (Azure#8466) [Computer Vision] Create CV API v3.0-preview (Azure#7402) Publish Microsoft.ContainerService api-version 2020-03-01 (Azure#8756) Update swagger based on auto-gen process change. (Azure#8766) add assignment-bot config (Azure#8716) add tag package-2019-12 to batch (Azure#8751) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is same as PR on V4 branch - #7831
Created the new PR altogether as it was easier after V4 merge.
Below is the context
Currently GatewayServiceConfigurationReader initialize during client start up with one time snapshot of databaseAccount read via GlobalEndPointManager. Its value remain same throughout the lifespan of application.
This PR will read all the databaseAccount configurations via GatewayServiceConfigurationReader dynamically from cache which updates with its scheduling mechanism or any read/write account error.
This will also fix an issue in which application hits DatabaseAccount read call twice during startup.
fixes #7668