-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[recorder] Sanitize tokens in recorded tests for auth #14431
Comments
Thanks for the issue @annelo-msft. |
Sure! Here is the PR: Azure/azure-sdk-for-net#19696 You can see the |
Currently done in ACR |
I believe this has been addressed in the unified recorder? |
Yes 😎 |
We'll need to sanitize token values in both headers and message bodies in our tests once.
In the .NET test framework, I needed to add:
For message bodies, .NET did not support sanitization of
application/x-www-form-urlencoded
content types. This needed to be added specially to the ACR-specific sanitizer.I don't know how the test framework works in other languages, but this issue represents the work to investigate and implement sanitization in recorded tests so we don't check in secrets in our test recordings.
The text was updated successfully, but these errors were encountered: