Add ACR challenge-based authentication and remove basic auth policy #19696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
annelo-msft
commented
Mar 22, 2021
sdk/core/Azure.Core/src/Shared/BearerTokenChallengeAuthenticationPolicy.cs
Outdated
Show resolved
Hide resolved
annelo-msft
commented
Mar 22, 2021
...rregistry/Azure.Containers.ContainerRegistry/tests/ContainerRegistryRecordedTestSanitizer.cs
Show resolved
Hide resolved
pakrym
reviewed
Mar 22, 2021
...rregistry/Azure.Containers.ContainerRegistry/tests/ContainerRegistryRecordedTestSanitizer.cs
Outdated
Show resolved
Hide resolved
pakrym
reviewed
Mar 22, 2021
...rregistry/Azure.Containers.ContainerRegistry/tests/ContainerRegistryRecordedTestSanitizer.cs
Show resolved
Hide resolved
christothes
reviewed
Mar 22, 2021
.../Azure.Containers.ContainerRegistry/src/Authentication/ContainerRegistryCredentialsPolicy.cs
Outdated
Show resolved
Hide resolved
annelo-msft
force-pushed
the
acr-add-auth
branch
2 times, most recently
from
bd06741
to
2ab0387
Compare
annelo-msft
force-pushed
the
acr-add-auth
branch
from
2ab0387
to
a5bf384
Compare
christothes
reviewed
Mar 23, 2021
.../Azure.Containers.ContainerRegistry/src/Authentication/ContainerRegistryCredentialsPolicy.cs
Outdated
Show resolved
Hide resolved
| /// Step 5: GET /api/v1/acr/repositories | ||
| /// Request Header: { Bearer acrTokenAccess } | ||
| /// </summary> | ||
| internal class ContainerRegistryCredentialsPolicy : BearerTokenChallengeAuthenticationPolicy |
There was a problem hiding this comment.
Do we have tests for this policy?
There was a problem hiding this comment.
Yes! see: sdk/containerregistry/Azure.Containers.ContainerRegistry/tests/Authentication/ContainerRegistryChallengeAuthenticationPolicyTest.cs
christothes
approved these changes
Mar 24, 2021
...iners.ContainerRegistry/src/Authentication/ContainerRegistryChallengeAuthenticationPolicy.cs
Outdated
Show resolved
Hide resolved
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks to @pallavit for her work on ACR's challenge-based authentication for Java!
This is the corresponding implementation for .NET.
Fixes #19469