Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace BasicAuthenticationPolicy and username/password constructors on ContainerRegistryClient with AAD alternatives #19469

Closed
3 tasks
annelo-msft opened this issue Mar 12, 2021 · 0 comments · Fixed by #19696
Closed
3 tasks

Replace BasicAuthenticationPolicy and username/password constructors on ContainerRegistryClient with AAD alternatives #19469

annelo-msft opened this issue Mar 12, 2021 · 0 comments · Fixed by #19696
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Container Registry
Milestone
[2021] April

Comments

@annelo-msft
Copy link
Member

The username/password constructors on ContainerRegistryClient and the BasicAuthenticationPolicy are workarounds to unblock library development while the AAD challenge-based authentication polices are under development.

Once the AAD policy is available, we will:

  • Replace username/password constructors with DefaultAzureCredential
  • Delete BasicAuthenticationPolicy
  • Replace BasicAuthenticationPolicy in the HttpPipeline to use the new policy.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 12, 2021
@annelo-msft annelo-msft added Client This issue points to a problem in the data-plane of the library. Container Registry labels Mar 12, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 12, 2021
@annelo-msft annelo-msft added this to the [2021] April milestone Mar 12, 2021
@annelo-msft annelo-msft changed the title Remove BasicAuthenticationPolicy and username/password constructors from ContainerRegistryClient Replace BasicAuthenticationPolicy and username/password constructors on ContainerRegistryClient with AAD alternatives Mar 12, 2021
@annelo-msft annelo-msft mentioned this issue Mar 12, 2021
Merged
@AlexGhiondea AlexGhiondea added the blocking-release Blocks release label Mar 18, 2021
@annelo-msft annelo-msft mentioned this issue Mar 22, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Container Registry
Projects
None yet
Milestone
[2021] April
Development

Successfully merging a pull request may close this issue.

Add ACR challenge-based authentication and remove basic auth policy annelo-msft/azure-sdk-for-net
2 participants
@AlexGhiondea @annelo-msft